Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-19 Thread Thomas Goirand 
Hi Leo,

I have attached the commits which I have locally, in order to fix and
upload transmission 2.84-0.1. I didn't include
0003-Upgraded-to-upstream-release-2.84.patch because it's 13MB.

1/ Do you agree that I git push these changes?
2/ Do you agree if I NMU these changes, which are fixing the 2 RC bugs
currently opened against transmission?

Cheers,

Thomas Goirand (zigo)
From fab1998a877c7eb54960dee464042425c83dc1b4 Mon Sep 17 00:00:00 2001
From: Thomas Goirand z...@debian.org
Date: Fri, 18 Jul 2014 10:36:49 +
Subject: [PATCH 1/6] New upstream release (Closes: #754982)

---
 debian/changelog | 8 
 1 file changed, 8 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index 780b145..8a06649 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+transmission (2.84-0.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * New upstream release:
+- Fixes build with newer miniupnpc (Closes: #754982).
+
+ -- Thomas Goirand z...@debian.org  Fri, 18 Jul 2014 10:35:51 +
+
 transmission (2.82-1.1) unstable; urgency=medium
 
   * Non-maintainer upload.
-- 
2.0.1

From 76de3471e3acc2e55ea53935e6809cd8bf004938 Mon Sep 17 00:00:00 2001
From: Thomas Goirand z...@debian.org
Date: Fri, 18 Jul 2014 10:38:17 +
Subject: [PATCH 2/6] Ran wrap-and-sort.

---
 debian/changelog   |  1 +
 debian/control | 74 --
 debian/copyright   |  1 -
 debian/transmission-cli.install|  2 +-
 debian/transmission-common.install |  6 ++--
 debian/transmission-daemon.install |  6 ++--
 debian/transmission-gtk.install|  4 +--
 debian/transmission-qt.install |  6 ++--
 8 files changed, 61 insertions(+), 39 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 8a06649..ed54140 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,7 @@ transmission (2.84-0.1) unstable; urgency=medium
   * Non-maintainer upload.
   * New upstream release:
 - Fixes build with newer miniupnpc (Closes: #754982).
+  * Ran wrap-and-sort.
 
  -- Thomas Goirand z...@debian.org  Fri, 18 Jul 2014 10:35:51 +
 
diff --git a/debian/control b/debian/control
index 30cfb4a..b28702e 100644
--- a/debian/control
+++ b/debian/control
@@ -2,18 +2,25 @@ Source: transmission
 Section: net
 Priority: optional
 Maintainer: Leo Costela cost...@debian.org
-Build-Depends: debhelper (= 8), autotools-dev, dh-autoreconf,
- dh-systemd [linux-any],
- libgtk-3-dev, libevent-dev (= 2.0),
- libglib2.0-dev, libnotify-dev (= 0.7), libssl-dev, zlib1g-dev,
- libcurl4-gnutls-dev | libcurl4-dev | libcurl-dev, 
- intltool (= 0.40), 
- qt5-qmake, qtbase5-dev, qttools5-dev-tools, qt5-default,
- libminiupnpc-dev, libnatpmp-dev (= 20110808),
- libsystemd-daemon-dev [linux-any],
-# buildflags.mk
- dpkg-dev (= 1.16.1~),
-# libcanberra-gtk-dev
+Build-Depends: autotools-dev,
+   debhelper (= 8),
+   dh-autoreconf,
+   dh-systemd [linux-any],
+   intltool (= 0.40),
+   libcurl4-gnutls-dev | libcurl4-dev | libcurl-dev,
+   libevent-dev (= 2.0),
+   libglib2.0-dev,
+   libgtk-3-dev,
+   libminiupnpc-dev,
+   libnatpmp-dev (= 20110808),
+   libnotify-dev (= 0.7),
+   libssl-dev,
+   libsystemd-daemon-dev [linux-any],
+   qt5-default,
+   qt5-qmake,
+   qtbase5-dev,
+   qttools5-dev-tools,
+   zlib1g-dev
 Standards-Version: 3.9.5
 Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/transmission.git
 Vcs-Git: git://anonscm.debian.org/collab-maint/transmission.git
@@ -22,10 +29,12 @@ Bugs: https://trac.transmissionbt.com/
 
 Package: transmission
 Architecture: all
-Depends: transmission-gtk (= ${binary:Version}) | transmission-qt (= ${binary:Version}) | transmission-cli (= ${binary:Version}), transmission-common (= ${binary:Version}), ${misc:Depends}
+Depends: transmission-common (= ${binary:Version}),
+ transmission-gtk (= ${binary:Version}) | transmission-qt (= ${binary:Version}) | transmission-cli (= ${binary:Version}),
+ ${misc:Depends}
 Description: lightweight BitTorrent client
  Transmission is a set of lightweight BitTorrent clients (in GUI, CLI
- and daemon form). All its incarnations feature a very simple, intuitive 
+ and daemon form). All its incarnations feature a very simple, intuitive
  interface on top on an efficient, cross-platform back-end.
  .
  This is just a metapackage depending on one of the front-end
@@ -34,7 +43,6 @@ Description: lightweight BitTorrent client
 Package: transmission-common
 Architecture: all
 Depends: ${misc:Depends}
-# because of the usr/share/icons move to -common
 Replaces: transmission-gtk ( 2.10-1)
 Breaks: transmission-gtk ( 2.10-1)
 Description: lightweight BitTorrent client (common files)
@@ -42,14 +50,19 @@ Description: lightweight BitTorrent

Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-18 Thread Petr Salinger 

I looked into config.log, the signature of some library call
in miniupnpc have been changed (addeded argument), I do not remeber name.

The easiest solution might be to upload current Transmission 2.84,
as upstream changelog for 2.83 says:

  Updated third party libraries: DHT updated to v0.22; miniupnpc updated
to v1.9
  Autoconf script fixes: better detection of ccache, minupnpc

Oh, that's cool! Do you think you can work that out soonish?


No, I am not transmission maintainer, I am kfreebsd porter.
And I am not DD, so I cannot upload anyway.

Sorry

Petr


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-17 Thread Thomas Goirand 
On 07/17/2014 02:38 AM, Petr Salinger wrote:
 Package: transmission
 Your package failed to build on kfreebsd:
 
 In fact, the problem is sligthly different.
 The transmission package does not support newly supplied
 libminiupnpc-dev under both Linux and kFreeBSD:
 
 checking supported miniupnp library... none
 
 As a result, it tries to use embedded version
 from transmission-2.82/third-party/miniupnp/
 
 On kFreeBSD, the build fails.
 On Linux, the build succeeds, but the resulting binary
 does not Depend: libminiupnpc10, as it have been expected.
 
 The transmission package should be ported to use newer miniupnpc
 everywhere.
 
 The problem is not kfreebsd specific at all.
 
 Petr

Oh, that explains it then! Thanks for the details.

Do you know why it's not finding the libminiupnpc-dev bindings in the
configure script? I'll try to find the time investigate later on.

Thomas Goirand (zigo)


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-17 Thread Thomas Goirand 
On 07/17/2014 02:38 AM, Petr Salinger wrote:
 Package: transmission
 Your package failed to build on kfreebsd:
 
 In fact, the problem is sligthly different.
 The transmission package does not support newly supplied
 libminiupnpc-dev under both Linux and kFreeBSD:
 
 checking supported miniupnp library... none
 
 As a result, it tries to use embedded version
 from transmission-2.82/third-party/miniupnp/
 
 On kFreeBSD, the build fails.
 On Linux, the build succeeds, but the resulting binary
 does not Depend: libminiupnpc10, as it have been expected.
 
 The transmission package should be ported to use newer miniupnpc
 everywhere.
 
 The problem is not kfreebsd specific at all.
 
 Petr

Oh, that explains it then! Thanks for the details.

Do you know why it's not finding the libminiupnpc-dev bindings in the
configure script? I'll try to find the time investigate later on.

Thomas Goirand (zigo)


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-17 Thread Petr Salinger 

As a result, it tries to use embedded version
from transmission-2.82/third-party/miniupnp/


Oh, that explains it then! Thanks for the details.

Do you know why it's not finding the libminiupnpc-dev bindings in the
configure script? I'll try to find the time investigate later on.


I looked into config.log, the signature of some library call
in miniupnpc have been changed (addeded argument), I do not remeber name.

The easiest solution might be to upload current Transmission 2.84,
as upstream changelog for 2.83 says:

  Updated third party libraries: DHT updated to v0.22; miniupnpc updated to v1.9
  Autoconf script fixes: better detection of ccache, minupnpc

Cheers

Petr


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-17 Thread Thomas Goirand 
On 07/17/2014 02:34 PM, Petr Salinger wrote:
 As a result, it tries to use embedded version
 from transmission-2.82/third-party/miniupnp/

 Oh, that explains it then! Thanks for the details.

 Do you know why it's not finding the libminiupnpc-dev bindings in the
 configure script? I'll try to find the time investigate later on.
 
 I looked into config.log, the signature of some library call
 in miniupnpc have been changed (addeded argument), I do not remeber name.
 
 The easiest solution might be to upload current Transmission 2.84,
 as upstream changelog for 2.83 says:
 
   Updated third party libraries: DHT updated to v0.22; miniupnpc updated
 to v1.9
   Autoconf script fixes: better detection of ccache, minupnpc
 
 Cheers
 
 Petr

Oh, that's cool! Do you think you can work that out soonish?

Cheers,

Thomas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-16 Thread Emilio Pozuelo Monfort 
Package: transmission
Version: 2.82-1.1
Severity: serious
Control: block 749560 with -1

Your package failed to build on kfreebsd:

miniupnpc.c:115:8: warning: no previous declaration for 'simpleUPnPcommand2' 
[-Wmissing-declarations]
 char * simpleUPnPcommand2(int s, const char * url, const char * service,
^
miniupnpc.c: In function 'upnpDiscover':
miniupnpc.c:515:21: error: storage size of 'reqn' isn't known
 struct ip_mreqn reqn; /* only defined with -D_BSD_SOURCE or -D_GNU_SOURCE 
*/
 ^
miniupnpc.c:516:29: error: invalid application of 'sizeof' to incomplete type 
'struct ip_mreqn'
 memset(reqn, 0, sizeof(struct ip_mreqn));
 ^
miniupnpc.c:515:21: warning: unused variable 'reqn' [-Wunused-variable]
 struct ip_mreqn reqn; /* only defined with -D_BSD_SOURCE or -D_GNU_SOURCE 
*/
 ^
make[5]: *** [miniupnpc.o] Error 1

https://buildd.debian.org/status/logs.php?pkg=transmissionver=2.82-1.1%2Bb1

Emilio


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-16 Thread Thomas Goirand 
On 07/16/2014 10:58 PM, Emilio Pozuelo Monfort wrote:
 Package: transmission
 Version: 2.82-1.1
 Severity: serious
 Control: block 749560 with -1
 
 Your package failed to build on kfreebsd:
 
 miniupnpc.c:115:8: warning: no previous declaration for 'simpleUPnPcommand2' 
 [-Wmissing-declarations]
  char * simpleUPnPcommand2(int s, const char * url, const char * service,
 ^
 miniupnpc.c: In function 'upnpDiscover':
 miniupnpc.c:515:21: error: storage size of 'reqn' isn't known
  struct ip_mreqn reqn; /* only defined with -D_BSD_SOURCE or 
 -D_GNU_SOURCE */
  ^
 miniupnpc.c:516:29: error: invalid application of 'sizeof' to incomplete type 
 'struct ip_mreqn'
  memset(reqn, 0, sizeof(struct ip_mreqn));
  ^
 miniupnpc.c:515:21: warning: unused variable 'reqn' [-Wunused-variable]
  struct ip_mreqn reqn; /* only defined with -D_BSD_SOURCE or 
 -D_GNU_SOURCE */
  ^
 make[5]: *** [miniupnpc.o] Error 1
 
 https://buildd.debian.org/status/logs.php?pkg=transmissionver=2.82-1.1%2Bb1
 
 Emilio

FYI, I just asked upstream for miniupnpc what he thinks about it.

Thomas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#754982: FTBFS on kfreebsd with new miniupnpc

2014-07-16 Thread Petr Salinger 

Package: transmission
Your package failed to build on kfreebsd:


In fact, the problem is sligthly different.
The transmission package does not support newly supplied 
libminiupnpc-dev under both Linux and kFreeBSD:


checking supported miniupnp library... none

As a result, it tries to use embedded version
from transmission-2.82/third-party/miniupnp/

On kFreeBSD, the build fails.
On Linux, the build succeeds, but the resulting binary
does not Depend: libminiupnpc10, as it have been expected.

The transmission package should be ported to use newer miniupnpc everywhere.

The problem is not kfreebsd specific at all.

Petr


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org