Bug#756722: lintian: false positive for embedded-library error
Hi Niels, On 24 August 2015 at 09:00, Niels Thykier wrote: > Hi Raphael, > > I noticed that you added the embedded-lib check for freetype. The > discriminator we currently use is a public function, which means even > correct shared use may cause an auto-reject tag (see below). > > * Are you aware of another discriminator we can use instead, which is > not a part of the public API? After digging in freetype's source code I found one that appears to be safer and safe in general. Attached patch makes lintian look for that other string. I will commit it sometime during the week (I don't have access to my ssh key atm). Apologies for responding until now. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net From 98bda78e8afd03a7c25dc9a758fe957f13b5d340 Mon Sep 17 00:00:00 2001 From: Raphael Geissert Date: Tue, 15 Sep 2015 12:55:13 +0200 Subject: [PATCH] Correct the detection of freetype embedders (Closes: #756722) Even though we now match on the name of a font, all the uses I could find of it in the archive were copies of FreeType. Moreover, matching on the name with the question mark should really limit the number of false positives. --- data/binaries/embedded-libs |2 +- debian/changelog|3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/data/binaries/embedded-libs b/data/binaries/embedded-libs index 0f979e2..2918446 100644 --- a/data/binaries/embedded-libs +++ b/data/binaries/embedded-libs @@ -39,7 +39,7 @@ bzip2 ||(?m)^This is a bug in bzip2 curl ||A libcurl function was given a bad argument expat ||(?m)^requested feature requires XML_DTD support in Expat file ||(?m)^could not find any (?:valid )?magic files -freetype ||FT_Get_CID_Is_Internally_CID_Keyed +freetype ||HuaTianSongTi[?] ftgl ||FTGlyphContainer gl2ps ||\(C\) 1999-2009 C\. Geuzaine glee ||Extension name exceeds 1023 characters\. diff --git a/debian/changelog b/debian/changelog index dace2e9..bc1a8b0 100644 --- a/debian/changelog +++ b/debian/changelog @@ -8,6 +8,9 @@ lintian (2.5.38) UNRELEASED; urgency=medium * checks/obsolete-sites.pm: + [AB] Stop at <>, $, or " when emitting URLs as tag parameter. + * data/binaries/embedded-libs: ++ [RG] Use a different string to detect the copies of freetype + (Closes: #756722) * data/obsolete-sites/obsolete-sites: + [AB] Add patch by Hideki Yamane to add sourceforge.jp (Closes: #798736) -- 1.7.2.5
Bug#756722: lintian: false positive for embedded-library error
Hi Raphael, I noticed that you added the embedded-lib check for freetype. The discriminator we currently use is a public function, which means even correct shared use may cause an auto-reject tag (see below). * Are you aware of another discriminator we can use instead, which is not a part of the public API? Thanks, ~Niels (quote in full for context) On Sat, 2 Aug 2014 09:11:41 +0200 Jakub Wilk wrote: > Control: tags -1 + confirmed > > * Atsuhito Kohda , 2014-08-02, 15:28: > >>>'embedded-library usr/lib/texmacs/TeXmacs/bin/texmacs.bin: freetype', > >>>automatically rejected package. > >> [...] > >>>I rebuild the (accepted) former version of texmacs but got the same > >>>lintian error so I believe this should be false positive. > >> > >>Hmm, I can't reproduce it here. I rebuilt texmacs (1:1.0.7.18-1) in > >>up-to-date unstable amd64 chroot, but the resulting packages don't > >>trigger any such error. > > > >Sorry but I mean texmacs 1.99.1-1 (accepted one) and 1.99.1-2 (rejected > >one) in experimental. > > Oh, I didn't notice that there's a package in experimental. That was a > bit of information I was missing. > > Even the package from the archive triggers the Lintian error: > > $ lintian -F texmacs_1.99.1-1_amd64.deb > E: texmacs: embedded-library usr/lib/texmacs/TeXmacs/bin/texmacs.bin: freetype > > (The package was accepted to the archive, because at that point Lintian > didn't have the check for freetype implemented yet.) > > To detect embedded copies of freetype, Lintian looks for the string > "FT_Get_CID_Is_Internally_CID_Keyed" in the binaries. But this is a name > of a public function, and texmacs just happens to use it. So it's indeed > a false positive. > > I'm not sure why exactly "FT_Get_CID_Is_Internally_CID_Keyed" was > chosen, and what would be a better string to use... Until we figure > it out, please add an override for the tag. > > >I'll upload the package to my homepage but my main machine is in my > >office so it will happen after monday. > > It's no longer necessary. :-) > > -- > Jakub Wilk > >
Bug#756722: lintian: false positive for embedded-library error
On Sat, 2 Aug 2014 09:11:41 +0200, Jakub Wilk wrote: > * Atsuhito Kohda , 2014-08-02, 15:28: (snip) >>Sorry but I mean texmacs 1.99.1-1 (accepted one) and 1.99.1-2 >>(rejected one) in experimental. > > Oh, I didn't notice that there's a package in experimental. That was a > bit of information I was missing. > > Even the package from the archive triggers the Lintian error: > > $ lintian -F texmacs_1.99.1-1_amd64.deb > E: texmacs: embedded-library usr/lib/texmacs/TeXmacs/bin/texmacs.bin: > freetype > > (The package was accepted to the archive, because at that point > Lintian didn't have the check for freetype implemented yet.) > > To detect embedded copies of freetype, Lintian looks for the string > "FT_Get_CID_Is_Internally_CID_Keyed" in the binaries. But this is a > name of a public function, and texmacs just happens to use it. So it's > indeed a false positive. > > I'm not sure why exactly "FT_Get_CID_Is_Internally_CID_Keyed" was > chosen, and what would be a better string to use... Until we figure it > out, please add an override for the tag. I see. Thanks for your clarification. Best regards, 2014-8-2(Sat) -- Debian Developer - much more I18N of Debian Atsuhito Kohda Department of Math., Univ. of Tokushima -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#756722: lintian: false positive for embedded-library error
Control: tags -1 + confirmed * Atsuhito Kohda , 2014-08-02, 15:28: 'embedded-library usr/lib/texmacs/TeXmacs/bin/texmacs.bin: freetype', automatically rejected package. [...] I rebuild the (accepted) former version of texmacs but got the same lintian error so I believe this should be false positive. Hmm, I can't reproduce it here. I rebuilt texmacs (1:1.0.7.18-1) in up-to-date unstable amd64 chroot, but the resulting packages don't trigger any such error. Sorry but I mean texmacs 1.99.1-1 (accepted one) and 1.99.1-2 (rejected one) in experimental. Oh, I didn't notice that there's a package in experimental. That was a bit of information I was missing. Even the package from the archive triggers the Lintian error: $ lintian -F texmacs_1.99.1-1_amd64.deb E: texmacs: embedded-library usr/lib/texmacs/TeXmacs/bin/texmacs.bin: freetype (The package was accepted to the archive, because at that point Lintian didn't have the check for freetype implemented yet.) To detect embedded copies of freetype, Lintian looks for the string "FT_Get_CID_Is_Internally_CID_Keyed" in the binaries. But this is a name of a public function, and texmacs just happens to use it. So it's indeed a false positive. I'm not sure why exactly "FT_Get_CID_Is_Internally_CID_Keyed" was chosen, and what would be a better string to use... Until we figure it out, please add an override for the tag. I'll upload the package to my homepage but my main machine is in my office so it will happen after monday. It's no longer necessary. :-) -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#756722: lintian: false positive for embedded-library error
Hi Jakub, On Fri, 1 Aug 2014 11:15:57 +0200, Jakub Wilk wrote: > * Atsuhito Kohda , 2014-08-01, 11:08: >>rejected by ftp-master because of lintian output: >>'embedded-library usr/lib/texmacs/TeXmacs/bin/texmacs.bin: freetype', >>automatically rejected package. > [...] >>I rebuild the (accepted) former version of texmacs but got the same >>lintian error so I believe this should be false positive. > > Hmm, I can't reproduce it here. I rebuilt texmacs (1:1.0.7.18-1) in > up-to-date unstable amd64 chroot, but the resulting packages don't > trigger any such error. Sorry but I mean texmacs 1.99.1-1 (accepted one) and 1.99.1-2 (rejected one) in experimental. Due to some fonts license issue, I upload texmacs in experimental recently. > Could you upload the packages somewhere (and preferably also the build > log), so that we can take a close look at them? I'll upload the package to my homepage but my main machine is in my office so it will happen after monday. Thanks for your work. Best regards, 2014-8-2(Sat) -- Debian Developer - much more I18N of Debian Atsuhito Kohda Department of Math., Univ. of Tokushima -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#756722: lintian: false positive for embedded-library error
* Atsuhito Kohda , 2014-08-01, 11:08: rejected by ftp-master because of lintian output: 'embedded-library usr/lib/texmacs/TeXmacs/bin/texmacs.bin: freetype', automatically rejected package. [...] I rebuild the (accepted) former version of texmacs but got the same lintian error so I believe this should be false positive. Hmm, I can't reproduce it here. I rebuilt texmacs (1:1.0.7.18-1) in up-to-date unstable amd64 chroot, but the resulting packages don't trigger any such error. Could you upload the packages somewhere (and preferably also the build log), so that we can take a close look at them? -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#756722: lintian: false positive for embedded-library error
Package: lintian Version: 2.5.25 Severity: important Dear Maintainer, * What led up to the situation? usual debuild and pdebuild. * What exactly did you do (or not do) that was effective (or ineffective)? usual debuild and pdebuild. * What was the outcome of this action? rejected by ftp-master because of lintian output: 'embedded-library usr/lib/texmacs/TeXmacs/bin/texmacs.bin: freetype', automatically rejected package. * What outcome did you expect instead? smooth upload without any error. I rebuild the (accepted) former version of texmacs but got the same lintian error so I believe this should be false positive. Thanks for your efforts. Best regards, 2014-8-1(Fri) Atsuhito Kohda -- System Information: Debian Release: jessie/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores) Locale: LANG=ja_JP.UTF-8, LC_CTYPE=ja_JP.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.24.51.20140727-1 ii bzip2 1.0.6-7 ii diffstat 1.58-1 ii file 1:5.19-1 ii gettext0.19.2-1 ii hardening-includes 2.5 ii intltool-debian0.35.0+20060710.1 ii libapt-pkg-perl0.1.29+b1 ii libarchive-zip-perl1.37-2 ii libclass-accessor-perl 0.34-1 ii libclone-perl 0.37-1 ii libdpkg-perl 1.17.10 ii libemail-valid-perl1.194-1 ii libfile-basedir-perl 0.03-1 ii libipc-run-perl0.92-1 ii liblist-moreutils-perl 0.33-2 ii libparse-debianchangelog-perl 1.2.0-1 ii libtext-levenshtein-perl 0.09-1 ii libtimedate-perl 2.3000-2 ii liburi-perl1.64-1 ii man-db 2.6.7.1-1 ii patchutils 0.3.3-1 ii perl [libdigest-sha-perl] 5.18.2-7 ii t1utils1.37-2 Versions of packages lintian recommends: ii libautodie-perl 2.25-1 ii libperlio-gzip-perl 0.18-3 ii perl-modules [libautodie-perl] 5.18.2-7 Versions of packages lintian suggests: pn binutils-multiarch ii dpkg-dev 1.17.10 ii libhtml-parser-perl3.71-1+b1 pn libtext-template-perl pn libyaml-perl ii xz-utils 5.1.1alpha+20120614-2 -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
