Bug#757585: missing libtool-update on smpeg
Hi, 2014-08-29 23:04 GMT+01:00 Andreas Barth a...@ayous.org: * Andreas Barth (a...@ayous.org) [140829 23:55]: - Remove everything from acinclude.m4 except the entry for socklen_t (the last one). According to changelog that change was already done by Branden Robinson in 2001, and confirmed by Felix Geyer in 2011. For that reason I tend to commit that change again on Sunday evening unless I get review otherwise. I am a bit busy right now and will continue to be for a few days, so I cannot guarantee that I have time to review this within 10 days at least. For me, it's fine if you want to NMU and do it ASAP, and I want to thank you anyway for finding the problem and the solution. Alas, I was helping to bootstrap the new arches NMUing other packages during the past few months, and now it's mine which is blocking things... :o) Cheers. -- Manuel A. Fernandez Montecelo manuel.montez...@gmail.com -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757585: missing libtool-update on smpeg
* Manuel A. Fernandez Montecelo (manuel.montez...@gmail.com) [140830 13:22]: Hi, 2014-08-29 23:04 GMT+01:00 Andreas Barth a...@ayous.org: * Andreas Barth (a...@ayous.org) [140829 23:55]: - Remove everything from acinclude.m4 except the entry for socklen_t (the last one). According to changelog that change was already done by Branden Robinson in 2001, and confirmed by Felix Geyer in 2011. For that reason I tend to commit that change again on Sunday evening unless I get review otherwise. I am a bit busy right now and will continue to be for a few days, so I cannot guarantee that I have time to review this within 10 days at least. Ok. I will wait a bit to give other the chance to review the patches, even though it looks fine for me. For me, it's fine if you want to NMU and do it ASAP, and I want to thank you anyway for finding the problem and the solution. Thanks for allowing the NMU. Alas, I was helping to bootstrap the new arches NMUing other packages during the past few months, and now it's mine which is blocking things... :o) I'm not saying my own packages never block ;) Andi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757585: missing libtool-update on smpeg
Hi, On 30.08.2014 13:24, Andreas Barth wrote: * Manuel A. Fernandez Montecelo (manuel.montez...@gmail.com) [140830 13:22]: Hi, 2014-08-29 23:04 GMT+01:00 Andreas Barth a...@ayous.org: * Andreas Barth (a...@ayous.org) [140829 23:55]: - Remove everything from acinclude.m4 except the entry for socklen_t (the last one). According to changelog that change was already done by Branden Robinson in 2001, and confirmed by Felix Geyer in 2011. For that reason I tend to commit that change again on Sunday evening unless I get review otherwise. I am a bit busy right now and will continue to be for a few days, so I cannot guarantee that I have time to review this within 10 days at least. Ok. I will wait a bit to give other the chance to review the patches, even though it looks fine for me. The acinclude.m4 changes look fine. Why is the AM_PROG_LIBTOOL - AC_PROG_LIBTOOL change needed? I know AM_PROG_LIBTOOL is deprecated but so is probably the whole autotools usage of smpeg. A test build with just the acinclude.m4 changes worked fine on pcc64el. Cheers, Felix -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757585: missing libtool-update on smpeg
* Felix Geyer (fge...@debian.org) [140830 18:51]: Why is the AM_PROG_LIBTOOL - AC_PROG_LIBTOOL change needed? Because autoreconf calls libtool only with AC_ and not with AM_, see bug #759739 (IMHO an error with autoreconf, but I don't want to wait for that with this fix). Or at least that was my experience. A test build with just the acinclude.m4 changes worked fine on pcc64el. Hm. I think I'll also re-test it then. Andi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757585: missing libtool-update on smpeg
Hi,
* Andreas Barth (a...@ayous.org) [140829 19:06]:
Control: reopen -1
* Use dh-autoreconf during build to update for new architectures
(Closes: #757585)
Unfortunatly this bug still exists on ppc64el, which seems to indicate
that also libtool needs refreshing (or autoreconf didn't work):
| dh_install --fail-missing -Xlibsmpeg.la
| dh_install: libsmpeg0 missing files (usr/lib/*/libsmpeg-0.4.so.0*), aborting
| make[1]: *** [override_dh_install] Error 255
See
https://buildd.debian.org/status/fetch.php?pkg=smpegarch=ppc64elver=0.4.5%2Bcvs20030824-7stamp=1409171354
for details.
As this is blocking the build of sdl-mixer1.2 I'll try to find and if
necessary upload a fix ASAP.
with some more investigation, the required changes are:
- Replace AM_PROG_LIBTOOL by AC_PROG_LIBTOOL in configure.in (so that
autoreconf also calls libtool)
- Remove everything from acinclude.m4 except the entry for socklen_t
(the last one).
For the second change, I'd prefer some review (the package builts fine,
but I'm not sure that this is enough).
Andi
--- smpeg-0.4.5+cvs20030824.orig/acinclude.m4
+++ smpeg-0.4.5+cvs20030824/acinclude.m4
@@ -1,605 +1,3 @@
-# Configure paths for SDL
-# Sam Lantinga 9/21/99
-# stolen from Manish Singh
-# stolen back from Frank Belew
-# stolen from Manish Singh
-# Shamelessly stolen from Owen Taylor
-
-dnl AM_PATH_SDL([MINIMUM-VERSION, [ACTION-IF-FOUND [, ACTION-IF-NOT-FOUND]]])
-dnl Test for SDL, and define SDL_CFLAGS and SDL_LIBS
-dnl
-AC_DEFUN(AM_PATH_SDL,
-[dnl
-dnl Get the cflags and libraries from the sdl-config script
-dnl
-AC_ARG_WITH(sdl-prefix,[ --with-sdl-prefix=PFX Prefix where SDL is installed (optional)],
-sdl_prefix=$withval, sdl_prefix=)
-AC_ARG_WITH(sdl-exec-prefix,[ --with-sdl-exec-prefix=PFX Exec prefix where SDL is installed (optional)],
-sdl_exec_prefix=$withval, sdl_exec_prefix=)
-AC_ARG_ENABLE(sdltest, [ --disable-sdltest Do not try to compile and run a test SDL program],
- , enable_sdltest=yes)
-
- if test x$sdl_exec_prefix != x ; then
- sdl_args=$sdl_args --exec-prefix=$sdl_exec_prefix
- if test x${SDL_CONFIG+set} != xset ; then
-SDL_CONFIG=$sdl_exec_prefix/bin/sdl-config
- fi
- fi
- if test x$sdl_prefix != x ; then
- sdl_args=$sdl_args --prefix=$sdl_prefix
- if test x${SDL_CONFIG+set} != xset ; then
-SDL_CONFIG=$sdl_prefix/bin/sdl-config
- fi
- fi
-
- AC_PATH_PROG(SDL_CONFIG, sdl-config, no)
- min_sdl_version=ifelse([$1], ,0.11.0,$1)
- AC_MSG_CHECKING(for SDL - version = $min_sdl_version)
- no_sdl=
- if test $SDL_CONFIG = no ; then
-no_sdl=yes
- else
-SDL_CFLAGS=`$SDL_CONFIG $sdlconf_args --cflags`
-SDL_LIBS=`$SDL_CONFIG $sdlconf_args --libs`
-
-sdl_major_version=`$SDL_CONFIG $sdl_args --version | \
- sed 's/\([[0-9]]*\).\([[0-9]]*\).\([[0-9]]*\)/\1/'`
-sdl_minor_version=`$SDL_CONFIG $sdl_args --version | \
- sed 's/\([[0-9]]*\).\([[0-9]]*\).\([[0-9]]*\)/\2/'`
-sdl_micro_version=`$SDL_CONFIG $sdl_config_args --version | \
- sed 's/\([[0-9]]*\).\([[0-9]]*\).\([[0-9]]*\)/\3/'`
-if test x$enable_sdltest = xyes ; then
- ac_save_CFLAGS=$CFLAGS
- ac_save_LIBS=$LIBS
- CFLAGS=$CFLAGS $SDL_CFLAGS
- LIBS=$LIBS $SDL_LIBS
-dnl
-dnl Now check if the installed SDL is sufficiently new. (Also sanity
-dnl checks the results of sdl-config to some extent
-dnl
- rm -f conf.sdltest
- AC_TRY_RUN([
-#include stdio.h
-#include stdlib.h
-#include string.h
-#include SDL.h
-
-char*
-my_strdup (char *str)
-{
- char *new_str;
-
- if (str)
-{
- new_str = (char *)malloc ((strlen (str) + 1) * sizeof(char));
- strcpy (new_str, str);
-}
- else
-new_str = NULL;
-
- return new_str;
-}
-
-int main (int argc, char *argv[])
-{
- int major, minor, micro;
- char *tmp_version;
-
- /* This hangs on some systems (?)
- system (touch conf.sdltest);
- */
- { FILE *fp = fopen(conf.sdltest, a); if ( fp ) fclose(fp); }
-
- /* HP/UX 9 (%@#!) writes to sscanf strings */
- tmp_version = my_strdup($min_sdl_version);
- if (sscanf(tmp_version, %d.%d.%d, major, minor, micro) != 3) {
- printf(%s, bad version string\n, $min_sdl_version);
- exit(1);
- }
-
- if (($sdl_major_version major) ||
- (($sdl_major_version == major) ($sdl_minor_version minor)) ||
- (($sdl_major_version == major) ($sdl_minor_version == minor) ($sdl_micro_version = micro)))
-{
- return 0;
-}
- else
-{
- printf(\n*** 'sdl-config --version' returned %d.%d.%d, but the minimum version\n, $sdl_major_version, $sdl_minor_version, $sdl_micro_version);
- printf(*** of SDL required is %d.%d.%d. If sdl-config is correct, then it is\n, major, minor, micro);
- printf(*** best to upgrade to the required version.\n);
- printf(*** If sdl-config was wrong, set the environment variable SDL_CONFIG\n);
- printf(*** to point to the correct copy of
Bug#757585: missing libtool-update on smpeg
* Andreas Barth (a...@ayous.org) [140829 23:55]: - Remove everything from acinclude.m4 except the entry for socklen_t (the last one). According to changelog that change was already done by Branden Robinson in 2001, and confirmed by Felix Geyer in 2011. For that reason I tend to commit that change again on Sunday evening unless I get review otherwise. Andi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
