Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Cyril Brulebois k...@debian.org (2014-09-06): Philipp Kern pk...@debian.org (2014-09-05): On Fri, Sep 05, 2014 at 09:55:24AM +0200, Cyril Brulebois wrote: Steven Chamberlain ste...@pyro.eu.org (2014-08-31): On 31/08/14 07:00, Philipp Kern wrote: Is perhaps the same true for stop_rdnssd() on the next line? So Steven committed a patch in to git, getting rid of the dhcp part; Philipp, should I upload that and we'll figure out the rdnssd part another time? ACK. I wanted to look at it today, but meh. rdnssd isn't as critical as it won't take your interface down if you kill it. You just won't get updated DNS information. Alright, thanks. Quickly checked on Linux that going back to the network step still kills the dhcp client and get it started again. Tagged and uploaded. Mraw, KiBi. Should that get fixed in wheezy as well? I've spotted this is still marked as affecting this release but if that's no practical issue (we would have been aware of this for quite some time already I guess), it might be OK to wheezy-ignore it or notfound it in wheezy's version. Thoughts? Mraw, KiBi. signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Steven Chamberlain ste...@pyro.eu.org (2014-08-31): On 31/08/14 07:00, Philipp Kern wrote: Is perhaps the same true for stop_rdnssd() on the next line? So Steven committed a patch in to git, getting rid of the dhcp part; Philipp, should I upload that and we'll figure out the rdnssd part another time? Mraw, KiBi. signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
On Fri, Sep 05, 2014 at 09:55:24AM +0200, Cyril Brulebois wrote: Steven Chamberlain ste...@pyro.eu.org (2014-08-31): On 31/08/14 07:00, Philipp Kern wrote: Is perhaps the same true for stop_rdnssd() on the next line? So Steven committed a patch in to git, getting rid of the dhcp part; Philipp, should I upload that and we'll figure out the rdnssd part another time? ACK. I wanted to look at it today, but meh. rdnssd isn't as critical as it won't take your interface down if you kill it. You just won't get updated DNS information. Kind regards and thanks Philipp Kern signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Philipp Kern pk...@debian.org (2014-09-05): On Fri, Sep 05, 2014 at 09:55:24AM +0200, Cyril Brulebois wrote: Steven Chamberlain ste...@pyro.eu.org (2014-08-31): On 31/08/14 07:00, Philipp Kern wrote: Is perhaps the same true for stop_rdnssd() on the next line? So Steven committed a patch in to git, getting rid of the dhcp part; Philipp, should I upload that and we'll figure out the rdnssd part another time? ACK. I wanted to look at it today, but meh. rdnssd isn't as critical as it won't take your interface down if you kill it. You just won't get updated DNS information. Alright, thanks. Quickly checked on Linux that going back to the network step still kills the dhcp client and get it started again. Tagged and uploaded. Mraw, KiBi. signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
On Fri, Aug 29, 2014 at 11:25:28PM +0200, Cyril Brulebois wrote: I'd be slightly happier if Philipp would comment on this since he seems to be the one having committed this change. See: | commit 8802ca520d9e91542d92bbfa5b2fc412a31cf2e2 | Author: Matt Palmer mpal...@hezmatt.org | Date: Sun Jan 30 22:29:42 2011 +1100 | | IPv6 support for using rDNS to preseed hostnames | | A lot of refactoring to make the code cleaner and simpler, but the | IPv6-specific changes were actually relatively small. | | Rebased-and-modified-by: Philipp Kern pk...@debian.org http://anonscm.debian.org/cgit/d-i/netcfg.git/commit/?id=8802ca520d9e91542d92bbfa5b2fc412a31cf2e2 I did some archeology and I'll spare you the details. That kill_dhcp_client is totally wrong where it is now, so LGTM. Thanks. Kind regards Philipp Kern signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Hi Philipp, On 31/08/14 07:00, Philipp Kern wrote: On Fri, Aug 29, 2014 at 11:25:28PM +0200, Cyril Brulebois wrote: See: | commit 8802ca520d9e91542d92bbfa5b2fc412a31cf2e2 | Author: Matt Palmer mpal...@hezmatt.org | Date: Sun Jan 30 22:29:42 2011 +1100 | | IPv6 support for using rDNS to preseed hostnames | | A lot of refactoring to make the code cleaner and simpler, but the | IPv6-specific changes were actually relatively small. | | Rebased-and-modified-by: Philipp Kern pk...@debian.org http://anonscm.debian.org/cgit/d-i/netcfg.git/commit/?id=8802ca520d9e91542d92bbfa5b2fc412a31cf2e2 I did some archeology and I'll spare you the details. That kill_dhcp_client is totally wrong where it is now, so LGTM. Thanks. Is perhaps the same true for stop_rdnssd() on the next line? Thanks, Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Hi, Please may I commit this to d-i/netcfg (assuming my d-i Git privileges include that repository). As well as kfreebsd, I expect hurd is currently affected by this bug, so this patch would also fix it there. Thanks. --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +netcfg (1.120) UNRELEASED; urgency=medium + + [ Steven Chamberlain ] + * Do not kill_dhcp_client after setting the hostname and domain, +otherwise Linux udhcpc will stop renewing its lease, and on other +platforms dhclient will de-configure the network interface +(Closes: #757711, #757988) + + -- Debian Install System Team debian-b...@lists.debian.org Fri, 29 Aug 2014 22:05:47 +0100 + netcfg (1.119) unstable; urgency=medium [ Colin Watson ] diff --git a/dhcp.c b/dhcp.c index aa37bd0..5ef0dbc 100644 --- a/dhcp.c +++ b/dhcp.c @@ -614,7 +614,6 @@ int netcfg_activate_dhcp (struct debconfclient *client, struct netcfg_interface netcfg_write_loopback(); netcfg_write_interface(interface); netcfg_write_resolv(domain, interface); -kill_dhcp_client(); stop_rdnssd(); return 0; -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Steven Chamberlain ste...@pyro.eu.org (2014-08-29): Please may I commit this to d-i/netcfg (assuming my d-i Git privileges include that repository). (Yes, we have no per-repository settings that I'm aware of.) As well as kfreebsd, I expect hurd is currently affected by this bug, so this patch would also fix it there. Thanks. --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,13 @@ +netcfg (1.120) UNRELEASED; urgency=medium + + [ Steven Chamberlain ] + * Do not kill_dhcp_client after setting the hostname and domain, +otherwise Linux udhcpc will stop renewing its lease, and on other +platforms dhclient will de-configure the network interface +(Closes: #757711, #757988) + + -- Debian Install System Team debian-b...@lists.debian.org Fri, 29 Aug 2014 22:05:47 +0100 + netcfg (1.119) unstable; urgency=medium [ Colin Watson ] diff --git a/dhcp.c b/dhcp.c index aa37bd0..5ef0dbc 100644 --- a/dhcp.c +++ b/dhcp.c @@ -614,7 +614,6 @@ int netcfg_activate_dhcp (struct debconfclient *client, struct netcfg_interface netcfg_write_loopback(); netcfg_write_interface(interface); netcfg_write_resolv(domain, interface); -kill_dhcp_client(); stop_rdnssd(); return 0; I'd be slightly happier if Philipp would comment on this since he seems to be the one having committed this change. See: | commit 8802ca520d9e91542d92bbfa5b2fc412a31cf2e2 | Author: Matt Palmer mpal...@hezmatt.org | Date: Sun Jan 30 22:29:42 2011 +1100 | | IPv6 support for using rDNS to preseed hostnames | | A lot of refactoring to make the code cleaner and simpler, but the | IPv6-specific changes were actually relatively small. | | Rebased-and-modified-by: Philipp Kern pk...@debian.org http://anonscm.debian.org/cgit/d-i/netcfg.git/commit/?id=8802ca520d9e91542d92bbfa5b2fc412a31cf2e2 Mraw, KiBi. signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
On Tue, Aug 12, 2014 at 02:45:25AM +0200, Cyril Brulebois wrote: That I don't know. Maybe try and compare with netcfg + dhcp client du jour on Linux, and see whether netcfg's behaviour is different in both cases, or the dhcp client's one, or the kernel's one. In the end there's a lot of sadness around what we do, what Ubuntu does, and what the end result is. Ubuntu uses isc-dhcp-client, so the same as on kfreebsd-* and might as well have some additional patches to netcfg because of this. But at work we do use Ubuntu and found that dhclient is called with -1. If the lease expires during installation and your switch does DHCP snooping, you lose network during installation because the DHCP client does not continue to renew it. This is anecdotal experience but divergence between Linux and kfreebsd wrt DHCP might mean that certain problems need to be solved twice or certain failure modes only happen in one or another, with userspace being the reason, not even the kernel difference. Kind regards Philipp Kern signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
On Tue, Aug 12, 2014 at 02:45:25AM +0200, Cyril Brulebois wrote: That I don't know. Maybe try and compare with netcfg + dhcp client du jour on Linux, and see whether netcfg's behaviour is different in both cases, or the dhcp client's one, or the kernel's one. netcfg kills the running DHCP client on linux too. On 12/08/14 20:19, Philipp Kern wrote: In the end there's a lot of sadness around what we do, what Ubuntu does, and what the end result is. Ubuntu uses isc-dhcp-client, so the same as on kfreebsd-* and might as well have some additional patches to netcfg because of this. I could maybe look into porting udhcpc to kfreebsd; that is if netcfg maintainers still think it is preferred over ISC DHCP? (udhcpc saves about 2MiB in the install image, if that's reason enough). Or otherwise go the other way and try to have all architectures using isc-dhcp-client-udeb. Except - I'm not sure how heavily systemd is going to feature in d-i for jessie or jessie+1? If systemd's own DHCP client is going to take over this task someday we'd end up with different implementations again, making either of the above changes a waste of time, and personally I'd prefer to keep the fully-featured ISC DHCP in that case. (Releasing the DHCP lease and deconfiguring the interface seems to be a feature udhcpc *lacks*, hence why the problem is not seen yet on linux). But at work we do use Ubuntu and found that dhclient is called with -1. If the lease expires during installation and your switch does DHCP snooping, you lose network during installation because the DHCP client does not continue to renew it. FWIW the netcfg patch in my last message seems to have fixed this nicely for kfreebsd. And it keeps the dhclient/udhcpc running throughout the install - I think that is desirable whichever one is used, to avoid the issue described above. This is anecdotal experience but divergence between Linux and kfreebsd wrt DHCP might mean that certain problems need to be solved twice or certain failure modes only happen in one or another, with userspace being the reason, not even the kernel difference. Thanks for sharing that info. Regards, -- Steven Chamberlain ste...@pyro.eu.org -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Steven Chamberlain ste...@pyro.eu.org (2014-08-12): Except - I'm not sure how heavily systemd is going to feature in d-i for jessie or jessie+1? Last I checked we were using busybox init… Mraw, KiBi. signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
tags 757711 + patch thanks I'd like to propose this patch to netcfg as a fix for this bug: https://bugs.debian.org/757711#52 On 12/08/14 20:53, Cyril Brulebois wrote: Steven Chamberlain ste...@pyro.eu.org (2014-08-12): Except - I'm not sure how heavily systemd is going to feature in d-i for jessie or jessie+1? Last I checked we were using busybox init… I guess that means there are no plans for jessie d-i to use systemd. So for now my thoughts are: * it is desirable to converge on a common DHCP client across all architectures, but for jessie (having just looked at udhcpc) it is too late to do this * for jessie+1, we'll have to wait and see whether systemd finds its way into d-i: because if it does, it may take over DHCP client functionality and non-linux ports may be best keeping isc-dhcp-client-udeb (udhcpc would go away); if it does not, it may be better for udhcpc to be ported to non-linux and converge on that instead Regards, -- Steven Chamberlain ste...@pyro.eu.org signature.asc Description: OpenPGP digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Steven Chamberlain ste...@pyro.eu.org (2014-08-11): retitle 757711 netcfg: promptly kills dhclient, deconfigures interface reassign 757711 src:netcfg found 757711 netcfg/1.118 severity 757711 grave user debian-...@lists.debian.org usertags 757711 + kfreebsd thanks Steve, if you want to interact with the maintainer of a package you're reassigning a bug to, you need to add the said maintainer to Cc. Otherwise the received mail only contains the results of the control commands: https://lists.debian.org/debian-boot/2014/08/msg00215.html Now that -boot@ owns the bug report, keeping the bug report, -bsd@, and the submitter in the loop should be sufficient. Full quoting follows, for those not following -bsd@. Mraw, KiBi. Hi, On 11/08/14 08:18, Jan Henke wrote: [...] DHCP client terminating directly after network detection (after receiving signal 15), which interferes later with the mirror selection, as there is no Internet connection then. More specifically, this is what I see happening: * dhclient correctly gets a DHCP lease and correctly sets the IPv4 address on the interface * if it doesn't know yet what hostname to use, netcfg prompts the user to enter one (and the DNS search domain) * right after entering those, dhclient receives SIGTERM, gives up the DHCP lease and deconfigures the interface. Aug 11 11:12:09 netcfg[1872]: WARNING **: Started DHCP client; PID is 1919 Aug 11 11:12:10 dhclient: DHCPDISCOVER on em0 to 255.255.255.255 port 67 interval 1 Aug 11 11:12:10 dhclient: DHCPREQUEST on em0 to 255.255.255.255 port 67 Aug 11 11:12:10 dhclient: DHCPOFFER from 10.0.2.2 Aug 11 11:12:10 dhclient: DHCPACK from 10.0.2.2 Aug 11 11:12:10 dhclient: bound to 10.0.2.15 -- renewal in 41223 seconds. Aug 11 11:12:12 netcfg[1872]: DEBUG: Reading domain name returned via DHCP Aug 11 11:12:12 netcfg[1872]: DEBUG: DHCP domain name is '' Aug 11 11:12:12 netcfg[1872]: DEBUG: Reading nameservers from /etc/resolv.conf Aug 11 11:12:12 netcfg[1872]: DEBUG: Read nameserver 10.0.2.3 Aug 11 11:12:12 netcfg[1872]: DEBUG: State is now 1 Aug 11 11:12:12 netcfg[1872]: DEBUG: State is now 2 Aug 11 11:12:12 netcfg[1872]: DEBUG: State is now 5 Aug 11 11:12:12 netcfg[1872]: DEBUG: Using DNS to try and obtain default hostname Aug 11 11:12:12 netcfg[1872]: DEBUG: Getting default hostname from rDNS lookup of autoconfigured address fe80::5054:ff:fe12:3456 Aug 11 11:12:12 netcfg[1872]: DEBUG: getnameinfo() returned -2 (Name or service not known) Aug 11 11:12:12 netcfg[1872]: DEBUG: Getting default hostname from rDNS lookup of autoconfigured address 10.0.2.15 Aug 11 11:12:12 netcfg[1872]: DEBUG: getnameinfo() returned -2 (Name or service not known) ...then hostname and domain are provided... Aug 11 11:12:22 netcfg[1872]: DEBUG: State is now 6 Aug 11 11:12:23 netcfg[1872]: DEBUG: Network config complete Aug 11 11:12:23 netcfg[1872]: DEBUG: No interface given; clearing /etc/network/interfaces Aug 11 11:12:23 netcfg[1872]: DEBUG: Writing informative header Aug 11 11:12:23 netcfg[1872]: DEBUG: Success! Aug 11 11:12:23 netcfg[1872]: DEBUG: Writing loopback interface Aug 11 11:12:23 netcfg[1872]: DEBUG: Success! Aug 11 11:12:23 netcfg[1872]: DEBUG: Writing DHCP stanza for em0 Aug 11 11:12:23 netcfg[1872]: INFO: No hotpluggable devices are present in the system. Aug 11 11:12:23 netcfg[1872]: DEBUG: Success! Aug 11 11:12:23 dhclient: Received signal 15, initiating shutdown. Aug 11 11:12:23 dhclient: DHCPRELEASE on em0 to 10.0.2.2 port 67 Incriminating code is at: http://anonscm.debian.org/cgit/d-i/netcfg.git/tree/dhcp.c#n617 Is it really intended that kill_dhcp_client will deconfigure the interface? Why was this not a problem for wheezy d-i? Is it supposed to be brought back up again in a later step? Regards, -- Steven Chamberlain ste...@pyro.eu.org signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
retitle 757711 netcfg: promptly kills dhclient, deconfigures interface reassign 757711 src:netcfg found 757711 netcfg/1.118 severity 757711 grave user debian-...@lists.debian.org usertags 757711 + kfreebsd thanks Hi, On 11/08/14 08:18, Jan Henke wrote: [...] DHCP client terminating directly after network detection (after receiving signal 15), which interferes later with the mirror selection, as there is no Internet connection then. More specifically, this is what I see happening: * dhclient correctly gets a DHCP lease and correctly sets the IPv4 address on the interface * if it doesn't know yet what hostname to use, netcfg prompts the user to enter one (and the DNS search domain) * right after entering those, dhclient receives SIGTERM, gives up the DHCP lease and deconfigures the interface. Aug 11 11:12:09 netcfg[1872]: WARNING **: Started DHCP client; PID is 1919 Aug 11 11:12:10 dhclient: DHCPDISCOVER on em0 to 255.255.255.255 port 67 interval 1 Aug 11 11:12:10 dhclient: DHCPREQUEST on em0 to 255.255.255.255 port 67 Aug 11 11:12:10 dhclient: DHCPOFFER from 10.0.2.2 Aug 11 11:12:10 dhclient: DHCPACK from 10.0.2.2 Aug 11 11:12:10 dhclient: bound to 10.0.2.15 -- renewal in 41223 seconds. Aug 11 11:12:12 netcfg[1872]: DEBUG: Reading domain name returned via DHCP Aug 11 11:12:12 netcfg[1872]: DEBUG: DHCP domain name is '' Aug 11 11:12:12 netcfg[1872]: DEBUG: Reading nameservers from /etc/resolv.conf Aug 11 11:12:12 netcfg[1872]: DEBUG: Read nameserver 10.0.2.3 Aug 11 11:12:12 netcfg[1872]: DEBUG: State is now 1 Aug 11 11:12:12 netcfg[1872]: DEBUG: State is now 2 Aug 11 11:12:12 netcfg[1872]: DEBUG: State is now 5 Aug 11 11:12:12 netcfg[1872]: DEBUG: Using DNS to try and obtain default hostname Aug 11 11:12:12 netcfg[1872]: DEBUG: Getting default hostname from rDNS lookup of autoconfigured address fe80::5054:ff:fe12:3456 Aug 11 11:12:12 netcfg[1872]: DEBUG: getnameinfo() returned -2 (Name or service not known) Aug 11 11:12:12 netcfg[1872]: DEBUG: Getting default hostname from rDNS lookup of autoconfigured address 10.0.2.15 Aug 11 11:12:12 netcfg[1872]: DEBUG: getnameinfo() returned -2 (Name or service not known) ...then hostname and domain are provided... Aug 11 11:12:22 netcfg[1872]: DEBUG: State is now 6 Aug 11 11:12:23 netcfg[1872]: DEBUG: Network config complete Aug 11 11:12:23 netcfg[1872]: DEBUG: No interface given; clearing /etc/network/interfaces Aug 11 11:12:23 netcfg[1872]: DEBUG: Writing informative header Aug 11 11:12:23 netcfg[1872]: DEBUG: Success! Aug 11 11:12:23 netcfg[1872]: DEBUG: Writing loopback interface Aug 11 11:12:23 netcfg[1872]: DEBUG: Success! Aug 11 11:12:23 netcfg[1872]: DEBUG: Writing DHCP stanza for em0 Aug 11 11:12:23 netcfg[1872]: INFO: No hotpluggable devices are present in the system. Aug 11 11:12:23 netcfg[1872]: DEBUG: Success! Aug 11 11:12:23 dhclient: Received signal 15, initiating shutdown. Aug 11 11:12:23 dhclient: DHCPRELEASE on em0 to 10.0.2.2 port 67 Incriminating code is at: http://anonscm.debian.org/cgit/d-i/netcfg.git/tree/dhcp.c#n617 Is it really intended that kill_dhcp_client will deconfigure the interface? Why was this not a problem for wheezy d-i? Is it supposed to be brought back up again in a later step? Regards, -- Steven Chamberlain ste...@pyro.eu.org signature.asc Description: OpenPGP digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Control: found -1 netcfg/1.117 Cyril Brulebois k...@debian.org (2014-08-11): Steven Chamberlain ste...@pyro.eu.org (2014-08-11): retitle 757711 netcfg: promptly kills dhclient, deconfigures interface reassign 757711 src:netcfg found 757711 netcfg/1.118 severity 757711 grave Eeww, I missed that. user debian-...@lists.debian.org usertags 757711 + kfreebsd thanks Steven, if you're going to raise severity to something RC, *please* check whether the version in testing is also affected. In this particular case you've effectively prevented netcfg's migration to testing while it was fixing a bug, not introducing one! The found command above should tell the BTS and britney that the bug was already in testing, so that it's considered for the next britney run. (I'm not sure I'm convinced by the severity anyway.) Jan, sending the whole /var/log/syslog could help, instead of just a screenshot of the last few lines. Mraw, KiBi. signature.asc Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
found 757711 1.108+deb7u1 thanks On 11/08/14 23:57, Cyril Brulebois wrote: found 757711 netcfg/1.118 severity 757711 grave Eeww, I missed that. Sorry, assumed you'd seen this... though I did feel the severity was justified since DHCP is the most common use-case. I also don't know yet it if this is really kfreebsd-specific? Steven, if you're going to raise severity to something RC, *please* check whether the version in testing is also affected. I really tried to do this before the ~1800UTC deadline, which I think is when Britney takes a snapshot of BTS state. I'm afraid it didn't go smoothly and I ran out of time. And so that left only two options: * cheat: downgrade the bug against my own judgement, or tentatively mark it as affecting testing - with a slight chance of introducing a new bug otherwise, * or leave it this way, even if it delays migration for a day, until someone else or I can figure this out for sure. Anyhow I've tested as far back as the wheezy version of netcfg and seemingly, that shows the same issue, suggesting it was a change somewhere else (like isc-dhcp-client-udeb) that caused this bug to appear. It still may be netcfg where this needs to be fixed, I don't know yet. Jan, sending the whole /var/log/syslog could help, instead of just a screenshot of the last few lines. I've attached mine (captured with serial logging tricks), but doesn't seem to give more clues than my last message in this thread. Regards, -- Steven Chamberlain ste...@pyro.eu.org Copyright (c) 1992-2014 The FreeBSD Project. Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994 The Regents of the University of California. All rights reserved. FreeBSD is a registered trademark of The FreeBSD Foundation. #0 Mon, 11 Aug 2014 02:00:01 +0100 amd64 Debian clang version 3.4.2-4 (tags/RELEASE_34/dot2-final) (based on LLVM 3.4.2) VT: running with driver vga. CPU: QEMU Virtual CPU version 1.1.2 (2400.14-MHz K8-class CPU) Origin = AuthenticAMD Id = 0x623 Family = 0x6 Model = 0x2 Stepping = 3 Features=0x78bfbfdFPU,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CLFLUSH,MMX,FXSR,SSE,SSE2 Features2=0x80002001SSE3,CX16,HV AMD Features=0x20100800SYSCALL,NX,LM AMD Features2=0x5LAHF,SVM real memory = 268427264 (255 MB) avail memory = 157302784 (150 MB) Event timer LAPIC quality 400 ACPI APIC Table: BOCHS BXPCAPIC random device not loaded; using insecure entropy ioapic0: Changing APIC ID to 1 ioapic0 Version 1.1 irqs 0-23 on motherboard random: Software, Yarrow initialized kbd1 at kbdmux0 cryptosoft0: software crypto on motherboard acpi0: BOCHS BXPCRSDT on motherboard acpi0: Power Button (fixed) cpu0: ACPI CPU on acpi0 atrtc0: AT realtime clock port 0x70-0x71,0x72-0x77 irq 8 on acpi0 Event timer RTC frequency 32768 Hz quality 0 hpet0: High Precision Event Timer iomem 0xfed0-0xfed003ff on acpi0 Timecounter HPET frequency 1 Hz quality 950 Timecounter ACPI-safe frequency 3579545 Hz quality 850 acpi_timer0: 24-bit timer at 3.579545MHz port 0xb008-0xb00b on acpi0 pcib0: ACPI Host-PCI bridge port 0xcf8-0xcff on acpi0 pci0: ACPI PCI bus on pcib0 pci_link4: Unable to route IRQs: AE_NOT_FOUND isab0: PCI-ISA bridge at device 1.0 on pci0 isa0: ISA bus on isab0 atapci0: Intel PIIX3 WDMA2 controller port 0x1f0-0x1f7,0x3f6,0x170-0x177,0x376,0xc040-0xc04f at device 1.1 on pci0 ata0: ATA channel at channel 0 on atapci0 ata1: ATA channel at channel 1 on atapci0 pci0: bridge at device 1.3 (no driver attached) vgapci0: VGA-compatible display mem 0xfc00-0xfdff,0xfebf-0xfebf0fff at device 2.0 on pci0 vgapci0: Boot video device em0: Intel(R) PRO/1000 Legacy Network Connection 1.0.6 port 0xc000-0xc03f mem 0xfeba-0xfebb irq 11 at device 3.0 on pci0 em0: Ethernet address: 52:54:00:12:34:56 atkbdc0: Keyboard controller (i8042) port 0x60,0x64 irq 1 on acpi0 atkbd0: AT Keyboard irq 1 on atkbdc0 kbd0 at atkbd0 atkbd0: [GIANT-LOCKED] psm0: PS/2 Mouse flags 0x100 irq 12 on atkbdc0 psm0: [GIANT-LOCKED] psm0: model IntelliMouse Explorer, device ID 4 ppc0: Parallel port port 0x378-0x37f irq 7 on acpi0 ppc0: Generic chipset (NIBBLE-only) in COMPATIBLE mode ppbus0: Parallel port bus on ppc0 lpt0: Printer on ppbus0 lpt0: Interrupt-driven port ppi0: Parallel I/O on ppbus0 uart0: 16550 or compatible port 0x3f8-0x3ff irq 4 flags 0x10 on acpi0 uart0: console (9600,n,8,1) attimer0: AT timer at port 0x40 on isa0 Timecounter i8254 frequency 1193182 Hz quality 0 Event timer i8254 frequency 1193182 Hz quality 100 Timecounters tick every 1.000 msec IPsec: Initialized Security Association Processing. md0: Preloaded image mfsroot.gz 75497472 bytes at 0x81692000 cd0 at ata1 bus 0 scbus1 target 0 lun 0 cd0: QEMU QEMU DVD-ROM 1.1. Removable CD-ROM SCSI-0 device cd0: Serial Number QM3 cd0: 16.700MB/s transfers (WDMA2, ATAPI 12bytes, PIO 65534bytes) cd0: cd present [8540 x 2048 byte records] GEOM_PART: integrity check failed (cd0, MBR) GEOM_PART: integrity check
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
AFAICT so far: * netcfg kills the running DHCP client after a hostname is set - this could be a bug * on kFreeBSD, isc-dhcp-client-udeb is used; killing it releases the DHCP lease and deconfigures the interface, which could be intentional * on Linux, Busybox udhcpc is used, killing it seems to have no effect Regards, -- Steven Chamberlain ste...@pyro.eu.org signature.asc Description: OpenPGP digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
Steven Chamberlain ste...@pyro.eu.org (2014-08-12):
found 757711 1.108+deb7u1
thanks
On 11/08/14 23:57, Cyril Brulebois wrote:
found 757711 netcfg/1.118
severity 757711 grave
Eeww, I missed that.
Sorry, assumed you'd seen this... though I did feel the severity was
justified since DHCP is the most common use-case. I also don't know yet
it if this is really kfreebsd-specific?
Well, given the amount of testing I've been doing lately (mostly if not
only with DHCP), I would have caught it on Linux if it hadn't been
kfreebsd-specific…
Steven, if you're going to raise severity to something RC, *please*
check whether the version in testing is also affected.
I really tried to do this before the ~1800UTC deadline, which I think is
when Britney takes a snapshot of BTS state. I'm afraid it didn't go
smoothly and I ran out of time. And so that left only two options:
* cheat: downgrade the bug against my own judgement, or tentatively
mark it as affecting testing - with a slight chance of introducing a new
bug otherwise,
Given the following changelog entry, I think it would have been a safe
thing to do, even without looking at the actual changes:
https://packages.qa.debian.org/n/netcfg/news/20140809T213533Z.html
I wouldn't call it cheating, BTW. :)
If you plan to perform some testing, all good, found/notfound versions
can be fixed (no pun intended) afterwards. In the worst case, udeb
freeze is in place anyway, so I can only yell at myself (as a maintainer
in this particular case and/or as d-i release manager in the general
case) if I unblocked packages introducing regressions:
https://lists.debian.org/debian-devel-announce/2014/08/msg3.html
* or leave it this way, even if it delays migration for a day, until
someone else or I can figure this out for sure.
Anyway, that's not the end of the world, I was only trying to give
general directions to avoid such things in the future.
See my summary to debian-{boot,cd,release}@ (towards the end of the
mail):
https://lists.debian.org/debian-boot/2014/08/msg00251.html
Anyhow I've tested as far back as the wheezy version of netcfg and
seemingly, that shows the same issue, suggesting it was a change
somewhere else (like isc-dhcp-client-udeb) that caused this bug to
appear. It still may be netcfg where this needs to be fixed, I don't
know yet.
That I don't know. Maybe try and compare with netcfg + dhcp client du
jour on Linux, and see whether netcfg's behaviour is different in both
cases, or the dhcp client's one, or the kernel's one.
At least that's what I'd try out of the blue if I were to debug this.
(I'm not volunteering. :p)
Mraw,
KiBi.
signature.asc
Description: Digital signature
Bug#757711: netcfg: promptly kills dhclient, deconfigures interface
I hope someone can explain the intent of the code below from netcfg:
why are DHCP clients killed here? Is it to avoid them clobbering a
manual hostname/domain setting? And is that really an issue in
practice, with whatever DHCP client[s] we use now?
The other thing is, the whole idea of DHCP is that the client should
stay running, to renew/retain its lease and/or change IP if asked to.
And perhaps release the DHCP lease at the end of the install. If on
Linux, udhcpc is killed off, it probably isn't doing any of those things
currently?
I'll be testing this change tomorrow to see if it helps on kfreebsd at
least:
--- a/dhcp.c
+++ b/dhcp.c
@@ -608,19 +608,18 @@ int netcfg_activate_dhcp (struct debconfclient *client,
struct netcfg_interface
case DOMAIN:
if (!have_domain netcfg_get_domain (client, domain))
state = HOSTNAME;
else {
di_debug(Network config complete);
netcfg_write_common(, hostname, domain);
netcfg_write_loopback();
netcfg_write_interface(interface);
netcfg_write_resolv(domain, interface);
-kill_dhcp_client();
stop_rdnssd();
return 0;
}
break;
case HOSTNAME_SANS_NETWORK:
if (netcfg_get_hostname (client, netcfg/get_hostname, hostname,
0))
state = ASK_OPTIONS;
Regards,
--
Steven Chamberlain
ste...@pyro.eu.org
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
