Bug#759018: [PATCH] grub-install: Install PV Xen binaries into the upstream specified path

2014-10-22 Thread Ian Campbell
Upstream have defined a specification for where guests ought to place their
xenpv grub binaries in order to facilitate chainloading from a stage 1 grub
loaded from dom0.

http://xenbits.xen.org/docs/unstable-staging/misc/x86-xenpv-bootloader.html

The spec calls for installation into /boot/xen/pvboot-i386.elf or
/boot/xen/pvboot-x86_64.elf.

Signed-off-by: Ian Campbell i...@hellion.org.uk
---
 util/grub-install.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/util/grub-install.c b/util/grub-install.c
index 70f514c..5f4d737 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -1979,6 +1979,14 @@ main (int argc, char *argv[])
}
   break;
 
+case GRUB_INSTALL_PLATFORM_I386_XEN:
+ grub_install_copy_file (imgfile, /boot/xen/pvboot-i386.elf, 1);
+ break;
+
+case GRUB_INSTALL_PLATFORM_X86_64_XEN:
+ grub_install_copy_file (imgfile, /boot/xen/pvboot-x86_64.elf, 1);
+ break;
+
 case GRUB_INSTALL_PLATFORM_MIPSEL_LOONGSON:
 case GRUB_INSTALL_PLATFORM_MIPSEL_QEMU_MIPS:
 case GRUB_INSTALL_PLATFORM_MIPS_QEMU_MIPS:
@@ -1987,8 +1995,6 @@ main (int argc, char *argv[])
 case GRUB_INSTALL_PLATFORM_MIPSEL_ARC:
 case GRUB_INSTALL_PLATFORM_ARM_UBOOT:
 case GRUB_INSTALL_PLATFORM_I386_QEMU:
-case GRUB_INSTALL_PLATFORM_I386_XEN:
-case GRUB_INSTALL_PLATFORM_X86_64_XEN:
   grub_util_warn (%s,
  _(WARNING: no platform-specific install was performed));
   break;
-- 
2.1.0


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#759018: [PATCH] grub-install: Install PV Xen binaries into the upstream specified path

2014-10-22 Thread Andrei Borzenkov
On Wed, Oct 22, 2014 at 12:23 PM, Ian Campbell i...@hellion.org.uk wrote:
 Upstream have defined a specification for where guests ought to place their
 xenpv grub binaries in order to facilitate chainloading from a stage 1 grub
 loaded from dom0.

 http://xenbits.xen.org/docs/unstable-staging/misc/x86-xenpv-bootloader.html

 The spec calls for installation into /boot/xen/pvboot-i386.elf or
 /boot/xen/pvboot-x86_64.elf.

 Signed-off-by: Ian Campbell i...@hellion.org.uk
 ---
  util/grub-install.c | 10 --
  1 file changed, 8 insertions(+), 2 deletions(-)

 diff --git a/util/grub-install.c b/util/grub-install.c
 index 70f514c..5f4d737 100644
 --- a/util/grub-install.c
 +++ b/util/grub-install.c
 @@ -1979,6 +1979,14 @@ main (int argc, char *argv[])
 }
break;

 +case GRUB_INSTALL_PLATFORM_I386_XEN:
 + grub_install_copy_file (imgfile, /boot/xen/pvboot-i386.elf, 1);
 + break;
 +
 +case GRUB_INSTALL_PLATFORM_X86_64_XEN:
 + grub_install_copy_file (imgfile, /boot/xen/pvboot-x86_64.elf, 1);
 + break;
 +

What ensures that /boot/xen exists? Should grub-install create it?

  case GRUB_INSTALL_PLATFORM_MIPSEL_LOONGSON:
  case GRUB_INSTALL_PLATFORM_MIPSEL_QEMU_MIPS:
  case GRUB_INSTALL_PLATFORM_MIPS_QEMU_MIPS:
 @@ -1987,8 +1995,6 @@ main (int argc, char *argv[])
  case GRUB_INSTALL_PLATFORM_MIPSEL_ARC:
  case GRUB_INSTALL_PLATFORM_ARM_UBOOT:
  case GRUB_INSTALL_PLATFORM_I386_QEMU:
 -case GRUB_INSTALL_PLATFORM_I386_XEN:
 -case GRUB_INSTALL_PLATFORM_X86_64_XEN:
grub_util_warn (%s,
   _(WARNING: no platform-specific install was 
 performed));
break;
 --
 2.1.0


 ___
 Grub-devel mailing list
 grub-de...@gnu.org
 https://lists.gnu.org/mailman/listinfo/grub-devel


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org