Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-03 Thread Steve French
I was trying to reproduce this with totem playing a 30 second FLAC
file over the network mount but wasn't able to - how did you repro it?

On Thu, Oct 2, 2014 at 4:33 AM, Pavel Shilovsky pshilov...@samba.org wrote:
 2014-10-01 15:34 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:
 I managed to complete a git bisect -- fs/cifs:

  git bisect good
 69cebd75606f8b9162ad5d0104367370ceabeeba is the first bad commit
 commit 69cebd75606f8b9162ad5d0104367370ceabeeba
 Author: Pavel Shilovsky pshilov...@samba.org
 Date:   Tue Jun 24 13:42:03 2014 +0400

 CIFS: Fix rsize usage in readpages

 If a server changes maximum buffer size for read (rsize) requests
 on reconnect we can fail on repeating with a big size buffer on
 -EAGAIN error in readpages. Fix this by checking rsize all the
 time before repeating requests.

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

 :04 04 8ed2e10a1581bab7b47a7dab4c5763bfdebe0e69
 9eca94b68e9a21e1e5e6712fd37012cfe6e7d6d6 M  fs
 am64:/usr/src/linux# git bisect log
 git bisect start '--' 'fs/cifs'
 # good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
 git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
 # bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
 git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
 # bad: [0ada36b244e8316bb47b46b84b33c5a507bed7a4] CIFS: Separate page
 reading from user read
 git bisect bad 0ada36b244e8316bb47b46b84b33c5a507bed7a4
 # good: [619aa48edbab47367fa8a65e568f63fd64d6b4af] CIFS: Separate page
 sending from writepages
 git bisect good 619aa48edbab47367fa8a65e568f63fd64d6b4af
 # good: [43de94eadf0ceda54509335343bdc1349a2c5ab3] CIFS: Separate writing
 from iovec write
 git bisect good 43de94eadf0ceda54509335343bdc1349a2c5ab3
 # good: [cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1] CIFS: Use multicredits
 for SMB 2.1/3 writes
 git bisect good cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1
 # bad: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix rsize usage in
 readpages
 git bisect bad 69cebd75606f8b9162ad5d0104367370ceabeeba
 # good: [387eb92ac6892518fb67e423f65fcaca76e256a8] CIFS: Separate page
 search from readpages
 git bisect good 387eb92ac6892518fb67e423f65fcaca76e256a8
 # first bad commit: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix
 rsize usage in readpages

 It points to a different first bad commit and I apologise if this has made
 it more difficult to locate the problem.

 I am happy to try more tests to help identify the problem.

 Thank you for pointing it out!

 I've reproduced and created a patch that fixes the problem to me (see
 the attachment). Can you test it, please?

 --
 Best regards,
 Pavel Shilovsky.



-- 
Thanks,

Steve


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-03 Thread Arthur Marsh

Hi, I just did:

aplay file-on-server.wav

where the file was several minutes long and I could repeatedly restart 
the samba server if I wanted to, but if I had a crash it happened on the 
first restart of the server.


WAV files have the advantage in testing of a constant and fairly high 
data rate for playback.


Regards,

Arthur.

Steve French wrote, on 04/10/14 02:29:

I was trying to reproduce this with totem playing a 30 second FLAC
file over the network mount but wasn't able to - how did you repro it?

On Thu, Oct 2, 2014 at 4:33 AM, Pavel Shilovsky pshilov...@samba.org wrote:

2014-10-01 15:34 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:

I managed to complete a git bisect -- fs/cifs:

  git bisect good
69cebd75606f8b9162ad5d0104367370ceabeeba is the first bad commit
commit 69cebd75606f8b9162ad5d0104367370ceabeeba
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Tue Jun 24 13:42:03 2014 +0400

 CIFS: Fix rsize usage in readpages

 If a server changes maximum buffer size for read (rsize) requests
 on reconnect we can fail on repeating with a big size buffer on
 -EAGAIN error in readpages. Fix this by checking rsize all the
 time before repeating requests.

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

:04 04 8ed2e10a1581bab7b47a7dab4c5763bfdebe0e69
9eca94b68e9a21e1e5e6712fd37012cfe6e7d6d6 M  fs
am64:/usr/src/linux# git bisect log
git bisect start '--' 'fs/cifs'
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# bad: [0ada36b244e8316bb47b46b84b33c5a507bed7a4] CIFS: Separate page
reading from user read
git bisect bad 0ada36b244e8316bb47b46b84b33c5a507bed7a4
# good: [619aa48edbab47367fa8a65e568f63fd64d6b4af] CIFS: Separate page
sending from writepages
git bisect good 619aa48edbab47367fa8a65e568f63fd64d6b4af
# good: [43de94eadf0ceda54509335343bdc1349a2c5ab3] CIFS: Separate writing
from iovec write
git bisect good 43de94eadf0ceda54509335343bdc1349a2c5ab3
# good: [cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1] CIFS: Use multicredits
for SMB 2.1/3 writes
git bisect good cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1
# bad: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix rsize usage in
readpages
git bisect bad 69cebd75606f8b9162ad5d0104367370ceabeeba
# good: [387eb92ac6892518fb67e423f65fcaca76e256a8] CIFS: Separate page
search from readpages
git bisect good 387eb92ac6892518fb67e423f65fcaca76e256a8
# first bad commit: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix
rsize usage in readpages

It points to a different first bad commit and I apologise if this has made
it more difficult to locate the problem.

I am happy to try more tests to help identify the problem.


Thank you for pointing it out!

I've reproduced and created a patch that fixes the problem to me (see
the attachment). Can you test it, please?

--
Best regards,
Pavel Shilovsky.







--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-03 Thread Steve French
Retried (slightly earlier build) but instead of doing ifconfig lo
down I did a killall of smbd - I then got a system hang within a few
seconds of killing samba.   Did you ever get the failure early, before
restarting Samba?

On Fri, Oct 3, 2014 at 12:34 PM, Arthur Marsh
arthur.ma...@internode.on.net wrote:
 Hi, I just did:

 aplay file-on-server.wav

 where the file was several minutes long and I could repeatedly restart the
 samba server if I wanted to, but if I had a crash it happened on the first
 restart of the server.

 WAV files have the advantage in testing of a constant and fairly high data
 rate for playback.

 Regards,

 Arthur.

 Steve French wrote, on 04/10/14 02:29:

 I was trying to reproduce this with totem playing a 30 second FLAC
 file over the network mount but wasn't able to - how did you repro it?

 On Thu, Oct 2, 2014 at 4:33 AM, Pavel Shilovsky pshilov...@samba.org
 wrote:

 2014-10-01 15:34 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:

 I managed to complete a git bisect -- fs/cifs:

   git bisect good
 69cebd75606f8b9162ad5d0104367370ceabeeba is the first bad commit
 commit 69cebd75606f8b9162ad5d0104367370ceabeeba
 Author: Pavel Shilovsky pshilov...@samba.org
 Date:   Tue Jun 24 13:42:03 2014 +0400

  CIFS: Fix rsize usage in readpages

  If a server changes maximum buffer size for read (rsize) requests
  on reconnect we can fail on repeating with a big size buffer on
  -EAGAIN error in readpages. Fix this by checking rsize all the
  time before repeating requests.

  Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
  Signed-off-by: Pavel Shilovsky pshilov...@samba.org
  Signed-off-by: Steve French smfre...@gmail.com

 :04 04 8ed2e10a1581bab7b47a7dab4c5763bfdebe0e69
 9eca94b68e9a21e1e5e6712fd37012cfe6e7d6d6 M  fs
 am64:/usr/src/linux# git bisect log
 git bisect start '--' 'fs/cifs'
 # good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
 git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
 # bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
 git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
 # bad: [0ada36b244e8316bb47b46b84b33c5a507bed7a4] CIFS: Separate page
 reading from user read
 git bisect bad 0ada36b244e8316bb47b46b84b33c5a507bed7a4
 # good: [619aa48edbab47367fa8a65e568f63fd64d6b4af] CIFS: Separate page
 sending from writepages
 git bisect good 619aa48edbab47367fa8a65e568f63fd64d6b4af
 # good: [43de94eadf0ceda54509335343bdc1349a2c5ab3] CIFS: Separate
 writing
 from iovec write
 git bisect good 43de94eadf0ceda54509335343bdc1349a2c5ab3
 # good: [cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1] CIFS: Use
 multicredits
 for SMB 2.1/3 writes
 git bisect good cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1
 # bad: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix rsize usage
 in
 readpages
 git bisect bad 69cebd75606f8b9162ad5d0104367370ceabeeba
 # good: [387eb92ac6892518fb67e423f65fcaca76e256a8] CIFS: Separate page
 search from readpages
 git bisect good 387eb92ac6892518fb67e423f65fcaca76e256a8
 # first bad commit: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix
 rsize usage in readpages

 It points to a different first bad commit and I apologise if this has
 made
 it more difficult to locate the problem.

 I am happy to try more tests to help identify the problem.


 Thank you for pointing it out!

 I've reproduced and created a patch that fixes the problem to me (see
 the attachment). Can you test it, please?

 --
 Best regards,
 Pavel Shilovsky.








-- 
Thanks,

Steve


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-03 Thread Arthur Marsh
Sorry, I only tried doing a service restart rather than a service stop, 
wait, service start. I assumed the problem happened when the client was 
starved for input when smbd was stopped.


I notice that the patches for this have come through to Linus' tree. I 
am rebuilding the kernel with them after removing Pavel's test patch.


Regards,

Arthur.

Steve French wrote, on 04/10/14 04:29:

Retried (slightly earlier build) but instead of doing ifconfig lo
down I did a killall of smbd - I then got a system hang within a few
seconds of killing samba.   Did you ever get the failure early, before
restarting Samba?

On Fri, Oct 3, 2014 at 12:34 PM, Arthur Marsh
arthur.ma...@internode.on.net wrote:

Hi, I just did:

aplay file-on-server.wav

where the file was several minutes long and I could repeatedly restart the
samba server if I wanted to, but if I had a crash it happened on the first
restart of the server.

WAV files have the advantage in testing of a constant and fairly high data
rate for playback.

Regards,

Arthur.

Steve French wrote, on 04/10/14 02:29:


I was trying to reproduce this with totem playing a 30 second FLAC
file over the network mount but wasn't able to - how did you repro it?

On Thu, Oct 2, 2014 at 4:33 AM, Pavel Shilovsky pshilov...@samba.org
wrote:


2014-10-01 15:34 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:


I managed to complete a git bisect -- fs/cifs:

   git bisect good
69cebd75606f8b9162ad5d0104367370ceabeeba is the first bad commit
commit 69cebd75606f8b9162ad5d0104367370ceabeeba
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Tue Jun 24 13:42:03 2014 +0400

  CIFS: Fix rsize usage in readpages

  If a server changes maximum buffer size for read (rsize) requests
  on reconnect we can fail on repeating with a big size buffer on
  -EAGAIN error in readpages. Fix this by checking rsize all the
  time before repeating requests.

  Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
  Signed-off-by: Pavel Shilovsky pshilov...@samba.org
  Signed-off-by: Steve French smfre...@gmail.com

:04 04 8ed2e10a1581bab7b47a7dab4c5763bfdebe0e69
9eca94b68e9a21e1e5e6712fd37012cfe6e7d6d6 M  fs
am64:/usr/src/linux# git bisect log
git bisect start '--' 'fs/cifs'
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# bad: [0ada36b244e8316bb47b46b84b33c5a507bed7a4] CIFS: Separate page
reading from user read
git bisect bad 0ada36b244e8316bb47b46b84b33c5a507bed7a4
# good: [619aa48edbab47367fa8a65e568f63fd64d6b4af] CIFS: Separate page
sending from writepages
git bisect good 619aa48edbab47367fa8a65e568f63fd64d6b4af
# good: [43de94eadf0ceda54509335343bdc1349a2c5ab3] CIFS: Separate
writing
from iovec write
git bisect good 43de94eadf0ceda54509335343bdc1349a2c5ab3
# good: [cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1] CIFS: Use
multicredits
for SMB 2.1/3 writes
git bisect good cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1
# bad: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix rsize usage
in
readpages
git bisect bad 69cebd75606f8b9162ad5d0104367370ceabeeba
# good: [387eb92ac6892518fb67e423f65fcaca76e256a8] CIFS: Separate page
search from readpages
git bisect good 387eb92ac6892518fb67e423f65fcaca76e256a8
# first bad commit: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix
rsize usage in readpages

It points to a different first bad commit and I apologise if this has
made
it more difficult to locate the problem.

I am happy to try more tests to help identify the problem.



Thank you for pointing it out!

I've reproduced and created a patch that fixes the problem to me (see
the attachment). Can you test it, please?

--
Best regards,
Pavel Shilovsky.














--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-02 Thread Pavel Shilovsky
2014-10-01 15:34 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:
 I managed to complete a git bisect -- fs/cifs:

  git bisect good
 69cebd75606f8b9162ad5d0104367370ceabeeba is the first bad commit
 commit 69cebd75606f8b9162ad5d0104367370ceabeeba
 Author: Pavel Shilovsky pshilov...@samba.org
 Date:   Tue Jun 24 13:42:03 2014 +0400

 CIFS: Fix rsize usage in readpages

 If a server changes maximum buffer size for read (rsize) requests
 on reconnect we can fail on repeating with a big size buffer on
 -EAGAIN error in readpages. Fix this by checking rsize all the
 time before repeating requests.

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

 :04 04 8ed2e10a1581bab7b47a7dab4c5763bfdebe0e69
 9eca94b68e9a21e1e5e6712fd37012cfe6e7d6d6 M  fs
 am64:/usr/src/linux# git bisect log
 git bisect start '--' 'fs/cifs'
 # good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
 git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
 # bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
 git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
 # bad: [0ada36b244e8316bb47b46b84b33c5a507bed7a4] CIFS: Separate page
 reading from user read
 git bisect bad 0ada36b244e8316bb47b46b84b33c5a507bed7a4
 # good: [619aa48edbab47367fa8a65e568f63fd64d6b4af] CIFS: Separate page
 sending from writepages
 git bisect good 619aa48edbab47367fa8a65e568f63fd64d6b4af
 # good: [43de94eadf0ceda54509335343bdc1349a2c5ab3] CIFS: Separate writing
 from iovec write
 git bisect good 43de94eadf0ceda54509335343bdc1349a2c5ab3
 # good: [cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1] CIFS: Use multicredits
 for SMB 2.1/3 writes
 git bisect good cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1
 # bad: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix rsize usage in
 readpages
 git bisect bad 69cebd75606f8b9162ad5d0104367370ceabeeba
 # good: [387eb92ac6892518fb67e423f65fcaca76e256a8] CIFS: Separate page
 search from readpages
 git bisect good 387eb92ac6892518fb67e423f65fcaca76e256a8
 # first bad commit: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix
 rsize usage in readpages

 It points to a different first bad commit and I apologise if this has made
 it more difficult to locate the problem.

 I am happy to try more tests to help identify the problem.

Thank you for pointing it out!

I've reproduced and created a patch that fixes the problem to me (see
the attachment). Can you test it, please?

-- 
Best regards,
Pavel Shilovsky.
From ca4df0717fbf3f99e728bc534e91ea64bc138528 Mon Sep 17 00:00:00 2001
From: Pavel Shilovsky pshilov...@samba.org
Date: Thu, 2 Oct 2014 13:16:40 +0400
Subject: [PATCH] CIFS: Fix readpages retrying on reconnects

If we got a reconnect error from async readv we re-add pages back
to page_list and continue loop. That is wrong because these pages
have been already added to the pagecache but page_list has pages that
have not been added to the pagecache yet. This ends up with a general
protection fault in put_pages after readpages. Fix it by not retrying
the read of these pages and falling back to readpage instead.

Signed-off-by: Pavel Shilovsky pshilov...@samba.org
---
 fs/cifs/file.c |8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 7c018a1..5f29354 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -3568,15 +3568,9 @@ static int cifs_readpages(struct file *file, struct address_space *mapping,
 lru_cache_add_file(page);
 unlock_page(page);
 page_cache_release(page);
-if (rc == -EAGAIN)
-	list_add_tail(page-lru, tmplist);
 			}
+			/* Fallback to the readpage in error/reconnect cases */
 			kref_put(rdata-refcount, cifs_readdata_release);
-			if (rc == -EAGAIN) {
-/* Re-add pages to the page_list and retry */
-list_splice(tmplist, page_list);
-continue;
-			}
 			break;
 		}
 
-- 
1.7.10.4



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-02 Thread Arthur Marsh



Pavel Shilovsky wrote, on 02/10/14 19:03:

2014-10-01 15:34 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:

I managed to complete a git bisect -- fs/cifs:

  git bisect good
69cebd75606f8b9162ad5d0104367370ceabeeba is the first bad commit
commit 69cebd75606f8b9162ad5d0104367370ceabeeba
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Tue Jun 24 13:42:03 2014 +0400

 CIFS: Fix rsize usage in readpages

 If a server changes maximum buffer size for read (rsize) requests
 on reconnect we can fail on repeating with a big size buffer on
 -EAGAIN error in readpages. Fix this by checking rsize all the
 time before repeating requests.

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

:04 04 8ed2e10a1581bab7b47a7dab4c5763bfdebe0e69
9eca94b68e9a21e1e5e6712fd37012cfe6e7d6d6 M  fs
am64:/usr/src/linux# git bisect log
git bisect start '--' 'fs/cifs'
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# bad: [0ada36b244e8316bb47b46b84b33c5a507bed7a4] CIFS: Separate page
reading from user read
git bisect bad 0ada36b244e8316bb47b46b84b33c5a507bed7a4
# good: [619aa48edbab47367fa8a65e568f63fd64d6b4af] CIFS: Separate page
sending from writepages
git bisect good 619aa48edbab47367fa8a65e568f63fd64d6b4af
# good: [43de94eadf0ceda54509335343bdc1349a2c5ab3] CIFS: Separate writing
from iovec write
git bisect good 43de94eadf0ceda54509335343bdc1349a2c5ab3
# good: [cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1] CIFS: Use multicredits
for SMB 2.1/3 writes
git bisect good cb7e9eabb2b584884db0d11ae0376d31ac1cfdc1
# bad: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix rsize usage in
readpages
git bisect bad 69cebd75606f8b9162ad5d0104367370ceabeeba
# good: [387eb92ac6892518fb67e423f65fcaca76e256a8] CIFS: Separate page
search from readpages
git bisect good 387eb92ac6892518fb67e423f65fcaca76e256a8
# first bad commit: [69cebd75606f8b9162ad5d0104367370ceabeeba] CIFS: Fix
rsize usage in readpages

It points to a different first bad commit and I apologise if this has made
it more difficult to locate the problem.

I am happy to try more tests to help identify the problem.


Thank you for pointing it out!

I've reproduced and created a patch that fixes the problem to me (see
the attachment). Can you test it, please?



I've tested it on AMD64 and confirms that it works.

Thanks very much!

Arthur.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-02 Thread Pavel Shilovsky
2014-10-02 20:04 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:

 I've tested it on AMD64 and confirms that it works.

 Thanks very much!

 Arthur.

Ok, thank you for the testing.

Steve, can you take a look at the patch (posted to the list too),
please? It seems like we have a chance to merge it into the mainline
before v3.17 released.

-- 
Best regards,
Pavel Shilovsky.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-02 Thread Steve French
ok

What about 
http://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=286feb9838a18a2400485d643f799aebed12d133
as well?

On Thu, Oct 2, 2014 at 11:14 AM, Pavel Shilovsky pshilov...@samba.org wrote:
 2014-10-02 20:04 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:

 I've tested it on AMD64 and confirms that it works.

 Thanks very much!

 Arthur.

 Ok, thank you for the testing.

 Steve, can you take a look at the patch (posted to the list too),
 please? It seems like we have a chance to merge it into the mainline
 before v3.17 released.

 --
 Best regards,
 Pavel Shilovsky.



-- 
Thanks,

Steve


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-02 Thread Steve French
That is also a problem that can cause corruption - closing the wrong file handle

On Thu, Oct 2, 2014 at 11:51 AM, Steve French smfre...@gmail.com wrote:
 ok

 What about 
 http://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=286feb9838a18a2400485d643f799aebed12d133
 as well?

 On Thu, Oct 2, 2014 at 11:14 AM, Pavel Shilovsky pshilov...@samba.org wrote:
 2014-10-02 20:04 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:

 I've tested it on AMD64 and confirms that it works.

 Thanks very much!

 Arthur.

 Ok, thank you for the testing.

 Steve, can you take a look at the patch (posted to the list too),
 please? It seems like we have a chance to merge it into the mainline
 before v3.17 released.

 --
 Best regards,
 Pavel Shilovsky.



 --
 Thanks,

 Steve



-- 
Thanks,

Steve


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-02 Thread Pavel Shilovsky
2014-10-02 20:56 GMT+04:00 Steve French smfre...@gmail.com:
 That is also a problem that can cause corruption - closing the wrong file 
 handle

 On Thu, Oct 2, 2014 at 11:51 AM, Steve French smfre...@gmail.com wrote:
 ok

 What about 
 http://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=286feb9838a18a2400485d643f799aebed12d133
 as well?

Agree. This should be merged too.

-- 
Best regards,
Pavel Shilovsky.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-10-01 Thread Arthur Marsh



Pavel Shilovsky wrote, on 01/10/14 10:32:

2014-09-30 18:49 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:

Pardon the top post but I tried the same thing on my dual core Pentium 4
machine mounting via cifs a filesytem on my AMD64 (quad core) machine, then
running aplay /mnt/remotefilesystem/somefile.wav
then restarting samba on the serving machine.

The results were the same as what I've posted before with the client being
on the quad-core AMD64 machine and the server being the Pentium 4 machine, a
nasty lock-up pointing to similar code.

Has anyone else been able to reproduce this problem?

Regards,

Arthur Marsh.

Arthur Marsh wrote, on 27/09/14 01:45:


Arthur Marsh wrote on 16/09/14 03:17:


Arthur Marsh wrote, on 14/09/14 21:15:


On 3.16.0 kernels, whether compiled by myself or the stock Debian
kernel, if I have program accessing a file on a CIFS-mounted file system
(specifically playing an audio file), and restart the samba server on
the remote machine, I might get a brief pause, but no major problems.

On 3.17.0-rc1 and later I get a complete machine lock-up.

Illustration:

https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

Has anyone else experienced similar?

I'm happy to supply any further details and try test fixes.

Arthur.



I'm still getting the problem with kernel 3.17.0-rc5

Has anyone been able to reproduce the problem?

Arthur.



I was off sick this past week but completed the bisect:

git bisect good
66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Fri Jun 20 15:48:40 2014 +0400

  CIFS: Separate filling pages from iovec write

  Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
  Signed-off-by: Pavel Shilovsky pshilov...@samba.org
  Signed-off-by: Steve French smfre...@gmail.com

:04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
318c46c63c983fe898480e1b88e97b818af1e502 M  fs


git bisect log:

git bisect start
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
# good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
'cleanup-for-3.17' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
# skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch
'for-next' of git://git.samba.org/sfrench/cifs-2.6
git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
# skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache:
d_splice_alias mustn't create directory aliases
git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
# bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus'
of git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
# good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915:
Enable PSR by default.
git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
# good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
remove disp_pd
git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
# good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
rdma_create_qp() failure recovery logic
git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
# good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
s/ltcg/ltc/ + cleanup
git bisect good 95484b57265caa671a57efed06e322d56461774b
# good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
# bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch
'stable-3.17' of git://git.infradead.org/users/pcmoore/selinux
git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
# bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage
in user read
git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
# good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
initialization from writepages
git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
# skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage
in iovec write
git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
# bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
pages from iovec write
git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
# good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage
in writepages
git bisect good 66231a47965c551d3056d5104f8b06688065748c
# good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix
cifs_writev_requeue when wsize changes

Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-30 Thread Arthur Marsh
Pardon the top post but I tried the same thing on my dual core Pentium 4 
machine mounting via cifs a filesytem on my AMD64 (quad core) machine, 
then running aplay /mnt/remotefilesystem/somefile.wav

then restarting samba on the serving machine.

The results were the same as what I've posted before with the client 
being on the quad-core AMD64 machine and the server being the Pentium 4 
machine, a nasty lock-up pointing to similar code.


Has anyone else been able to reproduce this problem?

Regards,

Arthur Marsh.

Arthur Marsh wrote, on 27/09/14 01:45:

Arthur Marsh wrote on 16/09/14 03:17:

Arthur Marsh wrote, on 14/09/14 21:15:

On 3.16.0 kernels, whether compiled by myself or the stock Debian
kernel, if I have program accessing a file on a CIFS-mounted file system
(specifically playing an audio file), and restart the samba server on
the remote machine, I might get a brief pause, but no major problems.

On 3.17.0-rc1 and later I get a complete machine lock-up.

Illustration:

https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

Has anyone else experienced similar?

I'm happy to supply any further details and try test fixes.

Arthur.


I'm still getting the problem with kernel 3.17.0-rc5

Has anyone been able to reproduce the problem?

Arthur.



I was off sick this past week but completed the bisect:

git bisect good
66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Fri Jun 20 15:48:40 2014 +0400

 CIFS: Separate filling pages from iovec write

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

:04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
318c46c63c983fe898480e1b88e97b818af1e502 M  fs


git bisect log:

git bisect start
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
# good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
'cleanup-for-3.17' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
# skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch
'for-next' of git://git.samba.org/sfrench/cifs-2.6
git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
# skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache:
d_splice_alias mustn't create directory aliases
git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
# bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus'
of git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
# good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915:
Enable PSR by default.
git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
# good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
remove disp_pd
git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
# good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
rdma_create_qp() failure recovery logic
git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
# good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
s/ltcg/ltc/ + cleanup
git bisect good 95484b57265caa671a57efed06e322d56461774b
# good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
# bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch
'stable-3.17' of git://git.infradead.org/users/pcmoore/selinux
git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
# bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage
in user read
git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
# good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
initialization from writepages
git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
# skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage
in iovec write
git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
# bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
pages from iovec write
git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
# good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage
in writepages
git bisect good 66231a47965c551d3056d5104f8b06688065748c
# good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix
cifs_writev_requeue when wsize changes
git bisect good 7f6c50086a6f5bc0fee46548afc836070a439313
# first bad commit: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] 

Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-30 Thread Pavel Shilovsky
2014-09-30 18:49 GMT+04:00 Arthur Marsh arthur.ma...@internode.on.net:
 Pardon the top post but I tried the same thing on my dual core Pentium 4
 machine mounting via cifs a filesytem on my AMD64 (quad core) machine, then
 running aplay /mnt/remotefilesystem/somefile.wav
 then restarting samba on the serving machine.

 The results were the same as what I've posted before with the client being
 on the quad-core AMD64 machine and the server being the Pentium 4 machine, a
 nasty lock-up pointing to similar code.

 Has anyone else been able to reproduce this problem?

 Regards,

 Arthur Marsh.

 Arthur Marsh wrote, on 27/09/14 01:45:

 Arthur Marsh wrote on 16/09/14 03:17:

 Arthur Marsh wrote, on 14/09/14 21:15:

 On 3.16.0 kernels, whether compiled by myself or the stock Debian
 kernel, if I have program accessing a file on a CIFS-mounted file system
 (specifically playing an audio file), and restart the samba server on
 the remote machine, I might get a brief pause, but no major problems.

 On 3.17.0-rc1 and later I get a complete machine lock-up.

 Illustration:

 https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

 Has anyone else experienced similar?

 I'm happy to supply any further details and try test fixes.

 Arthur.


 I'm still getting the problem with kernel 3.17.0-rc5

 Has anyone been able to reproduce the problem?

 Arthur.


 I was off sick this past week but completed the bisect:

 git bisect good
 66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
 commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
 Author: Pavel Shilovsky pshilov...@samba.org
 Date:   Fri Jun 20 15:48:40 2014 +0400

  CIFS: Separate filling pages from iovec write

  Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
  Signed-off-by: Pavel Shilovsky pshilov...@samba.org
  Signed-off-by: Steve French smfre...@gmail.com

 :04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
 318c46c63c983fe898480e1b88e97b818af1e502 M  fs


 git bisect log:

 git bisect start
 # good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
 git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
 # bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
 git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
 # good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
 git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
 git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
 # good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
 'cleanup-for-3.17' of
 git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
 git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
 # skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch
 'for-next' of git://git.samba.org/sfrench/cifs-2.6
 git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
 # skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache:
 d_splice_alias mustn't create directory aliases
 git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
 # bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus'
 of git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
 git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
 # good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915:
 Enable PSR by default.
 git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
 # good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
 remove disp_pd
 git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
 # good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
 rdma_create_qp() failure recovery logic
 git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
 # good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
 s/ltcg/ltc/ + cleanup
 git bisect good 95484b57265caa671a57efed06e322d56461774b
 # good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
 'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
 git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
 # bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch
 'stable-3.17' of git://git.infradead.org/users/pcmoore/selinux
 git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
 # bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage
 in user read
 git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
 # good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
 initialization from writepages
 git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
 # skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage
 in iovec write
 git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
 # bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
 pages from iovec write
 git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
 # good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage
 in writepages
 git bisect good 66231a47965c551d3056d5104f8b06688065748c
 # good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix
 

Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-27 Thread Arthur Marsh
I also reproduced the general protection fault with the current Linus 
git head (3.17-rc6+) and trying each of vers=1.0 and vers=2.0 and vers=3.0.


I am really surprised if no-one else has experienced this problem given 
how I have been able to reproduce it across all the 3.17.0-r1 to 
3.17.0-rc6 kernel versions.


Arthur.

Steve French wrote on 27/09/14 02:02:

Am curious whether it also fails with vers=3.0 on mount

On Fri, Sep 26, 2014 at 9:32 AM, Steve French smfre...@gmail.com wrote:

cifs mount (default mount options) or mount with SMB2 or SMB3
(vers=2.02 or vers=3.0)?

On Fri, Sep 26, 2014 at 9:15 AM, Arthur Marsh
arthur.ma...@internode.on.net wrote:

Arthur Marsh wrote on 16/09/14 03:17:


Arthur Marsh wrote, on 14/09/14 21:15:


On 3.16.0 kernels, whether compiled by myself or the stock Debian
kernel, if I have program accessing a file on a CIFS-mounted file system
(specifically playing an audio file), and restart the samba server on
the remote machine, I might get a brief pause, but no major problems.

On 3.17.0-rc1 and later I get a complete machine lock-up.

Illustration:

https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

Has anyone else experienced similar?

I'm happy to supply any further details and try test fixes.

Arthur.



I'm still getting the problem with kernel 3.17.0-rc5

Has anyone been able to reproduce the problem?

Arthur.



I was off sick this past week but completed the bisect:

git bisect good
66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Fri Jun 20 15:48:40 2014 +0400

 CIFS: Separate filling pages from iovec write

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

:04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
318c46c63c983fe898480e1b88e97b818af1e502 M  fs


git bisect log:

git bisect start
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
# good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
'cleanup-for-3.17' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
# skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch 'for-next'
of git://git.samba.org/sfrench/cifs-2.6
git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
# skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache: d_splice_alias
mustn't create directory aliases
git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
# bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
# good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915: Enable
PSR by default.
git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
# good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
remove disp_pd
git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
# good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
rdma_create_qp() failure recovery logic
git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
# good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
s/ltcg/ltc/ + cleanup
git bisect good 95484b57265caa671a57efed06e322d56461774b
# good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
# bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch 'stable-3.17'
of git://git.infradead.org/users/pcmoore/selinux
git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
# bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage in
user read
git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
# good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
initialization from writepages
git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
# skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage in
iovec write
git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
# bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
pages from iovec write
git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
# good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage in
writepages
git bisect good 66231a47965c551d3056d5104f8b06688065748c
# good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix
cifs_writev_requeue when wsize changes
git bisect 

Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-27 Thread Shirish Pargaonkar
On Sat, 2014-09-27 at 13:36 +0930, Arthur Marsh wrote:
 I tried each of the -o vers=2.0 and the -o vers=3.0 options to the mount 
 -t cifs command with kernel 3.17.0-rc6 and also received a general 
 protection fault.
 
 Arthur.
 
 Steve French wrote on 27/09/14 02:02:
  Am curious whether it also fails with vers=3.0 on mount
 
  On Fri, Sep 26, 2014 at 9:32 AM, Steve French smfre...@gmail.com wrote:
  cifs mount (default mount options) or mount with SMB2 or SMB3
  (vers=2.02 or vers=3.0)?
 
  On Fri, Sep 26, 2014 at 9:15 AM, Arthur Marsh
  arthur.ma...@internode.on.net wrote:
  Arthur Marsh wrote on 16/09/14 03:17:
 
  Arthur Marsh wrote, on 14/09/14 21:15:
 
  On 3.16.0 kernels, whether compiled by myself or the stock Debian
  kernel, if I have program accessing a file on a CIFS-mounted file system
  (specifically playing an audio file), and restart the samba server on
  the remote machine, I might get a brief pause, but no major problems.
 
  On 3.17.0-rc1 and later I get a complete machine lock-up.
 
  Illustration:
 
  https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large
 
  Has anyone else experienced similar?
 
  I'm happy to supply any further details and try test fixes.
 
  Arthur.
 
 
  I'm still getting the problem with kernel 3.17.0-rc5
 
  Has anyone been able to reproduce the problem?
 
  Arthur.
 
 
  I was off sick this past week but completed the bisect:
 
  git bisect good
  66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
  commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
  Author: Pavel Shilovsky pshilov...@samba.org
  Date:   Fri Jun 20 15:48:40 2014 +0400
 
   CIFS: Separate filling pages from iovec write
 
   Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
   Signed-off-by: Pavel Shilovsky pshilov...@samba.org
   Signed-off-by: Steve French smfre...@gmail.com
 
  :04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
  318c46c63c983fe898480e1b88e97b818af1e502 M  fs
 
 
  git bisect log:
 
  git bisect start
  # good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
  git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
  # bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
  git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
  # good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
  git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
  git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
  # good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
  'cleanup-for-3.17' of
  git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
  git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
  # skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch 'for-next'
  of git://git.samba.org/sfrench/cifs-2.6
  git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
  # skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache: d_splice_alias
  mustn't create directory aliases
  git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
  # bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus' of
  git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
  git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
  # good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915: 
  Enable
  PSR by default.
  git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
  # good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
  remove disp_pd
  git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
  # good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
  rdma_create_qp() failure recovery logic
  git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
  # good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
  s/ltcg/ltc/ + cleanup
  git bisect good 95484b57265caa671a57efed06e322d56461774b
  # good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
  'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
  git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
  # bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch 
  'stable-3.17'
  of git://git.infradead.org/users/pcmoore/selinux
  git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
  # bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage in
  user read
  git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
  # good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
  initialization from writepages
  git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
  # skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage 
  in
  iovec write
  git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
  # bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
  pages from iovec write
  git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
  # good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage 
  in
  writepages
  git bisect good 66231a47965c551d3056d5104f8b06688065748c
  # 

Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-26 Thread Arthur Marsh

Arthur Marsh wrote on 16/09/14 03:17:

Arthur Marsh wrote, on 14/09/14 21:15:

On 3.16.0 kernels, whether compiled by myself or the stock Debian
kernel, if I have program accessing a file on a CIFS-mounted file system
(specifically playing an audio file), and restart the samba server on
the remote machine, I might get a brief pause, but no major problems.

On 3.17.0-rc1 and later I get a complete machine lock-up.

Illustration:

https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

Has anyone else experienced similar?

I'm happy to supply any further details and try test fixes.

Arthur.


I'm still getting the problem with kernel 3.17.0-rc5

Has anyone been able to reproduce the problem?

Arthur.



I was off sick this past week but completed the bisect:

git bisect good
66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Fri Jun 20 15:48:40 2014 +0400

CIFS: Separate filling pages from iovec write

Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
Signed-off-by: Pavel Shilovsky pshilov...@samba.org
Signed-off-by: Steve French smfre...@gmail.com

:04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5 
318c46c63c983fe898480e1b88e97b818af1e502 M  fs



git bisect log:

git bisect start
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge 
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
# good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag 
'cleanup-for-3.17' of 
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc

git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
# skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch 
'for-next' of git://git.samba.org/sfrench/cifs-2.6

git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
# skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache: 
d_splice_alias mustn't create directory aliases

git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
# bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus' 
of git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform

git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
# good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915: 
Enable PSR by default.

git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
# good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420: 
remove disp_pd

git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
# good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove 
rdma_create_qp() failure recovery logic

git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
# good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc: 
s/ltcg/ltc/ + cleanup

git bisect good 95484b57265caa671a57efed06e322d56461774b
# good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch 
'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc

git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
# bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch 
'stable-3.17' of git://git.infradead.org/users/pcmoore/selinux

git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
# bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage 
in user read

git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
# good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages 
initialization from writepages

git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
# skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage 
in iovec write

git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
# bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling 
pages from iovec write

git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
# good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage 
in writepages

git bisect good 66231a47965c551d3056d5104f8b06688065748c
# good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix 
cifs_writev_requeue when wsize changes

git bisect good 7f6c50086a6f5bc0fee46548afc836070a439313
# first bad commit: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: 
Separate filling pages from iovec write



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-26 Thread Steve French
cifs mount (default mount options) or mount with SMB2 or SMB3
(vers=2.02 or vers=3.0)?

On Fri, Sep 26, 2014 at 9:15 AM, Arthur Marsh
arthur.ma...@internode.on.net wrote:
 Arthur Marsh wrote on 16/09/14 03:17:

 Arthur Marsh wrote, on 14/09/14 21:15:

 On 3.16.0 kernels, whether compiled by myself or the stock Debian
 kernel, if I have program accessing a file on a CIFS-mounted file system
 (specifically playing an audio file), and restart the samba server on
 the remote machine, I might get a brief pause, but no major problems.

 On 3.17.0-rc1 and later I get a complete machine lock-up.

 Illustration:

 https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

 Has anyone else experienced similar?

 I'm happy to supply any further details and try test fixes.

 Arthur.


 I'm still getting the problem with kernel 3.17.0-rc5

 Has anyone been able to reproduce the problem?

 Arthur.


 I was off sick this past week but completed the bisect:

 git bisect good
 66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
 commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
 Author: Pavel Shilovsky pshilov...@samba.org
 Date:   Fri Jun 20 15:48:40 2014 +0400

 CIFS: Separate filling pages from iovec write

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

 :04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
 318c46c63c983fe898480e1b88e97b818af1e502 M  fs


 git bisect log:

 git bisect start
 # good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
 git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
 # bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
 git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
 # good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
 git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
 git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
 # good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
 'cleanup-for-3.17' of
 git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
 git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
 # skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch 'for-next'
 of git://git.samba.org/sfrench/cifs-2.6
 git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
 # skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache: d_splice_alias
 mustn't create directory aliases
 git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
 # bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus' of
 git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
 git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
 # good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915: Enable
 PSR by default.
 git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
 # good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
 remove disp_pd
 git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
 # good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
 rdma_create_qp() failure recovery logic
 git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
 # good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
 s/ltcg/ltc/ + cleanup
 git bisect good 95484b57265caa671a57efed06e322d56461774b
 # good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
 'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
 git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
 # bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch 'stable-3.17'
 of git://git.infradead.org/users/pcmoore/selinux
 git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
 # bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage in
 user read
 git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
 # good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
 initialization from writepages
 git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
 # skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage in
 iovec write
 git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
 # bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
 pages from iovec write
 git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
 # good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage in
 writepages
 git bisect good 66231a47965c551d3056d5104f8b06688065748c
 # good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix
 cifs_writev_requeue when wsize changes
 git bisect good 7f6c50086a6f5bc0fee46548afc836070a439313
 # first bad commit: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS:
 Separate filling pages from iovec write







-- 
Thanks,

Steve


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-26 Thread Steve French
Am curious whether it also fails with vers=3.0 on mount

On Fri, Sep 26, 2014 at 9:32 AM, Steve French smfre...@gmail.com wrote:
 cifs mount (default mount options) or mount with SMB2 or SMB3
 (vers=2.02 or vers=3.0)?

 On Fri, Sep 26, 2014 at 9:15 AM, Arthur Marsh
 arthur.ma...@internode.on.net wrote:
 Arthur Marsh wrote on 16/09/14 03:17:

 Arthur Marsh wrote, on 14/09/14 21:15:

 On 3.16.0 kernels, whether compiled by myself or the stock Debian
 kernel, if I have program accessing a file on a CIFS-mounted file system
 (specifically playing an audio file), and restart the samba server on
 the remote machine, I might get a brief pause, but no major problems.

 On 3.17.0-rc1 and later I get a complete machine lock-up.

 Illustration:

 https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

 Has anyone else experienced similar?

 I'm happy to supply any further details and try test fixes.

 Arthur.


 I'm still getting the problem with kernel 3.17.0-rc5

 Has anyone been able to reproduce the problem?

 Arthur.


 I was off sick this past week but completed the bisect:

 git bisect good
 66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
 commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
 Author: Pavel Shilovsky pshilov...@samba.org
 Date:   Fri Jun 20 15:48:40 2014 +0400

 CIFS: Separate filling pages from iovec write

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

 :04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
 318c46c63c983fe898480e1b88e97b818af1e502 M  fs


 git bisect log:

 git bisect start
 # good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
 git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
 # bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
 git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
 # good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
 git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
 git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
 # good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
 'cleanup-for-3.17' of
 git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
 git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
 # skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch 'for-next'
 of git://git.samba.org/sfrench/cifs-2.6
 git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
 # skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache: d_splice_alias
 mustn't create directory aliases
 git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
 # bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus' of
 git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
 git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
 # good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915: Enable
 PSR by default.
 git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
 # good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
 remove disp_pd
 git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
 # good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
 rdma_create_qp() failure recovery logic
 git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
 # good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
 s/ltcg/ltc/ + cleanup
 git bisect good 95484b57265caa671a57efed06e322d56461774b
 # good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
 'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
 git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
 # bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch 'stable-3.17'
 of git://git.infradead.org/users/pcmoore/selinux
 git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
 # bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage in
 user read
 git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
 # good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
 initialization from writepages
 git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
 # skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage in
 iovec write
 git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
 # bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
 pages from iovec write
 git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
 # good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage in
 writepages
 git bisect good 66231a47965c551d3056d5104f8b06688065748c
 # good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix
 cifs_writev_requeue when wsize changes
 git bisect good 7f6c50086a6f5bc0fee46548afc836070a439313
 # first bad commit: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS:
 Separate filling pages from iovec write







 --
 Thanks,

 Steve



-- 
Thanks,

Steve


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a 

Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-26 Thread Arthur Marsh



Steve French wrote on 27/09/14 02:02:

cifs mount (default mount options) or mount with SMB2 or SMB3
(vers=2.02 or vers=3.0)?

On Fri, Sep 26, 2014 at 9:15 AM, Arthur Marsh
arthur.ma...@internode.on.net wrote:

Arthur Marsh wrote on 16/09/14 03:17:


Arthur Marsh wrote, on 14/09/14 21:15:


On 3.16.0 kernels, whether compiled by myself or the stock Debian
kernel, if I have program accessing a file on a CIFS-mounted file system
(specifically playing an audio file), and restart the samba server on
the remote machine, I might get a brief pause, but no major problems.

On 3.17.0-rc1 and later I get a complete machine lock-up.

Illustration:

https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

Has anyone else experienced similar?

I'm happy to supply any further details and try test fixes.

Arthur.



I'm still getting the problem with kernel 3.17.0-rc5

Has anyone been able to reproduce the problem?

Arthur.



I was off sick this past week but completed the bisect:

git bisect good
66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Fri Jun 20 15:48:40 2014 +0400

 CIFS: Separate filling pages from iovec write

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

:04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
318c46c63c983fe898480e1b88e97b818af1e502 M  fs


git bisect log:

git bisect start
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
# good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
'cleanup-for-3.17' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
# skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch 'for-next'
of git://git.samba.org/sfrench/cifs-2.6
git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
# skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache: d_splice_alias
mustn't create directory aliases
git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
# bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
# good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915: Enable
PSR by default.
git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
# good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
remove disp_pd
git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
# good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
rdma_create_qp() failure recovery logic
git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
# good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
s/ltcg/ltc/ + cleanup
git bisect good 95484b57265caa671a57efed06e322d56461774b
# good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
# bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch 'stable-3.17'
of git://git.infradead.org/users/pcmoore/selinux
git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
# bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage in
user read
git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
# good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
initialization from writepages
git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
# skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage in
iovec write
git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
# bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
pages from iovec write
git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
# good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage in
writepages
git bisect good 66231a47965c551d3056d5104f8b06688065748c
# good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix
cifs_writev_requeue when wsize changes
git bisect good 7f6c50086a6f5bc0fee46548afc836070a439313
# first bad commit: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS:
Separate filling pages from iovec write










mount -t cifs //192.168.1.100/homes /mnt/homes


//192.168.1.100/homes on /mnt/homes type cifs 
(rw,relatime,vers=1.0,cache=strict,username=root,domain=VICTORIA,uid=0,noforceuid,gid=0,noforcegid,addr=192.168.1.100,unix,posixpaths,serverino,acl,rsize=1048576,wsize=65536,actimeo=1)


Regards, 

Bug#762306: lockup when accessing cifs-mounted file on 3.17.0-rc1 and later when remote samba server is restarted

2014-09-26 Thread Arthur Marsh
I tried each of the -o vers=2.0 and the -o vers=3.0 options to the mount 
-t cifs command with kernel 3.17.0-rc6 and also received a general 
protection fault.


Arthur.

Steve French wrote on 27/09/14 02:02:

Am curious whether it also fails with vers=3.0 on mount

On Fri, Sep 26, 2014 at 9:32 AM, Steve French smfre...@gmail.com wrote:

cifs mount (default mount options) or mount with SMB2 or SMB3
(vers=2.02 or vers=3.0)?

On Fri, Sep 26, 2014 at 9:15 AM, Arthur Marsh
arthur.ma...@internode.on.net wrote:

Arthur Marsh wrote on 16/09/14 03:17:


Arthur Marsh wrote, on 14/09/14 21:15:


On 3.16.0 kernels, whether compiled by myself or the stock Debian
kernel, if I have program accessing a file on a CIFS-mounted file system
(specifically playing an audio file), and restart the samba server on
the remote machine, I might get a brief pause, but no major problems.

On 3.17.0-rc1 and later I get a complete machine lock-up.

Illustration:

https://pbs.twimg.com/media/BxfPkdgCcAAlpUo.jpg:large

Has anyone else experienced similar?

I'm happy to supply any further details and try test fixes.

Arthur.



I'm still getting the problem with kernel 3.17.0-rc5

Has anyone been able to reproduce the problem?

Arthur.



I was off sick this past week but completed the bisect:

git bisect good
66386c08be5d1a2eefc1f7ab8c008561b6c811e5 is the first bad commit
commit 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
Author: Pavel Shilovsky pshilov...@samba.org
Date:   Fri Jun 20 15:48:40 2014 +0400

 CIFS: Separate filling pages from iovec write

 Reviewed-by: Shirish Pargaonkar spargaon...@suse.com
 Signed-off-by: Pavel Shilovsky pshilov...@samba.org
 Signed-off-by: Steve French smfre...@gmail.com

:04 04 1be960992f3d75b4998082fda3f3c2fca213b9e5
318c46c63c983fe898480e1b88e97b818af1e502 M  fs


git bisect log:

git bisect start
# good: [19583ca584d6f574384e17fe7613dfaeadcdc4a6] Linux 3.16
git bisect good 19583ca584d6f574384e17fe7613dfaeadcdc4a6
# bad: [7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9] Linux 3.17-rc1
git bisect bad 7d1311b93e58ed55f3a31cc8f94c4b8fe988a2b9
# good: [ae045e2455429c418a418a3376301a9e5753a0a8] Merge
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect good ae045e2455429c418a418a3376301a9e5753a0a8
# good: [44c916d58b9ef1f2c4aec2def57fa8289c716a60] Merge tag
'cleanup-for-3.17' of
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good 44c916d58b9ef1f2c4aec2def57fa8289c716a60
# skip: [023f78b02c729070116fa3a7ebd4107a032d3f5c] Merge branch 'for-next'
of git://git.samba.org/sfrench/cifs-2.6
git bisect skip 023f78b02c729070116fa3a7ebd4107a032d3f5c
# skip: [908790fa3b779d37365e6b28e3aa0f6e833020c3] dcache: d_splice_alias
mustn't create directory aliases
git bisect skip 908790fa3b779d37365e6b28e3aa0f6e833020c3
# bad: [58d08e3b2c2033354b91467da33deffa06360c28] Merge tag 'for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/olof/chrome-platform
git bisect bad 58d08e3b2c2033354b91467da33deffa06360c28
# good: [27d438c56009e5ae632de36fe70985d1aab5e344] Revert drm/i915: Enable
PSR by default.
git bisect good 27d438c56009e5ae632de36fe70985d1aab5e344
# good: [ee34fb97a96ceac3334705ebab8b541ca291699f] ARM: dts: exynos5420:
remove disp_pd
git bisect good ee34fb97a96ceac3334705ebab8b541ca291699f
# good: [d1e458fe671baf1e60afafc88bda090202a412f1] svcrdma: remove
rdma_create_qp() failure recovery logic
git bisect good d1e458fe671baf1e60afafc88bda090202a412f1
# good: [95484b57265caa671a57efed06e322d56461774b] drm/nouveau/ltc:
s/ltcg/ltc/ + cleanup
git bisect good 95484b57265caa671a57efed06e322d56461774b
# good: [63b12bdb0d21aca527996fb2c547387bfd3e14b8] Merge branch
'signal-cleanup' of git://git.kernel.org/pub/scm/linux/kernel/git/rw/misc
git bisect good 63b12bdb0d21aca527996fb2c547387bfd3e14b8
# bad: [96784de59fb35077c2bb33c39328992b836d87d3] Merge branch 'stable-3.17'
of git://git.infradead.org/users/pcmoore/selinux
git bisect bad 96784de59fb35077c2bb33c39328992b836d87d3
# bad: [25f402598d2c8f0808d93715ad33e43b265c1604] CIFS: Fix rsize usage in
user read
git bisect bad 25f402598d2c8f0808d93715ad33e43b265c1604
# good: [90ac1387c2dfcd9b4bd302fce03b9ddff73d0093] CIFS: Separate pages
initialization from writepages
git bisect good 90ac1387c2dfcd9b4bd302fce03b9ddff73d0093
# skip: [6ec0b01b2691d1465bb7219e031e8bf38ccd9397] CIFS: Fix wsize usage in
iovec write
git bisect skip 6ec0b01b2691d1465bb7219e031e8bf38ccd9397
# bad: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS: Separate filling
pages from iovec write
git bisect bad 66386c08be5d1a2eefc1f7ab8c008561b6c811e5
# good: [66231a47965c551d3056d5104f8b06688065748c] CIFS: Fix wsize usage in
writepages
git bisect good 66231a47965c551d3056d5104f8b06688065748c
# good: [7f6c50086a6f5bc0fee46548afc836070a439313] CIFS: Fix
cifs_writev_requeue when wsize changes
git bisect good 7f6c50086a6f5bc0fee46548afc836070a439313
# first bad commit: [66386c08be5d1a2eefc1f7ab8c008561b6c811e5] CIFS:
Separate filling pages from iovec write