Bug#764692: usbmuxd: FTBFS on kfreebsd-*

2014-10-12 Thread Steven Chamberlain
tags 764692 + patch
thanks

Hi,

[adding -glibc@ and -bsd@ to Cc:]

On 10/10/14 10:47, Jonathan Wiltshire wrote:
   CC   usbmuxd-device.o
 device.c: In function 'send_anon_rst':
 device.c:264:4: error: 'struct tcphdr' has no member named 'th_sport'
   th.th_sport = htons(sport);

glibc-provided features.h no longer defines a __FAVOR_BSD macro, so the
BSD version of struct tcphdr in netinet/tcp.h cannot be used, even if
_BSD_SOURCE was requested as it was in this case:

src/device.c:
  22 #define _BSD_SOURCE
[...]
  28 #include sys/time.h
  29 #include netinet/in.h
  30 #include netinet/tcp.h

It works to define __FAVOR_BSD here (patch attached), but I wonder if
that should be fixed in glibc headers somehow?

There are already many users of netinet/tcp.h that define __FAVOR_BSD
however:  http://codesearch.debian.net/search?q=define+__FAVOR_BSD

Regards,
-- 
Steven Chamberlain
ste...@pyro.eu.org
--- a/src/device.c
+++ b/src/device.c
@@ -20,6 +20,7 @@
 */
 
 #define _BSD_SOURCE
+#define __FAVOR_BSD
 
 #ifdef HAVE_CONFIG_H
 #include config.h


Bug#764692: usbmuxd: FTBFS on kfreebsd-*

2014-10-10 Thread Jonathan Wiltshire

Package: src:usbmuxd
Version: 1.0.8+git20140527.e72f2f7-1
Severity: serious
Justification: FTBFS (but built successfully in the past)

Hi,

usbmuxd fails to build on kfreebsd-amd64 and kfreebsd-i386 with the 
message:


make[3]: Entering directory 
'/«BUILDDIR»/usbmuxd-1.0.8+git20140527.e72f2f7/src'

  CC   usbmuxd-client.o
  CC   usbmuxd-device.o
device.c: In function 'send_anon_rst':
device.c:264:4: error: 'struct tcphdr' has no member named 'th_sport'
  th.th_sport = htons(sport);
^
device.c:265:4: error: 'struct tcphdr' has no member named 'th_dport'
  th.th_dport = htons(dport);
^
device.c:266:4: error: 'struct tcphdr' has no member named 'th_ack'
  th.th_ack = htonl(ack);
^
device.c:267:4: error: 'struct tcphdr' has no member named 'th_flags'
  th.th_flags = TH_RST;
^

(and so on, until make abandons ship.)

--
Jonathan Wiltshire  j...@debian.org
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

directhex i have six years of solaris sysadmin experience, from
8-10. i am well qualified to say it is made from bonghits
layered on top of bonghits


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org