Bug#766811: spurious library links

[Michael Biebl]

Am 17.03.2017 um 16:50 schrieb Nathan Scott:
> Hi Michael,
> 
> Yes, please go right ahead with NMU -

Done. I've just uploaded xfsprogs_4.9.0+nmu1

 I will follow up with the XFS
> folks when I can.

debdiff is attached. It slightly differs from Marco's original patch.
Instead of disabling the code, I simply removed it. This should be more
suitable for upstreaming.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff -Nru xfsprogs-4.9.0/debian/changelog xfsprogs-4.9.0+nmu1/debian/changelog
--- xfsprogs-4.9.0/debian/changelog 2017-01-05 23:05:55.0 +0100
+++ xfsprogs-4.9.0+nmu1/debian/changelog2017-03-17 19:27:58.0 
+0100
@@ -1,3 +1,11 @@
+xfsprogs (4.9.0+nmu1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove code in include/buildmacros which creates bogus symlinks for
+libraries. (Closes: #766811)
+
+ -- Michael Biebl   Fri, 17 Mar 2017 19:27:58 +0100
+
 xfsprogs (4.9.0) unstable; urgency=low
 
   * New upstream release
diff -Nru xfsprogs-4.9.0/include/buildmacros 
xfsprogs-4.9.0+nmu1/include/buildmacros
--- xfsprogs-4.9.0/include/buildmacros  2017-01-05 23:05:55.0 +0100
+++ xfsprogs-4.9.0+nmu1/include/buildmacros 2017-03-17 19:27:58.0 
+0100
@@ -75,13 +75,7 @@
../$(INSTALL) -m 644 -T old_lib $(LIBNAME).lai $(PKG_LIB_DIR); \
../$(INSTALL) -m 644 $(LIBNAME).lai $(PKG_LIB_DIR)/$(LIBNAME).la ; \
../$(INSTALL) -m 755 -d $(PKG_ROOT_LIB_DIR); \
-   ../$(INSTALL) -T so_base $(LIBNAME).lai $(PKG_ROOT_LIB_DIR); \
-   if [ "x$(shell readlink -f $(PKG_LIB_DIR))" != \
-"x$(shell readlink -f $(PKG_ROOT_LIB_DIR))" ]; then \
-   ../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).a 
$(PKG_ROOT_LIB_DIR)/$(LIBNAME).a; \
-   ../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).la 
$(PKG_ROOT_LIB_DIR)/$(LIBNAME).la; \
-   ../$(INSTALL) -S $(PKG_ROOT_LIB_DIR)/$(LIBNAME).so 
$(PKG_LIB_DIR)/$(LIBNAME).so; \
-   fi
+   ../$(INSTALL) -T so_base $(LIBNAME).lai $(PKG_ROOT_LIB_DIR);
 else
 INSTALL_LTLIB_DEV = $(INSTALL_LTLIB_STATIC)
 endif


signature.asc
Description: OpenPGP digital signature

Bug#766811: spurious library links

[Nathan Scott]

Hi Michael,

Yes, please go right ahead with NMU - I will follow up with the XFS folks
when I can.

thanks!

On Sat, Mar 18, 2017 at 1:32 AM, Michael Biebl  wrote:

> Hi Nathan,
>
> thanks for your quick reply
>
> Am 17.03.2017 um 13:22 schrieb Nathan Scott:
> >> So this NMU happened, but unfortunately your followup maintainer upload,
> >> i.e. 4.5.0 did not include the changes from the NMU.
> >
> > (d'oh, these changes needs to be sent upstream to the kernel.org
> >  XFS list)
>
> I'm not sure about Marco, but I don't know the procedures getting a
> patch into xfsprogs. So I would very much prefer if you forward the
> patch to the right people.
>
> >> Nathan, could you make another upload including the fix from Marco?
> >
> > I'm currently traveling and will be unable to attend to this for some
> time.
>
> Should Marco or myself do another NMU then? I would send you an updated
> debdiff in this case.
>
> Regards,
> Michael
>
> --
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
>
>

Bug#766811: spurious library links

[Michael Biebl]

Hi Nathan,

thanks for your quick reply

Am 17.03.2017 um 13:22 schrieb Nathan Scott:
>> So this NMU happened, but unfortunately your followup maintainer upload,
>> i.e. 4.5.0 did not include the changes from the NMU.
> 
> (d'oh, these changes needs to be sent upstream to the kernel.org
>  XFS list)

I'm not sure about Marco, but I don't know the procedures getting a
patch into xfsprogs. So I would very much prefer if you forward the
patch to the right people.

>> Nathan, could you make another upload including the fix from Marco?
> 
> I'm currently traveling and will be unable to attend to this for some time.

Should Marco or myself do another NMU then? I would send you an updated
debdiff in this case.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature

Bug#766811: spurious library links

[Nathan Scott]

Hi Michael,

> So this NMU happened, but unfortunately your followup maintainer upload,
> i.e. 4.5.0 did not include the changes from the NMU.

(d'oh, these changes needs to be sent upstream to the kernel.org XFS list)

> Nathan, could you make another upload including the fix from Marco?

I'm currently traveling and will be unable to attend to this for some time.

cheers.

--
Nathan


On Fri, Mar 17, 2017 at 3:28 AM, Michael Biebl  wrote:

> Hi Nathan
>
> On Tue, 9 Feb 2016 22:20:23 -0500 (EST) Nathan Scott
>  wrote:
>
> > > Should I NMU?
> >
> > Please go right ahead Marco - many thanks!
>
> So this NMU happened, but unfortunately your followup maintainer upload,
> i.e. 4.5.0 did not include the changes from the NMU.
>
> Nathan, could you make another upload including the fix from Marco?
>
> I've attached the debdiff which still seems to apply against 4.9.0
>
> Seeing that this issue already caused two duplicates being filed, I'd
> say it's worth fixing for stretch.
>
> Regards,
> Michael
>
> --
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
>
>

Bug#766811: spurious library links

[Michael Biebl]

Hi Nathan

On Tue, 9 Feb 2016 22:20:23 -0500 (EST) Nathan Scott
 wrote:

> > Should I NMU?
> 
> Please go right ahead Marco - many thanks!

So this NMU happened, but unfortunately your followup maintainer upload,
i.e. 4.5.0 did not include the changes from the NMU.

Nathan, could you make another upload including the fix from Marco?

I've attached the debdiff which still seems to apply against 4.9.0

Seeing that this issue already caused two duplicates being filed, I'd
say it's worth fixing for stretch.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

diff -Nru xfsprogs-4.3.0/debian/changelog xfsprogs-4.3.0+nmu1/debian/changelog
--- xfsprogs-4.3.0/debian/changelog 2015-11-27 00:38:33.0 +0100
+++ xfsprogs-4.3.0+nmu1/debian/changelog2016-02-10 04:39:50.0 
+0100
@@ -1,3 +1,11 @@
+xfsprogs (4.3.0+nmu1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Disabled the code in include/buildmacros which creates bogus symlinks
+for libraries. (Closes: #766811)
+
+ -- Marco d'Itri   Wed, 10 Feb 2016 04:24:23 +0100
+
 xfsprogs (4.3.0) unstable; urgency=low
 
   * New upstream release
diff -Nru xfsprogs-4.3.0/include/buildmacros 
xfsprogs-4.3.0+nmu1/include/buildmacros
--- xfsprogs-4.3.0/include/buildmacros  2015-09-11 03:51:36.0 +0200
+++ xfsprogs-4.3.0+nmu1/include/buildmacros 2016-02-10 04:39:50.0 
+0100
@@ -76,7 +76,7 @@
../$(INSTALL) -m 644 $(LIBNAME).lai $(PKG_LIB_DIR)/$(LIBNAME).la ; \
../$(INSTALL) -m 755 -d $(PKG_ROOT_LIB_DIR); \
../$(INSTALL) -T so_base $(LIBNAME).lai $(PKG_ROOT_LIB_DIR); \
-   if [ "x$(shell readlink -f $(PKG_LIB_DIR))" != \
+   if false && [ "x$(shell readlink -f $(PKG_LIB_DIR))" != \
 "x$(shell readlink -f $(PKG_ROOT_LIB_DIR))" ]; then \
../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).a 
$(PKG_ROOT_LIB_DIR)/$(LIBNAME).a; \
../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).la 
$(PKG_ROOT_LIB_DIR)/$(LIBNAME).la; \


signature.asc
Description: OpenPGP digital signature

Bug#766811: spurious library links

[Nathan Scott]

- Original Message -
> [..]
> Right. Nathan, this code path is not used on Red Hat and SuSE, which
> already implemented a merged /usr, and it has always been wrong on
> Debian: I think it should just be removed from the upstream package.
> Should I NMU?

Please go right ahead Marco - many thanks!

--
Nathan

Bug#766811: spurious library links

[Marco d'Itri]

On Feb 06, Jakub Wilk  wrote:

> AFAICS this is the code responsible for creating /lib/libfoo <->
> /usr/lib/libfoo symlinks (see include/buildmacros:79):
> 
> if [ "x$(shell readlink -f $(PKG_LIB_DIR))" != \
> "x$(shell readlink -f $(PKG_ROOT_LIB_DIR))" ]; then \
>../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).a 
> $(PKG_ROOT_LIB_DIR)/$(LIBNAME).a; \
>../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).la 
> $(PKG_ROOT_LIB_DIR)/$(LIBNAME).la; \
>../$(INSTALL) -S $(PKG_ROOT_LIB_DIR)/$(LIBNAME).so 
> $(PKG_LIB_DIR)/$(LIBNAME).so; \
> fi

Right. Nathan, this code path is not used on Red Hat and SuSE, which 
already implemented a merged /usr, and it has always been wrong on 
Debian: I think it should just be removed from the upstream package.
Should I NMU?

-- 
ciao,
Marco


signature.asc
Description: PGP signature

Bug#766811: spurious library links

[Jakub Wilk]

* Marco d'Itri , 2016-02-06, 01:58:

I can still see them in the current version:

You are right, I was fooled because the extra files disappear if you
rebuild the package:

md@bongo:/tmp/xfs/xfsprogs-4.3.0+nmu1$ find debian/|grep libhandle
debian/xfslibs-dev/lib/libhandle.so
debian/xfslibs-dev/usr/lib/libhandle.a
debian/xfslibs-dev/usr/lib/libhandle.la
debian/xfsprogs/lib/libhandle.so.1
debian/xfsprogs/lib/libhandle.so.1.0.3


I can't reproduce this disappearance in a clean up-to-date sid chroot.

AFAICS this is the code responsible for creating /lib/libfoo <-> 
/usr/lib/libfoo symlinks (see include/buildmacros:79):


if [ "x$(shell readlink -f $(PKG_LIB_DIR))" != \
"x$(shell readlink -f $(PKG_ROOT_LIB_DIR))" ]; then \
   ../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).a 
$(PKG_ROOT_LIB_DIR)/$(LIBNAME).a; \
   ../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).la 
$(PKG_ROOT_LIB_DIR)/$(LIBNAME).la; \
   ../$(INSTALL) -S $(PKG_ROOT_LIB_DIR)/$(LIBNAME).so 
$(PKG_LIB_DIR)/$(LIBNAME).so; \
fi

I guess the symlinks weren't created on your system only because your 
/lib is symlinked to /usr/lib.


--
Jakub Wilk

Bug#766811: spurious library links

[Marco d'Itri]

On Jan 24, Jakub Wilk  wrote:

> I can still see them in the current version:
You are right, I was fooled because the extra files disappear if you 
rebuild the package:

md@bongo:/tmp/xfs/xfsprogs-4.3.0+nmu1$ find debian/|grep libhandle
debian/xfslibs-dev/lib/libhandle.so
debian/xfslibs-dev/usr/lib/libhandle.a
debian/xfslibs-dev/usr/lib/libhandle.la
debian/xfsprogs/lib/libhandle.so.1
debian/xfsprogs/lib/libhandle.so.1.0.3

So I wonder if this was a libtool bug and we just need to request 
a binnmu of the package.

-- 
ciao,
Marco


signature.asc
Description: PGP signature

Bug#766811: spurious library links

[Jakub Wilk]

Control: found -1 4.3.0

* Marco d'Itri , 2014-10-26, 02:48:

These links do not appear to have any purpose and should be removed:

/lib/libhandle.a -> /usr/lib/libhandle.a
/lib/libhandle.la -> /usr/lib/libhandle.la
/usr/lib/libhandle.so -> /lib/libhandle.so


I can still see them in the current version:

$ dpkg -c xfslibs-dev_4.3.0_amd64.deb | grep ^l.*/usr/lib/libhandle
lrwxrwxrwx root/root 0 2015-11-27 01:33 ./usr/lib/libhandle.so -> 
/lib/libhandle.so
lrwxrwxrwx root/root 0 2015-11-27 01:33 ./lib/libhandle.a -> 
/usr/lib/libhandle.a
lrwxrwxrwx root/root 0 2015-11-27 01:33 ./lib/libhandle.la -> 
/usr/lib/libhandle.la

--
Jakub Wilk

Bug#766811: spurious library links

[Marco d'Itri]

On Oct 26, Marco d'Itri  wrote:

> These links do not appear to have any purpose and should be removed:
> 
> /lib/libhandle.a -> /usr/lib/libhandle.a
> /lib/libhandle.la -> /usr/lib/libhandle.la
> /usr/lib/libhandle.so -> /lib/libhandle.so
> 
> Also, policy forbids to thip the .la files at all for normal libraries.
This is an obvious bug and I have not heard back from you in over one
year, what are your plans about fixing this? Do you need help?

-- 
ciao,
Marco


signature.asc
Description: PGP signature

Bug#766811: spurious library links

[Marco d'Itri]

Package: xfslibs-dev
Version: 3.2.1
Severity: normal

These links do not appear to have any purpose and should be removed:

/lib/libhandle.a -> /usr/lib/libhandle.a
/lib/libhandle.la -> /usr/lib/libhandle.la
/usr/lib/libhandle.so -> /lib/libhandle.so

Also, policy forbids to thip the .la files at all for normal libraries.

-- 
ciao,
Marco


signature.asc
Description: Digital signature