Bug#767711: openstack-pkg-tools: systemd start fails a fresh install

2014-11-10 Thread Thomas Goirand
Hi Mikael,

I have uploaded version 19 of openstack-pkg-tools, which fixes the
issue. The way to fix it is to do:

RuntimeDirectory=${PROJECT_NAME}

as per the systemd manpages, and per what the guys in #debian-systemd
adviced.

The fixed package has been uploaded to Sid, and unblocked by the release
team. I will then re-upload updates of all OpenStack packages so that
they have the fixe.

Cheers,

Thomas Goirand (zigo)


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767711: openstack-pkg-tools: systemd start fails a fresh install

2014-11-10 Thread Mikaël Cluseau

Hi Thomas,

On 11/11/2014 10:36 AM, Thomas Goirand wrote:

I have uploaded version 19 of openstack-pkg-tools, which fixes the
issue. The way to fix it is to do:

RuntimeDirectory=${PROJECT_NAME}

as per the systemd manpages, and per what the guys in #debian-systemd
adviced.


Systemd is awesome: of course, they though about the fact that /run or 
/var/run is standard and doesn't have to be repeated in each unit...


Thanks for fixing :-)


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767711: openstack-pkg-tools: systemd start fails a fresh install

2014-11-01 Thread Mikael Cluseau
Package: openstack-pkg-tools
Version: 16
Severity: important

Dear Maintainer,

The systemd service files do not create the (required) runtime directories 
(/var/run/${PROJECT_NAME}). This is required to have
the PID file written since the init script is ran as a non-root user 
($SYSTEM_USER, like keystone for keystone).

I propose the following fix: 
https://github.com/MikaelCluseau/debian-openstack-pkg-tools/commit/514de23de656dda1bd92d6012254685e0cc27b57

commit 514de23de656dda1bd92d6012254685e0cc27b57
Author: Mikaël Cluseau mclus...@isi.nc
Date:   Sun Nov 2 11:03:13 2014 +1100

Fix the missing RuntimeDirectory in systemd units.

Generic fix since init-script-template requires this directory to exist
and cannot create it when started with systemd: the systemd unit sets
the user who start the init-script, which cannot create the runtime
directory since it's not root.

diff --git a/init-template/pkgos-gen-systemd-unit 
b/init-template/pkgos-gen-systemd-unit
index 0ce0858..8168319 100755
--- a/init-template/pkgos-gen-systemd-unit
+++ b/init-template/pkgos-gen-systemd-unit
@@ -35,6 +35,7 @@ User=${SYSTEM_USER}
 Group=${SYSTEM_GROUP}
 ExecStart=${SCRIPTNAME} systemd-start
 ExecStop=${SCRIPTNAME} systemd-stop
+RuntimeDirectory=/var/run/${PROJECT_NAME}
 PIDFile=/var/run/${PROJECT_NAME}/${NAME}.pid
 Restart=on-failure
 Type=forking


-- System Information:
Debian Release: jessie/sid
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767711: openstack-pkg-tools: systemd start fails a fresh install

2014-11-01 Thread Mikaël Cluseau

On 11/02/2014 12:54 PM, Mikael Cluseau wrote:

+RuntimeDirectory=/var/run/${PROJECT_NAME}


This is not ok, systemd says its invalid. It needs to be :

+RuntimeDirectory=/run/${PROJECT_NAME}


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org