Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
On Sun, Nov 30, 2014 at 05:39:09PM -0500, Vincent Legout wrote: > Miriam Ruiz writes: > > > I thought I had already uploaded it yeah, go ahead if I didn't > > Uploaded. Thanks to you both! > Peter, can you please request an unblock? Yep, the release team unblocked it in #771665. G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org p.penc...@storpool.com PGP key:http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 signature.asc Description: Digital signature
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
Miriam Ruiz writes: > I thought I had already uploaded it yeah, go ahead if I didn't Uploaded. Peter, can you please request an unblock? Thanks, Vincent signature.asc Description: PGP signature
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
I thought I had already uploaded it yeah, go ahead if I didn't Miry 2014-11-30 17:29 GMT+01:00 Vincent Legout : > Hi Miriam, > > Miriam Ruiz writes: > >> I'll upload newer versions this afternoon :) > > zaz has already been uploaded. Do you still plan to upload phlipple? I > can do the upload if needed. > > Thanks, > Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
Hi Miriam, Miriam Ruiz writes: > I'll upload newer versions this afternoon :) zaz has already been uploaded. Do you still plan to upload phlipple? I can do the upload if needed. Thanks, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
I'll upload newer versions this afternoon :) Thanks for the reminder!!! Miry 2014-11-24 13:02 GMT+01:00 Peter Pentchev : > On Tue, Nov 11, 2014 at 01:14:41PM +0200, Peter Pentchev wrote: >> On Tue, Nov 11, 2014 at 02:09:37AM +0100, Miriam Ruiz wrote: >> > 2014-11-10 20:56 GMT+01:00 Peter Pentchev : >> > > On Mon, Nov 10, 2014 at 08:07:21PM +0100, Miriam Ruiz wrote: >> > >> Thanks a lot, I'll have a look at it and commit it.Do you want to be >> > >> included in Uploaders, as the patch seems to say? If you do, you're >> > >> essentially declaring that you're willing to take care of that >> > >> package, essentially :) >> > > >> > > Sure, why not? :) I could refresh its packaging after the freeze. >> > >> > Well, it's not really a "why not" decision :) , I mean, it's somehow a >> > kind of commitment statement. I mean, while debian/changelog >> > essentially talks about the past (who did what), imo Maintaner and >> > Uploaders talk about the future of the packahe, more or less saying: >> > "hey, if there's something to fix in here, contact me and I will try >> > to take care of it". >> >> Yes, of course you're absolutely right; I apologize for the flippancy. >> >> Yes, I would like to be listed as an uploader for both phlipple and zaz, >> if it's all right with you. This would be a kind of a come-back to >> the Games team for me, and the fact that I actually enjoy and play >> phlipple might help, too :) >> >> Thanks for your patience! > > Hi, > > Mmm, ping? :) Yesterday both phlipple and zaz were marked for > autoremoval from testing in two weeks' time (December 8th). > > I could commit these fixes and put a package up for sponsoring; > of course, it would be better if you could review them, and I do > understand that sometimes time is in short supply. > > [1] > http://lists.alioth.debian.org/pipermail/pkg-games-devel/2014-November/032970.html > [2] > http://lists.alioth.debian.org/pipermail/pkg-games-devel/2014-November/032969.html > > G'luck, > Peter > > -- > Peter Pentchev r...@ringlet.net r...@freebsd.org p.penc...@storpool.com > PGP key:http://people.FreeBSD.org/~roam/roam.key.asc > Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
On Tue, Nov 11, 2014 at 01:14:41PM +0200, Peter Pentchev wrote: > On Tue, Nov 11, 2014 at 02:09:37AM +0100, Miriam Ruiz wrote: > > 2014-11-10 20:56 GMT+01:00 Peter Pentchev : > > > On Mon, Nov 10, 2014 at 08:07:21PM +0100, Miriam Ruiz wrote: > > >> Thanks a lot, I'll have a look at it and commit it.Do you want to be > > >> included in Uploaders, as the patch seems to say? If you do, you're > > >> essentially declaring that you're willing to take care of that > > >> package, essentially :) > > > > > > Sure, why not? :) I could refresh its packaging after the freeze. > > > > Well, it's not really a "why not" decision :) , I mean, it's somehow a > > kind of commitment statement. I mean, while debian/changelog > > essentially talks about the past (who did what), imo Maintaner and > > Uploaders talk about the future of the packahe, more or less saying: > > "hey, if there's something to fix in here, contact me and I will try > > to take care of it". > > Yes, of course you're absolutely right; I apologize for the flippancy. > > Yes, I would like to be listed as an uploader for both phlipple and zaz, > if it's all right with you. This would be a kind of a come-back to > the Games team for me, and the fact that I actually enjoy and play > phlipple might help, too :) > > Thanks for your patience! Hi, Mmm, ping? :) Yesterday both phlipple and zaz were marked for autoremoval from testing in two weeks' time (December 8th). I could commit these fixes and put a package up for sponsoring; of course, it would be better if you could review them, and I do understand that sometimes time is in short supply. [1] http://lists.alioth.debian.org/pipermail/pkg-games-devel/2014-November/032970.html [2] http://lists.alioth.debian.org/pipermail/pkg-games-devel/2014-November/032969.html G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org p.penc...@storpool.com PGP key:http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 signature.asc Description: Digital signature
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
On Tue, Nov 11, 2014 at 02:09:37AM +0100, Miriam Ruiz wrote: > 2014-11-10 20:56 GMT+01:00 Peter Pentchev : > > On Mon, Nov 10, 2014 at 08:07:21PM +0100, Miriam Ruiz wrote: > >> Thanks a lot, I'll have a look at it and commit it.Do you want to be > >> included in Uploaders, as the patch seems to say? If you do, you're > >> essentially declaring that you're willing to take care of that > >> package, essentially :) > > > > Sure, why not? :) I could refresh its packaging after the freeze. > > Well, it's not really a "why not" decision :) , I mean, it's somehow a > kind of commitment statement. I mean, while debian/changelog > essentially talks about the past (who did what), imo Maintaner and > Uploaders talk about the future of the packahe, more or less saying: > "hey, if there's something to fix in here, contact me and I will try > to take care of it". Yes, of course you're absolutely right; I apologize for the flippancy. Yes, I would like to be listed as an uploader for both phlipple and zaz, if it's all right with you. This would be a kind of a come-back to the Games team for me, and the fact that I actually enjoy and play phlipple might help, too :) Thanks for your patience! G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org p.penc...@storpool.com PGP key:http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 signature.asc Description: Digital signature
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
Well, it's not really a "why not" decision :) , I mean, it's somehow a kind of commitment statement. I mean, while debian/changelog essentially talks about the past (who did what), imo Maintaner and Uploaders talk about the future of the packahe, more or less saying: "hey, if there's something to fix in here, contact me and I will try to take care of it". Miry 2014-11-10 20:56 GMT+01:00 Peter Pentchev : > On Mon, Nov 10, 2014 at 08:07:21PM +0100, Miriam Ruiz wrote: >> Thanks a lot, I'll have a look at it and commit it.Do you want to be >> included in Uploaders, as the patch seems to say? If you do, you're >> essentially declaring that you're willing to take care of that >> package, essentially :) > > Sure, why not? :) I could refresh its packaging after the freeze. > > Thanks for looking at the patch! > > G'luck, > Peter > > -- > Peter Pentchev r...@ringlet.net r...@freebsd.org p.penc...@storpool.com > PGP key:http://people.FreeBSD.org/~roam/roam.key.asc > Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
On Mon, Nov 10, 2014 at 08:07:21PM +0100, Miriam Ruiz wrote: > Thanks a lot, I'll have a look at it and commit it.Do you want to be > included in Uploaders, as the patch seems to say? If you do, you're > essentially declaring that you're willing to take care of that > package, essentially :) Sure, why not? :) I could refresh its packaging after the freeze. Thanks for looking at the patch! G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org p.penc...@storpool.com PGP key:http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 signature.asc Description: Digital signature
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
Thanks a lot, I'll have a look at it and commit it.Do you want to be included in Uploaders, as the patch seems to say? If you do, you're essentially declaring that you're willing to take care of that package, essentially :) Greetings, Miry 2014-11-10 10:50 GMT+01:00 Peter Pentchev : > package src:phlipple > tags 768741 + confirmed patch > thanks > > On Sun, Nov 09, 2014 at 08:13:56AM +0100, Lucas Nussbaum wrote: > [snip] >> Usertags: qa-ftbfs-20141108 qa-ftbfs >> Justification: FTBFS in jessie on amd64 > [snip] >> > gcc -std=gnu99 -Wall -g -g -O2 -fstack-protector-strong -Wformat >> > -Werror=format-security -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,defs >> > -Wl,-as-needed -Wl,--no-undefined -o phlipple camera.o engine.o game.o >> > gfxconstants.o gradientrenderer.o interpolator.o levels.o main.o >> > mainscreen.o osinterface_sdl.o phlipplerootscene.o quad.o quadrenderer.o >> > scenes.o settings.o textrenderer.o texture.o vertex.o -lSDL -lvorbisfile >> > -lGLEW -lGLU -lGL-lGLU -lGL -lSDL_mixer -lSDL_image >> > /usr/bin/ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5' >> > //lib/x86_64-linux-gnu/libm.so.6: error adding symbols: DSO missing from >> > command line >> > collect2: error: ld returned 1 exit status > > Hi Miriam, > > Attached is a little patch that adds a, well, a little patch :) to the > phlipple source package to make it link with libm. I think that the > reason this shows up now is that the libraries that phlipple depends on, > e.g. libvorbis, libvorbisfile, etc, have changed since May to not > explicitly list their own dependencies in the pkg-config output. In the > May rebuild, phlipple picked up -lm from its dependent libraries' > dependencies, and it compiled just fine; now it doesn't, and it must > figure out that -lm should be added all by itself. > > As noted in the patch, I know that this is not a proper fix, but I > believe that it should be a simple minimal targeted fix for the Jessie > freeze. > > So what do you think about the attached patch? I have taken the liberty > of adding a changelog entry and adding myself to the Uploaders, so that > the build is happy, but of course it's perfectly fine if you take just > the patch and commit it yourself. Still, if you agree, I could commit > it to the pkg-games Subversion repo myself, then prepare a package and > put it up in the sponsoring queue. > > Thanks for all your work in pkg-games and Debian in general, and also > thanks to Lucas for his tireless, endless rebuilds! :) > > G'luck, > Peter > > -- > Peter Pentchev r...@ringlet.net r...@freebsd.org p.penc...@storpool.com > PGP key:http://people.FreeBSD.org/~roam/roam.key.asc > Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
package src:phlipple tags 768741 + confirmed patch thanks On Sun, Nov 09, 2014 at 08:13:56AM +0100, Lucas Nussbaum wrote: [snip] > Usertags: qa-ftbfs-20141108 qa-ftbfs > Justification: FTBFS in jessie on amd64 [snip] > > gcc -std=gnu99 -Wall -g -g -O2 -fstack-protector-strong -Wformat > > -Werror=format-security -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,defs > > -Wl,-as-needed -Wl,--no-undefined -o phlipple camera.o engine.o game.o > > gfxconstants.o gradientrenderer.o interpolator.o levels.o main.o > > mainscreen.o osinterface_sdl.o phlipplerootscene.o quad.o quadrenderer.o > > scenes.o settings.o textrenderer.o texture.o vertex.o -lSDL -lvorbisfile > > -lGLEW -lGLU -lGL-lGLU -lGL -lSDL_mixer -lSDL_image > > /usr/bin/ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5' > > //lib/x86_64-linux-gnu/libm.so.6: error adding symbols: DSO missing from > > command line > > collect2: error: ld returned 1 exit status Hi Miriam, Attached is a little patch that adds a, well, a little patch :) to the phlipple source package to make it link with libm. I think that the reason this shows up now is that the libraries that phlipple depends on, e.g. libvorbis, libvorbisfile, etc, have changed since May to not explicitly list their own dependencies in the pkg-config output. In the May rebuild, phlipple picked up -lm from its dependent libraries' dependencies, and it compiled just fine; now it doesn't, and it must figure out that -lm should be added all by itself. As noted in the patch, I know that this is not a proper fix, but I believe that it should be a simple minimal targeted fix for the Jessie freeze. So what do you think about the attached patch? I have taken the liberty of adding a changelog entry and adding myself to the Uploaders, so that the build is happy, but of course it's perfectly fine if you take just the patch and commit it yourself. Still, if you agree, I could commit it to the pkg-games Subversion repo myself, then prepare a package and put it up in the sponsoring queue. Thanks for all your work in pkg-games and Debian in general, and also thanks to Lucas for his tireless, endless rebuilds! :) G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org p.penc...@storpool.com PGP key:http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 From 4e2e82fccd3967cad11ca2626f4be5760f46dcc2 Mon Sep 17 00:00:00 2001 From: Peter Pentchev Date: Mon, 10 Nov 2014 11:38:20 +0200 Subject: [PATCH] Add a minimal patch to link with libm. A much better fix would be a configure script check for cos(3) in libm, but I think that this should be suitable for the Jessie freeze. Closes: #768741 --- debian/changelog | 7 +++ debian/control| 2 +- debian/patches/libm.patch | 26 ++ debian/patches/series | 1 + 4 files changed, 35 insertions(+), 1 deletion(-) create mode 100644 debian/patches/libm.patch diff --git a/debian/changelog b/debian/changelog index 5eecebc..591449b 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +phlipple (0.8.5-2) UNRELEASED; urgency=medium + + * Team upload. + * Add the libm patch to link with -lm for cos(3). Closes: #768741 + + -- Peter Pentchev Mon, 10 Nov 2014 11:23:55 +0200 + phlipple (0.8.5-1) unstable; urgency=low [ Miriam Ruiz ] diff --git a/debian/control b/debian/control index 0be7dc4..c13dda5 100644 --- a/debian/control +++ b/debian/control @@ -2,7 +2,7 @@ Source: phlipple Section: games Priority: optional Maintainer: Debian Games Team -Uploaders: Miriam Ruiz +Uploaders: Miriam Ruiz , Peter Pentchev Build-Depends: debhelper (>= 9), dh-buildinfo, quilt, autotools-dev, libsdl1.2-dev, libsdl-image1.2-dev, libsdl-mixer1.2-dev, libglew1.6-dev | libglew1.5-dev diff --git a/debian/patches/libm.patch b/debian/patches/libm.patch new file mode 100644 index 000..94d4d23 --- /dev/null +++ b/debian/patches/libm.patch @@ -0,0 +1,26 @@ +Description: Link with libm for cos(). + This is fallout from the fact that other libraries in Debian, such as + libvorbisfile, no longer include their own dependencies in the pkg-config + output. Until now, phlipple built just fine because -lm was added by + other libraries; now it has to add it on its own. + . + This bug should really be fixed upstream by adding an explicit check for + cos(3) in configure.ac, something like AC_CHECK_LIB([m], [cos]) + I do intend to do that in a future upload, but IMHO this minimal patch + ought to be suitable for the Jessie freeze. +Debian-Bug: https://bugs.debian.org/768741 +Author: Peter Pentchev +Forwarded: not-yet +Last-Update: 2014-11-10 + +--- a/src/Makefile.in b/src/Makefile.in +@@ -211,7 +211,7 @@ + vertex.h + + phlipple_LDFLAGS = +-phlipple_LDADD = $(PHLIPPLE_LIBS) $(GL_LIBS) ++phlipple_LDADD = $(PHLIPPLE_LIBS) $(GL_LIBS) -lm + all: all-am + + .SUFFIXES: diff --git a/debian/patches/series b/debian/patches/serie
Bug#768741: phlipple: FTBFS in jessie: ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5'
Source: phlipple Version: 0.8.5-1 Severity: serious Tags: jessie sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20141108 qa-ftbfs Justification: FTBFS in jessie on amd64 Hi, During a rebuild of all packages in jessie (in a jessie chroot, not a sid chroot), your package failed to build on amd64. Relevant part (hopefully): > gcc -std=gnu99 -Wall -g -g -O2 -fstack-protector-strong -Wformat > -Werror=format-security -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,defs > -Wl,-as-needed -Wl,--no-undefined -o phlipple camera.o engine.o game.o > gfxconstants.o gradientrenderer.o interpolator.o levels.o main.o mainscreen.o > osinterface_sdl.o phlipplerootscene.o quad.o quadrenderer.o scenes.o > settings.o textrenderer.o texture.o vertex.o -lSDL -lvorbisfile -lGLEW -lGLU > -lGL-lGLU -lGL -lSDL_mixer -lSDL_image > /usr/bin/ld: engine.o: undefined reference to symbol 'cos@@GLIBC_2.2.5' > //lib/x86_64-linux-gnu/libm.so.6: error adding symbols: DSO missing from > command line > collect2: error: ld returned 1 exit status The full build log is available from: http://aws-logs.debian.net/ftbfs-logs/2014/11/08/phlipple_0.8.5-1_jessie.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org