Bug#770069: Bug#769672: hdapsd: Doesn't start at boot
On 02/12/14 14:01, Roger Lynn wrote: > On 02/12/2014 13:47, Evgeni Golov wrote: >> On 11/26/2014 08:28 AM, Evgeni Golov wrote: >>> Thanks. Could you please test the following patched version: >>> https://people.debian.org/~evgeni/tmp/hdapsd_20141024-3~test1_amd64.deb >>> >>> What I do not really understand: read() should be interrupted on >>> SIGTERM/SIGUSR1, so we already should jump out of the loop!? > > As far as I remember from when I looked at the code, a signal will interrupt > the read() to call the signal handler. The signal handler sets a global > variable and returns, which means the read() continues to wait. When the > read() eventually returns the global variable is checked at the end of the > main while loop which means that the program can finish. > >> Could any one of you confirm the package as working (properly stoping) >> now, compared to the -2 version currently found in Debian? >> I'd like to get it into Jessie, but can't test properly w/o the hardware. > > Sorry, I missed your previous email. I'll try to test it in the next day or > two. It stops immediately now, although the ordering of the logs is a little strange. Here are the syslogs after starting and stopping it. Note the last line and timings: Dec 2 23:00:50 brahms hdapsd[15249]: Selected interface: FREEFALL Dec 2 23:00:50 brahms hdapsd[15249]: Uses hardware logic from /dev/freefall Dec 2 23:01:09 brahms hdapsd[15249]: Terminating hdapsd Dec 2 23:01:09 brahms systemd[1]: hdapsd.service: main process exited, code=exited, status=255/n/a Dec 2 23:01:09 brahms systemd[1]: Unit hdapsd.service entered failed state. Dec 2 23:01:09 brahms hdapsd[15249]: Tue Dec 2 23:00:50 2014: Starting hdapsd Thanks, Roger -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#770069: Bug#769672: hdapsd: Doesn't start at boot
On 02/12/2014 13:47, Evgeni Golov wrote: Hi, On 11/26/2014 08:28 AM, Evgeni Golov wrote: Thanks. Could you please test the following patched version: https://people.debian.org/~evgeni/tmp/hdapsd_20141024-3~test1_amd64.deb What I do not really understand: read() should be interrupted on SIGTERM/SIGUSR1, so we already should jump out of the loop!? As far as I remember from when I looked at the code, a signal will interrupt the read() to call the signal handler. The signal handler sets a global variable and returns, which means the read() continues to wait. When the read() eventually returns the global variable is checked at the end of the main while loop which means that the program can finish. Could any one of you confirm the package as working (properly stoping) now, compared to the -2 version currently found in Debian? I'd like to get it into Jessie, but can't test properly w/o the hardware. Sorry, I missed your previous email. I'll try to test it in the next day or two. Roger -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#770069: Bug#769672: hdapsd: Doesn't start at boot
Hi, On 11/26/2014 08:28 AM, Evgeni Golov wrote: > Thanks. Could you please test the following patched version: > https://people.debian.org/~evgeni/tmp/hdapsd_20141024-3~test1_amd64.deb > > What I do not really understand: read() should be interrupted on > SIGTERM/SIGUSR1, so we already should jump out of the loop!? Could any one of you confirm the package as working (properly stoping) now, compared to the -2 version currently found in Debian? I'd like to get it into Jessie, but can't test properly w/o the hardware. Greets Evgeni -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
