Bug#774428: unblock: simpleburn/1.7.0-2
On 02/14/2015 03:54 PM, Mateusz Łukasik wrote:
I think now it's done:
http://mentors.debian.net/debian/pool/main/s/simpleburn/simpleburn_1.7.0-3.dsc
Thanks! I trimmed down your changes a bit to increase the chance for an
unblock.
Attaching the debdiff with the changes between 1.7.0-1 and 1.7.0-3 for
the release team.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
diff -Nru simpleburn-1.7.0/debian/changelog simpleburn-1.7.0/debian/changelog
--- simpleburn-1.7.0/debian/changelog 2014-07-28 14:22:17.0 +0200
+++ simpleburn-1.7.0/debian/changelog 2015-02-15 10:52:28.0 +0100
@@ -1,3 +1,21 @@
+simpleburn (1.7.0-3) unstable; urgency=medium
+
+ * Drop fix-bashisms.patch which contained errors and was
+too invasive to be considered during the Jessie freeze.
+ * Add debian/patches/replace_shebangs.patch to replace all
+#!/bin/sh shebangs with #!/bin/bash. (Closes: #772365)
+
+ -- Mateusz Åukasik mat...@linuxmint.pl Sat, 14 Feb 2015 15:46:32 +0100
+
+simpleburn (1.7.0-2) unstable; urgency=medium
+
+ * Add patch to fix bashism in /bin/sh script -- thanks to
+Georges Khaznadar georges.khazna...@free.fr for the help.
+(Closes: #772365)
+ * Bump Standards-Version to 3.9.6 (no changes needed).
+
+ -- Mateusz Åukasik mat...@linuxmint.pl Wed, 31 Dec 2014 15:22:53 +0100
+
simpleburn (1.7.0-1) unstable; urgency=medium
* New upstream release. (LP: #1279659)
diff -Nru simpleburn-1.7.0/debian/control simpleburn-1.7.0/debian/control
--- simpleburn-1.7.0/debian/control 2014-02-11 12:18:00.0 +0100
+++ simpleburn-1.7.0/debian/control 2014-12-31 15:13:28.0 +0100
@@ -4,7 +4,7 @@
Maintainer: Mateusz Åukasik mat...@linuxmint.pl
Build-Depends: debhelper (= 9), cmake (= 2.6), pkg-config, libudev-dev,
libburn-dev, libgtk2.0-dev (= 2.12)
-Standards-Version: 3.9.5
+Standards-Version: 3.9.6
Homepage: http://simpleburn.tuxfamily.org
Vcs-Git: git://github.com/mati75/simpleburn.git
Vcs-Browser: https://github.com/mati75/simpleburn.git
diff -Nru simpleburn-1.7.0/debian/patches/replace_shebangs.patch simpleburn-1.7.0/debian/patches/replace_shebangs.patch
--- simpleburn-1.7.0/debian/patches/replace_shebangs.patch 1970-01-01 01:00:00.0 +0100
+++ simpleburn-1.7.0/debian/patches/replace_shebangs.patch 2015-02-15 10:43:08.0 +0100
@@ -0,0 +1,34 @@
+Description: Replace all #!/bin/sh shebangs with #!/bin/bash
+Author: Mateusz Åukasik mat...@linuxmint.pl
+Bug-Debian: https://bugs.debian.org/772365
+
+Index: simpleburn-1.7.0/scripts/simpleburn-detect.sh
+===
+--- simpleburn-1.7.0.orig/scripts/simpleburn-detect.sh
simpleburn-1.7.0/scripts/simpleburn-detect.sh
+@@ -1,4 +1,4 @@
+-#!/bin/sh
++#!/bin/bash
+
+ function detect() {
+ device=$1 #assumes it is a valid CD / DVD device
+Index: simpleburn-1.7.0/scripts/simpleburn-gauges.sh
+===
+--- simpleburn-1.7.0.orig/scripts/simpleburn-gauges.sh
simpleburn-1.7.0/scripts/simpleburn-gauges.sh
+@@ -1,4 +1,4 @@
+-#!/bin/sh
++#!/bin/bash
+
+ function mencodergauge () {
+ totalsize=$1 #bytes
+Index: simpleburn-1.7.0/scripts/simpleburn.sh
+===
+--- simpleburn-1.7.0.orig/scripts/simpleburn.sh
simpleburn-1.7.0/scripts/simpleburn.sh
+@@ -1,4 +1,4 @@
+-#!/bin/sh
++#!/bin/bash
+
+ function printusage() {
+ echo error: invalid parameters
diff -Nru simpleburn-1.7.0/debian/patches/series simpleburn-1.7.0/debian/patches/series
--- simpleburn-1.7.0/debian/patches/series 2013-07-23 00:00:00.0 +0200
+++ simpleburn-1.7.0/debian/patches/series 2015-02-15 10:51:29.0 +0100
@@ -1 +1,2 @@
fix_desktop.patch
+replace_shebangs.patch
Bug#774428: unblock: simpleburn/1.7.0-2
Control: tags -1 + confirmed moreinfo On Sun, 2015-02-15 at 11:07 +0100, John Paul Adrian Glaubitz wrote: On 02/14/2015 03:54 PM, Mateusz Łukasik wrote: I think now it's done: http://mentors.debian.net/debian/pool/main/s/simpleburn/simpleburn_1.7.0-3.dsc Thanks! I trimmed down your changes a bit to increase the chance for an unblock. Attaching the debdiff with the changes between 1.7.0-1 and 1.7.0-3 for the release team. Please go ahead, and remove the moreinfo tag once the package is in unstable. Regards, Adam -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
On 02/11/2015 12:34 AM, Mehdi Dogguy wrote: Looks like a sensible plan. Can we help to make that happen? Sure. I am just waiting for Mateusz to make another upload to mentors. Mateusz, ping? Otherwise I'd be happy to NMU. -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
On 14.02.2015 11:52 AM, John Paul Adrian Glaubitz wrote: On 02/11/2015 12:34 AM, Mehdi Dogguy wrote: Looks like a sensible plan. Can we help to make that happen? Sure. I am just waiting for Mateusz to make another upload to mentors. Mateusz, ping? Otherwise I'd be happy to NMU. I think now it's done: http://mentors.debian.net/debian/pool/main/s/simpleburn/simpleburn_1.7.0-3.dsc Mateusz -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
Le 2015-01-11 13:03, John Paul Adrian Glaubitz a écrit : As pointed out earlier this thread, it might be more wise to apply the fix to simpleburn_1.7.0-2 from unstable as well as it turns out that the previously applied patch is not a 100% correct, isn't it? My suggestion would be to upload a version 1.7.0-3 to unstable which reverts the buggy change of the previous upload and therefore have the issue fixed in unstable and Jessie. Any other opinions? Looks like a sensible plan. Can we help to make that happen? Regards, -- Mehdi -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
On 06.01.2015 23:49 John Paul Adrian Glaubitz wrote: On 01/06/2015 11:44 PM, Vincent Cheng wrote: Alright, I guess we will have to go the t-p-u way then. Would it be ok if I prepared an upload of simpleburn_1.7.0-1+deb8u1 for t-p-u with the proposed change of the shebang? Why not just upload simpleburn to sid with the proposed shebang change, and revert the patch that was added in the latest upload as well (since it's broken as Adam suggested)? The maintainer can always deal with fixing the actual bashisms (ideally upstream as well) after the freeze. Good point. I am putting Mateusz on the CC to let him know. Adrian Sorry for late, I was busy in this week. I put update sources to mentors: http://mentors.debian.net/debian/pool/main/s/simpleburn/simpleburn_1.7.0-1+deb8u1.dsc Mateusz -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
Hi Mateusz! On 01/11/2015 12:19 PM, Mateusz Łukasik wrote: Sorry for late, I was busy in this week. I put update sources to mentors: http://mentors.debian.net/debian/pool/main/s/simpleburn/simpleburn_1.7.0-1+deb8u1.dsc As pointed out earlier this thread, it might be more wise to apply the fix to simpleburn_1.7.0-2 from unstable as well as it turns out that the previously applied patch is not a 100% correct, isn't it? My suggestion would be to upload a version 1.7.0-3 to unstable which reverts the buggy change of the previous upload and therefore have the issue fixed in unstable and Jessie. Any other opinions? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
Control: tags -1 moreinfo Hi, On Fri, Jan 02, 2015 at 05:30:04PM +0100, John Paul Adrian Glaubitz wrote: I just reviewed and uploaded simpleburn 1.7.0-2 which contains a patch by Georges Khaznadar to address #772365 which is an RC bug. I am attaching the debdiff which shows the additional patch to fix the bashisms as well as the respective changelog entry in debian/changelog. It seems upstream is writing the script purely with bash in mind. I wonder if it wouldn't less risky (and easier) to just change the first line to #! /bin/bash. That way, the change would be limited and would still cover future changes to the script. Cheers, Ivo -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01/06/2015 10:35 PM, Holger Levsen wrote: well, yes, but then probably not really (in all cases) for scripts which were explicitly written for bash... Alright, I guess we will have to go the t-p-u way then. Would it be ok if I prepared an upload of simpleburn_1.7.0-1+deb8u1 for t-p-u with the proposed change of the shebang? Adrian - -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBCAAGBQJUrFXyAAoJEHQmOzf1tfkTRYkQAKQgJct+Bt3RvW0Ca3AF+gin Ts7f+2yWhfuZxY5Vh2i6uQyj8fmm5Ck4rmFk+rOJK024YZURjoMs672MNX1X3PzC 3BW/LJXiIZH2+B6Fk67sDDly0qR4dI6w/YDZfL4nbsKvfZquHPu8P0zWTn+85vTz p/K9tqZScVoonKj3iaA5GxDDpSIx1oi9ZQ+zj4Q1XTn0Qxo+1SAmV/rqmTLlgvon qcJL6rLoGSeLaknjCyFIJHtsEP/hRZ5HEpr4TUsCMugdqgZeIcpGykxpayvagQEP Go3ThMSmrONzHnYP1qiOlgi9zKdkSG1fQLZa+rRoYJPjNB5CC8O41rLG7ebEKLyZ AAxgGjml7lhEedYO8iFjPSQRdcSy7UpgdfNSaNUR/zUlxWtTeb9Da8moGltwd0s0 xoxHAuFdWZ5yVXp6RRsFykykw16nqP1WZYokASS0egfKr7V2450tqEcrT+4Kml4P xo9v82sxMDXij90aL8h7jwILq+h4Oo+ogKXujAXnz2+q0gPzYeOJYjA/jQQI8bad c4Orp97/JwxxtHkPcYmeHwah5KeEkO6sxENX/qt3/Xp8WF/q9FXuNBxthHqBf0lT hc+2RP4yJVhsko+WmZOYARhu6nKw8n5ZUlYyOMiUgZEt5LwQng0Uxy0g3C3ul8hh E4uo1yVIcqMN14y2Se35 =Xp57 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
Hi, On Dienstag, 6. Januar 2015, John Paul Adrian Glaubitz wrote: Isn't the whole point of the release goal to actually get rid of the bashisms? well, yes, but then probably not really (in all cases) for scripts which were explicitly written for bash... So, #!/bin/bash can be both, a workaround and a design goal. cheers, Holger, sometimes too writing explicitly bash code (still) signature.asc Description: This is a digitally signed message part.
Bug#774428: unblock: simpleburn/1.7.0-2
On Tue, Jan 6, 2015 at 1:39 PM, John Paul Adrian Glaubitz glaub...@physik.fu-berlin.de wrote: On 01/06/2015 10:35 PM, Holger Levsen wrote: well, yes, but then probably not really (in all cases) for scripts which were explicitly written for bash... Alright, I guess we will have to go the t-p-u way then. Would it be ok if I prepared an upload of simpleburn_1.7.0-1+deb8u1 for t-p-u with the proposed change of the shebang? Why not just upload simpleburn to sid with the proposed shebang change, and revert the patch that was added in the latest upload as well (since it's broken as Adam suggested)? The maintainer can always deal with fixing the actual bashisms (ideally upstream as well) after the freeze. Regards, Vincent -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
On 01/06/2015 09:41 PM, Ivo De Decker wrote: It seems upstream is writing the script purely with bash in mind. I wonder if it wouldn't less risky (and easier) to just change the first line to #! /bin/bash. That way, the change would be limited and would still cover future changes to the script. Isn't the whole point of the release goal to actually get rid of the bashisms? Just changing the shebang doesn't fix the actual problem, does it? It just shoves everything under the carpet. I don't think that's a reasonable way and would render the whole bug report with it's RC status pointless. Yes, the diff is a bit larger, but also very repetitive. It isn't too much to review therefore and in the end, it would just break simpleburn at worst, so I don't think we should be super cautious with any changes regarding the package. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
On Tue, 2015-01-06 at 22:03 +0100, John Paul Adrian Glaubitz wrote:
On 01/06/2015 09:41 PM, Ivo De Decker wrote:
It seems upstream is writing the script purely with bash in mind. I wonder
if
it wouldn't less risky (and easier) to just change the first line to
#! /bin/bash. That way, the change would be limited and would still cover
future changes to the script.
Isn't the whole point of the release goal to actually get rid
of the bashisms? Just changing the shebang doesn't fix the actual
problem, does it? It just shoves everything under the carpet. I
don't think that's a reasonable way and would render the whole
bug report with it's RC status pointless.
Release goals are not (and ttbomk never have been) RC. The bug is RC
because the script uses features outside of what policy says may be
expected from /bin/sh, without declaring that, not because of any
release goal. Changing the shebang very much fixes the policy violation.
Yes, the diff is a bit larger, but also very repetitive.
It's also broken.
+ cdda2wav dev=$device -t $track -
2/dev/null | flac -f -o $title.flac -
+- status=${PIPESTATUS[0]}
++ status=$?
The original line and suggested replacement do _not_ do the same thing.
(The original returns the status of cdda2wav, the replacement returns
the status of flac.)
Regards,
Adam
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
On 01/06/2015 11:44 PM, Vincent Cheng wrote: Alright, I guess we will have to go the t-p-u way then. Would it be ok if I prepared an upload of simpleburn_1.7.0-1+deb8u1 for t-p-u with the proposed change of the shebang? Why not just upload simpleburn to sid with the proposed shebang change, and revert the patch that was added in the latest upload as well (since it's broken as Adam suggested)? The maintainer can always deal with fixing the actual bashisms (ideally upstream as well) after the freeze. Good point. I am putting Mateusz on the CC to let him know. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#774428: unblock: simpleburn/1.7.0-2
Package: release.debian.org
Severity: normal
Tags: patch
User: release.debian@packages.debian.org
Usertags: unblock
Hello!
I just reviewed and uploaded simpleburn 1.7.0-2 which contains
a patch by Georges Khaznadar to address #772365 which is an
RC bug.
I am attaching the debdiff which shows the additional patch
to fix the bashisms as well as the respective changelog
entry in debian/changelog.
Please unblock simpleburn_1.7.0-2 so we can fix this bug
for Jessie. Thanks!
Cheers,
Adrian
unblock simpleburn/1.7.0-2
-- System Information:
Debian Release: 8.0
APT prefers testing
APT policy: (500, 'testing'), (99, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.16.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL
set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru simpleburn-1.7.0/debian/changelog simpleburn-1.7.0/debian/changelog
--- simpleburn-1.7.0/debian/changelog 2014-07-28 14:22:17.0 +0200
+++ simpleburn-1.7.0/debian/changelog 2015-01-02 17:03:12.0 +0100
@@ -1,3 +1,12 @@
+simpleburn (1.7.0-2) unstable; urgency=medium
+
+ * Add patch to fix bashism in /bin/sh script -- thanks to
+Georges Khaznadar georges.khazna...@free.fr for the help.
+(Closes: #772365)
+ * Bump Standards-Version to 3.9.6 (no changes needed).
+
+ -- Mateusz Łukasik mat...@linuxmint.pl Wed, 31 Dec 2014 15:22:53 +0100
+
simpleburn (1.7.0-1) unstable; urgency=medium
* New upstream release. (LP: #1279659)
diff -Nru simpleburn-1.7.0/debian/control simpleburn-1.7.0/debian/control
--- simpleburn-1.7.0/debian/control 2014-02-11 12:18:00.0 +0100
+++ simpleburn-1.7.0/debian/control 2014-12-31 15:13:28.0 +0100
@@ -4,7 +4,7 @@
Maintainer: Mateusz Łukasik mat...@linuxmint.pl
Build-Depends: debhelper (= 9), cmake (= 2.6), pkg-config, libudev-dev,
libburn-dev, libgtk2.0-dev (= 2.12)
-Standards-Version: 3.9.5
+Standards-Version: 3.9.6
Homepage: http://simpleburn.tuxfamily.org
Vcs-Git: git://github.com/mati75/simpleburn.git
Vcs-Browser: https://github.com/mati75/simpleburn.git
diff -Nru simpleburn-1.7.0/debian/patches/fix-bashisms.patch simpleburn-1.7.0/debian/patches/fix-bashisms.patch
--- simpleburn-1.7.0/debian/patches/fix-bashisms.patch 1970-01-01 01:00:00.0 +0100
+++ simpleburn-1.7.0/debian/patches/fix-bashisms.patch 2014-12-31 15:16:21.0 +0100
@@ -0,0 +1,588 @@
+Description: fix bashism in /bin/sh script
+Author: Georges Khaznadar georges.khazna...@free.fr
+Bug-Debian: https://bugs.debian.org/772365
+
+--- a/scripts/simpleburn-detect.sh
b/scripts/simpleburn-detect.sh
+@@ -1,6 +1,6 @@
+ #!/bin/sh
+
+-function detect() {
++detect() {
+ device=$1 #assumes it is a valid CD / DVD device
+ readcd dev=$device -fulltoc 2/dev/null; rm -f ~/toc.dat; rm -f toc.dat #wait for loading
+ if cdrom_id $device | grep -q ID_CDROM_MEDIA; then
+@@ -22,7 +22,7 @@ function detect() {
+ if [ -z $mediacapacity ]; then
+ mediacapacity=`cdrecord -atip dev=$device 21 | grep phys size:... | tail -1 | sed 's/phys size:... \+//'`
+ fi
+-let mediacapacity=mediacapacity*2048
++mediacapacity=$((mediacapacity*2048))
+ fi
+ { mplayer -dvd-device $device dvd://1 -identify -vo null -ao null -frames 0 21 /tmp/simpleburn-detect.$$ ;} 21 /dev/null
+ if grep -q ID_DVD_TITLES /tmp/simpleburn-detect.$$; then
+@@ -31,13 +31,13 @@ function detect() {
+ for title in `cat /tmp/simpleburn-detect.$$ | grep TITLE_[0-9]\+_LENGTH`; do #for each title during more than 3'
+ titlenum=`echo $title | cut -d'_' -f4`
+ titlelenght=`echo $title | cut -d'=' -f2 | cut -f1 -d'.'`
+- let minutes=titlelenght/60
+- if (( minutes 3 )); then
+- if (( $titlenum != 1 )); then
++ minutes=$((titlelenght/60))
++ if [ $(( minutes 3 )) = 1 ]; then
++ if [ $(( $titlenum != 1 )) = 1 ]; then
+ { mplayer -dvd-device $device dvd://$titlenum -identify -vo null -ao null -frames 0 21 /tmp/simpleburn-detect.$$; } 21 /dev/null
+ fi
+ if grep -q ID_AID /tmp/simpleburn-detect.$$ grep -q ID_SID /tmp/simpleburn-detect.$$; then
+- let trackscount=trackscount+1
++ trackscount=$((trackscount+1))
+ if [ ! -z $mediainfos ]; then
+ mediainfos=$mediainfos\n
+ detailedinfos=$detailedinfos\n
+@@ -58,7 +58,7 @@ function detect() {
+ subdetailedinfos=$subdetailedinfos $languagename($languageid)
+ done
+ mediainfos=$mediainfos;$mediasubinfos
+-if [ $id == ID_AID ]
++if [ $id = ID_AID ]
+ then detailedinfos=$detailedinfos\n\tlanguages: $subdetailedinfos
+ else detailedinfos=$detailedinfos\n\tsubtitles: $subdetailedinfos
+ fi
+@@ -76,16 +76,17 @@ function detect() {
+ mediatype=cd
+ if cdrom_id $device | grep -q ID_CDROM_MEDIA_CD_R; then
+ mediacapacity=`cdrecord -atip dev=$device 21
