Bug#776488: regression: arm map_hardware[] not NULL terminated

[Ian Campbell]

On Wed, 2015-01-28 at 18:38 +0100, Cyril Brulebois wrote:
> dann frazier  (2015-01-28):
> > On Wed, Jan 28, 2015 at 06:10:49PM +0100, Cyril Brulebois wrote:
> > > I was about to push it but you apparently already did; adjusting tags
> > > accordingly.
> > 
> > Cool, thanks :) Do you +1 me uploading this? If so, should I request an
> > unblock or does that need to come from you?
> 
> Feel free to go ahead. I doubt any arm folks (hello Ian) would disagree
> with having that package uploaded ASAP.

Dann already dropped me a line and I said to go ahead.

>  Maybe they have some comments as
> to why nobody reported any crashes yet though (maybe the compiler saving
> the day?).

My guess is that next thing in memory just happened to be some zeroes,
i.e. padding for alignment or some thing like that.

Ian.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#776488: regression: arm map_hardware[] not NULL terminated

[Cyril Brulebois]

dann frazier  (2015-01-28):
> On Wed, Jan 28, 2015 at 06:10:49PM +0100, Cyril Brulebois wrote:
> > I was about to push it but you apparently already did; adjusting tags
> > accordingly.
> 
> Cool, thanks :) Do you +1 me uploading this? If so, should I request an
> unblock or does that need to come from you?

Feel free to go ahead. I doubt any arm folks (hello Ian) would disagree
with having that package uploaded ASAP. Maybe they have some comments as
to why nobody reported any crashes yet though (maybe the compiler saving
the day?).

As far as unblocks for udeb-producing packages are concerned, they show
up on this page, which I use (ir)regularly to feed the release team with
grouped unblock requests: .

If someone feels a given package deserves a urgent migration (as in: you
want to prod me actively instead of waiting on my looking at the said
page), opening a regular unblock request with me in x-debbugs-cc should
do the job (if the cc is forgotten, the release folks will loop me in
anyway).

Mraw,
KiBi.


signature.asc
Description: Digital signature

Bug#776488: regression: arm map_hardware[] not NULL terminated

[dann frazier]

On Wed, Jan 28, 2015 at 06:10:49PM +0100, Cyril Brulebois wrote:
> dann frazier  (2015-01-28):
> > Package: libdebian-installer4
> > Version: 0.98
> > Severity: serious
> > Tags: d-i patch
> > 
> > The map_hardware[] table in src/system/subarch-arm-linux.c is no longer NULL
> > terminated. I believe this could lead to a segfault on armel/armhf 
> > platforms,
> > resulting in a failed install.
> > 
> > This bug was introduced back in version 0.92. The end of the table was 
> > trimmed,
> > and accidentally took the NULL terminator with it:
> >   
> > http://anonscm.debian.org/cgit/d-i/libdebian-installer.git/commit/?id=3a7209e49fa5cfe8c4e4122325405022031a8afc
> >   
> > DISCLAIMER: I haven't actually observed a crash, I just discovered this 
> > while
> > reviewing source. But it does seem like a potential time-bomb we should fix
> > pre-release. Here's the obvious patch:
> > 
> > diff --git a/src/system/subarch-arm-linux.c b/src/system/subarch-arm-linux.c
> > index 590576a..3fc5e2a 100644
> > --- a/src/system/subarch-arm-linux.c
> > +++ b/src/system/subarch-arm-linux.c
> > @@ -103,6 +103,7 @@ static struct map map_hardware[] = {
> >  { "OMAP3 Beagle Board", "omap" },
> >  { "OMAP4 Panda Board", "omap" },
> >  { "ARM-Versatile Express", "vexpress" },
> > +{ NULL, NULL }
> >  };
> 
> I was about to push it but you apparently already did; adjusting tags
> accordingly.

Cool, thanks :) Do you +1 me uploading this? If so, should I request an
unblock or does that need to come from you?


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Bug#776488: regression: arm map_hardware[] not NULL terminated

[Cyril Brulebois]

Control: tag -1 - d-i + pending

dann frazier  (2015-01-28):
> Package: libdebian-installer4
> Version: 0.98
> Severity: serious
> Tags: d-i patch
> 
> The map_hardware[] table in src/system/subarch-arm-linux.c is no longer NULL
> terminated. I believe this could lead to a segfault on armel/armhf platforms,
> resulting in a failed install.
> 
> This bug was introduced back in version 0.92. The end of the table was 
> trimmed,
> and accidentally took the NULL terminator with it:
>   
> http://anonscm.debian.org/cgit/d-i/libdebian-installer.git/commit/?id=3a7209e49fa5cfe8c4e4122325405022031a8afc
>   
> DISCLAIMER: I haven't actually observed a crash, I just discovered this while
> reviewing source. But it does seem like a potential time-bomb we should fix
> pre-release. Here's the obvious patch:
> 
> diff --git a/src/system/subarch-arm-linux.c b/src/system/subarch-arm-linux.c
> index 590576a..3fc5e2a 100644
> --- a/src/system/subarch-arm-linux.c
> +++ b/src/system/subarch-arm-linux.c
> @@ -103,6 +103,7 @@ static struct map map_hardware[] = {
>  { "OMAP3 Beagle Board", "omap" },
>  { "OMAP4 Panda Board", "omap" },
>  { "ARM-Versatile Express", "vexpress" },
> +{ NULL, NULL }
>  };

I was about to push it but you apparently already did; adjusting tags
accordingly.

Thanks!

Mraw,
KiBi.


signature.asc
Description: Digital signature

Bug#776488: regression: arm map_hardware[] not NULL terminated

[dann frazier]

Package: libdebian-installer4
Version: 0.98
Severity: serious
Tags: d-i patch

The map_hardware[] table in src/system/subarch-arm-linux.c is no longer NULL
terminated. I believe this could lead to a segfault on armel/armhf platforms,
resulting in a failed install.

This bug was introduced back in version 0.92. The end of the table was trimmed,
and accidentally took the NULL terminator with it:
  
http://anonscm.debian.org/cgit/d-i/libdebian-installer.git/commit/?id=3a7209e49fa5cfe8c4e4122325405022031a8afc
  
DISCLAIMER: I haven't actually observed a crash, I just discovered this while
reviewing source. But it does seem like a potential time-bomb we should fix
pre-release. Here's the obvious patch:

diff --git a/src/system/subarch-arm-linux.c b/src/system/subarch-arm-linux.c
index 590576a..3fc5e2a 100644
--- a/src/system/subarch-arm-linux.c
+++ b/src/system/subarch-arm-linux.c
@@ -103,6 +103,7 @@ static struct map map_hardware[] = {
 { "OMAP3 Beagle Board", "omap" },
 { "OMAP4 Panda Board", "omap" },
 { "ARM-Versatile Express", "vexpress" },
+{ NULL, NULL }
 };
 
 static int read_dt_model(char *entry, int entry_len)

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libdebian-installer4 depends on:
ii  libc6  2.19-13
ii  multiarch-support  2.19-13

libdebian-installer4 recommends no packages.

libdebian-installer4 suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org