Bug#778698: unable to build with kernel 3.19

2015-03-14 Thread Kevin Locke 
Hi guys,

Any progress on this bug?  Eduard's patch worked for me.

For reference, this issue is #1409190[1] in Ubuntu, which they
addressed with a patch[2] to use the new file_inode helper[3] in
kernel 3.9 and later.

I'd love to see either approach get applied.

Cheers,
Kevin


1.  
https://bugs.launchpad.net/ubuntu/+source/nvidia-graphics-drivers-331-updates/+bug/1409190
2.  
https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/vivid/nvidia-graphics-drivers-304-updates/vivid/view/head:/debian/dkms/patches/buildfix_kernel_3.19.patch
3.  
https://github.com/torvalds/linux/commit/496ad9aa8ef448058e36ca7a787c61f2e63f0f54


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#778698: unable to build with kernel 3.19

2015-02-19 Thread Andreas Beckmann 
On 2015-02-18 20:58, Eduard Bloch wrote:
 Wrong. The thing I exchanged was just the use of a convenience shortcut,
 and it should work just fine without it with almost any kernel released
 in the last 8 years.
 
 $ git blame v3.18 include/linux/fs.h | grep f_dentry
 0f7fc9e4d (Josef Jeff Sipek2006-12-08 02:36:35 -0800  792) #define 
 f_dentry f_path.dentry

Thanks for the clarification.


Andreas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#778698: unable to build with kernel 3.19

2015-02-18 Thread Eduard Bloch 
Package: nvidia-kernel-source
Version: 343.36-1
Severity: important
Tags: upstream patch

Patch attached, tested, please apply.

-- Package-specific info:
uname -a:
Linux zombie 3.19.0+ #10 SMP PREEMPT Wed Feb 11 20:39:23 CET 2015 x86_64 
GNU/Linux

/proc/version:
Linux version 3.19.0+ (root@zombie) (gcc version 4.9.2 (Debian 4.9.2-10) ) #10 
SMP PREEMPT Wed Feb 11 20:39:23 CET 2015

/proc/driver/nvidia/version:
NVRM version: NVIDIA UNIX x86_64 Kernel Module  343.36  Mon Dec  1 16:18:58 PST 
2014
GCC version:  gcc version 4.9.2 (Debian 4.9.2-10) 

--- nvidia-graphics-drivers-343.36/debian/module/debian/patches/f_path.dentry.patch	1970-01-01 01:00:00.0 +0100
+++ nvidia-graphics-drivers-343.36.patched/debian/module/debian/patches/f_path.dentry.patch	2015-02-18 18:45:32.435160595 +0100
@@ -0,0 +1,33 @@
+diff -urd kernel-source-tree.orig/nv-frontend.c kernel-source-tree/nv-frontend.c
+--- a/nv-frontend.c	2014-12-02 00:26:56.0 +0100
 b/nv-frontend.c	2015-02-18 18:37:00.135142310 +0100
+@@ -327,7 +327,7 @@
+ unsigned long i_arg
+ )
+ {
+-return nvidia_frontend_ioctl(file-f_dentry-d_inode, file, cmd, i_arg);
++return nvidia_frontend_ioctl(file-f_path.dentry-d_inode, file, cmd, i_arg);
+ }
+ 
+ long nvidia_frontend_compat_ioctl(
+@@ -336,7 +336,7 @@
+ unsigned long i_arg
+ )
+ {
+-return nvidia_frontend_ioctl(file-f_dentry-d_inode, file, cmd, i_arg);
++return nvidia_frontend_ioctl(file-f_path.dentry-d_inode, file, cmd, i_arg);
+ }
+ 
+ int nvidia_frontend_mmap(
+diff -urd kernel-source-tree.orig/nv.c kernel-source-tree/nv.c
+--- a/nv.c	2014-12-02 00:26:56.0 +0100
 b/nv.c	2015-02-18 18:36:32.471141323 +0100
+@@ -1824,7 +1824,7 @@
+ unsigned long i_arg
+ )
+ {
+-return nvidia_ioctl(file-f_dentry-d_inode, file, cmd, i_arg);
++return nvidia_ioctl(file-f_path.dentry-d_inode, file, cmd, i_arg);
+ }
+ 
+ /*
--- nvidia-graphics-drivers-343.36/debian/module/debian/patches/series	2014-10-14 11:31:09.0 +0200
+++ nvidia-graphics-drivers-343.36.patched/debian/module/debian/patches/series	2015-02-18 18:44:37.023158617 +0100
@@ -3,3 +3,4 @@
 use-nv-kernel-ARCH.o_shipped.patch
 conditionally-include-linux_version.h.patch
 uvm-symvers.patch
+f_path.dentry.patch

Bug#778698: unable to build with kernel 3.19

2015-02-18 Thread Andreas Beckmann 
On 2015-02-18 18:58, Eduard Bloch wrote:
 Patch attached, tested, please apply.

Thanks, but NACK on the patch in this form - this needs to be properly
#if'ed on the kernel version s.t. it builds on all kernel versions.


Andreas


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#778698: unable to build with kernel 3.19

2015-02-18 Thread Eduard Bloch 
Hallo,
* Andreas Beckmann [Wed, Feb 18 2015, 07:06:40PM]:
 On 2015-02-18 18:58, Eduard Bloch wrote:
  Patch attached, tested, please apply.
 
 Thanks, but NACK on the patch in this form - this needs to be properly
 #if'ed on the kernel version s.t. it builds on all kernel versions.

Wrong. The thing I exchanged was just the use of a convenience shortcut,
and it should work just fine without it with almost any kernel released
in the last 8 years.

$ git blame v3.18 include/linux/fs.h | grep f_dentry
0f7fc9e4d (Josef Jeff Sipek2006-12-08 02:36:35 -0800  792) #define 
f_dentry   f_path.dentry

Regards,
Eduard.

-- 
Every great idea is worthless without someone to do the work. --Neil Williams


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org