Bug#778985: unblock: orafce/3.0.7-4

2015-02-24 Thread Mehdi Dogguy 
On Sun, Feb 22, 2015 at 10:25:16PM +0100, Christoph Berg m...@debian.org 
wrote:
 Re: Mehdi Dogguy 2015-02-22 20150222174611.gb14...@dogguy.org
  On Sun, Feb 22, 2015 at 03:32:26PM +0100, Christoph Berg m...@debian.org 
  wrote:
   + 
   +-\set ECHO all;
   ++\set ECHO none
   +
  
  Is it missing a semi-colon?
 
 No, to the contrary: The parser didn't understand all; and
 substituted it by none internally. The current test failure is
 because the previously silent substitution is now accompanied by a
 warning:
 

Alright. Unblocked.

Regards,

-- 
Mehdi Dogguy


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#778985: unblock: orafce/3.0.7-4

2015-02-22 Thread Christoph Berg 
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please consider unblocking package orafce. The new version fixes the
autopkgtest regression tests. (No change in the binaries.)

http://ci.debian.net/packages/o/orafce/unstable/amd64/

unblock orafce/3.0.7-4

Thanks!

diff -Nru orafce-3.0.7/debian/changelog orafce-3.0.7/debian/changelog
--- orafce-3.0.7/debian/changelog   2014-08-26 19:07:29.0 +0200
+++ orafce-3.0.7/debian/changelog   2015-02-22 15:25:29.0 +0100
@@ -1,3 +1,12 @@
+orafce (3.0.7-4) unstable; urgency=medium
+
+  * Fix test failures with PostgreSQL 9.4.1: \set ECHO all; was always
+silently interpreted as \set ECHO none; now psql will print a warning.
+Fix by using none explicitly. The test output was already expecting the
+none output variant.
+
+ -- Christoph Berg m...@debian.org  Sun, 22 Feb 2015 15:21:54 +0100
+
 orafce (3.0.7-3) unstable; urgency=medium
 
   * Fix invocation of orafce_sql_yyerror. Patch taken from upstream git.
diff -Nru orafce-3.0.7/debian/patches/regress-echo 
orafce-3.0.7/debian/patches/regress-echo
--- orafce-3.0.7/debian/patches/regress-echo1970-01-01 01:00:00.0 
+0100
+++ orafce-3.0.7/debian/patches/regress-echo2015-02-22 15:21:51.0 
+0100
@@ -0,0 +1,22 @@
+--- a/sql/dbms_pipe_session_A.sql
 b/sql/dbms_pipe_session_A.sql
+@@ -159,7 +159,7 @@ BEGIN
+   PERFORM dbms_pipe.send_message(pipename);
+ END; $$ LANGUAGE plpgsql;
+ 
+-\set ECHO all;
++\set ECHO none
+ 
+ SELECT createImplicitPipe();
+ 
+--- a/sql/dbms_pipe_session_B.sql
 b/sql/dbms_pipe_session_B.sql
+@@ -80,7 +80,7 @@ BEGIN
+   RETURN result;
+ END; $$ LANGUAGE plpgsql;
+ 
+-\set ECHO all;
++\set ECHO none
+ 
+ -- Receives messages sent via an implicit pipe
+ SELECT receiveFrom('named_pipe');
diff -Nru orafce-3.0.7/debian/patches/series orafce-3.0.7/debian/patches/series
--- orafce-3.0.7/debian/patches/series  2014-08-26 19:02:53.0 +0200
+++ orafce-3.0.7/debian/patches/series  2015-02-22 15:19:56.0 +0100
@@ -1,3 +1,4 @@
 git-to_date-conversion
 git-sqy_yyerror.patch
 regress-no-alert
+regress-echo

Christoph
-- 
c...@df7cb.de | http://www.df7cb.de/


signature.asc
Description: Digital signature

Bug#778985: unblock: orafce/3.0.7-4

2015-02-22 Thread Christoph Berg 
Re: Mehdi Dogguy 2015-02-22 20150222174611.gb14...@dogguy.org
 On Sun, Feb 22, 2015 at 03:32:26PM +0100, Christoph Berg m...@debian.org 
 wrote:
  + 
  +-\set ECHO all;
  ++\set ECHO none
  +
 
 Is it missing a semi-colon?

No, to the contrary: The parser didn't understand all; and
substituted it by none internally. The current test failure is
because the previously silent substitution is now accompanied by a
warning:

*** /tmp/adt-run.NG5yKZ/build.gjP/orafce-3.0.7/expected/dbms_pipe_session_A.out 
2014-07-27 20:10:01.0 +
--- /tmp/adt-run.NG5yKZ/build.gjP/orafce-3.0.7/results/dbms_pipe_session_A.out  
2015-02-21 06:53:26.265125313 +
***
*** 9,14 
--- 9,15 
  0
  (1 row)
  
+ unrecognized value all; for ECHO; assuming none
   createimplicitpipe 
  
   


The minimal fix is to just replace all; by what the parser was doing
internally anyway. (The proper fix that was applied upstream is to use
all, but then the rest of the expected output file needs dozens of
changes because everything is echoed.)

Christoph
-- 
e...@df7cb.de | http://www.df7cb.de/


signature.asc
Description: Digital signature