Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
On 2015-03-14 13:27, Herbert Parentes Fortes Neto (hpfn) wrote: It would be nice if you do the upload. I belive it would be faster to close the bug. OK, uploaded to experimental. Andreas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: [Pkg-phototools-devel] Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
On Fri, 13 Mar 2015 22:24:13 +0100 Andreas Beckmann a...@debian.org wrote: On 2015-03-13 22:00, Herbert Parentes Fortes Neto (hpfn) wrote: Thanks for checking the package. Looks good now! Do you need a sponsor to upload this? It would be nice if you do the upload. I belive it would be faster to close the bug. regrads, -- Herbert Parentes Fortes Neto (hpfn) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: [Pkg-phototools-devel] Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
Hi, Thanks for checking the package. And sorry about the delay. problems doing the upload. continue On Fri, 13 Mar 2015 14:28:45 +0100 Andreas Beckmann a...@debian.org wrote: Hi, maybe it's even time to remove the old transitional libgphoto2-2-dev package? (libsane-dev seems to be the only package still having a dependency on the old transitional one) Typos fixed. Vcs* are back. Removed the old transitional libgphoto2-2-dev package. link: http://mentors.debian.net/package/libgphoto2 regards, -- Herbert Parentes Fortes Neto (hpfn) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
On 2015-03-13 22:00, Herbert Parentes Fortes Neto (hpfn) wrote: Thanks for checking the package. Looks good now! Do you need a sponsor to upload this? Andreas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
On 2015-03-12 20:33, Herbert Parentes Fortes Neto (hpfn) wrote: I made the new debian package. 2.5.7-2. And uploaded to mentors. No transitional package. Can you take a look ? link: http://mentors.debian.net/package/libgphoto2 diff looks good, minor nitpicking: + * fix wrong trasitional package libgphoto2-port10. (Closes: #780240) +Thanks Guillem Jover and Andreas Beckmann. + * Removed the libgphoto2_port.so.1o symlink. typo: 10 + * debian/control: libgphoto2-port10 removed. +For libgphoto-port12: typo: gphoto2 +Breaks: libgphoto2-port10 (= 2.5.7) +Replaces: libgphoto2-port10 (= 2.5.7) +Removed Vcs* fields. Why? Going non-Vcs does not sound sensible. Andreas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
Hi, maybe it's even time to remove the old transitional libgphoto2-2-dev package? (libsane-dev seems to be the only package still having a dependency on the old transitional one) Andreas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: [Pkg-phototools-devel] Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
Hi Guillem, On Wed, 11 Mar 2015 00:59:54 +0100 Guillem Jover guil...@debian.org wrote: Package: libgphoto2-port10 Version: 2.5.7-1 Severity: serious Hi! The new version in experimental, has turned the libgphoto2-port10 into a transitional package for libgphoto2-port12 (w/o any rationale on the debian/changelog nor in debian/rules, nor any commit message as the git repo does not contain any of those changes either). The new library does break the ABI, so I don't see why the transition package? This will break applications using it. Why do you say that ? I tested the package with all packages that depend on libgphoto2 and everything went ok. In which package did you have problems ? regards, -- Herbert Parentes Fortes Neto (hpfn) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: [Pkg-phototools-devel] Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
Hi Andreas, On Thu, 12 Mar 2015 08:16:51 +0100 Andreas Beckmann a...@debian.org wrote: On 2015-03-12 06:53, Andreas Beckmann wrote: Package: libgphoto2-port12 Architecture: any Multi-Arch: same Breaks: libgphoto2-port10 ( 2.5.5) Replaces: libgphoto2-port10 ( 2.5.5) I don't think these Breaks+Replaces are needed at all, the filelist (except for the wrong symlink) does not look like there would be any clashes. Or rather use Breaks: libgphoto2-port10 (= 2.5.7) Replaces: libgphoto2-port10 (= 2.5.7) to ensure the incorrect transitional package gets removed (while allowing co-installation with libgphoto2-port10 from sid. I made the new debian package. 2.5.7-2. And uploaded to mentors. No transitional package. Can you take a look ? link: http://mentors.debian.net/package/libgphoto2 regards, -- Herbert Parentes Fortes Neto (hpfn) -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
On 2015-03-12 06:53, Andreas Beckmann wrote: Package: libgphoto2-port12 Architecture: any Multi-Arch: same Breaks: libgphoto2-port10 ( 2.5.5) Replaces: libgphoto2-port10 ( 2.5.5) I don't think these Breaks+Replaces are needed at all, the filelist (except for the wrong symlink) does not look like there would be any clashes. Or rather use Breaks: libgphoto2-port10 (= 2.5.7) Replaces: libgphoto2-port10 (= 2.5.7) to ensure the incorrect transitional package gets removed (while allowing co-installation with libgphoto2-port10 from sid. Andreas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
Followup-For: Bug #780240 Hi, during a test with piuparts I noticed your package fails to upgrade from 'sid' to 'experimental'. It installed fine in 'sid', then the upgrade to 'experimental' fails because it tries to overwrite other packages files without declaring a Breaks+Replaces relation. See policy 7.6 at https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces From the attached log (scroll to the bottom...): Selecting previously unselected package libgphoto2-port12:amd64. Preparing to unpack .../libgphoto2-port12_2.5.7-1_amd64.deb ... Unpacking libgphoto2-port12:amd64 (2.5.7-1) ... dpkg: error processing archive /var/cache/apt/archives/libgphoto2-port12_2.5.7-1_amd64.deb (--unpack): trying to overwrite '/usr/lib/x86_64-linux-gnu/libgphoto2_port.so.10', which is also in package libgphoto2-port10:amd64 2.5.4-1.1+b2 Preparing to unpack .../libgphoto2-6_2.5.7-1_amd64.deb ... Unpacking libgphoto2-6:amd64 (2.5.7-1) over (2.5.4-1.1+b2) ... Processing triggers for udev (215-12) ... Errors were encountered while processing: /var/cache/apt/archives/libgphoto2-port12_2.5.7-1_amd64.deb There must not be a libgphoto2_port.so.10 symlink in the libgphoto2-port12 package. cheers, Andreas libgphoto2-6_2.5.7-1.log.gz Description: application/gzip
Bug#780240: [Pkg-phototools-devel] Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
Hi Andreas,
On Wed, 11 Mar 2015 22:01:34 +0100
Andreas Beckmann a...@debian.org wrote:
Followup-For: Bug #780240
Hi,
during a test with piuparts I noticed your package fails to upgrade from
'sid' to 'experimental'.
It installed fine in 'sid', then the upgrade to 'experimental' fails
because it tries to overwrite other packages files without declaring a
Breaks+Replaces relation.
Exists the declaration on debian/control:
Package: libgphoto2-port12
Architecture: any
Multi-Arch: same
Breaks: libgphoto2-port10 (= 2.5.4-1.1)
Replaces: libgphoto2-port10 (= 2.5.4-1.1)
Pre-Depends: ${misc:Pre-Depends}
Depends:
${shlibs:Depends}
, ${misc:Depends}
Suggests: gphoto2 (= 2.5.6)
See policy 7.6 at
https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces
From the attached log (scroll to the bottom...):
Selecting previously unselected package libgphoto2-port12:amd64.
Preparing to unpack .../libgphoto2-port12_2.5.7-1_amd64.deb ...
Unpacking libgphoto2-port12:amd64 (2.5.7-1) ...
dpkg: error processing archive
/var/cache/apt/archives/libgphoto2-port12_2.5.7-1_amd64.deb (--unpack):
trying to overwrite '/usr/lib/x86_64-linux-gnu/libgphoto2_port.so.10',
which is also in package libgphoto2-port10:amd64 2.5.4-1.1+b2
Preparing to unpack .../libgphoto2-6_2.5.7-1_amd64.deb ...
Unpacking libgphoto2-6:amd64 (2.5.7-1) over (2.5.4-1.1+b2) ...
Processing triggers for udev (215-12) ...
Errors were encountered while processing:
/var/cache/apt/archives/libgphoto2-port12_2.5.7-1_amd64.deb
There must not be a libgphoto2_port.so.10 symlink in the libgphoto2-port12
package.
Why ? It was important when I did the tests.
regards,
--
Herbert Parentes Fortes Neto (hpfn)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: [Pkg-phototools-devel] Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
On Wed, 2015-03-11 at 15:22:14 -0300, Herbert Parentes Fortes Neto wrote: On Wed, 11 Mar 2015 00:59:54 +0100 Guillem Jover wrote: Package: libgphoto2-port10 Version: 2.5.7-1 Severity: serious The new version in experimental, has turned the libgphoto2-port10 into a transitional package for libgphoto2-port12 (w/o any rationale on the debian/changelog nor in debian/rules, nor any commit message as the git repo does not contain any of those changes either). The new library does break the ABI, so I don't see why the transition package? This will break applications using it. Why do you say that ? Because whenever there's a SONAME change that implies an ABI change (assuming a sane upstream). Although the usual error that upstreams make is in the other direction, not changing SONAME when there's an ABI change which breaks stuff. Here, it's pretty clear there's an ABI change given the commit that bumped the libtool versioning: http://sourceforge.net/p/gphoto/code/15175/ I tested the package with all packages that depend on libgphoto2 and everything went ok. That's not a sufficient check, and it does not mean these programs might not crash or misbehave if they are not executing the affected code. In any case an ABI change affects our users non the less, as people do use Debian to develop against the shipped libraries too. In which package did you have problems ? None, I just spotted this problem by reading the changelog, and went to check the actual source to verify it. Thanks, Guillem -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
On 2015-03-11 22:20, Herbert Parentes Fortes Neto (hpfn) wrote: There must not be a libgphoto2_port.so.10 symlink in the libgphoto2-port12 package. Why ? It was important when I did the tests. Then something is seriously borked in your package. The new library is not a valid replacement for the old one (otherwise there would have been no need for a soname change) - a proper library transition is required and all packages depending on libgphoto2-port10 will need to be rebuild against the new one to pick up the new dependency. With the wrong symlink removed, you can coinstall libgphoto2-port10 and libgphoto2-port12, so packages that have not yet been rebuild will continue usabale. Andreas -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
On 2015-03-12 05:24, Herbert Parentes Fortes Neto (hpfn) wrote:
Ok, digikam shows the photos on the celular(probably get confusing here),
but if you ask to import a select photo, it dies. That's enough.
I have doubts now. Check the steps:
At debian/control:
Package: libgphoto2-port12
Architecture: any
Multi-Arch: same
Breaks: libgphoto2-port10 ( 2.5.5)
Replaces: libgphoto2-port10 ( 2.5.5)
I don't think these Breaks+Replaces are needed at all, the filelist
(except for the wrong symlink) does not look like there would be any
clashes.
Pre-Depends: ${misc:Pre-Depends}
Depends:
${shlibs:Depends}
, ${misc:Depends}
Suggests: gphoto2 (= 2.5.6)
And for libgphoto2-port10
debuild 2.5.4 version;
cp 2.5.4/debian/libgphoto2-port10/* 2.5.7/debian/port10;
let debian/libgphoto2-port10.install do the job.
Why? You don't build a libgphoto2-port10 package any longer from the
2.5.7 sources.
Andreas
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: [Pkg-phototools-devel] Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
Ok, digikam shows the photos on the celular(probably get confusing here),
but if you ask to import a select photo, it dies. That's enough.
I have doubts now. Check the steps:
At debian/control:
Package: libgphoto2-port12
Architecture: any
Multi-Arch: same
Breaks: libgphoto2-port10 ( 2.5.5)
Replaces: libgphoto2-port10 ( 2.5.5)
Pre-Depends: ${misc:Pre-Depends}
Depends:
${shlibs:Depends}
, ${misc:Depends}
Suggests: gphoto2 (= 2.5.6)
And for libgphoto2-port10
debuild 2.5.4 version;
cp 2.5.4/debian/libgphoto2-port10/* 2.5.7/debian/port10;
let debian/libgphoto2-port10.install do the job.
Is that correct ?
regards,
--
Herbert Parentes Fortes Neto (hpfn)
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#780240: libgphoto2-port10: Wrong transition package for ABI changing library
Package: libgphoto2-port10 Version: 2.5.7-1 Severity: serious Hi! The new version in experimental, has turned the libgphoto2-port10 into a transitional package for libgphoto2-port12 (w/o any rationale on the debian/changelog nor in debian/rules, nor any commit message as the git repo does not contain any of those changes either). The new library does break the ABI, so I don't see why the transition package? This will break applications using it. Thanks, Guillem -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
