Bug#783142: VMs fail to start on Broadwell CPUs

2015-04-23 Thread Gianfranco Costamagna
Hi, patch applied on jessie branch

http://anonscm.debian.org/cgit/pkg-virtualbox/virtualbox.git/commit/?h=jessie


experimental should already be fine.

thanks!

cheers,

G.


Il Mercoledì 22 Aprile 2015 22:12, Moritz Mühlenhoff j...@inutil.org ha 
scritto:
On Wed, Apr 22, 2015 at 09:48:01PM +0200, Moritz Muehlenhoff wrote:
 Package: virtualbox
 Version: 4.3.18-dfsg-3
 Severity: important
 
 Hi,
 virtualbox doesn't work on Broadwell CPUs; all VMs fail to start no
 matter what the user configures in the VM settings.
 
 This was reported upstream at https://www.virtualbox.org/ticket/13820
 
 I verified that the patch by Frank works on my Thinkpad X250 with such
 a CPU. I'm attaching a suitable Debian diff.
 
 Please fix this for the jessie 8.1 point release, Broadwell CPUs will
 become increasingly popular and Vbox is completely broken on them.

Now really attached.


Cheers,
Moritz


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#783142: [Pkg-virtualbox-devel] Bug#783142: VMs fail to start on Broadwell CPUs

2015-04-23 Thread Gianfranco Costamagna
Hi Frank,

Hi all,


please be aware that the patch mentioned below by Gianfranco is not sufficient
for Linux = 3.19. The complete patch can be found here:

  https://www.virtualbox.org/attachment/ticket/13961/diff_smap_4

See https://www.virtualbox.org/ticket/13961#comment:18 for the explanation.


you are completely right, *but* jessie is shipped with kernel 3.16, if people 
want kernel 3.19 they need to use it from experimental (or build from source)

virtualbox in experimental already has the full patch you mentioned above

http://anonscm.debian.org/cgit/pkg-virtualbox/virtualbox.git/commit/?id=8345a3bfb01591402639a7ddab22e52a0d8ce471


So I presume in order to have a minimum diff for the jessie post release update 
we can use the minimal patch, and use backport/experimental for people who want 
to try newer kernels.

I tried to apply manually the patch on 4.3.18  but it doesn't apply cleanly.

cheers,

G.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#783142: [Pkg-virtualbox-devel] Bug#783142: VMs fail to start on Broadwell CPUs

2015-04-23 Thread Frank Mehnert
Hi all,

please be aware that the patch mentioned below by Gianfranco is not sufficient
for Linux = 3.19. The complete patch can be found here:

  https://www.virtualbox.org/attachment/ticket/13961/diff_smap_4

See https://www.virtualbox.org/ticket/13961#comment:18 for the explanation.

Frank

On Thursday 23 April 2015 07:43:17 Gianfranco Costamagna wrote:
 Hi, patch applied on jessie branch
 
 http://anonscm.debian.org/cgit/pkg-virtualbox/virtualbox.git/commit/?h=jessi
 e
 
 
 experimental should already be fine.
 
 thanks!
 
 cheers,
 
 G.
 
 
 Il Mercoledì 22 Aprile 2015 22:12, Moritz Mühlenhoff j...@inutil.org ha
 scritto:
 On Wed, Apr 22, 2015 at 09:48:01PM +0200, Moritz Muehlenhoff wrote:
  Package: virtualbox
  Version: 4.3.18-dfsg-3
  Severity: important
  
  Hi,
  virtualbox doesn't work on Broadwell CPUs; all VMs fail to start no
  matter what the user configures in the VM settings.
  
  This was reported upstream at https://www.virtualbox.org/ticket/13820
  
  I verified that the patch by Frank works on my Thinkpad X250 with such
  a CPU. I'm attaching a suitable Debian diff.
  
  Please fix this for the jessie 8.1 point release, Broadwell CPUs will
  become increasingly popular and Vbox is completely broken on them.
 
 Now really attached.
 
 
 Cheers,
 Moritz
 
 ___
 Pkg-virtualbox-devel mailing list
 pkg-virtualbox-de...@lists.alioth.debian.org
 http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-virtualbox-devel

-- 
Dr.-Ing. Frank Mehnert | Software Development Director, VirtualBox
ORACLE Deutschland B.V.  Co. KG | Werkstr. 24 | 71384 Weinstadt, Germany

ORACLE Deutschland B.V.  Co. KG
Hauptverwaltung: Riesstraße 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#783142: VMs fail to start on Broadwell CPUs

2015-04-22 Thread Moritz Mühlenhoff
On Wed, Apr 22, 2015 at 09:48:01PM +0200, Moritz Muehlenhoff wrote:
 Package: virtualbox
 Version: 4.3.18-dfsg-3
 Severity: important
 
 Hi,
 virtualbox doesn't work on Broadwell CPUs; all VMs fail to start no
 matter what the user configures in the VM settings.
 
 This was reported upstream at https://www.virtualbox.org/ticket/13820
 
 I verified that the patch by Frank works on my Thinkpad X250 with such
 a CPU. I'm attaching a suitable Debian diff.
 
 Please fix this for the jessie 8.1 point release, Broadwell CPUs will
 become increasingly popular and Vbox is completely broken on them.

Now really attached.

Cheers,
Moritz
diff -Naur virtualbox-4.3.18-dfsg.orig/debian/patches/disable-smap.patch virtualbox-4.3.18-dfsg/debian/patches/disable-smap.patch
--- virtualbox-4.3.18-dfsg.orig/debian/patches/disable-smap.patch	1970-01-01 01:00:00.0 +0100
+++ virtualbox-4.3.18-dfsg/debian/patches/disable-smap.patch	2015-04-22 19:50:08.474457626 +0200
@@ -0,0 +1,58 @@
+Description: Disable SMAP when during VirtualBox kernel calls
+This fixes virtualbox on Broadwell CPUs
+
+https://www.virtualbox.org/ticket/13820
+Author: frank.mehn...@oracle.com
+
+--- virtualbox-4.3.18-dfsg.orig/src/VBox/HostDrivers/Support/linux/SUPDrv-linux.c
 virtualbox-4.3.18-dfsg/src/VBox/HostDrivers/Support/linux/SUPDrv-linux.c
+@@ -48,6 +48,12 @@
+ # include iprt/power.h
+ # define VBOX_WITH_SUSPEND_NOTIFICATION
+ #endif
++#if LINUX_VERSION_CODE = KERNEL_VERSION(3, 7, 0)
++# include asm/smap.h
++#else
++static inline void clac(void) { }
++static inline void stac(void) { }
++#endif
+ 
+ #include linux/sched.h
+ #ifdef CONFIG_DEVFS_FS
+@@ -622,6 +628,7 @@ static int VBoxDrvLinuxIOCtl(struct inod
+ #endif
+ {
+ PSUPDRVSESSION pSession = (PSUPDRVSESSION)pFilp-private_data;
++int rc;
+ 
+ /*
+  * Deal with the two high-speed IOCtl that takes it's arguments from
+@@ -632,12 +639,15 @@ static int VBoxDrvLinuxIOCtl(struct inod
+   || uCmd == SUP_IOCTL_FAST_DO_HM_RUN
+   || uCmd == SUP_IOCTL_FAST_DO_NOP)
+pSession-fUnrestricted == true))
+-return supdrvIOCtlFast(uCmd, ulArg, g_DevExt, pSession);
++{
++stac();
++rc = supdrvIOCtlFast(uCmd, ulArg, g_DevExt, pSession);
++clac();
++return rc;
++}
+ return VBoxDrvLinuxIOCtlSlow(pFilp, uCmd, ulArg, pSession);
+ 
+ #else   /* !HAVE_UNLOCKED_IOCTL */
+-
+-int rc;
+ unlock_kernel();
+ if (RT_LIKELY(   (   uCmd == SUP_IOCTL_FAST_DO_RAW_RUN
+   || uCmd == SUP_IOCTL_FAST_DO_HM_RUN
+@@ -715,7 +725,9 @@ static int VBoxDrvLinuxIOCtlSlow(struct
+ /*
+  * Process the IOCtl.
+  */
++stac();
+ rc = supdrvIOCtl(uCmd, g_DevExt, pSession, pHdr, cbBuf);
++clac();
+ 
+ /*
+  * Copy ioctl data and output buffer back to user space.
diff -Naur virtualbox-4.3.18-dfsg.orig/debian/patches/series virtualbox-4.3.18-dfsg/debian/patches/series
--- virtualbox-4.3.18-dfsg.orig/debian/patches/series	2015-03-04 10:34:01.0 +0100
+++ virtualbox-4.3.18-dfsg/debian/patches/series	2015-04-22 19:48:16.138459638 +0200
@@ -14,3 +14,4 @@
 32-disable-guest-version-check.patch
 35-libvdeplug-soname.patch
 36-fix-vnc-version-string.patch
+disable-smap.patch


Bug#783142: VMs fail to start on Broadwell CPUs

2015-04-22 Thread Moritz Muehlenhoff
Package: virtualbox
Version: 4.3.18-dfsg-3
Severity: important

Hi,
virtualbox doesn't work on Broadwell CPUs; all VMs fail to start no
matter what the user configures in the VM settings.

This was reported upstream at https://www.virtualbox.org/ticket/13820

I verified that the patch by Frank works on my Thinkpad X250 with such
a CPU. I'm attaching a suitable Debian diff.

Please fix this for the jessie 8.1 point release, Broadwell CPUs will
become increasingly popular and Vbox is completely broken on them.

Cheers,
Moritz


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org