Bug#785281: [pkg-php-pear] Bug#785281: Split phpseclib?

[David Prévot]

Hi Mathieu,

 3./ The php-phpseclib should provide all the libraries it ships.
 This would be the proper fix for #785281.

 Digging a bit, this would not be the proper fix for #785281.

 Here is an extract from the diff:
   * Here's an example of how to use this library:
   * code
   * ?php
 - *include('Math/BigInteger.php');
 - *
 - *$a = new Math_BigInteger(2);
 - *$b = new Math_BigInteger(3);
 + *$a = new \phpseclib\Math\BigInteger(2);
 + *$b = new \phpseclib\Math\BigInteger(3);
 [...]
 +namespace phpseclib\Math;
 [...]

 Those are two different classes, with different namespaces.

I can’t see such difference between the currently packaged phpseclib and
php-math-biginteger. The namespaces change is supposed to happen in the
next 1. or 2. branch of phpseclib, but the latest upstream version as
available in Debian, is not yet inside this new namespace.

Ha, that reminds me of the “good old times” and
https://github.com/phpseclib/phpseclib/issues/125…

 It seems They should probably be installed at a different path:

 /usr/share/php/Math/BigInteger.php
 /usr/share/php/phpseclib/Math/BigInteger.php

Not yet, sorry.

 I prefer that the files are moved. But this may be a painfull transition.

One we’ll have to take care anyway, but I don’t intend to start it before
upstream publish a stable release with the new namespase (not even an
alpha has been published yet).

 I'd welcome if the phpseclib package Provides php-phpseclib-file-asn1

Sure, I’ll had the others too, but the previous question still stands:
should I
 add another fake “provides: php-math-biginteger (= 1.0.2-3)” for example
 (i.e., a bit higher than the current php-math-biginteger real package),
 or [would] you […] patch php-horde-mapi to drop the versionned dependency
 for php-math-biginteger.
?

Regards

David


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#785281: [pkg-php-pear] Bug#785281: Split phpseclib?

[Mathieu Parent]

2015-05-16 17:53 GMT+02:00 David Prévot taf...@debian.org:
 [ Following up to #785281 only, all recipient should get the message
   from it (once). ]

 Hi Mathieu,

 Le 16/05/2015 08:07, Mathieu Parent a écrit :

 There are three problems here:
 […]
 2./ The current package name from composer should be php-phpseclib
 instead. I will file a bug about this.

 There is already #757537. If that’s enough, I can try and work on it.

Yes, that would do it.

 3./ The php-phpseclib should provide all the libraries it ships.
 This would be the proper fix for #785281.

Digging a bit, this would not be the proper fix for #785281.

Here is an extract from the diff:
  * Here's an example of how to use this library:
  * code
  * ?php
- *include('Math/BigInteger.php');
- *
- *$a = new Math_BigInteger(2);
- *$b = new Math_BigInteger(3);
+ *$a = new \phpseclib\Math\BigInteger(2);
+ *$b = new \phpseclib\Math\BigInteger(3);
[...]
+namespace phpseclib\Math;
[...]

Those are two different classes, with different namespaces.

It seems They should probably be installed at a different path:

/usr/share/php/Math/BigInteger.php
/usr/share/php/phpseclib/Math/BigInteger.php


What do you think?


[...]
 Please let me know if you prefer me to add this additional hack into
 phpseclib, or if you’re willing to drop the versionned dependency from
 php-horde-mapi.

I prefer that the files are moved. But this may be a painfull transition.

I'd welcome if the phpseclib package Provides php-phpseclib-file-asn1



-- 
Mathieu


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org