Bug#788321: elinks: FTBFS on arm64

2015-06-25 Thread Wookey
+++ Moritz Muehlenhoff [2015-06-25 08:30 +0200]:
> 
> What I don't understand is why elinks built before on arm64, e.g. in
> jessie?

The jessie version (pre6-5) already had a build-dep on autotools-dev
(which makes the current config.{sub,guess} available, and then its own
manual machinery for updating them. 

That version built (and still builds) fine in jessie and unstable. 

pre6-6 was the first one to break:
https://buildd.debian.org/status/logs.php?pkg=elinks&arch=arm64 

and it dies with: "machine aarch64' not recognized"

That version was the firs to use a simple 'dh' rules file (according
to https://tracker.debian.org/news/681779) . But
presumably forgot to explicitly say --with autotools-dev? so the
shipped config.{sub,guess} was used, not the uptodate ones in
autotools-dev.

adding --with dh-autoreconf didn't fix that because this is a
non-automake/non-libtool package.

So it does all make sense.

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#788321: elinks: FTBFS on arm64

2015-06-24 Thread Moritz Muehlenhoff
Hi Wookey,

On Thu, Jun 25, 2015 at 01:07:08AM +0100, Wookey wrote:
> Moritz Mühlenhoff  wrote:
> > I have been holding this back since dh compat level 10 is supposed
> > to do that by default
> 
> This has been mentioned as a possible enhancement of debhelper but is
> not scheduled or certain yet:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=480576#35
> so we get to do it manually for a while longer.

Ah, ok. I thought that was done already.

> Edmund Grimley Evans  wrote:
> 
> > I was able to build successfully if I replaced
> > --with autoreconf
> > with either
> > --with autotools-dev
> > or
> > --with autoreconf,autotools-dev
> 
> The latter is correct. See
> https://wiki.debian.org/Autoreconf#dh-autoreconf_and_autotools-dev
> 
> This package uses autoconf, but not libtool or automake. So
> dh_autoreconf will not update config.{sub,guess} on its own.
> autotools-dev also needs to be installed and used.
> 
> I've just confirmed that doing this does indeed fix matters
> (autotools-dev is still in the control file so the above one-line
> change is all that's needed). Patch attached anyway, as I've done one.

What I don't understand is why elinks built before on arm64, e.g. in
jessie?

> I'm happy to NMU this if you like.

Thanks, but I'll do it this weekend, just haven't come around to it yet 
(and want to fold in another fix as well).

Cheers,
Moritz


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#788321: elinks: FTBFS on arm64

2015-06-24 Thread Wookey
Moritz Mühlenhoff  wrote:
> I have been holding this back since dh compat level 10 is supposed
> to do that by default

This has been mentioned as a possible enhancement of debhelper but is
not scheduled or certain yet:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=480576#35
so we get to do it manually for a while longer.

Edmund Grimley Evans  wrote:

> I was able to build successfully if I replaced
> --with autoreconf
> with either
> --with autotools-dev
> or
> --with autoreconf,autotools-dev

The latter is correct. See
https://wiki.debian.org/Autoreconf#dh-autoreconf_and_autotools-dev

This package uses autoconf, but not libtool or automake. So
dh_autoreconf will not update config.{sub,guess} on its own.
autotools-dev also needs to be installed and used.

I've just confirmed that doing this does indeed fix matters
(autotools-dev is still in the control file so the above one-line
change is all that's needed). Patch attached anyway, as I've done one.

I'm happy to NMU this if you like.

Wookey
-- 
Principal hats:  Linaro, Debian, Wookware, ARM
http://wookware.org/
diff -Nru elinks-0.12~pre6/debian/changelog elinks-0.12~pre6/debian/changelog
--- elinks-0.12~pre6/debian/changelog	2015-06-17 21:53:16.0 +
+++ elinks-0.12~pre6/debian/changelog	2015-06-24 21:53:11.0 +
@@ -1,3 +1,10 @@
+elinks (0.12~pre6-9.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Use autotools-dev as well as dh-autoreconf (Closes: #788321)
+
+ -- Wookey   Wed, 24 Jun 2015 16:18:46 +
+
 elinks (0.12~pre6-9) unstable; urgency=medium
 
   * Use dh-autoreconf to support arm64 (Closes: #788321)
diff -Nru elinks-0.12~pre6/debian/rules elinks-0.12~pre6/debian/rules
--- elinks-0.12~pre6/debian/rules	2015-06-17 21:46:39.0 +
+++ elinks-0.12~pre6/debian/rules	2015-06-24 21:53:37.0 +
@@ -4,7 +4,7 @@
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,-z,defs
 
 %:
-	dh $@ --with autoreconf
+	dh $@ --with autoreconf,autotools-dev
 
 override_dh_auto_configure:
 	dh_auto_configure --  --prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info --sysconfdir=/etc/elinks --without-lzma --without-openssl --without-x --enable-finger --with-gnutls=/usr --disable-nntp --enable-88-colors --enable-256-colors --enable-leds --enable-html-highlight --enable-fsp --disable-smb --with-perl --without-guile --without-python --without-ruby --with-gssapi --enable-cgi --disable-exmode --disable-bittorrent --disable-debug --without-spidermonkey


Bug#788321: elinks: FTBFS on arm64

2015-06-18 Thread Edmund Grimley Evans
Well, that's annoying. I thought it worked for me...

This time... I was able to reproduce 0.12~pre6-9's build failure in a
fresh chroot, and I was able to build successfully if I replaced

--with autoreconf

with either

--with autotools-dev

or

--with autoreconf,autotools-dev

Try that that last possibility, with both, perhaps?

I'm sorry this is dragging on for so long.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#788321: elinks: FTBFS on arm64

2015-06-10 Thread Moritz Mühlenhoff
On Wed, Jun 10, 2015 at 10:22:03AM +0100, Edmund Grimley Evans wrote:
> > Your patch seems to have been made against the debian/rules file
> > from jessie, but it has been migrated to dh in 0.12~pre6-7.
> 
> I wonder how that happened. Perhaps I'm using a tardy mirror.
> 
> Well, referring to
> https://sources.debian.net/src/elinks/0.12~pre6-8/debian/rules/ ...
> how about replacing "dh $@" with "dh $@ --with autoreconf"?

Ok. I have been holding this back since dh compat level 10 is supposed
to do that by default, but if arm64 needs this, I'll fold it into
the next upload.

Cheers,
Moritz


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#788321: elinks: FTBFS on arm64

2015-06-10 Thread Edmund Grimley Evans
> Your patch seems to have been made against the debian/rules file
> from jessie, but it has been migrated to dh in 0.12~pre6-7.

I wonder how that happened. Perhaps I'm using a tardy mirror.

Well, referring to
https://sources.debian.net/src/elinks/0.12~pre6-8/debian/rules/ ...
how about replacing "dh $@" with "dh $@ --with autoreconf"?


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#788321: elinks: FTBFS on arm64

2015-06-10 Thread Moritz Mühlenhoff
On Wed, Jun 10, 2015 at 09:41:48AM +0100, Edmund Grimley Evans wrote:
> Source: elinks
> Version: 0.12~pre6-8
> Tags: patch
> 
> It failed to build on arm64:
> 
> https://buildd.debian.org/status/package.php?p=elinks&suite=sid
> 
> Mysteriously, I couldn't reproduce the build failure in my chroot.
> However, you could try the attached patch with your next upload.
> 
> See https://wiki.debian.org/Autoreconf

Your patch seems to have been made against the debian/rules file
from jessie, but it has been migrated to dh in 0.12~pre6-7.

Cheers,
Moritz


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#788321: elinks: FTBFS on arm64

2015-06-10 Thread Edmund Grimley Evans
Source: elinks
Version: 0.12~pre6-8
Tags: patch

It failed to build on arm64:

https://buildd.debian.org/status/package.php?p=elinks&suite=sid

Mysteriously, I couldn't reproduce the build failure in my chroot.
However, you could try the attached patch with your next upload.

See https://wiki.debian.org/Autoreconf


patch
Description: Binary data