Bug#791475: bup: Unable to restore an emacs autosave file #.fetchmailrc#

[Rob Browning]

I suspect this has been fixed by:

  commit 0527f5d46b7d3f3f874d45cd59db01aa48a84046
  Author: Rob Browning 
  Date:   Tue Sep 6 23:34:24 2016 -0500

  Handle ntfs-3g EINVAL for attr save/restore

  It appears that ntfs-3g now returns EINVAL for unsupported ioctls
  including FS_IOC_GET_FLAGS and FS_IOC_SET_FLAGS.

  Treat EINVAL like the existing expected errors for these calls, but
  since there's evidence to suggest that other devices/filesystems use
  EINVAL to indicate more serious trouble and use ENOTTY to indicate
  unsupported ioctls, include a request to report any occurrences of
  EINVAL when ntfs-3g is not involved.

  Thanks to Mark J Hewitt for reporting the problem.

  Signed-off-by: Rob Browning 
  Tested-by: Rob Browning 

(EINVAL is 22) and so should be corrected in the next release.

And as a temporary solution, just adding EINVAL to the set of expected errno
values (as shown in that patch) should work fine.

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

Bug#791475: bup: Unable to restore an emacs autosave file #.fetchmailrc#

[Rob Browning]

David Creelman creelman.da...@gmail.com writes:

 Hi Rob, Robert,
 More details.
 lsattr on the original file gives
 -e-- /home/davidc/#.fetchmailrc#

 bup ls -l of the problem file gives
 -rwx-- davidc/davidc 833 2015-01-20 23:42
 home-dir/latest/home/davidc/#.fetchmailrc#

 lsattr of the original file is
 -e-- /home/davidc/#mredauto#1#

 bup ls -l of the file stored in bup is
 bup ls -l home-dir/latest/home/davidc/#mredauto#1#
 -rw-r--r-- davidc/davidc7790 2014-01-07 15:43
 home-dir/latest/home/davidc/#mredauto#1#

This is all (currently) myterious.  I don't see any reason you should be
having trouble, but we've had weirdness with attr before.  Maybe it's
more of the same?  What I'm wondering is if someone (maybe us) is
getting the attr value handling wrong (again).

If you're up for it, you might try adding a print statement like this to
metadata.py in _apply_linux_attr_rec():

else:
print  sys.stderr, 'bad chattr', repr((path, 
self.linux_attr))
raise

And then re-run the restore so we can see the linux_attr value when it
fails.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#791475: bup: Unable to restore an emacs autosave file #.fetchmailrc#

[David Creelman]

Hi Rob, Robert,
More details.
lsattr on the original file gives
-e-- /home/davidc/#.fetchmailrc#

bup ls -l of the problem file gives
-rwx-- davidc/davidc 833 2015-01-20 23:42
home-dir/latest/home/davidc/#.fetchmailrc#

Using --exclude-rx (the second one) I got past the first problem, but then
crashed on a different file

Traceback (most recent call last):
  File /usr/lib/bup/cmd/bup-restore, line 343, in module
do_node(n.parent, n, opt.sparse, owner_map, meta = meta)
  File /usr/lib/bup/cmd/bup-restore, line 279, in do_node
do_node(top, sub, sparse, owner_map, meta = m)
  File /usr/lib/bup/cmd/bup-restore, line 281, in do_node
apply_metadata(meta, fullname, opt.numeric_ids, owner_map)
  File /usr/lib/bup/cmd/bup-restore, line 105, in apply_metadata
m.apply_to_path(name, restore_numeric_ids = restore_numeric_ids)
  File /usr/lib/bup/bup/metadata.py, line 809, in apply_to_path
apply_metadata(path, restore_numeric_ids=num_ids)
  File /usr/lib/bup/bup/metadata.py, line 611, in _apply_linux_attr_rec
set_linux_file_attr(path, self.linux_attr)
OSError: [Errno 22] Invalid argument: 'davidc/#mredauto#1#'


lsattr of the original file is
-e-- /home/davidc/#mredauto#1#

bup ls -l of the file stored in bup is
bup ls -l home-dir/latest/home/davidc/#mredauto#1#
-rw-r--r-- davidc/davidc7790 2014-01-07 15:43
home-dir/latest/home/davidc/#mredauto#1#

The file is a racket (scheme IDE) file.
It's contents are just text. It's scheme script with some extra annotation.
Nothing particularly special. I've not included it because it's a bit long,
but I can later if you want

Let me know if you need other stuff.

Regards,
David




On Tue, 7 Jul 2015 at 15:15 Rob Browning r...@defaultvalue.org wrote:

 David Creelman creelman.da...@gmail.com writes:

  Having said that, it's just vanilla text. Nothing odd in it at first
 glance.
  It's ls -l is
  -rwx-- 1 davidc davidc 833 Jan 20 23:42 /home/davidc/#.fetchmailrc#*
  file gives
  /home/davidc/#.fetchmailrc#: ASCII text

 OK, thanks, and the lsattr call is the one most directly related to the
 error you encountered, so the output of that would still be interesting.

 --
 Rob Browning
 rlb @defaultvalue.org and @debian.org
 GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
 GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

Bug#791475: bup: Unable to restore an emacs autosave file #.fetchmailrc#

[Robert Edmonds]

Hi, David:

I'm not quite sure what the issue is here, so I've Cc'd the upstream bup
mailing list.  It looks like one of the ioctl() calls in the
bup_set_linux_file_attr() function is failing.

Did you run the 'bup restore' as a regular user or as root?

What is the type of the filesystem that you're attempting to restore to?

David Creelman wrote:
 Package: bup
 Version: 0.27-1
 Severity: important
 
 Dear Maintainer,
 
 Have successfully done a backup via index and then save.
 
 export BUP=/media/me/some-drive/backups
 bup index /home/redacted
 bup save -n home-dir /home/redacted
 
 Have then done an incremental backup
 bup index /home/redacted
 bup save -n home-dir /home/redacted
 
 All completes with minor errors about web cache files dissapearing, but okay.
 
 Tried to restore the latest backup by the following
 
 bup restore -C test-dir home-dir/latest/home/redacted
 
 Got the following error
 
 Traceback (most recent call last):
   File /usr/lib/bup/cmd/bup-restore, line 343, in module
 do_node(n.parent, n, opt.sparse, owner_map, meta = meta)
   File /usr/lib/bup/cmd/bup-restore, line 279, in do_node
 do_node(top, sub, sparse, owner_map, meta = m)
   File /usr/lib/bup/cmd/bup-restore, line 281, in do_node
 apply_metadata(meta, fullname, opt.numeric_ids, owner_map)
   File /usr/lib/bup/cmd/bup-restore, line 105, in apply_metadata
 m.apply_to_path(name, restore_numeric_ids = restore_numeric_ids)
   File /usr/lib/bup/bup/metadata.py, line 809, in apply_to_path
 apply_metadata(path, restore_numeric_ids=num_ids)
   File /usr/lib/bup/bup/metadata.py, line 611, in _apply_linux_attr_rec
 set_linux_file_attr(path, self.linux_attr)
 OSError: [Errno 22] Invalid argument: 'redacted/#.fetchmailrc#
 
 I was expecting the file to be able to be restored (indeed it seems to have 
 been 
 backed up).
 
 I am guessing that filenames containing hashes are not liked by bup?
 This means I won't be able to back up any folders containing emacs edited 
 files.
 #file# style files are used regularly by emacs.
 
 Not sure how to solve this one. 
 
 Should you require more details (or if I've missed something obvious to get 
 around this
 issue) please let me know.
 
 Regards,
 David
 
 -- System Information:
 Debian Release: stretch/sid
   APT prefers testing
   APT policy: (500, 'testing')
 Architecture: i386 (i686)
 
 Kernel: Linux 3.16.0-4-686-pae (SMP w/2 CPU cores)
 Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
 Shell: /bin/sh linked to /bin/dash
 Init: systemd (via /run/systemd/system)
 
 Versions of packages bup depends on:
 ii  git  1:2.1.4-2.1
 ii  libc62.19-18
 ii  par2 0.6.13-1
 ii  python   2.7.9-1
 ii  python-pylibacl  0.5.2-1
 ii  python-pyxattr   0.5.3-1
 ii  python2.72.7.10-2
 pn  python:any   none
 
 Versions of packages bup recommends:
 ii  bup-doc 0.27-1
 ii  python-fuse 2:0.2.1-11
 ii  python-tornado  4.2.0-1
 
 bup suggests no packages.
 
 -- no debconf information

-- 
Robert Edmonds
edmo...@debian.org


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#791475: bup: Unable to restore an emacs autosave file #.fetchmailrc#

[Rob Browning]

Robert Edmonds edmo...@debian.org writes:

 I'm not quite sure what the issue is here, so I've Cc'd the upstream bup
 mailing list.  It looks like one of the ioctl() calls in the
 bup_set_linux_file_attr() function is failing.

 Did you run the 'bup restore' as a regular user or as root?

 What is the type of the filesystem that you're attempting to restore to?

Both good questions.  For example, right now bup's handling of
differences between the source and destination filesystems could
likely use improvement.

   File /usr/lib/bup/bup/metadata.py, line 611, in _apply_linux_attr_rec
 set_linux_file_attr(path, self.linux_attr)
 OSError: [Errno 22] Invalid argument: 'redacted/#.fetchmailrc#

Any chance you still have the file around, and if so, assuming the
output isn't sensitive, I wonder what ls -l, stat and lsattr say
about it?

And even if you don't still have it in the filesystem, I wonder what
these commands say:

  bup ls -l home-dir/latest/home/redacted/#.fetchmailrc#

  bup cat-file --meta home-dir/latest/home/redacted/#.fetchmailrc# \
bup meta -tvvf -

 I am guessing that filenames containing hashes are not liked by bup?
 This means I won't be able to back up any folders containing emacs edited 
 files.
 #file# style files are used regularly by emacs.

I'm fairly sure that normally #file# should be handled without any
trouble.  I think there's something else going on here.

 Should you require more details (or if I've missed something obvious to get 
 around this
 issue) please let me know.

I wonder if adding this to the restore might provide a workaround for
now:

  --exclude-rx '^/redacted/#\.fetchmailrc#$'

Or perhaps:

  --exclude-rx '^redacted/#\.fetchmailrc#$'

Not sure which one is correct offhand.

Hope this helps
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#791475: bup: Unable to restore an emacs autosave file #.fetchmailrc#

[David Creelman]

Hi Rob,
I ran as root.
I had previously tried to run as my normal user, but I got an error about
not being able to access my own home dir, so I (perhaps a little heavy
handedly) simply did it all as root.
I'll try the --exclude and I'll do a bup ls too. I can't get to it right
now (external drive at home), so I'll try later on tonight (I'm at work
now).
The drive is a 500gb drive formatted to ext4.
The original file is kind of sensitive (contains passwords and such).
Having said that, it's just vanilla text. Nothing odd in it at first glance.
It's ls -l is
-rwx-- 1 davidc davidc 833 Jan 20 23:42 /home/davidc/#.fetchmailrc#*
file gives
/home/davidc/#.fetchmailrc#: ASCII text
Thanks for your help.
I'll get onto the bup suggestions (ls  --exclude) as soon as I can.
Regards,
David



On Tue, 7 Jul 2015 at 12:25 Rob Browning r...@defaultvalue.org wrote:

 Robert Edmonds edmo...@debian.org writes:

  I'm not quite sure what the issue is here, so I've Cc'd the upstream bup
  mailing list.  It looks like one of the ioctl() calls in the
  bup_set_linux_file_attr() function is failing.
 
  Did you run the 'bup restore' as a regular user or as root?
 
  What is the type of the filesystem that you're attempting to restore to?

 Both good questions.  For example, right now bup's handling of
 differences between the source and destination filesystems could
 likely use improvement.

File /usr/lib/bup/bup/metadata.py, line 611, in
 _apply_linux_attr_rec
  set_linux_file_attr(path, self.linux_attr)
  OSError: [Errno 22] Invalid argument: 'redacted/#.fetchmailrc#

 Any chance you still have the file around, and if so, assuming the
 output isn't sensitive, I wonder what ls -l, stat and lsattr say
 about it?

 And even if you don't still have it in the filesystem, I wonder what
 these commands say:

   bup ls -l home-dir/latest/home/redacted/#.fetchmailrc#

   bup cat-file --meta home-dir/latest/home/redacted/#.fetchmailrc# \
 bup meta -tvvf -

  I am guessing that filenames containing hashes are not liked by bup?
  This means I won't be able to back up any folders containing emacs
 edited files.
  #file# style files are used regularly by emacs.

 I'm fairly sure that normally #file# should be handled without any
 trouble.  I think there's something else going on here.

  Should you require more details (or if I've missed something obvious to
 get around this
  issue) please let me know.

 I wonder if adding this to the restore might provide a workaround for
 now:

   --exclude-rx '^/redacted/#\.fetchmailrc#$'

 Or perhaps:

   --exclude-rx '^redacted/#\.fetchmailrc#$'

 Not sure which one is correct offhand.

 Hope this helps
 --
 Rob Browning
 rlb @defaultvalue.org and @debian.org
 GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
 GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

Bug#791475: bup: Unable to restore an emacs autosave file #.fetchmailrc#

[Rob Browning]

David Creelman creelman.da...@gmail.com writes:

 Having said that, it's just vanilla text. Nothing odd in it at first glance.
 It's ls -l is
 -rwx-- 1 davidc davidc 833 Jan 20 23:42 /home/davidc/#.fetchmailrc#*
 file gives
 /home/davidc/#.fetchmailrc#: ASCII text

OK, thanks, and the lsattr call is the one most directly related to the
error you encountered, so the output of that would still be interesting.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#791475: bup: Unable to restore an emacs autosave file #.fetchmailrc#

[David Creelman]

Package: bup
Version: 0.27-1
Severity: important

Dear Maintainer,

Have successfully done a backup via index and then save.

export BUP=/media/me/some-drive/backups
bup index /home/redacted
bup save -n home-dir /home/redacted

Have then done an incremental backup
bup index /home/redacted
bup save -n home-dir /home/redacted

All completes with minor errors about web cache files dissapearing, but okay.

Tried to restore the latest backup by the following

bup restore -C test-dir home-dir/latest/home/redacted

Got the following error

Traceback (most recent call last):
  File /usr/lib/bup/cmd/bup-restore, line 343, in module
do_node(n.parent, n, opt.sparse, owner_map, meta = meta)
  File /usr/lib/bup/cmd/bup-restore, line 279, in do_node
do_node(top, sub, sparse, owner_map, meta = m)
  File /usr/lib/bup/cmd/bup-restore, line 281, in do_node
apply_metadata(meta, fullname, opt.numeric_ids, owner_map)
  File /usr/lib/bup/cmd/bup-restore, line 105, in apply_metadata
m.apply_to_path(name, restore_numeric_ids = restore_numeric_ids)
  File /usr/lib/bup/bup/metadata.py, line 809, in apply_to_path
apply_metadata(path, restore_numeric_ids=num_ids)
  File /usr/lib/bup/bup/metadata.py, line 611, in _apply_linux_attr_rec
set_linux_file_attr(path, self.linux_attr)
OSError: [Errno 22] Invalid argument: 'redacted/#.fetchmailrc#

I was expecting the file to be able to be restored (indeed it seems to have 
been 
backed up).

I am guessing that filenames containing hashes are not liked by bup?
This means I won't be able to back up any folders containing emacs edited files.
#file# style files are used regularly by emacs.

Not sure how to solve this one. 

Should you require more details (or if I've missed something obvious to get 
around this
issue) please let me know.

Regards,
David

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 3.16.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages bup depends on:
ii  git  1:2.1.4-2.1
ii  libc62.19-18
ii  par2 0.6.13-1
ii  python   2.7.9-1
ii  python-pylibacl  0.5.2-1
ii  python-pyxattr   0.5.3-1
ii  python2.72.7.10-2
pn  python:any   none

Versions of packages bup recommends:
ii  bup-doc 0.27-1
ii  python-fuse 2:0.2.1-11
ii  python-tornado  4.2.0-1

bup suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org