Bug#792852: gcom: copyright file missing after upgrade (policy 12.5)

2015-07-21 Thread Andreas Jimmy Gredler
On 07/19/2015 04:38 AM, Andreas Beckmann wrote:
 Package: gcom
 Version: 0.32-2
 Severity: serious
 User: debian...@lists.debian.org
 Usertags: piuparts
 
 Hi,

Hi Andreas,

Thank you so much for your bug report and all the details.

[ ... ]

 After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.
 
 This was observed on the following upgrade paths:
 
 lenny - squeeze - ...

[ ... ]

 Note that dpkg intentionally does not replace directories with symlinks
 and vice versa, you need the maintainer scripts to do this.
 See in particular the end of point 4 in
 https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase

I tried to find out what caused the problems but the package had a
comgt.links file so the symlink should have been created and I'm pretty
sure I verified that (but maybe not for lenny-squeeze).
Or do you mean that the behavior of dpkg changed and that's why the
symlink was not unpacked when using dpkg from squeeze?

 But since this has been a transitional package since squeeze,
 maybe it is easiest to just drop it and add unversioned Breaks+Replaces
 against it to comgt to ensure the buggy package is removed on upgrades.

Yes, that sounds like a great plan :) I will prepare a new package and
also fix the open bugs.

Best,
Andy


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#792852: gcom: copyright file missing after upgrade (policy 12.5)

2015-07-19 Thread Andreas Beckmann
Package: gcom
Version: 0.32-2
Severity: serious
User: debian...@lists.debian.org
Usertags: piuparts

Hi,

a test with piuparts revealed that your package misses the copyright
file after an upgrade, which is a violation of Policy 12.5:
https://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile

After the upgrade /usr/share/doc/$PACKAGE/ is just an empty directory.

This was observed on the following upgrade paths:

lenny - squeeze - ...

From the attached log (scroll to the bottom...):

7m24.3s ERROR: WARN: Inadequate results from running adequate!
  gcom: missing-copyright-file /usr/share/doc/gcom/copyright

  MISSING COPYRIGHT FILE: /usr/share/doc/gcom/copyright
  # ls -lad /usr/share/doc/gcom
  drwxr-xr-x 2 root root 40 Feb 13 15:14 /usr/share/doc/gcom
  # ls -la /usr/share/doc/gcom/
  total 0
  drwxr-xr-x   2 root root   40 Feb 13 15:14 .
  drwxr-xr-x 116 root root 2460 Feb 13 15:15 ..


Additional info may be available here:
https://wiki.debian.org/MissingCopyrightFile

Note that dpkg intentionally does not replace directories with symlinks
and vice versa, you need the maintainer scripts to do this.
See in particular the end of point 4 in
https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-unpackphase

It is recommended to use the dpkg-maintscript-helper commands
'dir_to_symlink' and 'symlink_to_dir' (available since dpkg 1.17.14)
to perform the conversion, ideally using d/$PACKAGE.mainstscript.
Do not forget to add 'Pre-Depends: ${misc:Pre-Depends}' in d/control.
See dpkg-maintscript-helper(1) and dh_installdeb(1) for details.


But since this has been a transitional package since squeeze,
maybe it is easiest to just drop it and add unversioned Breaks+Replaces
against it to comgt to ensure the buggy package is removed on upgrades.


cheers,

Andreas


gcom_0.32-2.log.gz
Description: application/gzip