Bug#794526: busybox: testsuite is run iff DEB_BUILD_OPTIONS contains nocheck
On Tue, Aug 04, 2015 at 03:35:38PM +0200, Cyril Brulebois wrote: The non attached patch certainly might not fix anything. ;) Sorry for the omission. Helmut diff -Nru busybox-1.22.0/debian/changelog busybox-1.22.0/debian/changelog --- busybox-1.22.0/debian/changelog 2015-03-04 17:46:39.0 +0100 +++ busybox-1.22.0/debian/changelog 2015-08-04 15:45:44.0 +0200 @@ -1,3 +1,11 @@ +busybox (1:1.22.0-15.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Fix logic inversion in DEB_BUILD_OPTIONS=nocheck handling. +(Closes: #794526) + + -- Helmut Grohne hel...@subdivi.de Tue, 04 Aug 2015 15:45:02 +0200 + busybox (1:1.22.0-15) unstable; urgency=medium [ Michael Gilbert ] diff -Nru busybox-1.22.0/debian/rules busybox-1.22.0/debian/rules --- busybox-1.22.0/debian/rules 2015-03-04 16:12:02.0 +0100 +++ busybox-1.22.0/debian/rules 2015-08-04 15:45:51.0 +0200 @@ -7,7 +7,7 @@ PKGVERSION := $(shell dpkg-parsechangelog | sed -ne 's,^Version: *\(.*\)$$,\1,p') VENDOR := $(shell dpkg-vendor --query vendor) -ifneq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) RUN_TESTSUITE = y endif TESTSUITE_ENV = SKIP_KNOWN_BUGS=y VERBOSE=y
Bug#794526: busybox: testsuite is run iff DEB_BUILD_OPTIONS contains nocheck
Hi, Helmut Grohne hel...@subdivi.de (2015-08-04): Source: busybox Version: 1.22.0-15 Severity: important Tags: patch User: helm...@debian.org Usertags: rebootstrap During a partial archive cross rebuild, I noticed that busybox FTCBFS, because it runs its test suite despite being told DEB_BUILD_OPTIONS=nocheck. This is surprising, because it actually tries to take care of that flag. Even more surprising (and the reason for flagging this bug as important) is that the test suite is not run during native buildd builds. It turned out that the detection logic has an inversion flaw, so the test suite is run and only run when DEB_BUILD_OPTIONS contains nocheck. The attached patch might or might not fix the FTCBFS, but it fixes the logic inversion. The non attached patch certainly might not fix anything. ;) Mraw, KiBi. signature.asc Description: Digital signature
Bug#794526: busybox: testsuite is run iff DEB_BUILD_OPTIONS contains nocheck
Source: busybox Version: 1.22.0-15 Severity: important Tags: patch User: helm...@debian.org Usertags: rebootstrap During a partial archive cross rebuild, I noticed that busybox FTCBFS, because it runs its test suite despite being told DEB_BUILD_OPTIONS=nocheck. This is surprising, because it actually tries to take care of that flag. Even more surprising (and the reason for flagging this bug as important) is that the test suite is not run during native buildd builds. It turned out that the detection logic has an inversion flaw, so the test suite is run and only run when DEB_BUILD_OPTIONS contains nocheck. The attached patch might or might not fix the FTCBFS, but it fixes the logic inversion. Helmut -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
