Bug#797466: lintian: Correct grammar of dir-or-file-in-build-tree long description

[Jakub Wilk]

* Niels Thykier , 2015-08-31, 12:55:

lindsay.d.o:/srv/lintian.debian.org/history/tags/.dat


Aren't those all false positives from #720910?


I'm still curious to know how could it happen.


I do not remember how or what happened.  I can trace the tag back to 
#678857, which includes Andreas Beckmann quoting me from IRC:


"""
 we occasially [sic!] also see buildd paths as well
"""


Perhaps by buildd paths you meant /build (or /tmp/buildd)? I can image 
that these can appear in debs easily by mistake.


--
Jakub Wilk

Bug#797466: lintian: Correct grammar of dir-or-file-in-build-tree long description

[Niels Thykier]

On 2015-08-31 11:12, Jakub Wilk wrote:
> * Niels Thykier , 2015-08-31, 07:39:
>>> I would have no idea what this tag is about if I didn't look at the
>>> code. It triggers when the package include files in
>>> /var/cache/pbuilder/build/ or /var/lib/sbuild/ or /var/lib/buildd/.
>>>
>>> But... how could it even happen that you ship stuff in any of these
>>> directories by accident? This doesn't seem plausible to me.
>>
>> I am afraid it is very plausible.  Between May 18th 2013 and Sep 21.
>> 2013 we had instances of this tag on lintian.d.o.
> 
> OK, I stand corrected.
> 
> Where did you get this information?

lindsay.d.o:/srv/lintian.debian.org/history/tags/.dat

> https://lintian.debian.org/tags/dir-or-file-in-build-tree.html says that
> tag has not been emitted.
> 

This is because the graphs only go back one year.  Although, I admit, I
am not sure how the site handles corner cases like the last tag
disappearing.

Furthermore, this tag is currently on the "fatal" auto-reject list, so
it is difficult reintroduce.

> I'm still curious to know how could it happen.
> 

I do not remember how or what happened.  I can trace the tag back to
#678857, which includes Andreas Beckmann quoting me from IRC:

"""
 we occasially [sic!] also see buildd paths as well
"""

Though I still cannot remember the concrete case and a quick googling
did not help either.

Thanks,
~Niels






signature.asc
Description: OpenPGP digital signature

Bug#797466: lintian: Correct grammar of dir-or-file-in-build-tree long description

[Jakub Wilk]

* Niels Thykier , 2015-08-31, 07:39:
I would have no idea what this tag is about if I didn't look at the 
code. It triggers when the package include files in 
/var/cache/pbuilder/build/ or /var/lib/sbuild/ or /var/lib/buildd/.


But... how could it even happen that you ship stuff in any of these 
directories by accident? This doesn't seem plausible to me.


I am afraid it is very plausible.  Between May 18th 2013 and Sep 21. 
2013 we had instances of this tag on lintian.d.o.


OK, I stand corrected.

Where did you get this information? 
https://lintian.debian.org/tags/dir-or-file-in-build-tree.html says that 
tag has not been emitted.


I'm still curious to know how could it happen.

--
Jakub Wilk

Bug#797466: lintian: Correct grammar of dir-or-file-in-build-tree long description

[Jakub Wilk]

Hi Chris!

* Chris Lamb la...@debian.org, 2015-08-30, 22:45:

-Info: Your package install file in our build tree.
+Info: Your package installed a file in our build tree.


That's an improvement, but I still don't understand what it's trying to 
tell me. I mean, whose build tree?!


I would have no idea what this tag is about if I didn't look at the 
code. It triggers when the package include files in 
/var/cache/pbuilder/build/ or /var/lib/sbuild/ or /var/lib/buildd/.


But... how could it even happen that you ship stuff in any of these 
directories by accident? This doesn't seem plausible to me.


--
Jakub Wilk

Bug#797466: lintian: Correct grammar of dir-or-file-in-build-tree long description

[Chris Lamb]

Package: lintian
Version: 2.5.36.1
Severity: wishlist
Tags: patch

Hi,

The attached patch corrects the grammar of the
dir-or-file-in-build-tree tag's long description.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/checks/files.desc b/checks/files.desc
index 1deb2cc..9c9b524 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1611,7 +1611,7 @@ Info: Debian packages should not install into 
tt/home/tt, because it
 Tag: dir-or-file-in-build-tree
 Severity: serious
 Certainty: possible
-Info: Your package install file in our build tree.
+Info: Your package installed a file in our build tree.
 
 Tag: file-name-is-not-valid-UTF-8
 Severity: serious

Bug#797466: lintian: Correct grammar of dir-or-file-in-build-tree long description

[Niels Thykier]

On 2015-08-30 23:14, Jakub Wilk wrote:
 Hi Chris!
 
 * Chris Lamb la...@debian.org, 2015-08-30, 22:45:
 -Info: Your package install file in our build tree.
 +Info: Your package installed a file in our build tree.
 
 That's an improvement, but I still don't understand what it's trying to
 tell me. I mean, whose build tree?!
 
 I would have no idea what this tag is about if I didn't look at the
 code. It triggers when the package include files in
 /var/cache/pbuilder/build/ or /var/lib/sbuild/ or /var/lib/buildd/.
 
 But... how could it even happen that you ship stuff in any of these
 directories by accident? This doesn't seem plausible to me.
 

I am afraid it is very plausible.  Between May 18th 2013 and Sep 21.
2013 we had instances of this tag on lintian.d.o.  I presume we had
instances even earlier and lintian simply could not detect them before then.

Thanks,
~Niels





signature.asc
Description: OpenPGP digital signature