Bug#797855: Intent to NMU [Re: Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source]

[intrigeri]

Hi,

intrigeri:
> The attached patch seems to be enough to do so: without it my build
> system would use the already generated files, with it it
> generates them.

Two weeks later: I intent to NMU the package with this patch applied
today or in the next few days, in time for the package to reach
testing (once #844227 is fixed) before the Stretch freeze.

Cheers,
-- 
intrigeri

Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source

[intrigeri]

Control: tag -1 + patch

Hi,

Liang Guo:
> On Thu, Sep 3, 2015 at 3:00 PM, Chris Lamb  wrote:
>> Just as a summary, adding python-six is not complete fix - your package
>> would still not being built from the generated sources.

> spice_codegen.py is called in your build procedure, but not in mine.

I think that's precisely the problem here: whether spice_codegen.py is
called or not depends on details about the build environment, which
means that sometimes we'll be building from the source (preferred form
of modification), and sometimes not.

> I remove spice-common/common/generated* to force build system regenerate
> these files, […]

I think it's the way to go (in addition to adding to Build-deps
whatever the code generation tools need, which you already did).

The attached patch seems to be enough to do so: without it my build
system would use the already generated files, with it it
generates them.

Cheers,
-- 
intrigeri

>From d0de8fa654f67469c464a18b459c9591b32432c9 Mon Sep 17 00:00:00 2001
From: intrigeri 
Date: Sat, 31 Dec 2016 15:18:40 +
Subject: [PATCH] debian/rules: delete generated files to ensure they're
 re-generated from source.

---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index 68edba9..cfebeb8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -28,6 +28,8 @@ build-gtk3-stamp:
 	mkdir build-gtk3
 	ls |egrep -v '(debian|build-gtk)'|xargs -i cp -r {} build-gtk3/
 	cp .version .tarball-version build-gtk3/
+	rm build-gtk3/spice-common/common/generated_*
+	rm build-gtk3/spice-common/tests/generated_*
 	cd build-gtk3 && autoreconf
 	cd build-gtk3 && ./configure --prefix=/usr --libdir=/usr/lib/$(DEB_HOST_MULTIARCH) \
 		--enable-smartcard=yes --with-gtk=3.0 --disable-static \
-- 
2.11.0

Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source

[Chris Lamb]

Hi Liang,

> Your pbuild have a custom script called D01_modify_environment, Can you
> show me the content ?

Well, you can see a more comprehensive list of variations between the
two build logs I linked here:

 https://reproducible.debian.net/reproducible.html#variation

.. but as previously mentioned that's a distraction I could reproduce
simply by changing from Europe/London to Etc/GMT-14.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source

[Liang Guo]

Hi, Chris,

On Thu, Sep 3, 2015 at 3:00 PM, Chris Lamb  wrote:
> Hi Liang,
>
>> I cannot reproduce this error on my build environment. it looks this
>> is caused by lack dependency on python-six module.
>
> Not completely. Please re-read my initial bug report:
>
>> > Depending on the timezone of the build system, the package may FTBFS as
>> > the `spice-common/python_modules/codegen.py` tool used to regenerate
>> > these files requires python-six which is not included in the
>> > Build-Depends.
>> >
>> > (ie. I don't believe simply including python-six as a build-dependency
>> > entirely resolves the issue)
>
> If any of that is unclear, please let me know and I will try and
> rephrase it.
>
> Just as a summary, adding python-six is not complete fix - your package
> would still not being built from the generated sources.
>

spice_codegen.py is called in your build procedure, but not in mine.
even I build
with a brand new pbuilder environment.  with following command line:

TZ=/usr/share/zoneinfo/Etc/GMT-14 pbuilder build spice-gtk_0.29-1.dsc

Do you know the reason?

I remove spice-common/common/generated* to force build system regenerate
these files, the generated files are same with the original file.

Would you like show me the build log with python-six on Build-deps ?

Thanks,
-- 
Liang Guo

Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source

[Chris Lamb]

Hi Liang,

> spice_codegen.py is called in your build procedure, but not in mine.

Sure, no problem :)  Without codegen being called:

 
https://reproducible.debian.net/rbuild/unstable/amd64/spice-gtk_0.29-1.rbuild.log

With codegen being called:

 
https://reproducible.debian.net/logs/unstable/amd64/spice-gtk_0.29-1.build2.log.gz

If it helps, here is a diff between the two:

 
https://reproducible.debian.net/logdiffs/unstable/amd64/spice-gtk_0.29-1.diff.gz


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source

[Chris Lamb]

Hi Liang,

> I cannot reproduce this error on my build environment. it looks this
> is caused by lack dependency on python-six module.

Not completely. Please re-read my initial bug report:

> > Depending on the timezone of the build system, the package may FTBFS as
> > the `spice-common/python_modules/codegen.py` tool used to regenerate
> > these files requires python-six which is not included in the
> > Build-Depends.
> > 
> > (ie. I don't believe simply including python-six as a build-dependency
> > entirely resolves the issue)

If any of that is unclear, please let me know and I will try and
rephrase it.

Just as a summary, adding python-six is not complete fix - your package
would still not being built from the generated sources.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source

[Liang Guo]

Hi, Chris,
On Fri, Sep 4, 2015 at 1:56 AM, Chris Lamb  wrote:
>
> If it helps, here is a diff between the two:
>
>  
> https://reproducible.debian.net/logdiffs/unstable/amd64/spice-gtk_0.29-1.diff.gz
>
Your pbuild have a custom script called D01_modify_environment, Can you show
me the content ?

Thanks,
-- 
Liang Guo
http://guoliang.me/

Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source

[Chris Lamb]

Source: spice-gtk
Version: 0.29-1
Severity: serious
Justification: fails to build from source
User: reproducible-bui...@lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi,

The spice-common/common/generated_* files are not reliably regenerated
from source.

Depending on the timezone of the build system, the package may FTBFS as
the `spice-common/python_modules/codegen.py` tool used to regenerate
these files requires python-six which is not included in the
Build-Depends.

(ie. I don't believe simply including python-six as a build-dependency
entirely resolves the issue)

Here's the build running in, for example,
TZ=/usr/share/zoneinfo/Etc/GMT-14

  [..]

  Making all in common
  make[5]: Entering directory
  '/tmp/buildd/spice-gtk-0.29/build-gtk3/spice-common/common'
GEN  generated_client_demarshallers.c
  Traceback (most recent call last):
File "../spice_codegen.py", line 7, in 
  from python_modules import spice_parser
File

"/tmp/buildd/spice-gtk-0.29/build-gtk3/spice-common/python_modules/spice_parser.py",
line 10, in 
  from . import ptypes
File

"/tmp/buildd/spice-gtk-0.29/build-gtk3/spice-common/python_modules/ptypes.py",
line 1, in 
  from . import codegen
File

"/tmp/buildd/spice-gtk-0.29/build-gtk3/spice-common/python_modules/codegen.py",
line 2, in 
  import six
  ImportError: No module named six
  Makefile:788: recipe for target 'generated_client_demarshallers.c'
  failed
  make[5]: *** [generated_client_demarshallers.c] Error 1
  make[5]: Leaving directory
  '/tmp/buildd/spice-gtk-0.29/build-gtk3/spice-common/common'
  Makefile:444: recipe for target 'all-recursive' failed
  make[4]: *** [all-recursive] Error 1
  make[4]: Leaving directory
  '/tmp/buildd/spice-gtk-0.29/build-gtk3/spice-common'
  Makefile:376: recipe for target 'all' failed
  make[3]: *** [all] Error 2
  make[3]: Leaving directory
  '/tmp/buildd/spice-gtk-0.29/build-gtk3/spice-common'
  Makefile:667: recipe for target 'all-recursive' failed
  make[2]: *** [all-recursive] Error 1
  make[2]: Leaving directory '/tmp/buildd/spice-gtk-0.29/build-gtk3'
  Makefile:570: recipe for target 'all' failed
  make[1]: *** [all] Error 2
  make[1]: Leaving directory '/tmp/buildd/spice-gtk-0.29/build-gtk3'
  debian/rules:42: recipe for target 'build-gtk3-stamp' failed
  make: *** [build-gtk3-stamp] Error 2
  dpkg-buildpackage: error: debian/rules build gave error exit status 2

  [..]

The full build log is attached or can be viewed here:


https://reproducible.debian.net/logs/unstable/amd64/spice-gtk_0.29-1.build2.log.gz


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-

Bug#797855: spice-gtk:spice-common/common/generated_* not reliably generated from source

[Liang Guo]

Hi,

I cannot reproduce this error on my build environment. it looks this
is caused by lack dependency on python-six module.

I have added it in spice-gtk[1] git repository master branch, would you
like have a try ?

Thanks,

[1]
ssh://git.debian.org/git/collab-maint/spice-gtk.git

-- 
Liang Guo