Bug#798053: Bug#824079: qgis: FTBFS on non-Linux: 'TCGETS' was not declared in this scope
Hi Bas, thanks for the patch - i will integrate it upstream. > [0] > https://anonscm.debian.org/cgit/pkg-grass/qgis.git/tree/debian/patches/qtermwidget-kfreebsd.patch?h=debian/2.14.2%2bdfsg-2 > [1] https://github.com/qgis/QGIS/pull/3068 I will close this bug with the next upload - and leave the hurd unfixed - if one think that is is important to have qtermwidget available for the hurd please open a new bug and provide a tested patch, i would be happy to apply it upstream, but i will not take any further action to solve this myself. Cheers Alf -- Alf Gaida BDBF C688 EFAD BA89 5A9F 464B CD28 0A0B 4D72 827C signature.asc Description: OpenPGP digital signature
Bug#798053: Bug#824079: qgis: FTBFS on non-Linux: 'TCGETS' was not declared in this scope
Control: tags 824079 pending On 05/13/2016 03:34 AM, Aaron M. Ucko wrote: > Sebastiaan Couwenberg writes: > >> Adding " || defined(__FreeBSD_kernel__)" to the #elif statements in >> kpty.cpp should be sufficient to not need the CMakeLists.txt changes. > > Indeed, that approach (my initial suggestion in #798053) also works, Alf > Gaida's opening comment in https://github.com/lxde/qtermwidget/issues/50 > notwithstanding. For that matter, so does simply testing whether > TIOCGETA and TIOCSETA are defined -- although they're not technically > required to be macros, they are in practice. qtermwidget in qgis is fixed [0] and on its way to unstable. The patch has also been forwarded to QGIS upstream [0]. The changes from the qtermwidget-kfreebsd.patch should also be forwarded to qtermwidget upstream. [0] https://anonscm.debian.org/cgit/pkg-grass/qgis.git/tree/debian/patches/qtermwidget-kfreebsd.patch?h=debian/2.14.2%2bdfsg-2 [1] https://github.com/qgis/QGIS/pull/3068 Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
Bug#798053: Bug#824079: qgis: FTBFS on non-Linux: 'TCGETS' was not declared in this scope
Sebastiaan Couwenberg writes: > Adding " || defined(__FreeBSD_kernel__)" to the #elif statements in > kpty.cpp should be sufficient to not need the CMakeLists.txt changes. Indeed, that approach (my initial suggestion in #798053) also works, Alf Gaida's opening comment in https://github.com/lxde/qtermwidget/issues/50 notwithstanding. For that matter, so does simply testing whether TIOCGETA and TIOCSETA are defined -- although they're not technically required to be macros, they are in practice. -- Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org) http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu
Bug#798053: Bug#824079: qgis: FTBFS on non-Linux: 'TCGETS' was not declared in this scope
Sebastiaan Couwenberg writes: > https://quickgit.kde.org/?p=kpty.git&a=commitdiff&h=35ea45b588db9afcbd796576833ac338c6b4b8e8 > > Is this your suggested patch? And if so, can you test it on kfreebsd-*? That's a fair question. The code change works if I hardcode -DHAVE_TCGETATTR -DHAVE_TCSETATTR on line 13 of src/plugins/grass/CMakeLists.txt. I initially tried adding corresponding check_function_exists calls to that block, but they proved ineffective; CMake evidently doesn't fall back on adding definitions to the command line in the absence of a config header. Likewise, #798053 is still an issue because there was no build system change to complement the code change. Thanks for checking! -- Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org) http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu
