Bug#802451: pbuilder: no longer overwrites Changed-By line in .changes file
Dixi quod… >because that somehow doubles the arguments (this is an old bug, >but previously, the doubling did not break the build): > >[…] >I: Running cd /tmp/buildd/*/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin" >HOME="/nonexistent" dpkg-buildpackage -us -uc -m'Thorsten Glaser >' -e'Thorsten Glaser ' -B -m'\''Thorsten >Glaser '\'' -e'\''Thorsten Glaser '\'' -B >-rfakeroot >/bin/sh: 2: Syntax error: Unterminated quoted string This is actually caused by the absence of --debbuildopts -sa from the command line, not by the presence of --binary-arch. Looks as if they are doubled, and in a broken way at that, when --debbuildopts is never given. With: I: Running cd /tmp/buildd/*/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin" HOME="/nonexistent" dpkg-buildpackage -us -uc -m'Thorsten Glaser ' -e'Thorsten Glaser ' -sa -sa -rfakeroot Without: I: Running cd /tmp/buildd/*/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin" HOME="/nonexistent" dpkg-buildpackage -us -uc -m'Thorsten Glaser ' -e'Thorsten Glaser ' -m'\''Thorsten Glaser '\'' -e'\''Thorsten Glaser '\'' -rfakeroot Looking at this, the -sa is doubled in the with case… Crazy. Wondering, //mirabilos -- „Cool, /usr/share/doc/mksh/examples/uhr.gz ist ja ein Grund, mksh auf jedem System zu installieren.“ -- XTaran auf der OpenRheinRuhr, ganz begeistert (EN: “[…]uhr.gz is a reason to install mksh on every system.”)
Bug#802451: pbuilder: no longer overwrites Changed-By line in .changes file
Mattia Rizzolo dixit: >Did you try? :) Now I did. I added this to /etc/pbuilderrc: case x$DEBEMAIL in (x*' <'*'>') export DEBBUILDOPTS="-m'$DEBEMAIL' -e'$DEBEMAIL'" ;; (x) ;; (*) [[ -n $DEBFULLNAME ]] && \ export DEBBUILDOPTS="-m'$DEBFULLNAME <$DEBEMAIL>' -e'$DEBFULLNAME <$DEBEMAIL>'" ;; esac This ought to restore previous behaviour. This works normally: […] I: Building the package I: Running cd /tmp/buildd/*/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin" HOME="/nonexistent" dpkg-buildpackage -us -uc -m'Thorsten Glaser ' -e'Thorsten Glaser ' -sa -v2.4.9.1+dfsg-1.2 -sa -v2.4.9.1+dfsg-1.2 -rfakeroot dpkg-buildpackage: source package opencv […] It fails when using --binary-arch on the command line though, because that somehow doubles the arguments (this is an old bug, but previously, the doubling did not break the build): […] I: Running cd /tmp/buildd/*/ && env PATH="/usr/sbin:/usr/bin:/sbin:/bin" HOME="/nonexistent" dpkg-buildpackage -us -uc -m'Thorsten Glaser ' -e'Thorsten Glaser ' -B -m'\''Thorsten Glaser '\'' -e'\''Thorsten Glaser '\'' -B -rfakeroot /bin/sh: 2: Syntax error: Unterminated quoted string […] Do you need a new bugreport for that? bye, //mirabilos -- This space for rent.
Bug#802451: pbuilder: no longer overwrites Changed-By line in .changes file
On Fri, Oct 23, 2015 at 11:15:33AM +, Thorsten Glaser wrote: > >> Nah, setting/amending DEBBUILDOPTS will likely work, and I’ll try it. > > > >Good, thanks. > >Please, can you close this bug if that option is enough for you? > > Will do once I tried this out (when I build the next package). Did you try? :) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#802451: pbuilder: no longer overwrites Changed-By line in .changes file
Mattia Rizzolo dixit: >[ I won't keep you in Cc/To, since my smtp (google...) doesn't like [ That’s not really an SMTP, just a bad emulation… ] >Maybe file bugs for those scripts/programs not respecting the docs? Uh maybe, but I’ve been happily using just DEBEMAIL for ages so… >> Nah, setting/amending DEBBUILDOPTS will likely work, and I’ll try it. > >Good, thanks. >Please, can you close this bug if that option is enough for you? Will do once I tried this out (when I build the next package). bye, //mirabilos -- exceptions: a truly awful implementation of quite a nice idea. just about the worst way you could do something like that, afaic. it's like anti-design. that too… may I quote you on that? sure, tho i doubt anyone will listen ;)
Bug#802451: pbuilder: no longer overwrites Changed-By line in .changes file
[ I won't keep you in Cc/To, since my smtp (google...) doesn't like yours, I'll rely on you ML subscription! ] On Wed, Oct 21, 2015 at 04:28:18PM +, Thorsten Glaser wrote: > > devscript use DEBEMAIL for only the email, etc); > > No. It’s documented to do that, but I found several things break > if DEBEMAIL and DEBFULLNAME are set, but setting DEBEMAIL to the > “realname ” format fixes those breakages and does not in‐ > troduce any new bugs, so I use that… umh.. I'd call all of them a bug. Digging on src:devscripts open bugs I found only https://bugs.debian.org/538142 ([nmudiff] Does not respect DEBEMAIL), but I don't really follow that little bug thread. Maybe file bugs for those scripts/programs not respecting the docs? > >mind you, I'm ok at reintroducing it, but with a different variable > >name, like $changedby_email or something, but I believe the need can > >already be fulfilled by the available options. > > Nah, setting/amending DEBBUILDOPTS will likely work, and I’ll try it. Good, thanks. Please, can you close this bug if that option is enough for you? -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#802451: pbuilder: no longer overwrites Changed-By line in .changes file
Mattia Rizzolo dixit:
>Is there a particular reason you can't add, i.e.,
>`${DEBEMAIL:+-e"$DEBEMAIL"}` (or directly your name/surname/mail) to
>your DEBBUILDOPTS pbuilderrc instead? I have DEBEMAIL exported from my
Hmm, good idea.
> devscript use DEBEMAIL for only the email, etc);
No. It’s documented to do that, but I found several things break
if DEBEMAIL and DEBFULLNAME are set, but setting DEBEMAIL to the
“realname ” format fixes those breakages and does not in‐
troduce any new bugs, so I use that…
>mind you, I'm ok at reintroducing it, but with a different variable
>name, like $changedby_email or something, but I believe the need can
>already be fulfilled by the available options.
Nah, setting/amending DEBBUILDOPTS will likely work, and I’ll try it.
>why is there nothing sombody can do that doen't upset somebody else :|
Yeah ☹ thanks for the fast reply though, much appreciated!
bye,
//mirabilos
--
“The final straw, to be honest, was probably my amazement at the volume of
petty, peevish whingeing certain of your peers are prone to dish out on
d-devel, telling each other how to talk more like a pretty princess, as though
they were performing some kind of public service.” (someone to me, privately)
Bug#802451: pbuilder: no longer overwrites Changed-By line in .changes file
On Tue, Oct 20, 2015 at 11:08:11AM +0200, Thorsten Glaser wrote:
> since one of the recent upgrades, pbuilder no longer overrides the
> Changed-By lines in the .changes files when $DEBEMAIL is set. Please
> revert this change as it’s necessary to do so when doing porter uploads,
That's the outcome of bug #567484.
I personally agree that's rather a surprise for most people. Just think
about sponsored uploads...
Is there a particular reason you can't add, i.e.,
`${DEBEMAIL:+-e"$DEBEMAIL"}` (or directly your name/surname/mail) to
your DEBBUILDOPTS pbuilderrc instead? I have DEBEMAIL exported from my
.zshrc, fwiw.
The option is actually documented (I forgot to remove it...), but
1) it conflicts quite some with the rest of the debian tooling (=>
devscript use DEBEMAIL for only the email, etc);
2) people (who don't like reading docs *before* trying to do stuff)
fill it an find themselves in weird position (maybe they won't notice
because they probably don't upload, but still);
3) IMHO overriding Changed-By: is a special need, that need not to be so
easy to use (wrongly even);
4) also, duplicating options like this is imho bad.
mind you, I'm ok at reintroducing it, but with a different variable
name, like $changedby_email or something, but I believe the need can
already be fulfilled by the available options.
> as otherwise the original package maintainers, not the porters, will
> receive the dak mails, which is very undesired and ensures bad blood
> between maintainers and porters (btdt).
please, let me sigh on this :(
why is there nothing sombody can do that doen't upset somebody else :|
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
Bug#802451: pbuilder: no longer overwrites Changed-By line in .changes file
Package: pbuilder Version: 0.219 Severity: normal Hi, since one of the recent upgrades, pbuilder no longer overrides the Changed-By lines in the .changes files when $DEBEMAIL is set. Please revert this change as it’s necessary to do so when doing porter uploads, as otherwise the original package maintainers, not the porters, will receive the dak mails, which is very undesired and ensures bad blood between maintainers and porters (BTDT). -- System Information: Debian Release: stretch/sid APT prefers unreleased APT policy: (500, 'unreleased'), (500, 'buildd-unstable'), (500, 'unstable') Architecture: x32 (x86_64) Foreign Architectures: i386, amd64 Kernel: Linux 4.1.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=C, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/lksh Init: sysvinit (via /sbin/init) Versions of packages pbuilder depends on: ii coreutils 8.23-4 ii debconf [debconf-2.0] 1.5.57 ii debianutils4.5.1 ii debootstrap1.0.72 ii dpkg-dev 1.18.3 ii wget 1.16.3-3 Versions of packages pbuilder recommends: ii devscripts 2.15.9 ii fakeroot1.20.2-1 ii iproute24.1.1-1 ii net-tools 1.60+git20150829.73cef8a-1 ii sudo1.8.12-1 Versions of packages pbuilder suggests: ii cowdancer 0.74 pn gdebi-core pn pbuilder-uml -- debconf information: pbuilder/mirrorsite: http://mirror.virt.tarent.de/mirror/ubuntu pbuilder/nomirror: * pbuilder/rewrite: false
