Bug#805684: python-box2d: FTBFS: swig doesn't like some comment styles any more

[SamuelOPH]

Thanks a lot Jonas,

Eriberto (my sponsor) already uploaded the new changes.

I'm currently starting at the packaging proccess and making some NMUs is
great to achieve more experience.

Are there any plans to update to pybox 2.3.1?
Is there anything I can help?

Samuel Henrique O. P. [samueloph]

Bug#805684: [Debian-olpc-devel] Bug#805684:

[Jonas Smedegaard]

Quoting SamuelOPH (2016-03-27 18:40:17)
> I uploaded a NMU

Thanks a lot!


> to 10-day/delay queue. Feel free to cancel this upload if needed.

On the contrary: Feel free to re-upload without deleay: Your changes are 
all excellent!

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature

Bug#805684:

[SamuelOPH]

Control: tags 805684 patch
Control: tags 805684 pending

Hi,

I uploaded a NMU to 10-day/delay queue. Feel free to cancel this
upload if needed.

The debian/changelog is:

python-box2d (2.0.2+svn20100109.244-1.2) unstable; urgency=medium

  * Non-maintainer upload.
  * debian/control:
- Change to new Homepage.
- Update to Debian Policy 3.9.7.
  * debian/patches:
- fix_comments.patch: Add patch to fix comment formatting so that the
  package doesn't FTBFS with SWIG 3 (patch courtesy of Jitka Plesnikova),
  thanks to Logan Rosen  for ponting out the patch
  (closes: #805684).
  * debian/watch:
- Change to new url from GitHub.
- Update to version 4.

I attached a debdiff.

Thanks.



Samuel Henrique O. P. [samueloph]


python-box2d.debdiff
Description: Binary data

Bug#805684: python-box2d: FTBFS: swig doesn't like some comment styles any more

[Logan Rosen]

Package: python-box2d
Version: 2.0.2+svn20100109.244-1.1
Followup-For: Bug #805684
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu xenial ubuntu-patch

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/fix_comments.patch: Fix comment formatting so that the
package doesn't FTBFS with SWIG 3 (patch courtesy of Jitka Plesnikova).

Thanks for considering the patch.


-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-19-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru python-box2d-2.0.2+svn20100109.244/debian/patches/fix_comments.patch python-box2d-2.0.2+svn20100109.244/debian/patches/fix_comments.patch
--- python-box2d-2.0.2+svn20100109.244/debian/patches/fix_comments.patch	1969-12-31 19:00:00.0 -0500
+++ python-box2d-2.0.2+svn20100109.244/debian/patches/fix_comments.patch	2015-12-09 00:50:31.0 -0500
@@ -0,0 +1,27 @@
+Description: fix malformed comments
+ The comments with # style cause an FTBFS with SWIG 3. This patch from Red Hat
+ changes them to the proper format.
+Author: Jitka Plesnikova <jples...@redhat.com>
+Origin: vendor, https://bugzilla.redhat.com/attachment.cgi?id=995672
+Bug-RedHat: https://bugzilla.redhat.com/show_bug.cgi?id=1196718
+Forwarded: not-needed
+Last-Update: 2015-12-09
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/Box2D/Box2D_pickling.i
 b/Box2D/Box2D_pickling.i
+@@ -538,9 +538,11 @@
+ 
+ %}
+ 
+-# These were originally set programmatically, which is perhaps cleaner,
+-# but this will set every class up properly without any unnecessary code
+-# execution
++/*
++ * These were originally set programmatically, which is perhaps cleaner,
++ * but this will set every class up properly without any unnecessary code
++ * execution
++ */
+ 
+ %extend b2World {
+  %pythoncode %{
diff -Nru python-box2d-2.0.2+svn20100109.244/debian/patches/series python-box2d-2.0.2+svn20100109.244/debian/patches/series
--- python-box2d-2.0.2+svn20100109.244/debian/patches/series	2010-07-19 12:25:43.0 -0400
+++ python-box2d-2.0.2+svn20100109.244/debian/patches/series	2015-12-09 00:44:33.0 -0500
@@ -1 +1,2 @@
 debian-changes-2.0.2+svn244-1
+fix_comments.patch

Bug#805684: python-box2d: FTBFS: swig doesn't like some comment styles any more

[Chris West (Faux)]

Source: python-box2d
Version: 2.0.2+svn20100109.244-1.1
Severity: serious
Justification: fails to build from source
Tags: sid stretch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-CC: reproducible-bui...@lists.alioth.debian.org

Dear Maintainer,

The package fails to build:

swig -python -c++ -IBox2D -O -includeall -ignoremissing -w201 -outdir . -o 
Box2D/Box2D_wrap.cpp Box2D/Box2D.i
Box2D/Box2D_pickling.i:541: Error: Unknown SWIG preprocessor directive: These 
(if this is a block of target language code, delimit it with %{ and %})
Box2D/Box2D_pickling.i:542: Error: Unknown SWIG preprocessor directive: but (if 
this is a block of target language code, delimit it with %{ and %})
Box2D/Box2D_pickling.i:543: Error: Unknown SWIG preprocessor directive: 
execution (if this is a block of target language code, delimit it with %{ and 
%})
error: command 'swig' failed with exit status 1

Full build log:
https://reproducible.debian.net/rb-pkg/unstable/amd64/python-box2d.html

-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)