Bug#806445: Yo

[intrigeri]

Control: tag -1 + moreinfo

Hi!

Kjö Hansi Glaz:
> The same bug happens when I:

> - check the checkbox "I trust signatures from 'USER' on others key"
> - change the value of the field "You Trust The Owner:"
> - "Sign This Key" (whatever option I choose)

> The upstream patch
> https://git.gnome.org/browse/seahorse/patch/?id=cdfc5b297d7420e47b9c973e8b8cb1b0fb576421
> applies on 3.20.0.

> The attached debdiff fixes the issue for me.

Thanks! I'll look into it and will propose a NMU as this badly affects
Tails upcoming 3.0 (Stretch-based) release.

Now, I'm a little bit confused: the upstream bug + patch are about
something triggered by gpgme 1.7+, but this Debian bug was initially
reported against the version of Seahorse that's in Jessie, and Jessie
has gpgme 1.5.1. So I'm wondering 1. if they really are the same
problem; and 2. whether it's a regression in Stretch (if it is, then
it clearly needs to be fixed IMO, and then a freeze exception will be
more obviously needed).

So, Kjö, Beren and Sebastian: can one of you please confirm whether
you've experienced one of the problems this bug report is about on
Debian Jessie? If yes, what version of libgpgme11 do you
have installed?

Cheers,
-- 
intrigeri

Bug#806445: Yo

[Kjö Hansi Glaz]

The same bug happens when I:

- check the checkbox "I trust signatures from 'USER' on others key"
- change the value of the field "You Trust The Owner:"
- "Sign This Key" (whatever option I choose)

The upstream patch
https://git.gnome.org/browse/seahorse/patch/?id=cdfc5b297d7420e47b9c973e8b8cb1b0fb576421
applies on 3.20.0.

The attached debdiff fixes the issue for me.

diff -Nru seahorse-3.20.0/debian/changelog seahorse-3.20.0/debian/changelog
--- seahorse-3.20.0/debian/changelog2016-12-05 18:51:47.0 +0100
+++ seahorse-3.20.0/debian/changelog2017-04-01 16:06:42.0 +0200
@@ -1,3 +1,12 @@
+seahorse (3.20.0-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * 01_ignore_KEY_CONSIDERED.patch: patch from upstream git. Ignore
+KEY_CONSIDERED line introduced in gpg 2.1.13 (Closes: #806445).
+  * Bump libgpgme-dev build-dependency to >= 1.7.0
+
+ -- Kjö Hansi Glaz   Sat, 01 Apr 2017 16:06:42 +0200
+
 seahorse (3.20.0-3) unstable; urgency=medium
 
   * Switch libgpgme11-dev build-dependency to libgpgme-dev.
diff -Nru seahorse-3.20.0/debian/control seahorse-3.20.0/debian/control
--- seahorse-3.20.0/debian/control  2016-12-05 18:50:49.0 +0100
+++ seahorse-3.20.0/debian/control  2017-04-01 16:06:42.0 +0200
@@ -16,7 +16,7 @@
libgck-1-dev (>= 3.11.91),
libgcr-3-dev (>= 3.11.91),
libglib2.0-dev (>= 2.10.0),
-   libgpgme-dev (>= 1.0.0),
+   libgpgme-dev (>= 1.7.0),
libgtk-3-dev (>= 3.16),
libldap2-dev,
libsecret-1-dev (>= 0.16),
diff -Nru seahorse-3.20.0/debian/control.in seahorse-3.20.0/debian/control.in
--- seahorse-3.20.0/debian/control.in   2016-12-05 18:50:49.0 +0100
+++ seahorse-3.20.0/debian/control.in   2017-04-01 16:06:42.0 +0200
@@ -12,7 +12,7 @@
libgck-1-dev (>= 3.11.91),
libgcr-3-dev (>= 3.11.91),
libglib2.0-dev (>= 2.10.0),
-   libgpgme-dev (>= 1.0.0),
+   libgpgme-dev (>= 1.7.0),
libgtk-3-dev (>= 3.16),
libldap2-dev,
libsecret-1-dev (>= 0.16),
diff -Nru seahorse-3.20.0/debian/patches/01_ignore_KEY_CONSIDERED.patch 
seahorse-3.20.0/debian/patches/01_ignore_KEY_CONSIDERED.patch
--- seahorse-3.20.0/debian/patches/01_ignore_KEY_CONSIDERED.patch   
1970-01-01 01:00:00.0 +0100
+++ seahorse-3.20.0/debian/patches/01_ignore_KEY_CONSIDERED.patch   
2017-04-01 16:06:42.0 +0200
@@ -0,0 +1,56 @@
+From cdfc5b297d7420e47b9c973e8b8cb1b0fb576421 Mon Sep 17 00:00:00 2001
+From: Tobias Mueller 
+Date: Tue, 14 Feb 2017 22:05:19 +0100
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=778607
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=806445
+Origin: 
https://git.gnome.org/browse/seahorse/commit/?id=cdfc5b297d7420e47b9c973e8b8cb1b0fb576421
+Subject: gpg: Ignore KEY_CONSIDERED line introduced in gpg 2.1.13
+
+gpg 2.1.13 introduced a new status line, KEY_CONSIDERED:
+https://lists.gnupg.org/pipermail/gnupg-announce/2016q2/000390.html
+gpgme 1.7.0 supported it:
+https://lists.gnupg.org/pipermail/gnupg-commits/2016-May/012130.html
+
+The line seems innocent in the sense that it tells you what keys GnuPG
+looked at without doing anything.  We can probably safely ignore that
+line, as we ignore many other lines already.
+
+https://bugzilla.gnome.org/show_bug.cgi?id=778607
+
+Signed-off-by: Stef Walter 
+ * Fixed this so it compiles
+---
+ configure.ac| 2 +-
+ pgp/seahorse-gpgme-key-op.c | 3 ++-
+ 2 files changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 0f748e3..fc4493c 100644
+--- a/configure.ac
 b/configure.ac
+@@ -10,7 +10,7 @@ GTK_REQ=3.4.0
+ GTK_MAX=GTK_VERSION_3_4
+ 
+ GNUPG_ACCEPTED="2.0.12 2.1.4"
+-GPGME_REQUIRED=1.0.0
++GPGME_REQUIRED=1.7.0
+ LIBSECRET_REQUIRED=0.16
+ AVAHI_GLIB_REQUIRED=0.6
+ 
+diff --git a/pgp/seahorse-gpgme-key-op.c b/pgp/seahorse-gpgme-key-op.c
+index a765033..3f81850 100644
+--- a/pgp/seahorse-gpgme-key-op.c
 b/pgp/seahorse-gpgme-key-op.c
+@@ -330,7 +330,8 @@ seahorse_gpgme_key_op_edit (gpointer data, 
gpgme_status_code_t status,
+   status == GPGME_STATUS_BAD_PASSPHRASE || status == 
GPGME_STATUS_USERID_HINT ||
+   status == GPGME_STATUS_SIGEXPIRED || status == 
GPGME_STATUS_KEYEXPIRED ||
+   status == GPGME_STATUS_PROGRESS || status == 
GPGME_STATUS_KEY_CREATED ||
+-  status == GPGME_STATUS_ALREADY_SIGNED || status == 
GPGME_STATUS_MISSING_PASSPHRASE) 
++  status == GPGME_STATUS_ALREADY_SIGNED || status == 
GPGME_STATUS_MISSING_PASSPHRASE ||
++  status == GPGME_STATUS_KEY_CONSIDERED)
+   return parms->err;
+ 
+   g_debug ("[edit key] state: %d / status: %d / args: %s",
+-- 
+cgit v0.12
+
diff -Nru seahorse-3.20.0/debian/patches/series