Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Raphael Hertzog]

Hi,

On Tue, 30 Aug 2016, Sam Hartman wrote:
> I think 3.x is likely to be new packaging and entirely breaks
> compatibility with the 2.x config.

Many packages have big changes from one major version to the next...

> If we orphan 2.x someone might fix the RC bug and get it back into
> testing.
> At this point I think releasing stretch with 2.x would be worse than
> releasing stretch without freeradius.

Then open an RC bug saying that we need to upgrade to 3.x before
letting the package enter back into stretch.

I don't think it warrants an early removal from Debian just because
you don't want 2.x in stretch.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/

Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Sam Hartman]

> "Raphael" == Raphael Hertzog  writes:

Raphael> It would seem natural to orphan it and to let the new
Raphael> maintainer deal with updating it to version 3.x.

I think 3.x is likely to be new packaging and entirely breaks
compatibility with the 2.x config.

If we orphan 2.x someone might fix the RC bug and get it back into
testing.
At this point I think releasing stretch with 2.x would be worse than
releasing stretch without freeradius.

Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Raphael Hertzog]

Hi,

On Tue, 30 Aug 2016, Sam Hartman wrote:
> In my previous job I was willing to put in the effort to maintain
> freeradius 3.x if some other developer  was willing to put together
> debian/copyright and do the DFSG audit.
> That never happened, although someone did 90% of the work and went
> silent.

Do you have any pointer of that work?

> I think requesting removal of freeradius 2.x would be preferable to
> orphaning it.

Why?

It would seem natural to orphan it and to let the new maintainer deal with
updating it to version 3.x.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/

Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Sam Hartman]

> "Josip" == Josip Rodin  writes:

Josip> On Tue, Aug 30, 2016 at 11:20:50AM +0200, Raphael Hertzog wrote:
>> Josip, do you really still care about this package?

Josip> I'm pretty sure I told Sam to take it over a few years
Josip> back...?

O, if that's what you were trying to say, that is very different from
 what I heard.

Regardless, I have move on from the job that had a lot of dependence on
FreeRadius, and can't give it attention either.

--Sam

Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Josip Rodin]

On Tue, Aug 30, 2016 at 11:20:50AM +0200, Raphael Hertzog wrote:
> Josip, do you really still care about this package?

I'm pretty sure I told Sam to take it over a few years back...?

If you want to fix that, by all means, just work on it.

-- 
 2. That which causes joy or happiness.

Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Sam Hartman]

> "Raphael" == Raphael Hertzog  writes:

Raphael> On Thu, 14 Jul 2016 22:09:52 + Santiago Vila 
 wrote:
>> I have the ok from the Release Managers to consider this issue as
>> RC for stretch. I'm going to wait at least one week before
>> raising this to "serious".

Raphael> So nobody fixed this issue and freeradius is now gone from
Raphael> testing :-(


In my opinion freeradius 2.x is better gone from Debian.

In my previous job I was willing to put in the effort to maintain
freeradius 3.x if some other developer  was willing to put together
debian/copyright and do the DFSG audit.
That never happened, although someone did 90% of the work and went
silent.

Unfortunately, my new job doesn't involve FreeRADIUS at all.

I think requesting removal of freeradius 2.x would be preferable to
orphaning it.

Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Raphael Hertzog]

On Thu, 14 Jul 2016 22:09:52 + Santiago Vila  wrote:
> I have the ok from the Release Managers to consider this issue as RC
> for stretch. I'm going to wait at least one week before raising
> this to "serious".

So nobody fixed this issue and freeradius is now gone from testing :-(

I wanted to do a quick NMU (*) to fix this but the package would really
deserve a bit more love than a simple NMU. The package has been basically
maintained by NMU for the last 4 years.

Josip, do you really still care about this package? If yes, please bring
it to a somewhat better state (using "dh" and maintaining in a git
repository would be a good start IMO). Otherwise get the package properly
orphaned.

Sam Hartman is the person who did most of the last uploads. He added
himself to Uploaders so he might be interested to officially take over.

Mark Hymers and Stephen Gran are also in Uploaders but I have no recent
activity from them. Do you want to be dropped from Uploaders?

In any case, it would be good if someone could work on freeradius and bring it
back into testing...

(*) The quick NMU failed because I got another build failure that I don't
know how to fix:
*** Warning: Linking the shared library rlm_sqlcounter.la against the loadable 
module
*** rlm_sql.so is not portable!
libtool: relink: gcc -shared  -fPIC -DPIC  .libs/rlm_sqlcounter.o   -Wl,-rpath 
-Wl,/usr/lib/freeradius 
-L/<>/freeradius-2.2.8+dfsg/debian/tmp//usr/lib/freeradius 
-L/usr/lib/freeradius -lfreeradius-radius -lrlm_sql -lssl -lcrypto -lnsl 
-lresolv -lpthread  -Wl,-z -Wl,relro   -Wl,-soname -Wl,rlm_sqlcounter-2.2.8.so 
-o .libs/rlm_sqlcounter-2.2.8.so
/usr/bin/ld: cannot find -lrlm_sql
collect2: error: ld returned 1 exit status
libtool:   error: error: relink 'rlm_sqlcounter.la' with the above command 
before installing it
../rules.mak:169: recipe for target 'install' failed

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/

Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Santiago Vila]

Greetings.

I have the ok from the Release Managers to consider this issue as RC
for stretch. I'm going to wait at least one week before raising
this to "serious".

If you need help to fix this bug, please tag it as "help".

Thanks.

Bug#806617: freeradius: FTBFS when built with dpkg-buildpackage -A (dh_install: freeradius-common missing files)

[Santiago Vila]

Package: src:freeradius
Version: 2.2.8+dfsg-0.1
User: sanv...@debian.org
Usertags: binary-indep
Severity: important

Dear maintainer:

I tried to build this package with "dpkg-buildpackage -A"
(i.e. only architecture-independent packages), and it failed:


[...]
 debian/rules build-indep
dh_testdir
mv config.sub config.sub.dist
mv config.guess config.guess.dist
ln -s /usr/share/misc/config.sub config.sub
ln -s /usr/share/misc/config.guess config.guess
CFLAGS="`dpkg-buildflags --get CFLAGS` `dpkg-buildflags --get CPPFLAGS`" 
CPPFLAGS="" LDFLAGS="`dpkg-buildflags --get LDFLAGS`" ./configure --build 
x86_64-linux-gnu \
--prefix=/usr \
--exec-prefix=/usr \
--mandir=/usr/share/man \
--sysconfdir=/etc \
--libdir=/usr/lib/freeradius \

[... snipped ...]

install -d -m 0755 
/<>/freeradius-2.2.8+dfsg/debian/tmp///usr/share/freeradius-dialupadmin/bin
find doc Changelog README -name CVS -prune -o -type f -print0 | \
  xargs -0 install -m 0644 -t 
/<>/freeradius-2.2.8+dfsg/debian/tmp///usr/share/doc/freeradius-dialupadmin
find conf -name CVS -prune -o -type f -print0 | \
  xargs -0 install -m 0644 -t 
/<>/freeradius-2.2.8+dfsg/debian/tmp///etc/freeradius-dialupadmin
find htdocs html lib sql -name CVS -prune -o -print | \
  while read file; do \
if [ -d "$file" ]; then \
  install -d -m 0755 
"/<>/freeradius-2.2.8+dfsg/debian/tmp///usr/share/freeradius-dialupadmin/$file";
 \
else \
  install -m 0644 "$file" 
"/<>/freeradius-2.2.8+dfsg/debian/tmp///usr/share/freeradius-dialupadmin/$file";
 \
fi; \
  done
sed -e 's#/usr/local/dialup_admin#/usr/share/freeradius-dialupadmin#' \
-e 's#/usr/local/radiusd#/usr#' \
-e 's#general_raddb_dir: 
%{general_radiusd_base_dir}/etc/raddb#general_raddb_dir: /etc/freeradius#' \
-e 's#general_clients_conf: 
/usr/local/etc/raddb/clients.conf#general_clients_conf: 
/etc/freeradius/clients.conf#' \
-e 's#%{general_base_dir}/conf#/etc/freeradius-dialupadmin#' \
-e 's#/usr/local/bin#/usr/bin#' \
conf/admin.conf > 
/<>/freeradius-2.2.8+dfsg/debian/tmp///etc/freeradius-dialupadmin/admin.conf
sed -e 's#../../README#/usr/share/doc/freeradius-dialupadmin/README#' \
htdocs/help/help.php > 
/<>/freeradius-2.2.8+dfsg/debian/tmp///usr/share/freeradius-dialupadmin/htdocs/help/help.php
for binfile in backup_radacct clean_radacct clearsession log_badlogins 
monthly_tot_stats showmodem snmpfinger sqlrelay_query tot_stats 
truncate_radacct; do \
  sed -e 's#/usr/local/bin/#/usr/bin#' \
  -e 's#/usr/local/dialup_admin/conf/#/etc/freeradius-dialupadmin/#' \
  bin/$binfile > 
/<>/freeradius-2.2.8+dfsg/debian/tmp///usr/share/freeradius-dialupadmin/bin/$binfile
 ; \
  chmod 0755 
/<>/freeradius-2.2.8+dfsg/debian/tmp///usr/share/freeradius-dialupadmin/bin/$binfile;
 \
done
sed -e 's#/usr/local/dialup_admin#/usr/share/freeradius-dialupadmin#' \
bin/dialup_admin.cron > 
/<>/freeradius-2.2.8+dfsg/debian/tmp///usr/share/freeradius-dialupadmin/bin/dialup_admin.cron
make[1]: Leaving directory '/<>/freeradius-2.2.8+dfsg/dialup_admin'
mv 
/<>/freeradius-2.2.8+dfsg/debian/tmp//usr/share/freeradius-dialupadmin/bin/dialup_admin.cron
 \
   
/<>/freeradius-2.2.8+dfsg/debian/tmp//usr/share/freeradius-dialupadmin/bin/freeradius-dialupadmin.cron
mv 
/<>/freeradius-2.2.8+dfsg/debian/tmp//usr/share/doc/freeradius-dialupadmin/Changelog
 \
   
/<>/freeradius-2.2.8+dfsg/debian/tmp//usr/share/doc/freeradius-dialupadmin/changelog
install -m0644 debian/apache2.conf 
/<>/freeradius-2.2.8+dfsg/debian/tmp//etc/freeradius-dialupadmin/
dh_install -i --sourcedir=/<>/freeradius-2.2.8+dfsg/debian/tmp/
dh_install: freeradius-common missing files (usr/share/freeradius/*), aborting
debian/rules:128: recipe for target 'install-indep' failed
make: *** [install-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit 
status 2


Sorry not to have a fix, as I am reporting many bugs similar to
this one. The common hints are:

* If the only architecture-independent packages are dummy transitional
ones and they were released with jessie, the easy fix is to drop them
now.

* When using "dh", it is allowed to use (independently)
optional targets override_dh_foo-arch and override_dh_foo-indep
(for several values of "foo").


Once that both "dpkg-buildpackage -A" and "dpkg-buildpackage -B" work
properly, the package would be suitable to be uploaded in source-only
form if you wish.

Thanks.