Bug#809352: Unescaped left brace in regex is deprecated
Control: affects -1 src:pacpl
Control: affects -1 src:libaudio-file-perl
Control: tag -1 + fixed-upstream
On Sun, Jun 18, 2017 at 11:28:41PM +0300, Niko Tyni wrote:
> On Tue, Dec 29, 2015 at 07:52:51PM +0100, Harald Dunkel wrote:
> > Package: libmp3-tag-perl
> > Version: 1.13-1
> >
> > perl 5.22.1-3 woes about some code in /usr/share/perl5/MP3/Tag.pm:
> >
> > Unescaped left brace in regex is deprecated, passed through in regex;
> > marked by
> > <-- HERE in m/(\\%(?:\\=)?(\w|\\{ <-- HERE
> > (?:\w|\\[^\w\\{}]|\\[\\{}])*\\}|\\\W))/ at /usr/share/perl5/MP3/Tag.pm
> > line 2611 (#1)
>
> This is fatal in Perl 5.26 (currently in experimental), making the
> package fail to build from source. Raising the severity accordingly.
This also breaks the build of src:papl and src:libaudio-file-perl
with Perl 5.26. It's fixed upstream in 1.14.
Ian, are you still maintaining this package? Would you be OK with
moving this under the pkg-perl umbrella?
--
Niko Tyni nt...@debian.org
Bug#809352: Unescaped left brace in regex is deprecated
severity 809352 important
user debian-p...@lists.debian.org
usertag 809352 + perl-5.26-transition
thanks
On Tue, Dec 29, 2015 at 07:52:51PM +0100, Harald Dunkel wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Package: libmp3-tag-perl
> Version: 1.13-1
>
> perl 5.22.1-3 woes about some code in /usr/share/perl5/MP3/Tag.pm:
>
> Unescaped left brace in regex is deprecated, passed through in regex; marked
> by
> <-- HERE in m/(\\%(?:\\=)?(\w|\\{ <-- HERE
> (?:\w|\\[^\w\\{}]|\\[\\{}])*\\}|\\\W))/ at /usr/share/perl5/MP3/Tag.pm
> line 2611 (#1)
This is fatal in Perl 5.26 (currently in experimental), making the
package fail to build from source. Raising the severity accordingly.
A full build log is available at
http://perl.debian.net/rebuild-logs/perl-5.26-throwaway/libmp3-tag-perl_1.13-1/libmp3-tag-perl_1.13-1_amd64-2017-05-21T16:40:46Z.build
and the server also hosts a repository of packages binNMU'd for Perl
5.26 that can be used for testing purposes; see
Bug#809352: Unescaped left brace in regex is deprecated
Attached is a patch.
Regards
Harri
Index: libmp3-tag-perl-1.13/lib/MP3/Tag.pm
===
--- libmp3-tag-perl-1.13.orig/lib/MP3/Tag.pm
+++ libmp3-tag-perl-1.13/lib/MP3/Tag.pm
@@ -2607,7 +2607,7 @@ sub parse_prepare {
my ($self, $pattern) = @_;
$pattern = "^\Q$pattern\E\$";
# unquote %. and %=. and %={WHATEVER} and %{WHATEVER}
-$pattern =~ s<(\\%(?:\\=)?(\w|\\{(?:\w|\\[^\w\\{}]|\\[\\{}])*\\}|\\\W))>
+$pattern =~ s<(\\%(?:\\=)?(\w|\\\{(?:\w|\\[^\w\\{}]|\\[\\{}])*\\}|\\\W))>
( __unquote($1) )ge;
# $pattern =~ s/(\\%(?:\\=)?)(\w|\\(\W))/$unquote{$1}$+/g;
return $self->parse_rex_prepare($pattern);
signature.asc
Description: OpenPGP digital signature
Bug#809352: Unescaped left brace in regex is deprecated
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Package: libmp3-tag-perl
Version: 1.13-1
perl 5.22.1-3 woes about some code in /usr/share/perl5/MP3/Tag.pm:
Unescaped left brace in regex is deprecated, passed through in regex; marked by
<-- HERE in m/(\\%(?:\\=)?(\w|\\{ <-- HERE
(?:\w|\\[^\w\\{}]|\\[\\{}])*\\}|\\\W))/ at /usr/share/perl5/MP3/Tag.pm line
2611 (#1)
(D deprecated, regexp) You used a literal "{" character in a regular
expression pattern. You should change to use "\{" instead, because a
future version of Perl (tentatively v5.26) will consider this to be a
syntax error. If the pattern delimiters are also braces, any matching
right brace ("}") should also be escaped to avoid confusing the parser,
for example,
qr{abc\{def\}ghi}
Regards
Harri
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
iQEcBAEBCAAGBQJWgtZ8AAoJEAqeKp5m04HL+6MIAIB0rRj9rYhXU5Neasb31nB5
aR+i8P7TfRdD1K1Kz5XgDJ/XXrJpP30+VaTrBJLh4sW915+9EXHTnDTydHq1Ufvz
m50b+ARInlJNXQVjw8mGx/6/B/Iie8VGTxr3tzPc+AaphEm5ZICDtGfs975GGKB0
B/7xCx4xnTHHH84CjOcSk99UEdM4SN6RAOra/s3PJD3Td5Sy932xwRyVfvra268K
yiGAW4FbhJXARd+x20q2snOuZ7+lDNINTBv2e42Sin7U12/e0JRJ1MruPQi6uZ1f
TK4cn7ziFCA43q+GA2edc+S87gFJrf6pWEs3T2k4/iuacx2ID80CyWbc+2I9vns=
=T+gL
-END PGP SIGNATURE-
