Bug#810652: phing fails to start: default.properties needs patch

[Scott Howard]

On Sun, Jan 10, 2016 at 10:01 PM, David Prévot  wrote:
> Control: retitle -1 phing fails to start: Missing JsMinTask.php
> Control: found -1 2.9.1-1
>

Thank you for figuring it out the root cause! I don't think there is a
rush; people can easily find this report and fix it themselves if they
are using the sid version. Part of the fun of unstable
Cheers,
Scott

Bug#810652: phing fails to start: default.properties needs patch

[David Prévot]

Control: retitle -1 phing fails to start: Missing JsMinTask.php
Control: found -1 2.9.1-1

Hi Scott,

Thanks for your report and your analyses.

On Sun, Jan 10, 2016 at 06:26:03PM -0500, Scott Howard wrote:

> When phing is run, it will fail:
> $ phing
> Buildfile: /home/showard/bootstrap/sitecake/build.xml
> [PHP Error] include_once(phing/tasks/ext/jsmin/JsMinTask.php): failed to open
> stream: No such file or directory [line 1272 of 
> /usr/share/php/phing/Phing.php]
[…]
> Why:
> JsMinTask.php is non-free, and removed during the config step in debian/rules.

Actually, JsMin.php was the non-free bit, and has been removed upstream
in 2.9.1. Now JsMinTask.php uses JShrink if available.

> However /usr/share/php/data/phing/tasks/default.properties still refers to it
> 
> Fix:
> Comment/delete the following line from
> /usr/share/php/data/phing/tasks/default.properties
> 
> jsmin=phing.tasks.ext.jsmin.JsMinTask

In fact, default.properties used to be patched to drop any reference to
JsMin. The error was actually to still remove JsMinTask.php in
debian/rules. I’ve just fixed it in Git, and checked (with sitecake)
that it now runs properly. The version in Jessie (2.8.2+dfsg-1) is not
affected.

Do you need the fix in the archive now (I can upload it quickly if you
wish), or can it wait for the next upstream release or PHP transition,
whatever comes first?

Regards

David


signature.asc
Description: PGP signature

Bug#810652: phing fails to start: default.properties needs patch

[Scott Howard]

Package: phing
Version: 2.13.0-1
Severity: important

Dear Maintainer,

When phing is run, it will fail:
$ phing
Buildfile: /home/showard/bootstrap/sitecake/build.xml
[PHP Error] include_once(phing/tasks/ext/jsmin/JsMinTask.php): failed to open
stream: No such file or directory [line 1272 of /usr/share/php/phing/Phing.php]
[PHP Error] include_once(): Failed opening
'phing/tasks/ext/jsmin/JsMinTask.php' for inclusion
(include_path='/usr/share/php/../classes:.:/usr/share/php:/usr/share/pear')
[line 1272 of /usr/share/php/phing/Phing.php]

BUILD FAILED
exception 'ConfigurationException' with message 'Error importing
phing/tasks/ext/jsmin/JsMinTask.php' in /usr/share/php/phing/Phing.php:1280
Stack trace:
#0 /usr/share/php/phing/Phing.php(1227): Phing::__import('phing/tasks/ext...',
NULL)
#1 /usr/share/php/phing/Project.php(630): Phing::import('phing.tasks.ext...',
NULL)
#2 /usr/share/php/phing/Project.php(163): Project->addTaskDefinition('jsmin',
'phing.tasks.ext...')
#3 /usr/share/php/phing/Phing.php(628): Project->init()
#4 /usr/share/php/phing/Phing.php(191): Phing->runBuild()
#5 /usr/share/php/phing/Phing.php(316): Phing::start(Array, NULL)
#6 /usr/share/php/phing.php(58): Phing::fire(Array)
#7 {main}

Total time: 0.0417 seconds

Error importing phing/tasks/ext/jsmin/JsMinTask.php



Why:
JsMinTask.php is non-free, and removed during the config step in debian/rules.
However /usr/share/php/data/phing/tasks/default.properties still refers to it

Fix:
Comment/delete the following line from
/usr/share/php/data/phing/tasks/default.properties

jsmin=phing.tasks.ext.jsmin.JsMinTask

Reference:
https://bugzilla.redhat.com/show_bug.cgi?id=894748#c14

Cheers,
Scott



-- System Information:
Debian Release: jessie/sid
  APT prefers wily-updates
  APT policy: (500, 'wily-updates'), (500, 'wily-security'), (500, 'wily'), 
(100, 'wily-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-23-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages phing depends on:
ii  php5-cli 5.6.11+dfsg-1ubuntu3.1
ii  php5-common  5.6.11+dfsg-1ubuntu3.1

Versions of packages phing recommends:
ii  pdepend2.1.0-2
ii  php-codesniffer2.3.3-1
ii  php-http-request2  2.2.1-2
ii  php-pear   5.6.11+dfsg-1ubuntu3.1
ii  php5-xdebug2.3.3-1ubuntu1
ii  phpmd  2.2.3-1

phing suggests no packages.

-- no debconf information