Bug#811089: [pkg-bacula-devel] Bug#811089: bconsole: typo forbids non-interactive restore

[Rhonda D'Vine]

Hi,

* Carsten Leonhardt  [2016-01-27 14:17:47 CET]:
> Hi Rhonda,
> > there is a typo in src/dird/ua_restore.c which hinders starting a
> > non-interactive restore.
> 
> could you give me an example invocation for such a restore?

*restore where=/bacula/restore/hostname client=hostname 
restore_job=hostname-restore restoreclient=backup-mgmt-fd select current all 
done yes

 Thing is, the restore_job option will be claimed to be a wrong option
if written this way without the patch, and if you use restorejob instead
it won't be parsed but you'll instead be asked to select one
interactively.  So with the patch it's possible to fully do it
non-interactive because both the parsing of the option and the checking
for the options do use the same syntax.

> Which version did you patch - the old 5.2.6 or the 7.0.5 from testing?

 I patched 5.2.6 here but like written originally the bug is still
unfixed with the 7.0.5 version.  Given that it's a one-character fix it
should be possible to convince the stable release team to get it fixed
for stable too.

 I'm a bit puzzled by the upstream bug comment that it should be fixed
already since 2012, but I still see it called restorejob in there in the
7.0.5 version.  It might be that they fixed it in the other direction,
of making restorejob work instead; but I'm uncertain, didn't check it
with a setup of that version.

 Hope that helps,
Rhonda
-- 
strg.at gmbh
rho...@strg.at
gumpendorfer strasse 132/9, 1060 wien
tel +43 (1) 526 56 29


signature.asc
Description: Digital signature

Bug#811089: [pkg-bacula-devel] Bug#811089: bconsole: typo forbids non-interactive restore

[Carsten Leonhardt]

Hi Rhonda,

> there is a typo in src/dird/ua_restore.c which hinders starting a
> non-interactive restore.

could you give me an example invocation for such a restore?

Which version did you patch - the old 5.2.6 or the 7.0.5 from testing?

leo

Bug#811089: bconsole: typo forbids non-interactive restore

[Rhonda D'Vine]

Package: bacula-console
Version: 5.2.6+dfsg-9.3
Severity: normal

Dear Maintainer,

 there is a typo in src/dird/ua_restore.c which hinders starting a
non-interactive restore.  This bug has been reported upstream at 
http://bugs.bacula.org/view.php?id=1899 and is a one character fix:

#v+
Index: bacula-5.2.6+dfsg/src/dird/ua_restore.c
===
--- bacula-5.2.6+dfsg.orig/src/dird/ua_restore.c2016-01-15 
14:54:10.676996102 +0100
+++ bacula-5.2.6+dfsg/src/dird/ua_restore.c 2016-01-15 14:54:45.129322694 
+0100
@@ -472,7 +472,7 @@
   "restoreclient", /* 19 */
   "copies",/* 20 */
   "comment",   /* 21 */
-  "restorejob",/* 22 */
+  "restore_job",   /* 22 */
   "replace",   /* 23 */
   NULL
};
#v-

 Please get this patch applied, it's really annoying to not being able
to give that option on the command line.  I've created myself a local
build with that patch and it works like a charm.  It would be extremely
nice to have this fixed in a stable update.  According to
https://sources.debian.net/src/bacula/7.0.5%2Bdfsg-4/src/dird/ua_restore.c/#L481
this still affects the version in unstable, too.

 Thanks,
Rhonda
-- 
strg.at gmbh
rho...@strg.at
gumpendorfer strasse 132/9, 1060 wien
tel +43 (1) 526 56 29


signature.asc
Description: Digital signature