Bug#811648: FTBFS with GCC 6: cannot convert x to y

[Sean Whitton]

Dear Gert,

On Mon, Jun 27, 2016 at 11:07:05AM +0200, Gert Wollny wrote:
> attached is a patch that fixes the according build failure. 

Thank you for your contribution :)

> Regarding maintainership, I'll have to test the program first to see
> whether it is of any interest to me to maintain it (Upstream seems to
> be dead).

In the meantime, you are encouraged to make a "QA upload" to fix the
problem.  See: .

-- 
Sean Whitton

Bug#811648: FTBFS with GCC 6: cannot convert x to y

[Gert Wollny]

Control: tags -1 patch 

Hi, 

attached is a patch that fixes the according build failure. 

Regarding maintainership, I'll have to test the program first to see
whether it is of any interest to me to maintain it (Upstream seems to
be dead).

Best, 
Gert 
Author: Gert Wollny 
Date: 2016-06-27
Description: Correct compilation with g++-6
Bug: https://bugs.debian.org/811648

--- a/Fileio.cpp
+++ b/Fileio.cpp
@@ -854,7 +854,7 @@
 
 	if(Notary || !g) {
 		ErrorBox("Output pending or\nno graph.");
-		return false;
+		return NULL;
 		}
 	cObsW = 0;iFile = -1;
 	cbOut = sizeOut = 0;	ptr = 0L;

Bug#811648: FTBFS with GCC 6: cannot convert x to y

[Martin Michlmayr]

Package: rlplot
Version: 1.5-2
Severity: important
User: debian-...@lists.debian.org
Usertags: ftbfs-gcc-6 gcc-6-cannot-convert

This package fails to build with GCC 6.  GCC 6 has not been released
yet, but it's expected that GCC 6 will become the default compiler for
stretch.

Note that only the first error is reported; there might be more.  You
can find a snapshot of GCC 6 in experimental.  To build with GCC 6,
you can set CC=gcc-6 CXX=g++-6 explicitly.

> sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
...
> g++ -I/usr/include/qt4/Qt -I/usr/include/qt4 -pipe -O2 -o rlplot.o -c 
> rlplot.cpp
> In file included from rlplot.cpp:19:0:
> rlplot.h:398:2: warning: 'typedef' was ignored in this declaration
>   typedef struct edge {
>   ^~~
> 
> rlplot.cpp: In member function 'bool Label::CalcRect(anyOutput*)':
> rlplot.cpp:5829:42: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>if(!(o->oGetTextExtent("A", 1, , ))) return false;
>   ^
> 
> rlplot.cpp: In member function 'void TextFrame::AddChar(anyOutput*, int)':
> rlplot.cpp:6850:28: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>if(c == 8) ReplMark(o, "");
> ^
> 
> rlplot.cpp: In member function 'void TextFrame::DelChar(anyOutput*)':
> rlplot.cpp:6911:17: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>ReplMark(o, ""); return;
>  ^
> 
> rlplot.cpp: In member function 'bool TextFrame::CopyText(anyOutput*, bool)':
> rlplot.cpp:7163:26: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>   if(b_cut) ReplMark(o, "");
>   ^
> 
> rlplot.cpp: In destructor 'virtual Graph::~Graph()':
> rlplot.cpp:8950:39: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>   Undo.InvalidGO(this);  DoZoom("reset");
>^
> 
> rlplot.cpp: In member function 'virtual bool Graph::Command(int, void*, 
> anyOutput*)':
> rlplot.cpp:9151:43: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>  "a graph before you can add a legend.");
>^
> 
> rlplot.cpp:9280:42: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>  "a graph before you can add an axis.");
>   ^
> 
> rlplot.cpp:9363:57: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>  InfoBox("Axes used for scaling\ncan not be deleted.");
>  ^
> 
> rlplot.cpp:9413:41: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>  "a graph before you can add a plot.");
>  ^
> 
> g++ -I/usr/include/qt4/Qt -I/usr/include/qt4 -pipe -O2 -o Fileio.o -c 
> Fileio.cpp
> Fileio.cpp:96:39: warning: invalid suffix on literal; C++11 requires a space 
> between literal and string macro [-Wliteral-suffix]
>add_to_buff(, , , "\" created by RLPlot version 
> "SZ_VERSION" for ", 0);
>^
> 
> In file included from Fileio.cpp:20:0:
> rlplot.h:398:2: warning: 'typedef' was ignored in this declaration
>   typedef struct edge {
>   ^~~
> 
> Fileio.cpp: In function 'int OpenOutputFile(char*)':
> Fileio.cpp:88:42: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
> ErrorBox("Open failed for output file");
>   ^
> 
> Fileio.cpp:94:51: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>cbOut = rlp_strcpy(ptr, 20, ";RLP 1.0\n;File \"");
>^
> 
> Fileio.cpp:96:90: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>add_to_buff(, , , "\" created by RLPlot version 
> "SZ_VERSION" for ", 0);
>   
> ^
> 
> Fileio.cpp:100:46: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>add_to_buff(, , , "Qt", 2);
>   ^
> 
> Fileio.cpp:102:59: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>add_to_buff(, , , "\n;Date/Time: ", 13);
>^
> 
> Fileio.cpp: In function 'void WriteTypObjLst(GraphObj**, int)':
> Fileio.cpp:144:44: warning: ISO C++ forbids converting a string constant to 
> 'char*' [-Wwrite-strings]
>   add_to_buff(, , , "(", 1);
> ^
> 
> Fileio.cpp:146:45: warning: ISO C++ forbids converting a string constant to 
> 'char*'