Bug#812489: wireshark: improve .desktop files

[Bálint Réczey]

Control: tags -1 confirmed pending upstream
Control: forwarded -1 https://code.wireshark.org/review/#/c/14241/1

Hi Pino,

2016-01-24 12:48 GMT+01:00 Pino Toscano :
> Source: wireshark
> Version: 2.0.1+g59ea380-3
> Severity: wishlist
> Tags: patch
>
> Hi,
>
> the current 08_wireshark-desktop-menu.patch patch changes the upstream
> .desktop files:
> - adding 'Encoding' keys
> - trimming the 'Categories' keys
> both of them are not great changes, and they can be improved; attached
> there is a new version of that patch, which does the following:
> - does not add 'Encoding' keys anymore, since .desktop files must be
>   UTF-8 (this key is deprecated)
> - there is nothing wrong in the Monitor, Qt, and GTK categories (they
>   reflect what wireshark is and does), so they are added back
>
> Now the only change done is switching the System category to Network,
> and IMHO this change could be proposed upstream (unlike what the patch
> claims).
The patch will be applied to next upload and I have also forwarded it now.

Thanks,
Balint

Bug#812489: wireshark: improve .desktop files

[Pino Toscano]

Source: wireshark
Version: 2.0.1+g59ea380-3
Severity: wishlist
Tags: patch

Hi,

the current 08_wireshark-desktop-menu.patch patch changes the upstream
.desktop files:
- adding 'Encoding' keys
- trimming the 'Categories' keys
both of them are not great changes, and they can be improved; attached
there is a new version of that patch, which does the following:
- does not add 'Encoding' keys anymore, since .desktop files must be
  UTF-8 (this key is deprecated)
- there is nothing wrong in the Monitor, Qt, and GTK categories (they
  reflect what wireshark is and does), so they are added back

Now the only change done is switching the System category to Network,
and IMHO this change could be proposed upstream (unlike what the patch
claims).

Thanks,
-- 
Pino
Description: Change "System" category to "Network" in desktop files
Forwarded: not-needed
Author: 
Author: Pino Toscano 

--- a/wireshark.desktop
+++ b/wireshark.desktop
@@ -108,4 +108,4 @@ Terminal=false
 MimeType=application/vnd.tcpdump.pcap;application/x-pcapng;application/x-snoop;application/x-iptrace;application/x-lanalyzer;application/x-nettl;application/x-radcom;application/x-etherpeek;application/x-visualnetworks;application/x-netinstobserver;application/x-5view;application/x-tektronix-rf5;
 # Category entry according to:
 # http://standards.freedesktop.org/menu-spec/1.0/
-Categories=System;Monitor;Qt;
+Categories=Network;Monitor;Qt;
--- a/wireshark-gtk.desktop
+++ b/wireshark-gtk.desktop
@@ -108,4 +108,4 @@ Terminal=false
 MimeType=application/vnd.tcpdump.pcap;application/x-pcapng;application/x-snoop;application/x-iptrace;application/x-lanalyzer;application/x-nettl;application/x-radcom;application/x-etherpeek;application/x-visualnetworks;application/x-netinstobserver;application/x-5view;application/x-tektronix-rf5;
 # Category entry according to:
 # http://standards.freedesktop.org/menu-spec/1.0/
-Categories=System;Monitor;GTK;
+Categories=Network;Monitor;GTK;