Control: tags -1 + moreinfo
Hello Jörg-Volker Peetz,
On Tue, Jan 26, 2016 at 01:06:13PM +0100, Jörg-Volker Peetz wrote:
> Package: util-linux
> Version: 2.27.1-2
> Severity: wishlist
>
> Dear Maintainer(s),
>
> just a little nitpick regarding the fix of #791511 and the use of sed:
>
> this line
>
> if sed '3!d' /etc/adjtime | grep -q '^UTC$'; then
>
> can be done without calling grep like
>
> if [ `sed -n '3!d; /^UTC$/p' /etc/adjtime` ]; then
What's the point of avoiding grep?
The grep package is Essential: yes.
If I'm not mistaken using a subshell will not lead to less processes
executed, so I'm not even sure about this being a microoptimization
(specially not if [ isn't a shell builtin, which it should normally
be though).
Also this scripts isn't even executed under the default init system.
Could you please tell me about the reason you think avoiding
grep is useful? As it currently stand I'm considering closing
this bug report without any action.
Regards,
Andreas Henriksson
