Bug#815490: gbsplay: FTBFS on non-linux architectures: error: 'ESTRPIPE' undeclared

[Vegard Nossum]

On 21 February 2016 at 22:35, Andreas Beckmann  wrote:
> Source: gbsplay
> Version: 0.0.93-1
> Severity: important
>
[...]
> gbsplay FTBFS on hurd-i386, kfreebsd-i386, kfreebsd-amd64 (but older
> versions  built successfully in the past on all these platforms):
[...]
> plugout_alsa.c: In function 'alsa_write':
> plugout_alsa.c:103:18: error: 'ESTRPIPE' undeclared (first use in this 
> function)
>if (retval != -ESTRPIPE)
>   ^
[...]

> If this probelm is not trivially fixable, please request decrufting
> of the outdated binary packages.

Hey,

In the gbsplay git repository there is this:

commit af783619b45d0def5824976b0af151bf2a3edc4e
Author: Tobias Diedrich 
Date:   Tue Sep 1 23:59:31 2015 +0200

   Freebsd doesn't have ESTRPIPE.

   See 
https://buildd.debian.org/status/fetch.php?pkg=gbsplay&arch=kfreebsd-amd64&ver=0.0.93-1&stamp=1441131835&file=log

diff --git plugout_alsa.c plugout_alsa.c
index a026a74..89dc8d7 100644
--- plugout_alsa.c
+++ plugout_alsa.c
@@ -94,13 +94,22 @@ static long regparm alsa_open(enum plugout_endian
endian, long rate)
   return 0;
}

+static long is_suspended(snd_pcm_sframes_t retval)
+{
+#ifdef HAVE_ESTRPIPE
+   return retval == -ESTRPIPE;
+#else
+   return snd_pcm_state(pcm_handle) == SND_PCM_STATE_SUSPENDED;
+#endif
+}

[...]

So it seems like it should have been fixed already? Do you need to get
the latest version from git or does gbsplay need to make a new release
or something for you to pick this up?


Vegard

Bug#815490: gbsplay: FTBFS on non-linux architectures: error: 'ESTRPIPE' undeclared

[Tobias Diedrich]

Hi,

I believe this was fixed in
https://github.com/mmitch/gbsplay/commit/af783619b45d0def5824976b0af151bf2a3edc4e
but we haven't gotten around to making a newer official release yet.

In the meantime you could try cherry-picking this commit (and maybe
a060526a51bf6b1d3e7d0472fc61971ba1ee7b00 as well to fix the
rand_long warning).

Cheers,

-- 
Tobias  PGP: http://8ef7ddba.uguu.de

Bug#815490: gbsplay: FTBFS on non-linux architectures: error: 'ESTRPIPE' undeclared

[Andreas Beckmann]

Source: gbsplay
Version: 0.0.93-1
Severity: important

Hi,

gbsplay FTBFS on hurd-i386, kfreebsd-i386, kfreebsd-amd64 (but older
versions  built successfully in the past on all these platforms):

https://buildd.debian.org/status/fetch.php?pkg=gbsplay&arch=hurd-i386&ver=0.0.93-1&stamp=1441124625
https://buildd.debian.org/status/fetch.php?pkg=gbsplay&arch=kfreebsd-amd64&ver=0.0.93-1&stamp=1441131835
https://buildd.debian.org/status/fetch.php?pkg=gbsplay&arch=kfreebsd-i386&ver=0.0.93-1&stamp=1441125313

[...]
/usr/bin/make V=1
make[1]: Entering directory '/«PKGBUILDDIR»'
DEP gbsinfo.c -o gbsinfo.d
DEP plugout_pulse.c -o plugout_pulse.d
DEP plugout_midi.c -o plugout_midi.d
DEP plugout_stdout.c -o plugout_stdout.d
DEP plugout_nas.c -o plugout_nas.d
DEP plugout_alsa.c -o plugout_alsa.d
DEP plugout_devdsp.c -o plugout_devdsp.d
DEP plugout.c -o plugout.d
DEP util.c -o util.d
DEP gbsplay.c -o gbsplay.d
DEP impulsegen.c -o impulsegen.d
DEP crc32.c -o crc32.d
DEP cfgparser.c -o cfgparser.d
DEP gbs.c -o gbs.d
DEP gbhw.c -o gbhw.d
DEP gbcpu.c -o gbcpu.d
CC gbcpu.c -o gbcpu.o
CC gbhw.c -o gbhw.o
CC gbs.c -o gbs.o
CC cfgparser.c -o cfgparser.o
CC crc32.c -o crc32.o
CC impulsegen.c -o impulsegen.o
CC gbsplay.c -o gbsplay.o
In file included from gbsplay.c:27:0:
util.h:11:13: warning: inline function 'rand_long' declared but never defined
 inline long rand_long(long max);
 ^
CC util.c -o util.o
CC plugout.c -o plugout.o
CC plugout_devdsp.c -o plugout_devdsp.o
CC plugout_alsa.c -o plugout_alsa.o
plugout_alsa.c: In function 'alsa_write':
plugout_alsa.c:103:18: error: 'ESTRPIPE' undeclared (first use in this function)
   if (retval != -ESTRPIPE)
  ^
plugout_alsa.c:103:18: note: each undeclared identifier is reported only once 
for each function it appears in
make[1]: *** [plugout_alsa.o] Error 1
Makefile:366: recipe for target 'plugout_alsa.o' failed
make[1]: Leaving directory '/«PKGBUILDDIR»'
make: *** [build-stamp] Error 2


If this probelm is not trivially fixable, please request decrufting
of the outdated binary packages.


Andreas