Bug#815844: [Reproducible-builds] Bug#815844: diffoscope won't build without python-magic from PyPi

[Holger Levsen]

control: severity -1 minor

Hi,

downgrading this bugs severity as it doesnt affect Debian as Lunar explained.


cheers,
Holger


signature.asc
Description: This is a digitally signed message part.

Bug#815844: [Reproducible-builds] Bug#815844: diffoscope won't build without python-magic from PyPi

[Jérémy Bobbio]

Leo Famulari:
> However, diffoscope's README [2] says that:
> 
> ``Magic-file-extension`` can be used instead of
> ``python-magic``. It is built from `file
> `_.
> Available on Debian and Fedora as ``python3-magic``.
> 
> I removed the requirement of python-magic from setup.py and built
> against the Python bindings distributed with `file`, as packaged in Guix
> [3]. Diffoscope seems to work just fine this way.

Indeed. That's how it works in Debian.

> Will you consider making python-magic an optional dependency of
> diffoscope, so that downstream packagers don't have to package
> python-magic from PyPi or work around this issue by patching setup.py?

I have no idea how you can specify alternate dependencies in setup.py or
if that's possible. If you find a solution I guess someone could apply a
patch.

If that's not possible, I believe that carrying a one-liner in Guix is
not unreasonable.

-- 
Lunar.''`. 
lu...@debian.org: :Ⓐ  :  # apt-get install anarchism
`. `'` 
  `-   


signature.asc
Description: Digital signature

Bug#815844: diffoscope won't build without python-magic from PyPi

[Leo Famulari]

Source: diffoscope

Dear Maintainer,

I am maintaining the diffoscope package in GNU Guix [0].

I recently updated from version 34 to 49, and found that I could not
build diffoscope from source without the python-magic package from PyPi
[1].

However, diffoscope's README [2] says that:

``Magic-file-extension`` can be used instead of
``python-magic``. It is built from `file
`_.
Available on Debian and Fedora as ``python3-magic``.

I removed the requirement of python-magic from setup.py and built
against the Python bindings distributed with `file`, as packaged in Guix
[3]. Diffoscope seems to work just fine this way.

I even confirmed, with strace, that diffoscope was using libmagic from
`file`.

Will you consider making python-magic an optional dependency of
diffoscope, so that downstream packagers don't have to package
python-magic from PyPi or work around this issue by patching setup.py?

[0]
https://www.gnu.org/software/guix/package-list.html#diffoscope

[1]
https://pypi.python.org/pypi/python-magic/

[2]
https://anonscm.debian.org/cgit/reproducible/diffoscope.git/tree/README.rst#n58

[3]
https://www.gnu.org/software/guix/package-list.html#python-file