Bug#816314: [Pkg-running-devel] Bug#816314: Bug#816314: fixed in garmin-forerunner-tools 0.10repacked-9

[Christian PERRIER]

Quoting Fenix (fenix...@gmail.com):
> Oooops.
> 
> I think that I know what happens. I just did clone [
> git://git.debian.org/git/pkg-running/garmin-forerunner-tools.git ] thinking
> that the master branch was updated until the last repackage.
> 
> I just see that the patches is inside de Debian/patches and not applied to
> the source code.
> 
> 
> So, was me who was seeing a non updated code. I'm sorry. I didn't know the
> Debian workflow.
> 
> 
> I'm going to update the code with the patches, and try to say something.

Well, the "816314_fix.patch" *is* in master.

The patch is in debian/patches *and* listed in debian/patches/series,
so as far as I can tell, it is applied at build time and thus is
ending in the built binaries.

Still the debian/0.10repacked-9 tag didn't end up on Alioth because of
an omission of mine on my local copy. This is now fixed.



signature.asc
Description: PGP signature

Bug#816314: [Pkg-running-devel] Bug#816314: fixed in garmin-forerunner-tools 0.10repacked-9

[Fenix]

Oooops.

I think that I know what happens. I just did clone [ 
git://git.debian.org/git/pkg-running/garmin-forerunner-tools.git ] 
thinking that the master branch was updated until the last repackage.


I just see that the patches is inside de Debian/patches and not applied 
to the source code.



So, was me who was seeing a non updated code. I'm sorry. I didn't know 
the Debian workflow.



I'm going to update the code with the patches, and try to say something.

Bug#816314: [Pkg-running-devel] Bug#816314: fixed in garmin-forerunner-tools 0.10repacked-9

[Fenix]

On 15/04/16 06:53, Christian PERRIER wrote:

Quoting Chris AtLee (ch...@atlee.ca):

I'm still getting a segfault in the latest version. Here's the traceback:

Program received signal SIGSEGV, Segmentation fault.
0x77bba378 in garmin_open (garmin=garmin@entry=0x7fffe350) at
usb_comm.c:137
137 usb_comm.c: No such file or directory.
(gdb) where
#0  0x77bba378 in garmin_open (garmin=garmin@entry=0x7fffe350)
at usb_comm.c:137
#1  0x77bc3180 in garmin_init (garmin=garmin@entry=0x7fffe350,
 verbose=) at protocol.c:1186
#2  0x00400725 in main (argc=, argv=)
 at garmin_save_runs.c:36



We may need to check this with Fenix, who provided the patch I
used. Sadly, I'm not in position to test myself




  Hi.

  I just went to re-open this. :)


  I don't know if that is important, but I see that in the master is 
not my change. Is it possible that the repacked9 is in real repacked8 again?

Bug#816314: [Pkg-running-devel] Bug#816314: fixed in garmin-forerunner-tools 0.10repacked-9

[Christian PERRIER]

Quoting Chris AtLee (ch...@atlee.ca):
> I'm still getting a segfault in the latest version. Here's the traceback:
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0x77bba378 in garmin_open (garmin=garmin@entry=0x7fffe350) at
> usb_comm.c:137
> 137 usb_comm.c: No such file or directory.
> (gdb) where
> #0  0x77bba378 in garmin_open (garmin=garmin@entry=0x7fffe350)
> at usb_comm.c:137
> #1  0x77bc3180 in garmin_init (garmin=garmin@entry=0x7fffe350,
> verbose=) at protocol.c:1186
> #2  0x00400725 in main (argc=, argv=)
> at garmin_save_runs.c:36


We may need to check this with Fenix, who provided the patch I
used. Sadly, I'm not in position to test myself



signature.asc
Description: PGP signature

Bug#816314: fixed in garmin-forerunner-tools 0.10repacked-9

[Chris AtLee]

I'm still getting a segfault in the latest version. Here's the traceback:

Program received signal SIGSEGV, Segmentation fault.
0x77bba378 in garmin_open (garmin=garmin@entry=0x7fffe350) at
usb_comm.c:137
137 usb_comm.c: No such file or directory.
(gdb) where
#0  0x77bba378 in garmin_open (garmin=garmin@entry=0x7fffe350)
at usb_comm.c:137
#1  0x77bc3180 in garmin_init (garmin=garmin@entry=0x7fffe350,
verbose=) at protocol.c:1186
#2  0x00400725 in main (argc=, argv=)
at garmin_save_runs.c:36

On Wed, 06 Apr 2016 09:50:50 + Christian Perrier 
wrote:
> Source: garmin-forerunner-tools
> Source-Version: 0.10repacked-9
>
> We believe that the bug you reported is fixed in the latest version of
> garmin-forerunner-tools, which is due to be installed in the Debian FTP
archive.
>
> A summary of the changes between this version and the previous one is
> attached.
>
> Thank you for reporting the bug, which will now be closed.  If you
> have further comments please address them to 816...@bugs.debian.org,
> and the maintainer will reopen the bug report if appropriate.
>
> Debian distribution maintenance software
> pp.
> Christian Perrier  (supplier of updated
garmin-forerunner-tools package)
>
> (This message was generated automatically at their request; if you
> believe that there is a problem with it please contact the archive
> administrators by mailing ftpmas...@ftp-master.debian.org)
>
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Format: 1.8
> Date: Wed, 06 Apr 2016 08:57:27 +0200
> Source: garmin-forerunner-tools
> Binary: garmin-forerunner-tools
> Architecture: source i386
> Version: 0.10repacked-9
> Distribution: unstable
> Urgency: medium
> Maintainer: Debian running develpment group <
pkg-running-de...@lists.alioth.debian.org>
> Changed-By: Christian Perrier 
> Description:
>  garmin-forerunner-tools - retrieve data from Garmin Forerunner/Edge GPS
devices
> Closes: 816314
> Changes:
>  garmin-forerunner-tools (0.10repacked-9) unstable; urgency=medium
>  .
>* Fix segmentation fault by properly checking the size of a counter
>  in protocol.c.
>  Great thanks to Fenix for the patch
>  Closes: #816314
> Checksums-Sha1:
>  7a81d77e28a20f48d490dd753f7cd6bc48d69bbe 2254
garmin-forerunner-tools_0.10repacked-9.dsc
>  35c2d5fef922f7dfce8e0ec18b6c155c94239a84 16348
garmin-forerunner-tools_0.10repacked-9.debian.tar.xz
>  ac567721fb37a59843c4517c41114e1ebd7ee074 193636
garmin-forerunner-tools-dbgsym_0.10repacked-9_i386.deb
>  7ebee932df1f437c89eedff2848d5f8d933194ee 119000
garmin-forerunner-tools_0.10repacked-9_i386.deb
> Checksums-Sha256:
>  7ca55e98cad94ee69b484508b7f64dc5247e0c0c10579a40d3347ad4e595c547 2254
garmin-forerunner-tools_0.10repacked-9.dsc
>  fed08f6663197563802e95ff861f719aac9b99d791aad38090afdeb4d79f3640 16348
garmin-forerunner-tools_0.10repacked-9.debian.tar.xz
>  6e90173fed70c15a0627aa8f5c540c33162848308562cbcc2ea93443a1c7ba3a 193636
garmin-forerunner-tools-dbgsym_0.10repacked-9_i386.deb
>  107b29a2f0f2644d80e82910f7042133d17745acd878a8db07e6e57c39a6dcab 119000
garmin-forerunner-tools_0.10repacked-9_i386.deb
> Files:
>  50005d8ea009f8372b908b7a40697a0d 2254 utils extra
garmin-forerunner-tools_0.10repacked-9.dsc
>  8f186360eb567efeafca8a981defb517 16348 utils extra
garmin-forerunner-tools_0.10repacked-9.debian.tar.xz
>  866e63a023f04f9f943933705ee68f23 193636 debug extra
garmin-forerunner-tools-dbgsym_0.10repacked-9_i386.deb
>  e0588897815a1c2790b5a5f7273f6142 119000 utils extra
garmin-forerunner-tools_0.10repacked-9_i386.deb