Bug#816326: schroot: don't fail on 15binfmt with a missing /bin/sh

[Wookey]

Package: src:schroot
Followup-For: Bug #816326

I can confirm that Raphael's patch fixes this issue for me too (not
very surprisingly).

Wookey

Bug#816326: [buildd-tools-devel] Bug#816326: schroot: don't fail on 15binfmt with a missing /bin/sh

[Raphael Geissert]

Hi,

On 1 March 2016 at 09:28, Johannes Schauer  wrote:
> Quoting Raphael Geissert (2016-02-29 22:44:42)
>> Once upon a time I found a chroot that didn't have a /bin/sh and schroot
>> failed miserably due to a call to binfmt --find on a non-existing file...
>> Attached patch makes 15binfmt test for $shell to be readable.
>
> this sounds like a possible fix for #815175

Oh, I somehow missed that bug report. Yes, the chroot I was talking
about was more or less in a similar state: it was actually a session
that had failed to be cleaned up (EBUSY at some point) and at the
second attempt to end it, 15binfmt failed.

My patch won't fix the 20copyfiles problem, however.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

Bug#816326: [buildd-tools-devel] Bug#816326: schroot: don't fail on 15binfmt with a missing /bin/sh

[Johannes Schauer]

Hi,


Quoting Raphael Geissert (2016-02-29 22:44:42)
> Once upon a time I found a chroot that didn't have a /bin/sh and schroot
> failed miserably due to a call to binfmt --find on a non-existing file...
> Attached patch makes 15binfmt test for $shell to be readable.

this sounds like a possible fix for #815175

cheers, josch


signature.asc
Description: signature

Bug#816326: schroot: don't fail on 15binfmt with a missing /bin/sh

[Raphael Geissert]

Source: schroot
Version: 1.6.10-2
Tags: patch
Severity: minor

Hi,

Once upon a time I found a chroot that didn't have a /bin/sh and
schroot failed miserably due to a call to binfmt --find on a
non-existing file...
Attached patch makes 15binfmt test for $shell to be readable.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net
Index: sources-schroot/1.6.10-2/etc/setup.d/15binfmt
===
--- sources-schroot/1.6.10-2/etc/setup.d/15binfmt
+++ sources-schroot/1.6.10-2/etc/setup.d/15binfmt
@@ -34,8 +34,12 @@
 fi
 
 shell="${CHROOT_PATH}/bin/sh"
 
+if ! [ -r "$shell" ]; then
+exit 0
+fi
+
 for emulator in $(update-binfmts --find "$shell"); do
 dst="${CHROOT_PATH}$emulator"
 if [ ! -e "$emulator" ]; then
 info "Missing emulator: $emulator; not enabling binfmt support"