Bug#819111: uscan: option for disabling repacking
* James McCoy , 2016-04-17, 13:49: Right, that's not a very intuitive name... Also, I was grepping for "repack", not for "mk-origtargz", as the latter is mostly an implementation detail. I agree. Let's find a better description. Is this agreeable? --no-symlink Don't rename nor repackage upstream tarball by not calling mk-origtargz. I think that would be fine if “by not calling mk-origtargz” was removed. Shouldn't it be s/repackage/repack/? Other than that, it looks good to me. -- Jakub Wilk
Bug#819111: uscan: option for disabling repacking
On Sun, Apr 17, 2016 at 11:09:45PM +0900, Osamu Aoki wrote: > On Tue, Apr 12, 2016 at 03:47:54PM +0200, Jakub Wilk wrote: > > Right, that's not a very intuitive name... Also, I was grepping for > > "repack", not for "mk-origtargz", as the latter is mostly an implementation > > detail. > > I agree. Let's find a better description. Is this agreeable? > > --no-symlink Don't rename nor repackage upstream tarball by not > calling mk-origtargz. I think that would be fine if “by not calling mk-origtargz” was removed. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy
Bug#819111: uscan: option for disabling repacking
Hi, On Tue, Apr 12, 2016 at 03:47:54PM +0200, Jakub Wilk wrote: > * Osamu Aoki , 2016-03-25, 01:04: ... > Download upstream sources (which used to be the primary purpose of uscan). > More specifically, I'm using uscan in get-orig-source target of > src:openinbrowser, where I have custom repacking code. I see. This is valid use. > >$ uscan --help | grep no-symlink > > --no-symlink Don't call mk-origtargz > > > >The name is a relic from when the only option was setting up a properly > >named symlink. > > Right, that's not a very intuitive name... Also, I was grepping for > "repack", not for "mk-origtargz", as the latter is mostly an implementation > detail. I agree. Let's find a better description. Is this agreeable? --no-symlink Don't rename nor repackage upstream tarball by not calling mk-origtargz. Please propose better text. I am not the best person for making English text. Osamu
Bug#819111: uscan: option for disabling repacking
* Osamu Aoki , 2016-03-25, 01:04: uscan repacks zip and xpi archives automatically, but AFAICS there's no option to turn off this feature. I am curious what Jakub is trying to achieve. Download upstream sources (which used to be the primary purpose of uscan). More specifically, I'm using uscan in get-orig-source target of src:openinbrowser, where I have custom repacking code. $ uscan --help | grep no-symlink --no-symlink Don't call mk-origtargz The name is a relic from when the only option was setting up a properly named symlink. Right, that's not a very intuitive name... Also, I was grepping for "repack", not for "mk-origtargz", as the latter is mostly an implementation detail. Are you using "uupdate" or "gbp-import-orig --uscan"? No. -- Jakub Wilk
Bug#819111: uscan: option for disabling repacking
Hi, On Wed, Mar 23, 2016 at 08:29:58PM -0400, James McCoy wrote: > On Wed, Mar 23, 2016 at 09:46:18PM +0100, Jakub Wilk wrote: > > uscan repacks zip and xpi archives automatically, but AFAICS there's no > > option to turn off this feature. I am curious what Jakub is trying to achieve. Can we upload upstream package with zip and xpi, now? Are you trying such? > $ uscan --help | grep no-symlink > --no-symlink Don't call mk-origtargz > > The name is a relic from when the only option was setting up a properly > named symlink. Over the years, as other mechanisms appeared, > --no-symlink remained the magic “off” switch. My first reaction was "Should we add yet-another-alias-option like --no-mk-origtargz" and expand manpage to explain: Don't call mk-origtargz. This turns off repackaging automatically. Are you using "uupdate" or "gbp-import-orig --uscan"? Then you may still wish to run mk-origtargz to get properly renamed filename but without automatic repackaging. You may also wish not to give extra option every time you update. ... There may be needs for such option and also support from opts= line. Osamu
Bug#819111: uscan: option for disabling repacking
On Wed, Mar 23, 2016 at 09:46:18PM +0100, Jakub Wilk wrote: > uscan repacks zip and xpi archives automatically, but AFAICS there's no > option to turn off this feature. $ uscan --help | grep no-symlink --no-symlink Don't call mk-origtargz The name is a relic from when the only option was setting up a properly named symlink. Over the years, as other mechanisms appeared, --no-symlink remained the magic “off” switch. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy
Bug#819111: uscan: option for disabling repacking
Package: devscripts Version: 2.16.2 Severity: wishlist uscan repacks zip and xpi archives automatically, but AFAICS there's no option to turn off this feature. -- Jakub Wilk
