Bug#820704: Bug#820705: RFS: subuser/0.5.6-3 [ITP]

[Stanislas Leduc]

Hi, 

I remove export PYTHON from debian/rules, also python3-setuprools from
package, infact not use. 

I use debian/clean for remove subuser.egg-info when i build package from
my host build, now i use pbuilder for build package, debian/clean
doesn't necessary. 

copyright file update to add missing licences and respective copyright. 

codespell and other commands return several warning that wrong words, i
see to log that and send them to developer for fix them. 

I check for upstream Metadata 

New version reflect change of them upload to mentors 

Best regards 

Stan

Bug#820704: Bug#820705: RFS: subuser/0.5.6-3 [ITP]

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo

Hi,

lets see:


"export PYTHON=`which python3`" what?


http://debomatic-amd64.debian.net/distribution#unstable/subuser/0.5.6-1/lintian
please fix the first lintian warning.

"Depends: ${misc:Depends}, ${python3:Depends}, python3-setuptools, git, 
docker.io"

why setuptools?

d/clean: is it useful?

d/copyright: "LGPL" <-- please add the version.

missing licenses:
./docs/_themes/sphinx_rtd_theme/static/css/theme.css: *  License - 
http://fontawesome.io/license (Font: SIL OFL 1.1, CSS: MIT License)
./docs/_themes/sphinx_rtd_theme/search.html::license: BSD, see LICENSE for 
details.
./docs/_themes/sphinx_rtd_theme/layout_old.html::license: BSD, see LICENSE 
for details.



apt-get install -t experimental check-all-the-things:
$ codespell --quiet-level=3


$ pep8 --ignore W191 .


$ pyflakes3 .

$ find -type f \( -iname '*.sh' -o -iname '*.bash' -o -iname '*.zsh' \) -exec 
shellcheck {} +

$ suspicious-source

$ grep -r '/tmp/' .


Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata


other stuff LGTM

G.

Bug#820704: Bug#820705: RFS: subuser/0.5.6-3 [ITP]

[Stanislas Leduc]

Hi, 

I follow your recommendations and push again new version : 

- Ajust debian/changelog 

- Modify debian/control and debian/rules 

Also for moment not include doc, WIP, discuss with developer because doc
include mp4 video. 

Thx for your review :) 

--- 

Stanislas Leduc