Bug#823796: [Python-apps-team] Bug#823796: phatch: impossible to use phatch there is just the logo that is displayed
> This patch works well here. I think it is simple enough to be accepted > by the release team. I've just uploaded the fixed package. PAPT: i couldnt commit it to the svn repo because the version in there is out of sync with the reality (ie the archive): it misses -3 and -4 while it contains the initial packaging for a new upstream release. you might want to look into what's going on and rectify it before the migration to git starts. -- Sandro "morph" Tosi My website: http://sandrotosi.me/ Me at Debian: http://wiki.debian.org/SandroTosi G+: https://plus.google.com/u/0/+SandroTosi
Bug#823796: phatch: impossible to use phatch there is just the logo that is displayed
Quack, On 05/27/2017 08:57 AM, Steve Cotton wrote: > This is a caused by a change in the PIL library, but it can be worked > round with a one-line change to Phatch, which seems the best option > before the Stretch release. This patch works well here. I think it is simple enough to be accepted by the release team. You do not seem to be a Debian contributor (yet). If noone from the PAPT steps up, I guess they won't object to an upload from a former DPMT member :-). \_o< signature.asc Description: OpenPGP digital signature
Bug#823796: phatch: impossible to use phatch there is just the logo that is displayed
On Sun, May 07, 2017 at 02:39:07PM +0200, Marc Dequènes wrote:
> Quack,
> File "/usr/share/phatch/phatch/lib/pyWx/treeEdit.py", line 120, in
> _AddFormToImageList
> wx_image = pil_wxImage(wxImage_pil(wx_image).resize(icon_size,\
> File "/usr/share/phatch/phatch/lib/pyWx/wxPil.py", line 45, in wxImage_pil
> image = Image.new('RGB', size)
> File "/usr/lib/python2.7/dist-packages/PIL/Image.py", line 2051, in new
> _check_size(size)
> File "/usr/lib/python2.7/dist-packages/PIL/Image.py", line 2027, in
> _check_size
> raise ValueError("Size must be a tuple")
> ValueError: Size must be a tuple
>
> \_o<
This is a caused by a change in the PIL library, but it can be worked
round with a one-line change to Phatch, which seems the best option
before the Stretch release.
Steve
From: Steve Cotton
Date: Sat, 27 May 2017 01:32:21 +0200
Subject: [PATCH] Convert images' wx.Size object to a tuple for the PIL library
The wxPython library wraps image sizes in a wx.Size object, a class
which provides the __len__ and accessor methods expected for a tuple.
There's been a breaking change to the PIL library, which now
explicitly checks the type of the size passed to it, and rejects
anything which is not a tuple or a list.
This patch adds a call to wx.Size.Get(), which returns the size as a
tuple.
Bug-Debian: https://bugs.debian.org/823796
PIL library change:
https://github.com/python-pillow/Pillow/commit/445451c0b9347b50e0f603db33f196e207de470d
---
phatch/lib/pyWx/wxPil.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/phatch/lib/pyWx/wxPil.py b/phatch/lib/pyWx/wxPil.py
index cf8c940..be73074 100644
--- a/phatch/lib/pyWx/wxPil.py
+++ b/phatch/lib/pyWx/wxPil.py
@@ -41,7 +41,7 @@ def pil_wxBitmap(image):
def wxImage_pil(wx_image):
-size = wx_image.GetSize()
+size = wx_image.GetSize().Get()
image = Image.new('RGB', size)
image.frombytes(wx_image.GetData())
if wx_image.HasAlpha():
Bug#823796: phatch: impossible to use phatch there is just the logo that is displayed
Quack,
Same problem with 0.2.7.1-4, with an additional trace (but the program
does not end):
$ phatch
/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/_core.py:8196:
GtkWarning: gtk_disable_setlocale() must be called before gtk_init()
return _core_.PyApp__BootstrapApp(*args, **kwargs)
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/wx-3.0-gtk2/wx/_core.py", line
16765, in
lambda event: event.callable(*event.args, **event.kw) )
File "/usr/share/phatch/phatch/pyWx/gui.py", line 1218, in show_frame
frame = Frame(self.filename, None, -1, ct.TITLE)
File "/usr/share/phatch/phatch/pyWx/gui.py", line 327, in __init__
frame.Frame.__init__(self, *args, **keyw)
File "/usr/share/phatch/phatch/pyWx/wxGlade/frame.py", line 141, in
__init__
self.tree = Tree(self, -1,
style=wx.TR_HAS_BUTTONS|wx.TR_NO_LINES|wx.TR_FULL_ROW_HIGHLIGHT|wx.TR_HIDE_ROOT|wx.TR_DEFAULT_STYLE|wx.SUNKEN_BORDER)
File "/usr/share/phatch/phatch/pyWx/wxGlade/frame.py", line 26, in
__init__
set_dirty = parent.set_dirty,
File "/usr/share/phatch/phatch/lib/pyWx/treeEdit.py", line 96, in __init__
self.CreateImageList(icon_size)
File "/usr/share/phatch/phatch/lib/pyWx/treeEdit.py", line 111, in
CreateImageList
self._AddFormToImageList(form, icon_size, icon_disabled)
File "/usr/share/phatch/phatch/lib/pyWx/treeEdit.py", line 120, in
_AddFormToImageList
wx_image = pil_wxImage(wxImage_pil(wx_image).resize(icon_size,\
File "/usr/share/phatch/phatch/lib/pyWx/wxPil.py", line 45, in wxImage_pil
image = Image.new('RGB', size)
File "/usr/lib/python2.7/dist-packages/PIL/Image.py", line 2051, in new
_check_size(size)
File "/usr/lib/python2.7/dist-packages/PIL/Image.py", line 2027, in
_check_size
raise ValueError("Size must be a tuple")
ValueError: Size must be a tuple
\_o<
signature.asc
Description: OpenPGP digital signature
Bug#823796: phatch: impossible to use phatch there is just the logo that is displayed
Package: phatch Version: 0.2.7.1-3.1 Severity: normal Tags: patch Dear Maintainer, *** Reporter, please consider answering these questions, where appropriate *** * What led up to the situation? * What exactly did you do (or not do) that was effective (or ineffective)? * What was the outcome of this action? * What outcome did you expect instead? *** End of the template - remove these template lines *** -- System Information: Debian Release: stretch/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 4.5.0-1-686-pae (SMP w/2 CPU cores) Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages phatch depends on: ii phatch-cli0.2.7.1-3.1 ii python-wxgtk3.0 3.0.2.0+dfsg-1+b1 ii python-wxversion 3.0.2.0+dfsg-1 pn python:any ii xdg-utils 1.1.1-1 phatch recommends no packages. Versions of packages phatch suggests: pn blender ii inkscape 0.91-9 -- no debconf information
