Bug#825858: systemd-insserv-generator shouldn't create insserv dependencies if the unit is masked

[Felipe Sateler]

On 30 May 2016 at 16:25, Laurent Bigonville  wrote:
> Hi,
>
> rpcbind is now providing a .service file, but the
> systemd-insserv-generator is still creating dependency information base
> on it:

Indeed. The long term solution is to drop insserv-generator (bugs
missing, I should finally sit and file them...).

But given the speed at which things are moving (we don't even have
bugs yet!), it may be worthwhile to borrow the check used in the
sysv-generator[1] and put it in the insserv-generator before checking
if the initscript exists[2]

[1] 
http://sources.debian.net/src/systemd/230-1/src/sysv-generator/sysv-generator.c/#L828-L835
[2] 
http://sources.debian.net/src/systemd/230-1/src/insserv-generator/insserv-generator.c/#L204


-- 

Saludos,
Felipe Sateler

Bug#825858: systemd-insserv-generator shouldn't create insserv dependencies if the unit is masked

[Laurent Bigonville]

On Mon, 30 May 2016 22:25:25 +0200 Laurent Bigonville  
wrote:


> Hi,
>
> rpcbind is now providing a .service file, but the
> systemd-insserv-generator is still creating dependency information base
> on it:
>
> # /run/systemd/generator/rpcbind.service.d/50-rpcbind-$portmap.conf
> # Automatically generated by systemd-insserv-generator
>
> [Unit]
> Wants=rpcbind.target
> Before=rpcbind.target
>
> and also
>
> # 
/run/systemd/generator/rpcbind.target.d/50-hard-dependency-rpcbind-$portmap.conf

> # Automatically generated by systemd-insserv-generator
>
> [Unit]
> SourcePath=/etc/insserv.conf.d/rpcbind
> Requires=rpcbind.service
>
> Shouldn't systemd-insserv-generator ignore inserv informations if the
> LSB initscript is masked by a systemd service?
>
> That would also need to check that the .service files have the proper
> dependencies.

On the other hand, it seems that the generator is not adding a Requires 
in the .service generated for nfs-common:


# /run/systemd/generator.late/nfs-common.service
# Automatically generated by systemd-sysv-generator

[Unit]
Documentation=man:systemd-sysv-generator(8)
SourcePath=/etc/init.d/nfs-common
Description=LSB: NFS support files common to client and server
DefaultDependencies=no
Before=sysinit.target
Before=multi-user.target
Before=multi-user.target
Before=multi-user.target
Before=graphical.target
Before=shutdown.target
After=rpcbind.target
After=time-sync.target
Conflicts=shutdown.target

[Service]
Type=forking
Restart=no
TimeoutSec=0
IgnoreSIGPIPE=no
KillMode=process
GuessMainPID=no
RemainAfterExit=yes
ExecStart=/etc/init.d/nfs-common start
ExecStop=/etc/init.d/nfs-common stop

$ grep portmap /etc/init.d/nfs-common
# Required-Start:$portmap $time

Bug#825858: systemd-insserv-generator shouldn't create insserv dependencies if the unit is masked

[Laurent Bigonville]

Package: systemd
Version: 230-1
Severity: normal

Hi,

rpcbind is now providing a .service file, but the
systemd-insserv-generator is still creating dependency information base
on it:

# /run/systemd/generator/rpcbind.service.d/50-rpcbind-$portmap.conf
# Automatically generated by systemd-insserv-generator

[Unit]
Wants=rpcbind.target
Before=rpcbind.target

and also

# 
/run/systemd/generator/rpcbind.target.d/50-hard-dependency-rpcbind-$portmap.conf
# Automatically generated by systemd-insserv-generator

[Unit]
SourcePath=/etc/insserv.conf.d/rpcbind
Requires=rpcbind.service

Shouldn't systemd-insserv-generator ignore inserv informations if the
LSB initscript is masked by a systemd service?

That would also need to check that the .service files have the proper
dependencies.

Cheers,

Laurent Bigonville

-- Package-specific info:

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.5.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages systemd depends on:
ii  adduser 3.114
ii  libacl1 2.2.52-3
ii  libapparmor12.10-4
ii  libaudit1   1:2.5.2-1
ii  libblkid1   2.28-5
ii  libc6   2.22-9
ii  libcap2 1:2.25-1
ii  libcap2-bin 1:2.25-1
ii  libcryptsetup4  2:1.7.0-2
ii  libgcrypt20 1.7.0-2
ii  libgpg-error0   1.22-2
ii  libkmod222-1.1
ii  liblzma55.1.1alpha+20120614-2.1
ii  libmount1   2.28-5
ii  libpam0g1.1.8-3.2
ii  libseccomp2 2.3.1-2
ii  libselinux1 2.5-3
ii  libsystemd0 230-1
ii  mount   2.28-5
ii  util-linux  2.28-5

Versions of packages systemd recommends:
ii  dbus1.10.8-1
ii  libpam-systemd  230-1

Versions of packages systemd suggests:
pn  systemd-container  
pn  systemd-ui 

Versions of packages systemd is related to:
ii  udev  230-1

-- no debconf information