Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
control: tags -1 + pending Hi Stefano, On Sat, Jul 30, 2016 at 06:39:28PM -0400, Stefano Rivera wrote: > Suggested solution attached. thanks, applied to the develop branch now, will upload to sid shortly and then proceed with fixing this via jessie-pu… -- cheers, Holger signature.asc Description: Digital signature
Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
Hi Stefano, On Sat, Jul 30, 2016 at 06:39:28PM -0400, Stefano Rivera wrote: > Suggested solution attached. > Subject: [PATCH] Don't test the current Debian release status > Tracking that is distro-info-data's problem > def testConfStdDistroNames(self): > -self.assertEqual(self.oldstable, 'wheezy') > -self.assertEqual(self.stable, 'jessie') > -self.assertEqual(self.testing, 'stretch') > self.assertEqual(self.unstable, 'sid') > self.assertEqual(self.experimental, 'experimental') I guess thats actually a nice solution, I was about to reply just replace wheezy with jessie would be a poor fix, as it's bound to break again. I'll give this solution a try, but am about to board a flight, so this might take some time… Thanks! -- cheers, Holger signature.asc Description: Digital signature
Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
Control: tag -1 + patch > def testConfStdDistroNames(self): > self.assertEqual(self.oldstable, 'squeeze') > self.assertEqual(self.stable, 'wheezy') > self.assertEqual(self.testing, 'jessie') > self.assertEqual(self.unstable, 'sid') > self.assertEqual(self.experimental, 'experimental') > > which is incorrect since jessie was released ... > > I'm not sure about what this unittest is supposed to accomplish ... > > And the bug will manifest again once stretch gets released Suggested solution attached. SR -- Stefano Rivera http://tumbleweed.org.za/ +1 415 683 3272 From 4a95908fdd67f7a7e8f23b1afeedf495b903aa1f Mon Sep 17 00:00:00 2001 From: Stefano Rivera Date: Sat, 30 Jul 2016 18:37:20 -0400 Subject: [PATCH] Don't test the current Debian release status Tracking that is distro-info-data's problem Closes: #827411 --- tests/test_config.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/test_config.py b/tests/test_config.py index 17b704c..f189861 100644 --- a/tests/test_config.py +++ b/tests/test_config.py @@ -17,9 +17,6 @@ class ConfStdDistroTests(unittest.TestCase): self.experimental = 'experimental' def testConfStdDistroNames(self): -self.assertEqual(self.oldstable, 'wheezy') -self.assertEqual(self.stable, 'jessie') -self.assertEqual(self.testing, 'stretch') self.assertEqual(self.unstable, 'sid') self.assertEqual(self.experimental, 'experimental') -- 2.8.1
Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
control: reassign -1 piuparts > Are you sure that this isn't a bug in piuparts? > There is a hardcoded mapping from codenames to releases ... Agreed, that's the bug. SR -- Stefano Rivera http://tumbleweed.org.za/ +1 415 683 3272
Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
Control: tag -1 - jessie On 2016-06-16 12:18, Holger Levsen wrote: > On Thu, Jun 16, 2016 at 11:06:28AM +0100, Dominic Hargreaves wrote: >>> I'm not sure how to deal with this bug report :-( Maybe this is actually >>> a bug in distro-info in jessie and this bug should be reassigned there? >>> (+"affects piuparts") >> >> That sounds quite appropriate. JFTR, python-distro-info (0.14). Are you sure that this isn't a bug in piuparts? There is a hardcoded mapping from codenames to releases ... This is from 0.62: def testConfStdDistroNames(self): self.assertEqual(self.oldstable, 'squeeze') self.assertEqual(self.stable, 'wheezy') self.assertEqual(self.testing, 'jessie') self.assertEqual(self.unstable, 'sid') self.assertEqual(self.experimental, 'experimental') which is incorrect since jessie was released ... I'm not sure about what this unittest is supposed to accomplish ... And the bug will manifest again once stretch gets released, therefore clearing the jessie tag. Andreas
Bug#827411: [Piuparts-devel] Bug#827411: Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
control: severity -1 serious control: reassign -1 python-distro-info control: found -1 0.14 control: tags -1 + jessie control: affects -1 piuparts thanks On Thu, Jun 16, 2016 at 11:06:28AM +0100, Dominic Hargreaves wrote: > > I'm not sure how to deal with this bug report :-( Maybe this is actually > > a bug in distro-info in jessie and this bug should be reassigned there? > > (+"affects piuparts") > > That sounds quite appropriate. JFTR, python-distro-info (0.14). > > > I've downgraded the severity for now as the package builds fine in sid. > > I think the correct action is to tag this bug jessie and or update > the 'fixed' version metadata, rather than downgrade - but I expect > that can all get fixed up once/if the bug is reassigned :) agreed, doing so now. -- cheers, Holger signature.asc Description: Digital signature
Bug#827411: [Piuparts-devel] Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
On Thu, Jun 16, 2016 at 09:59:39AM +, Holger Levsen wrote: > control: severity -1 important > thanks > > Hi Dominic, hi distro-info maintainers, > > thanks for your bug report, Dominic! > > On Wed, Jun 15, 2016 at 10:20:18PM +0100, Dominic Hargreaves wrote: > > Source: piuparts > > Version: 0.62 > > Severity: serious > > Justification: FTBFS > > > > This package fails to build on a clean jessie sbuild chroot: > > > > == > > FAIL: testConfStdDistroNames (test_config.ConfStdDistroTests) > > -- > > Traceback (most recent call last): > > File "/<>/tests/test_config.py", line 20, in > > testConfStdDistroNames > > self.assertEqual(self.oldstable, 'squeeze') > > AssertionError: 'wheezy' != 'squeeze' > > looking at tests/test_config.py I see nothing wrong, wheezy is > oldstablde there and squeeze is only referenced there for history. > > So I assume it's actually not piuparts which "is wrong" but distro-info > in that jessie chroot, which states that squeeze is oldstable, which it > isn't. > > I'm not sure how to deal with this bug report :-( Maybe this is actually > a bug in distro-info in jessie and this bug should be reassigned there? > (+"affects piuparts") That sounds quite appropriate. JFTR, python-distro-info (0.14). > I've downgraded the severity for now as the package builds fine in sid. I think the correct action is to tag this bug jessie and or update the 'fixed' version metadata, rather than downgrade - but I expect that can all get fixed up once/if the bug is reassigned :) Cheers, Dominic.
Bug#827411: [Piuparts-devel] Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
control: severity -1 important thanks Hi Dominic, hi distro-info maintainers, thanks for your bug report, Dominic! On Wed, Jun 15, 2016 at 10:20:18PM +0100, Dominic Hargreaves wrote: > Source: piuparts > Version: 0.62 > Severity: serious > Justification: FTBFS > > This package fails to build on a clean jessie sbuild chroot: > > == > FAIL: testConfStdDistroNames (test_config.ConfStdDistroTests) > -- > Traceback (most recent call last): > File "/<>/tests/test_config.py", line 20, in > testConfStdDistroNames > self.assertEqual(self.oldstable, 'squeeze') > AssertionError: 'wheezy' != 'squeeze' looking at tests/test_config.py I see nothing wrong, wheezy is oldstablde there and squeeze is only referenced there for history. So I assume it's actually not piuparts which "is wrong" but distro-info in that jessie chroot, which states that squeeze is oldstable, which it isn't. I'm not sure how to deal with this bug report :-( Maybe this is actually a bug in distro-info in jessie and this bug should be reassigned there? (+"affects piuparts") I've downgraded the severity for now as the package builds fine in sid. -- cheers, Holger signature.asc Description: Digital signature
Bug#827411: piuparts: FTBFS on jessie: 'wheezy' != 'squeeze'
Source: piuparts Version: 0.62 Severity: serious Justification: FTBFS This package fails to build on a clean jessie sbuild chroot: == FAIL: testConfStdDistroNames (test_config.ConfStdDistroTests) -- Traceback (most recent call last): File "/<>/tests/test_config.py", line 20, in testConfStdDistroNames self.assertEqual(self.oldstable, 'squeeze') AssertionError: 'wheezy' != 'squeeze' -- Ran 39 tests in 0.536s FAILED (failures=1) The complete log is at http://perl.debian.net/rebuild-logs/jessie/piuparts_0.62/piuparts_0.62_amd64-20160615-1509.build Cheers, Dominic.
