Bug#827901: caja-sendto does not pass any parameters to mailer, so send to mail does not work at all

2016-06-22 Thread John Paul Adrian Glaubitz
Control: severity -1 normal
Control: tags -1 +patch

On 06/22/2016 12:55 PM, Erik Thiele wrote:
> well. Actually I just
> read from https://www.debian.org/Bugs/Developer#severities
> grave
> makes the package in question unusable or mostly so,...

Documentation is not necessarily up-to-date. So, if in doubt, just ask
the maintainers. They are reachable in IRC and via mailing lists.

> sorry if I chose the wrong severity.

I'm reducing the severity to "normal". I don't consider this to be a
serious bug. Plus, this bug needs to be tagged as "patch" if you
supply a patch to address the issue.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Bug#827901: caja-sendto does not pass any parameters to mailer, so send to mail does not work at all

2016-06-22 Thread Erik Thiele
> > I set severity to grave as debian documentation sais i should mark
> > as grave when the package in question is unusable or mostly so.
> 
> Does the package work *not_at_all* or does it break other packages? Or
> is it just one functionality which is not working properly?
> 
> If it's just the latter, then this bug report should not be marked as
> "grave". Tagging a bug with severity "grave" has ramifications which
> can include the removal of the package from the archives and I'm not
> sure if that's what you intended.
> 
> Please do not file a bug report with severity of "grave" until you
> fully understand what the ramifications are and what the purpose of
> tagging it as "grave" is. Tagging it as "normal" is enough for 99% of
> the cases unless this issue is actually serious, e.g. a vulnerability
> with a working exploit.
> 
> Just tagging the bug as "grave" does not automatically make people fix
> the issue faster. The severity is readjusted by the maintainers anyway
> when doing triaging.

well. Actually I just
read from https://www.debian.org/Bugs/Developer#severities
grave
makes the package in question unusable or mostly so,...

and I think that caja-sendto is probably most of the time used to send
files by mail, and since that feature does not work, i thought grave
would be correct.

sorry if I chose the wrong severity.



erik



Bug#827901: caja-sendto does not pass any parameters to mailer, so send to mail does not work at all

2016-06-22 Thread John Paul Adrian Glaubitz
On 06/22/2016 12:02 PM, Erik Thiele wrote:
> I set severity to grave as debian documentation sais i should mark as
> grave when the package in question is unusable or mostly so.

Does the package work *not_at_all* or does it break other packages? Or
is it just one functionality which is not working properly?

If it's just the latter, then this bug report should not be marked as
"grave". Tagging a bug with severity "grave" has ramifications which
can include the removal of the package from the archives and I'm not
sure if that's what you intended.

Please do not file a bug report with severity of "grave" until you fully
understand what the ramifications are and what the purpose of tagging
it as "grave" is. Tagging it as "normal" is enough for 99% of the
cases unless this issue is actually serious, e.g. a vulnerability with
a working exploit.

Just tagging the bug as "grave" does not automatically make people fix
the issue faster. The severity is readjusted by the maintainers anyway
when doing triaging.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Bug#827901: caja-sendto does not pass any parameters to mailer, so send to mail does not work at all

2016-06-22 Thread Erik Thiele
Package: caja-sendto
Version: 1.8.0-3
Severity: grave

this report is about the feature of caja to send files by email when
caja-sendto package is installed. therefore you right click on a file
in caja and say sendto. then you choose email and enter a mail address.

I set severity to grave as debian documentation sais i should mark as
grave when the package in question is unusable or mostly so. since the
main task of caja-sendto is send files by mail, I hope grave is the
right severity, also I think that right click on a file to send it by
email is an important major feature of the mate desktop.

i am using the mate desktop and created a new system user to make sure,
that all configuration is clean.

to see error messages, i use the console instead of right click on a
file:

from the console i do:
#caja-sendto bla-2.png 
Init caja burn plugin
Init pidgin plugin
Init gajim plugin
Init email client plugin
Init removable-devices plugin
** Message: Mailer type: 0
** Message: Command: icedove

^^ you see Command: icedove without any parameters.

i can switch the system default mailer to claws-mail and get:

#caja-sendto bla-2.png 
Init caja burn plugin
Init pidgin plugin
Init gajim plugin
Init email client plugin
Init removable-devices plugin
** Message: Mailer type: 3
** Message: Command: claws-mail

^^ again you see there are no parameters passed to claws-mail.

so in both cases the mailer will open but not compose an email and also
not append the attachments.

also you see in the icedove case that icedove is not recognized as
icedove (it should be mailer type 4, see emailclient.c in the
sourcecode). this is because debian calls it icedove and caja-send
checks for "thunder".

i appended a patch to this report which fixes both issues:

- icedove is recognized as thunderbird (mailer type 4) correctly.

- mailer opens compose window and attachments are appended.



cu
erik--- /home/global/erik/compiling/ori/caja-extensions-1.8.0/sendto/plugins/emailclient/emailclient.c	2014-03-01 13:13:18.0 +0100
+++ emailclient.c	2016-06-22 11:37:48.0 +0200
@@ -95,23 +95,20 @@
 		/* Find what the default mailer is */
 		if (strstr (mail_cmd, "balsa"))
 			type = MAILER_BALSA;
-		else if (strstr (mail_cmd, "thunder") || strstr (mail_cmd, "seamonkey")) {
-			char **strv;
-
+		else if (strstr (mail_cmd, "thunder") || strstr (mail_cmd, "seamonkey")
+			 || strstr(mail_cmd, "icedove") )
 			type = MAILER_THUNDERBIRD;
-
-			/* Thunderbird sucks, see
-			 * https://bugzilla.gnome.org/show_bug.cgi?id=614222 */
-			strv = g_strsplit (mail_cmd, " ", -1);
-			g_free (mail_cmd);
-			mail_cmd = g_strdup_printf ("%s %%s", strv[0]);
-			g_strfreev (strv);
-		} else if (strstr (mail_cmd, "sylpheed") || strstr (mail_cmd, "claws"))
+		else if (strstr (mail_cmd, "sylpheed") || strstr (mail_cmd, "claws"))
 			type = MAILER_SYLPHEED;
 		else if (strstr (mail_cmd, "anjal"))
 			type = MAILER_EVO;
 	}
-
+	
+	char **strv = g_strsplit (mail_cmd, " ", -1);
+	g_free (mail_cmd);
+	mail_cmd = g_strdup_printf ("%s %%s", strv[0]);
+	g_strfreev (strv);
+	
 	if (mail_cmd == NULL)
 		return FALSE;