Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Sean Whitton]

control: tag -1 -moreinfo +confirmed
control: noowner -1

Hello,

On Fri, Jul 01, 2016 at 12:11:35PM +0300, Dmitry Bogatov wrote:
> Added Forwarded: header at bootom of description. It works. If I add it at 
> top,
> it will be lost during patch->commit->patch conversion.

Okay.  I think that fails DEP-3 but that might be okay for the sake of
sane gbp usage.  Up to the judgment of the DD who sponsors!

Thanks for your patience.

-- 
Sean Whitton

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Dmitry Bogatov]

> > > Thanks for your response.  I think this package is almost ready.  Please
> > > add Forwarded: headers to the patches based on our discussion.
> > Is it any wat to get best of 'gbp pq' and dep3?
> I generally resort to using quilt :(

Added Forwarded: header at bootom of description. It works. If I add it at top,
it will be lost during patch->commit->patch conversion.

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Web-Site: sinsekvu.github.io

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Sean Whitton]

On Thu, Jun 30, 2016 at 04:26:02PM +0300, Dmitry Bogatov wrote:
> 
> > Thanks for your response.  I think this package is almost ready.  Please
> > add Forwarded: headers to the patches based on our discussion.
> 
> Is it any wat to get best of 'gbp pq' and dep3?

I generally resort to using quilt :(

-- 
Sean Whitton

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Dmitry Bogatov]

> Thanks for your response.  I think this package is almost ready.  Please
> add Forwarded: headers to the patches based on our discussion.

Is it any wat to get best of 'gbp pq' and dep3?

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Web-Site: sinsekvu.github.io

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Sean Whitton]

Hello Dmitry,

Thanks for your response.  I think this package is almost ready.  Please
add Forwarded: headers to the patches based on our discussion.

-- 
Sean Whitton

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Sergio Durigan Junior]

On Wednesday, June 29 2016, Gianfranco Costamagna wrote:

>>3) Any reason why you're using debhelper version 10?  It's still
>
>>experimental, so you probably should be using version 9.
>
>
> I'm not sure about this, some days ago debhelper 11 implementation started, 
> so I think compat
> level 10 is somewhat considered stable?
> https://anonscm.debian.org/git/debhelper/debhelper.git/commit/?id=d52c3364f9518e021be31f350204fe8e4a24619b

According to:

  

It's ready for public testing, but that doesn't necessarily mean that
it's stable.

Cheers,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Gianfranco Costamagna]

Hi,

>3) Any reason why you're using debhelper version 10?  It's still

>experimental, so you probably should be using version 9.


I'm not sure about this, some days ago debhelper 11 implementation started, so 
I think compat
level 10 is somewhat considered stable?
https://anonscm.debian.org/git/debhelper/debhelper.git/commit/?id=d52c3364f9518e021be31f350204fe8e4a24619b

Gianfranco

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Sean Whitton]

control: owner -1 !
control: tag -1 +moreinfo

Hello Dmitry,

I thought you were finished after evil and its dependencies :)  Glad to
see more ELPA packages.  Here's a review for you.

1. The "-el" suffix on the source package name is pointless because the
   name already contains "elisp" so it's clear that it's an Emacs
   package.  Please consider dropping the suffix.  On the Emacsen team
   we use upstream names where possible.

2. Have you forwarded 0001-Fix-Package-Version-header.patch upstream?

3. Please patch README.md to remove the installation instructions (might
   be confusing to someone who has already installed the package) and
   remove the MELPA badges from the top (useless in plain text).

4. No pristine-tar branch is available.  For the sake of the sponsorship
   process it might be worth adding one.

I installed the package and it seems to work well!

On Tue, Jun 28, 2016 at 10:50:00PM -0400, Sergio Durigan Junior wrote:
> 1) The links listed on the Vcs-* fields are not valid, so perhaps you
> may want to (a) push your git repo temporarily at another URL, or (b)
> create the repo under collab-maint/ and push your things there.

They seem to work now!

> 3) Any reason why you're using debhelper version 10?  It's still
> experimental, so you probably should be using version 9.

My guess is that he generated the packaging with dh-make-elpa.  It sets
compat 10 in order to enable dh_elpa_test.  In this case, it's not
necessary since there is no test suite.

-- 
Sean Whitton

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Dmitry Bogatov]

> 1) The links listed on the Vcs-* fields are not valid, so perhaps you
> may want to (a) push your git repo temporarily at another URL, or (b)
> create the repo under collab-maint/ and push your things there.

Thanks. Fixed.

> 2) It seems you forgot to set the distribution to 'unstable' on your
> debian/changelog file.

Correct. Fixed.

> 3) Any reason why you're using debhelper version 10?  It's still
> experimental, so you probably should be using version 9.

Compat 10 is default for emacs packages. dh_elpa_test(1).

-- 
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Web-Site: sinsekvu.github.io

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Sergio Durigan Junior]

On Tuesday, June 28 2016, Dmitry Bogatov wrote:

> Dear mentors,
>
> I am looking for a sponsor for my package "elisp-slime-nav-el"
>
> * Package name: elisp-slime-nav-el
>   Version : 0.9-1
>   Upstream Author : Steve Purcell 
> * Url : https://github.com/purcell/elisp-slime-nav
> * Licenses: GPL-3+
>   Section : lisp

Hey Dmitry,

Thanks for the package.  Just a quick review because I'm not at my
Debian machine right now.

A few things pop out when I looked at the mentors.d.n for your package.

1) The links listed on the Vcs-* fields are not valid, so perhaps you
may want to (a) push your git repo temporarily at another URL, or (b)
create the repo under collab-maint/ and push your things there.

2) It seems you forgot to set the distribution to 'unstable' on your
debian/changelog file.

3) Any reason why you're using debhelper version 10?  It's still
experimental, so you probably should be using version 9.

For now, that's all I have.  I will try to look at the package later and
see if I have any more comments about it.

Thanks!

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Dmitry Bogatov]

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "elisp-slime-nav-el"

* Package name: elisp-slime-nav-el
  Version : 0.9-1
  Upstream Author : Steve Purcell 
* Url : https://github.com/purcell/elisp-slime-nav
* Licenses: GPL-3+
  Section : lisp

It builds those binary packages:

elpa-elisp-slime-nav -- Emacs extension that provide Emacs Lisp code 
navigation

To access futher information about this package, visit the following URL:

http://mentors.debian.net/package/elisp-slime-nav-el

Alternatively, one can download the package with dget using this command:


http://mentors.debian.net/debian/pool/main/e/elisp-slime-nav-el/elisp-slime-nav-el_0.9-1.dsc

Alternatively, you can access package debian/ directory via git from URL:

https://anonscm.debian.org/git/pkg-emacsen/pkg/elisp-slime-nav.git

More information about elisp-slime-nav-el can be obtained from 
https://github.com/purcell/elisp-slime-nav

Changes since last upload:

  * Initial release (Closes: #828885)

Regards,
  Dmitry Bogatov