Bug#829286: RFS: newlisp/10.7.0-2

[Sergio Durigan Junior]

On Monday, July 04 2016, Gianfranco Costamagna wrote:

>>Still nothing.  I had read the page, but it mentions the format of the
>>.commands file, and not dcut's CLI options.  I also tried specifying the
>>options in a different order, but I get the same error.
>
>
> dcut ftp-master reschedule -d 0  -f newlisp_10.7.0-2_source.changes
>
> this works for dput-ng I think

Alright, after installing dput-ng (I had the "normal" dput package
installed) it works.  And I can confirm that the commands were accepted
and that the package apparently has moved to the 0-day queue.  Indeed,
it seems like a bug...

Thanks!

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#829286: RFS: newlisp/10.7.0-2

[Gianfranco Costamagna]

Hi,



>Still nothing.  I had read the page, but it mentions the format of the
>.commands file, and not dcut's CLI options.  I also tried specifying the
>options in a different order, but I get the same error.


dcut ftp-master reschedule -d 0  -f newlisp_10.7.0-2_source.changes

this works for dput-ng I think

BTW if you can't check-do that, you might want to add -k KEYID
or ask me to reschedule it :)

G.

Bug#829286: RFS: newlisp/10.7.0-2

[Sergio Durigan Junior]

On Sunday, July 03 2016, James Cowgill wrote:

>> Hm, here's what I see when I try it:
>> 
>>   D: dcut 0.2.1
>>   D: trying to get maintainer email from environment
>>   D: Uploader from env: Sergio Durigan Junior 
>>   D: first argument "ftp-master" treated as host
>>   D: loading dput
>>   D: calling dput.read_configs
>>   D: Parsing Configuration File /etc/dput.cf
>>   D: Parsing Configuration File /home/sergio/.dput.cf
>>   D: Successfully parsed command "reschedule -d 0 -f 
>> newlisp_10.7.0-2_source.changes"
>>   D: calling debsign: ['debsign', '-mSergio Durigan Junior ',
>>   
>> '/tmp/dcut.RMMfsD/dcut.Sergio_Durigan_Junior__sergiodj_sergiodj_net_.1467570258.1694.commands']
>>   .commands file has invalid Commands line: reschedule -d 0 -f 
>> newlisp_10.7.0-2_source.changes
>>   debsign: .commands file appears to be invalid. see:
>>   ftp://ftp.upload.debian.org/pub/UploadQueue/README
>>   for valid format
>>   Error: debsign failed.
>> 
>> Is this my fault?
>
> I think the syntax is:
>  dcut reschedule newlisp_10.7.0-2_source.changes 0-day
>
> The above link that dcut outputted contains the format of all the
> available commands.

Still nothing.  I had read the page, but it mentions the format of the
.commands file, and not dcut's CLI options.  I also tried specifying the
options in a different order, but I get the same error.

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#829286: RFS: newlisp/10.7.0-2

[James Cowgill]

Hi,

On Sun, 2016-07-03 at 14:28 -0400, Sergio Durigan Junior wrote:
> On Sunday, July 03 2016, Gianfranco Costamagna wrote:
> > as a DM, I'm pretty sure (but I can't check this anymore since I
> > moved to DD),
> > that you can reschedule stuff for other people too.
> > Can you please try this command?
> > dcut ftp-master reschedule -d 0 -f newlisp_10.7.0-2_source.changes
> > 
> > this should move the newlisp in incoming queue
> 
> Hm, here's what I see when I try it:
> 
>   D: dcut 0.2.1
>   D: trying to get maintainer email from environment
>   D: Uploader from env: Sergio Durigan Junior 
>   D: first argument "ftp-master" treated as host
>   D: loading dput
>   D: calling dput.read_configs
>   D: Parsing Configuration File /etc/dput.cf
>   D: Parsing Configuration File /home/sergio/.dput.cf
>   D: Successfully parsed command "reschedule -d 0 -f 
> newlisp_10.7.0-2_source.changes"
>   D: calling debsign: ['debsign', '-mSergio Durigan Junior ',
>   
> '/tmp/dcut.RMMfsD/dcut.Sergio_Durigan_Junior__sergiodj_sergiodj_net_.1467570258.1694.commands']
>   .commands file has invalid Commands line: reschedule -d 0 -f 
> newlisp_10.7.0-2_source.changes
>   debsign: .commands file appears to be invalid. see:
>   ftp://ftp.upload.debian.org/pub/UploadQueue/README
>   for valid format
>   Error: debsign failed.
> 
> Is this my fault?

I think the syntax is:
 dcut reschedule newlisp_10.7.0-2_source.changes 0-day

The above link that dcut outputted contains the format of all the
available commands.

James

signature.asc
Description: This is a digitally signed message part

Bug#829286: RFS: newlisp/10.7.0-2

[Sergio Durigan Junior]

On Sunday, July 03 2016, Gianfranco Costamagna wrote:

>>Thanks for the review, Gianfranco.  If I may, I'd like to propose that
>
>>you upload the package as-is by the end of tomorrow (Sunday) even if
>>Andrey doesn't reply.  I'd really like to get these fixes uploaded ASAP.
>
>
> fine for me, you already did a nice bug triaging, and almost fixed
> all the bugs you got (+1 unreproducible/possibly fixed)
>
> dput -e 1 ftp-master newlisp_10.7.0-2_source.changes
>
> BTW, I put it on deferred/1, and I have a question for you :)

Thanks, Gianfranco.

> as a DM, I'm pretty sure (but I can't check this anymore since I moved to DD),
> that you can reschedule stuff for other people too.
> Can you please try this command?
> dcut ftp-master reschedule -d 0 -f newlisp_10.7.0-2_source.changes
>
> this should move the newlisp in incoming queue

Hm, here's what I see when I try it:

  D: dcut 0.2.1
  D: trying to get maintainer email from environment
  D: Uploader from env: Sergio Durigan Junior 
  D: first argument "ftp-master" treated as host
  D: loading dput
  D: calling dput.read_configs
  D: Parsing Configuration File /etc/dput.cf
  D: Parsing Configuration File /home/sergio/.dput.cf
  D: Successfully parsed command "reschedule -d 0 -f 
newlisp_10.7.0-2_source.changes"
  D: calling debsign: ['debsign', '-mSergio Durigan Junior 
',
  
'/tmp/dcut.RMMfsD/dcut.Sergio_Durigan_Junior__sergiodj_sergiodj_net_.1467570258.1694.commands']
  .commands file has invalid Commands line: reschedule -d 0 -f 
newlisp_10.7.0-2_source.changes
  debsign: .commands file appears to be invalid. see:
  ftp://ftp.upload.debian.org/pub/UploadQueue/README
  for valid format
  Error: debsign failed.

Is this my fault?

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#829286: RFS: newlisp/10.7.0-2

[Sergio Durigan Junior]

On Saturday, July 02 2016, Gianfranco Costamagna wrote:

> I agree with your POV, lets see Andrey's opinion, I'm fine with the changes 
> now :)

Thanks for the review, Gianfranco.  If I may, I'd like to propose that
you upload the package as-is by the end of tomorrow (Sunday) even if
Andrey doesn't reply.  I'd really like to get these fixes uploaded ASAP.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#829286: RFS: newlisp/10.7.0-2

[Gianfranco Costamagna]

Hi,


>Hm, this is actually only needed for GNU/kFreeBSD, which uses -lncurses
>on the linking phase.  I updated Build-Depends to reflect that.


wonderful
>Yeah, it was just a simple sed command to remove things from all
>Makefiles.  But it seems I did not specify the right set of files to
>apply the substitutions.


ok

> [snip]

I agree with your POV, lets see Andrey's opinion, I'm fine with the changes now 
:)

Gianfranco

Bug#829286: RFS: newlisp/10.7.0-2

[Sergio Durigan Junior]

Control: tags -1 - moreinfo

On Saturday, July 02 2016, Gianfranco Costamagna wrote:

>>I'd like to get a few changes I've made to newlisp uploaded.  They
>
>>basically fix two bugs: 828805 and 828806.
>>
>>The changes are:
>>
>>- Support GNU/kFreeBSD builds (by creating the necessary makefiles and
>>  adjusting source files accordingly), and
>>
>>- Do not use -m32/-m64 when building.
>>
>>I have also updated the Vcs-* links in order to reflect the use of
>>collab-maint instead of my personal git server.
>>
>>I'm Cc'ing Andrey Rahmatullin on this message because he is the DD who
>>sponsored the package first, so I believe I should give him "precedence"
>>(also because I'd like to get DM rights on newlisp, so it's easier if I
>>work with just one person).
>
>
> sure, I won't upload it, unless Andrey asks me.
>
> I have just a few notes, from a quick review:
>
> 1) + libncurses5-dev
>
>
> why?

Hm, this is actually only needed for GNU/kFreeBSD, which uses -lncurses
on the linking phase.  I updated Build-Depends to reflect that.

> please explain the additional build dependency in changelog!

Done.

> 2)
> did you remove the -m32 and -m64 with some special sed command?

Yeah, it was just a simple sed command to remove things from all
Makefiles.  But it seems I did not specify the right set of files to
apply the substitutions.

> I ask, because you also patched some binaries in the source tree, and
> I'm mostly sure this isn't what you have to do:
> +diff --git a/qa-specific-tests/ffitest.dylib 
> b/qa-specific-tests/ffitest.dylib
> +index 3017a91..4e0eb2e 100755
> +--- a/qa-specific-tests/ffitest.dylib
>  b/qa-specific-tests/ffitest.dylib
>
>
> this, IIRC is some OSX special file, so I guess you better remove that file
> from the patch, since it is introducing really useless stuff.

Totally right, and this is actually a Windows binary used for testing.

> also, you have an ~1k LOC patch, where probably you would just need to patch
> two or three places
> (but if you got this patch upstream accepted I would leave it as-is)
>
> Otherwise I would avoid patching places such as
> +-(compile-recover "gcc -m32 ../util/ffitest.c -shared -o 
> ffitest.dylib")
> +-(compile-recover "gcc -m64 ../util/ffitest.c -shared -o 
> ffitest.dylib"))
>
>
> makefile_sunos*
> makefile_opensolaris*
> makefile_netbsd*
>
> and so on
>
> As a personal opinion, I would patch all of them only after getting them 
> accepted
> upstream, and in case they don't care about this, just patch the minimum set 
> of files/makefiles
> used in Debian/Linux/kFreeBSD builds.

Right, I only patched the GNU/{Linux,kFreeBSD} files now.  Thanks for
the heads up.

> Otherwise a 1k lines patch will be probably a nightmare to maintain/rebase on 
> new releases.

On the one hand, I see your point in maintaining a large patch on Debian
and rebasing it on every new release.  On the other hand, this patch
only touches the build system, which is unlikely to change much in the
near future.  Also, I am in touch with upstream and will propose all of
my local patches to them, so hopefully I won't need to carry anything
else for the next releases.

I've uploaded a new version of the package to mentors.d.n.  If you could
take a look, I'd appreciate!

Cheers,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature

Bug#829286: RFS: newlisp/10.7.0-2

[Gianfranco Costamagna]

control: tags -1 moreinfo


>I'd like to get a few changes I've made to newlisp uploaded.  They

>basically fix two bugs: 828805 and 828806.
>
>The changes are:
>
>- Support GNU/kFreeBSD builds (by creating the necessary makefiles and
>  adjusting source files accordingly), and
>
>- Do not use -m32/-m64 when building.
>
>I have also updated the Vcs-* links in order to reflect the use of
>collab-maint instead of my personal git server.
>
>I'm Cc'ing Andrey Rahmatullin on this message because he is the DD who
>sponsored the package first, so I believe I should give him "precedence"
>(also because I'd like to get DM rights on newlisp, so it's easier if I
>work with just one person).


sure, I won't upload it, unless Andrey asks me.

I have just a few notes, from a quick review:

1) + libncurses5-dev


why?


please explain the additional build dependency in changelog!

2)
did you remove the -m32 and -m64 with some special sed command?

I ask, because you also patched some binaries in the source tree, and
I'm mostly sure this isn't what you have to do:
+diff --git a/qa-specific-tests/ffitest.dylib b/qa-specific-tests/ffitest.dylib
+index 3017a91..4e0eb2e 100755
+--- a/qa-specific-tests/ffitest.dylib
 b/qa-specific-tests/ffitest.dylib


this, IIRC is some OSX special file, so I guess you better remove that file
from the patch, since it is introducing really useless stuff.

also, you have an ~1k LOC patch, where probably you would just need to patch
two or three places
(but if you got this patch upstream accepted I would leave it as-is)

Otherwise I would avoid patching places such as
+-(compile-recover "gcc -m32 ../util/ffitest.c -shared -o 
ffitest.dylib")
+-(compile-recover "gcc -m64 ../util/ffitest.c -shared -o 
ffitest.dylib"))


makefile_sunos*
makefile_opensolaris*
makefile_netbsd*

and so on

As a personal opinion, I would patch all of them only after getting them 
accepted
upstream, and in case they don't care about this, just patch the minimum set of 
files/makefiles
used in Debian/Linux/kFreeBSD builds.

Otherwise a 1k lines patch will be probably a nightmare to maintain/rebase on 
new releases.

Just my .02$, of course I tagged moreinfo, but Andrey might have a different 
opinion...

cheers!

Gianfranco

Bug#829286: RFS: newlisp/10.7.0-2

[Sergio Durigan Junior]

Package: sponsorship-requests
Severity: normal

Hi,

I'd like to get a few changes I've made to newlisp uploaded.  They
basically fix two bugs: 828805 and 828806.

The changes are:

- Support GNU/kFreeBSD builds (by creating the necessary makefiles and
  adjusting source files accordingly), and

- Do not use -m32/-m64 when building.

I have also updated the Vcs-* links in order to reflect the use of
collab-maint instead of my personal git server.

I'm Cc'ing Andrey Rahmatullin on this message because he is the DD who
sponsored the package first, so I believe I should give him "precedence"
(also because I'd like to get DM rights on newlisp, so it's easier if I
work with just one person).

The package can be found at:

  

And can be downloaded with:

  dget -x 
https://mentors.debian.net/debian/pool/main/n/newlisp/newlisp_10.7.0-2.dsc

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/


signature.asc
Description: PGP signature