Bug#830178: Possible fix

[Sandro Tosi]

thanks a lot Piotr! these days i'm going thru the list of packages we
care at work for stretch so a mail-ping was super effective :)

On Wed, Nov 2, 2016 at 6:39 PM, Piotr Ożarowski  wrote:
> [Sandro Tosi, 2016-11-02]
>> thanks! i pinged that bug to see if upstream will release a new
>> version soo, if not we could just pick up that patch
>
> I uploaded -2, thanks for the reminder and sorry for the delay (RL, I
> will try to keep up a bit with Debian this weekend...)



-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Bug#830178: Possible fix

[Piotr Ożarowski]

[Sandro Tosi, 2016-11-02]
> thanks! i pinged that bug to see if upstream will release a new
> version soo, if not we could just pick up that patch

I uploaded -2, thanks for the reminder and sorry for the delay (RL, I
will try to keep up a bit with Debian this weekend...)

Bug#830178: Possible fix

[Sandro Tosi]

thanks! i pinged that bug to see if upstream will release a new
version soo, if not we could just pick up that patch

On Wed, Nov 2, 2016 at 6:05 PM, Nish Aravamudan
 wrote:
> On Wed, Nov 2, 2016 at 3:00 PM, Sandro Tosi  wrote:
>> On Mon, 26 Sep 2016 17:34:47 -0700 Nish Aravamudan
>>  wrote:
>>> So I am tracking the same issue seen on Ubuntu 16.10 and I found:
>>>
>>> https://github.com/sphinx-doc/sphinx/pull/2396
>>>
>>> I tested the following patch to the sourc3, and it does seem to build,
>>> although I'm not sure I fully understand why yet (I'm completely new to
>>> sphinx, just trying to help fix these bugs :) But I think it's because
>>> upstream sphinx has changed an underlying data structure (index)?
>>>
>>> -Nish
>>>
>>> --- a/doc/build/templates/genindex.mako
>>> +++ b/doc/build/templates/genindex.mako
>>> @@ -21,7 +21,7 @@
>>>  numcols = 1
>>>  numitems = 0
>>>  %>
>>> -% for entryname, (links, subitems) in entries:
>>> +% for entryname, (links, subitems, dummy) in entries:
>>>
>>>  
>>>  % if links:
>>>
>>
>> hey Piotr, did you have a chance to look at this patch? do you think
>> it's ok to apply to the debian package or would you rather forward it
>> upstream and ask what they thnk about it?
>
> Sorry, I should have updated this bug: upstream mako has picked this
> up already: https://github.com/zzzeek/mako/pull/20
>
> -Nish



-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Bug#830178: Possible fix

[Nish Aravamudan]

On Wed, Nov 2, 2016 at 3:00 PM, Sandro Tosi  wrote:
> On Mon, 26 Sep 2016 17:34:47 -0700 Nish Aravamudan
>  wrote:
>> So I am tracking the same issue seen on Ubuntu 16.10 and I found:
>>
>> https://github.com/sphinx-doc/sphinx/pull/2396
>>
>> I tested the following patch to the sourc3, and it does seem to build,
>> although I'm not sure I fully understand why yet (I'm completely new to
>> sphinx, just trying to help fix these bugs :) But I think it's because
>> upstream sphinx has changed an underlying data structure (index)?
>>
>> -Nish
>>
>> --- a/doc/build/templates/genindex.mako
>> +++ b/doc/build/templates/genindex.mako
>> @@ -21,7 +21,7 @@
>>  numcols = 1
>>  numitems = 0
>>  %>
>> -% for entryname, (links, subitems) in entries:
>> +% for entryname, (links, subitems, dummy) in entries:
>>
>>  
>>  % if links:
>>
>
> hey Piotr, did you have a chance to look at this patch? do you think
> it's ok to apply to the debian package or would you rather forward it
> upstream and ask what they thnk about it?

Sorry, I should have updated this bug: upstream mako has picked this
up already: https://github.com/zzzeek/mako/pull/20

-Nish

Bug#830178: Possible fix

[Sandro Tosi]

On Mon, 26 Sep 2016 17:34:47 -0700 Nish Aravamudan
 wrote:
> So I am tracking the same issue seen on Ubuntu 16.10 and I found:
>
> https://github.com/sphinx-doc/sphinx/pull/2396
>
> I tested the following patch to the sourc3, and it does seem to build,
> although I'm not sure I fully understand why yet (I'm completely new to
> sphinx, just trying to help fix these bugs :) But I think it's because
> upstream sphinx has changed an underlying data structure (index)?
>
> -Nish
>
> --- a/doc/build/templates/genindex.mako
> +++ b/doc/build/templates/genindex.mako
> @@ -21,7 +21,7 @@
>  numcols = 1
>  numitems = 0
>  %>
> -% for entryname, (links, subitems) in entries:
> +% for entryname, (links, subitems, dummy) in entries:
>
>  
>  % if links:
>

hey Piotr, did you have a chance to look at this patch? do you think
it's ok to apply to the debian package or would you rather forward it
upstream and ask what they thnk about it?

thanks!!

Bug#830178: Possible fix

[Nish Aravamudan]

So I am tracking the same issue seen on Ubuntu 16.10 and I found:

https://github.com/sphinx-doc/sphinx/pull/2396

I tested the following patch to the sourc3, and it does seem to build,
although I'm not sure I fully understand why yet (I'm completely new to
sphinx, just trying to help fix these bugs :) But I think it's because
upstream sphinx has changed an underlying data structure (index)?

-Nish

--- a/doc/build/templates/genindex.mako
+++ b/doc/build/templates/genindex.mako
@@ -21,7 +21,7 @@
 numcols = 1
 numitems = 0
 %>
-% for entryname, (links, subitems) in entries:
+% for entryname, (links, subitems, dummy) in entries:
 
 
 % if links:


-- 
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd