Bug#832704: RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client
Hi >See license.html. The project is GPL-2, but some files have GPL-2+ in >their headers. rescheduled, thanks :) and sorry for the useless question G.
Bug#832704: RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client
Hello Gianfranco, On Fri, Nov 18, 2016 at 06:54:01PM +, Gianfranco Costamagna wrote: > Hi, I put the package in deferred/5, because I'm not sure about the whole > license. > Isn't it something like GPL-2+ instead of GPL-2? > I agree single files are ok, but the "*" wildcard seems a GPL-2+ to me, even > if > I didn't find a copying file. See license.html. The project is GPL-2, but some files have GPL-2+ in their headers. -- Sean Whitton signature.asc Description: PGP signature
Bug#832704: RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client
control: tag -1 -moreinfo +confirmed control: noowner -1 I consider d648533e5f1d9942a07cb9e907eec2d58b1965fb ready for upload. On Mon, Nov 14, 2016 at 04:47:59PM +0800, Boyuan Yang wrote: > A missing dependency libqt4-sql-sqlite caused this problem. It seems that > the automatic dh_shlibdeps failed to list it inside Depends list (it only > listed libqt4-sql). A explicit dependency was added the latest commit. Okay. Perhaps dlopen() is used to access libqt4-sql-sqlite. > > > * Copyright information update for beta10 version. > > > > 3. Are you installing the plugins at present, 'hunspell' and 'webcam'? > > Contents of package suggests not. Upstream seems to think they belong > > in separate binary packages. What do you think about that? > > Added debian/README.Debian file to explain the situation. The plugin structure > won't support Qt5, plus upstream placed the plugin inside /usr/share, which > is > not acceptable. The building system (CMake) for plugins is not in standard > status, too. My choice is not to install the plugins and wait until upstream > provides with a better solution. > > Patching may be possible but that would be painful. Yes, this seems like an upstream problem. I hope they can resolve it. > > > Blhc on debomatic reported some missing CXXFLAGS (-fPIE). However > > > since new gcc has already set -fPIE by default since 6.2.0-7, this > > > should be harmless. > > > > Yes. Lintian would be complaining if it wasn't being passed. > > Again this needs patching, so I would choose to look into it later until some > real problem comes up. What needs patching? If it was needed, Lintian would have emitted a warning. > > 4. I'm curious why you nuked gbp.conf. Entirely up to you, of > > course. > > I found git-buildpackage not reading the "debian/gbp.conf" at all unless I > list it explicitly inside environment variable, which is different from words > written in man 5 gbp.conf. Command line arguments should be a better choice > for me. That's really weird. I've never seen that. You might want to report a bug. > > 5. Your Forwarded: headers got eaten at some point. Would be nice > > to restore them. > > Well it is a problem hiding in gbp pq, which will eat non-mandatory headers > when exporting patches because git commit does not preserve those > information. > Maybe I fill file a bug report (feature request?) later. Already exists: #785274 A workaround is to put the Forwarded: headed at the end of the patch description, above the '---' line. -- Sean Whitton signature.asc Description: PGP signature
Bug#832704: RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client
在 2016年11月13日星期日 CST 下午2:43:47，Sean Whitton 写道： > plus some other minor comments below. The blocker: > > hephaestus ~ % nixnote2 > QSqlDatabase: QSQLITE driver not loaded > QSqlDatabase: available drivers: QMYSQL3 QMYSQL > ERROR 2016-11-13 14:38:58.946 ( sql/databaseconnection.cpp @ 44 ) Error > opening database: QSqlError(-1, "Driver not loaded", "Driver not loaded") > > Any ideas? A missing dependency libqt4-sql-sqlite caused this problem. It seems that the automatic dh_shlibdeps failed to list it inside Depends list (it only listed libqt4-sql). A explicit dependency was added the latest commit. > > * Some minor modification to package description in debian/control. > > 1. There's a grammatical error in your change: s/provide/provides/. > > 2. The sentence doesn't really make sense. Maybe s/and/to/ is what you > meant? Fixed. > > * Copyright information update for beta10 version. > > 3. Are you installing the plugins at present, 'hunspell' and 'webcam'? > Contents of package suggests not. Upstream seems to think they belong > in separate binary packages. What do you think about that? Added debian/README.Debian file to explain the situation. The plugin structure won't support Qt5, plus upstream placed the plugin inside /usr/share, which is not acceptable. The building system (CMake) for plugins is not in standard status, too. My choice is not to install the plugins and wait until upstream provides with a better solution. Patching may be possible but that would be painful. > > Blhc on debomatic reported some missing CXXFLAGS (-fPIE). However > > since new gcc has already set -fPIE by default since 6.2.0-7, this > > should be harmless. > > Yes. Lintian would be complaining if it wasn't being passed. Again this needs patching, so I would choose to look into it later until some real problem comes up. > 4. I'm curious why you nuked gbp.conf. Entirely up to you, of course. I found git-buildpackage not reading the "debian/gbp.conf" at all unless I list it explicitly inside environment variable, which is different from words written in man 5 gbp.conf. Command line arguments should be a better choice for me. > 5. Your Forwarded: headers got eaten at some point. Would be nice to > restore them. Well it is a problem hiding in gbp pq, which will eat non-mandatory headers when exporting patches because git commit does not preserve those information. Maybe I fill file a bug report (feature request?) later. > 6. You could install the new screenshot.png to > /usr/share/doc/nixnote2/examples (see dh_installexamples(1)). Done. Git repository updated on https://anonscm.debian.org/git/collab-maint/nixnote2.git Package on debian-mentors updated: https://mentors.debian.net/package/nixnote2 Package built on debomatic: http://debomatic-amd64.debian.net/distribution#unstable/ nixnote2/2.0~beta10+dfsg-1/ Sincerely, Boyuan Yang signature.asc Description: This is a digitally signed message part.
Bug#832704: RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client
control: retitle 832704 RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client Dear Boyuan, On Sat, Nov 12, 2016 at 11:26:52AM +0800, Boyuan Yang wrote: > Since the dependency qevercloud has entered unstable, it is perfectly > fine to move towards nixnote2. I have prepared the 2.0~beta10 version > of nixnote2 package, which should address previous problems. Thank you for your efforts. There is only one issue blocking upload, plus some other minor comments below. The blocker: hephaestus ~ % nixnote2 QSqlDatabase: QSQLITE driver not loaded QSqlDatabase: available drivers: QMYSQL3 QMYSQL ERROR 2016-11-13 14:38:58.946 ( sql/databaseconnection.cpp @ 44 ) Error opening database: QSqlError(-1, "Driver not loaded", "Driver not loaded") Any ideas? > * Some minor modification to package description in debian/control. 1. There's a grammatical error in your change: s/provide/provides/. 2. The sentence doesn't really make sense. Maybe s/and/to/ is what you meant? > * Copyright information update for beta10 version. 3. Are you installing the plugins at present, 'hunspell' and 'webcam'? Contents of package suggests not. Upstream seems to think they belong in separate binary packages. What do you think about that? > Blhc on debomatic reported some missing CXXFLAGS (-fPIE). However > since new gcc has already set -fPIE by default since 6.2.0-7, this > should be harmless. Yes. Lintian would be complaining if it wasn't being passed. 4. I'm curious why you nuked gbp.conf. Entirely up to you, of course. 5. Your Forwarded: headers got eaten at some point. Would be nice to restore them. 6. You could install the new screenshot.png to /usr/share/doc/nixnote2/examples (see dh_installexamples(1)). -- Sean Whitton signature.asc Description: PGP signature
Bug#832704: RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client
retitle 832704 RFS: nixnote2/2.0~beta10+dfsg-1 [ITP] -- Open Source Evernote client thanks Hi Sean, Since the dependency qevercloud has entered unstable, it is perfectly fine to move towards nixnote2. I have prepared the 2.0~beta10 version of nixnote2 package, which should address previous problems. Detailed changes since 2.0~beta9+dfsg: * Legacy code about old OpenOffice.org was further explained in README.source. * Move packaging Git repository to collab-maint, now I have write permission there. The old GitHub repository still exists and in an up-to-date state. * Some minor modification to package description in debian/control. * Switched back to build with Qt4. This is not ideal but will help squashing bugs raised when using Qt5. I will switch back to build against Qt5 once upstream declared that the Qt5 version is in mature state. * Copyright information update for beta10 version. Package on debian-mentors: https://mentors.debian.net/package/nixnote2 Packaging repository can be found at https://anonscm.debian.org/git/collab-maint/nixnote2.git Deb-o-matic-amd64 build status: http://debomatic-amd64.debian.net/debomatic/unstable/pool/nixnote2_2.0~beta10+dfsg-1/nixnote2_2.0~beta10+dfsg-1.dsc Blhc on debomatic reported some missing CXXFLAGS (-fPIE). However since new gcc has already set -fPIE by default since 6.2.0-7, this should be harmless. Looking forward to further review. Sincerely, Boyuan Yang
