Bug#834190: perl: please make the output of ExtUtils::Command::MM reproducible

2017-02-08 Thread Chris Lamb
Hi Dominic,

> I suppose my question was whether you saw this in the context of
> a package build (which would be odd, but I'm sure there are cases
> where it happens) or at some other time

Package builds, definitely. :)

Digging into the history of our "notes.git", this was (at least) in
rt-extension-customfieldsonupdate and rt-extension-spawnlinkedticketinqueue.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#834190: perl: please make the output of ExtUtils::Command::MM reproducible

2017-02-08 Thread Dominic Hargreaves
On Wed, Feb 08, 2017 at 03:48:56PM +1300, Chris Lamb wrote:
> Hi Dominic,
> 
> > Could you clarify how this showed up as an issue as part of the
> > reproducible builds work?
> 
> Not sure how I can add beyond the original bug report alas :) However,
> what I was seeing was that ExtUtils::Command::MM was generating
> "perllocal.pod" files that contained the current time of day,
> hence the patch.

I suppose my question was whether you saw this in the context of
a package build (which would be odd, but I'm sure there are cases
where it happens) or at some other time (in which case, is there
still a justification for working towards reproducibility)? I appreciate
this was a long time ago so you may not have the information, and I
should have asked this at the time.

perllocal.pod generation is already disabled for vendor installs so either
there is a bug in that or you saw the generation happening elsewhere.

https://sources.debian.net/src/perl/5.24.1-1/debian/patches/debian/no_packlist_perllocal.diff/

> > A reproducible build should just disable perllocal generation
> >
> >   — https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/pull/279
> 
> I'm afraid I just don't know -- am not deep enough into Perl packaging
> to know the impact of this.
> 
> Let me comment on there actually...

Thanks!
Dominic.



Bug#834190: perl: please make the output of ExtUtils::Command::MM reproducible

2017-02-07 Thread Chris Lamb
Hi Dominic,

> Could you clarify how this showed up as an issue as part of the
> reproducible builds work?

Not sure how I can add beyond the original bug report alas :) However,
what I was seeing was that ExtUtils::Command::MM was generating
"perllocal.pod" files that contained the current time of day,
hence the patch.

> A reproducible build should just disable perllocal generation
>
>   — https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/pull/279

I'm afraid I just don't know -- am not deep enough into Perl packaging
to know the impact of this.

Let me comment on there actually...


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#834190: perl: please make the output of ExtUtils::Command::MM reproducible

2017-02-07 Thread Dominic Hargreaves
On Fri, Aug 12, 2016 at 10:39:13PM +0100, Chris Lamb wrote:
> Whilst working on the Reproducible Builds effort [0], I noticed
> that ExtUtils::Command::MM generates perllocal.pod files that are
> not reproducible.
> 
> For example:
> 
>   -=head2 Sun Jul  3 14:56:53 2016: C   +=head2 Sun Aug  6 23:18:50 2017: C 
> Patch attached.
> 
>  [0] https://reproducible-builds.org/

Hi Chris,

Could you clarify how this showed up as an issue as part of the
reproducible builds work? There seems to be some resistance to the
change in https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/pull/279
that I don't quite understand, and it'd be nice to demonstrate more
clearly that it's relevant outside Debian...

Cheers,
Dominic.



Bug#834190: perl: please make the output of ExtUtils::Command::MM reproducible

2016-08-28 Thread Chris Lamb
Hi,

> perl: please make the output of ExtUtils::Command::MM reproducible

See also #835815.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#834190: perl: please make the output of ExtUtils::Command::MM reproducible

2016-08-12 Thread Chris Lamb
Source: perl
Version: 5.22.2-3
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps toolchain
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], I noticed
that ExtUtils::Command::MM generates perllocal.pod files that are
not reproducible.

For example:

  -=head2 Sun Jul  3 14:56:53 2016: Chttps://reproducible-builds.org/


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-
diff --git a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm 
b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm
index 203b3aa..0f1217b 100644
--- a/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm
+++ b/cpan/ExtUtils-MakeMaker/lib/ExtUtils/Command/MM.pm
@@ -213,7 +213,8 @@ sub perllocal_install {
: @ARGV;
 
 my $pod;
-$pod = sprintf < L<$name|$name>
 
  =over 4